New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use files with the correct extension for migrations #135

Merged
merged 1 commit into from Dec 12, 2013

Conversation

Projects
None yet
2 participants
@lmorchard
Contributor

lmorchard commented Dec 12, 2013

When editing migrations in VIM, I noticed that Knex was picking up the .swp files and throwing an error. This commit filters by extension for just the expected files.

I didn't code up a full-blown test, but the addition of a random crap file in the migration fixtures will trigger the error that this commit fixes.

tgriesser added a commit that referenced this pull request Dec 12, 2013

Merge pull request #135 from lmorchard/use-extension-for-migration-li…
…st-all

Only use files with the correct extension for migrations

@tgriesser tgriesser merged commit e1be421 into tgriesser:master Dec 12, 2013

1 check passed

default The Travis CI build passed
Details
@tgriesser

This comment has been minimized.

Owner

tgriesser commented Dec 12, 2013

Ah, good call, thanks @lmorchard!

@lmorchard lmorchard deleted the lmorchard:use-extension-for-migration-list-all branch Dec 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment