Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove duplicate transaction promise #3319

Merged
merged 1 commit into from Jun 30, 2019

Conversation

Projects
None yet
3 participants
@vonagam
Copy link
Contributor

commented Jun 30, 2019

Fixes second issue from #3309.

@elhigu

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Would it be possible to add test case for the bug it fixes?

@vonagam

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

As i said in the issue - your tests are already sufficient. You can see it in tests logs.

Look: logs for PR that introduced the problem (there are 260 UnhandledPromiseRejectionWarning), logs for this PR (there are none of those).

If you want tests to show rejections more clearly you should force tests to exit with non-zero status on unhandled rejections. How to do it i wrote in the issue. But you need to eliminate other unhandled rejections (there are around ten of them) before you do so.

@kibertoad kibertoad merged commit ee060b4 into tgriesser:master Jun 30, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on fix-transaction at 88.062%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 30, 2019

Thanks! I'll release a fixed version shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.