Shadowling Update 2: 121% Merge-Ready #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Xhuis' second shadowling fix, along with a slight rework and expansion of the veil spell.
|
This is good, I've seen some Shadowling rounds and this should go a long way in smoothing things over. 👍 |
New commit coming right after I test it |
apuh3
changed the title
|
|
||
| faction = list("faithless") | ||
|
|
||
| /mob/living/simple_animal/ascendant_shadowling/Process_Spacemove(var/movement_dir = 0) | ||
| return 1 //copypasta from carp code | ||
|
|
||
| /mob/living/simple_animal/ascendant_shadowling/say(var/message) | ||
| message = message + "!!" |
There was a problem hiding this comment.
this should be an override of treat_message(), you should basically never override say() directly. it's also probably more aesthetically pleasing to just add ..() | list(SPAN_REALLYBIG, SPAN_YELL) to get_spans
|
Many thanks, I'll fix those things up in a few hours. |
As requested
apuh3
changed the title
theOperand
added a commit
that referenced
this pull request
Jul 3, 2015
Shadowling Update 2: 121% Merge-Ready
|
Thank you very much for doing this, I'm on a bit of a hiatus because of real life issues. \o/ |
TheDZD
added a commit
to TheDZD/Paradise
that referenced
this pull request
Jul 31, 2015
GoryMoon
pushed a commit
to Ravenholdt/hdstation
that referenced
this pull request
Oct 25, 2020
Shadowling Update 2: 121% Merge-Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a remake of #9540, which should've probably been merged ages ago but wasn't, then should've been remade ages ago, but wasn't because Xhuis was presumably run over by an ambulance.
I shuffled a bit of the code around in the shadowling veil ability to make it more readable, and cut out some copypasted code, fixed some bugs, and made it darken monitors.
Fixes #9021, fixes #9794, fixes #9538, fixes #9197. More generally, should fix any item ever not getting its light cut by veil, whether the item is on the ground or being worn/held/pocketed.
I'm not sure if shadowling is in the rotation, but it's even more probably 100% ready to go with these changes than ever before.