You can no longer eat/drink or consume pills while having a mask/helmet covering your mouth. #3230
Conversation
|
complete shit close posthaste 👎 Just kidding, this will make a lot of people very mad so I love it. 👍
|
|
👍 take off your fucking internals to eat fuck |
This comment was marked as abuse.
This comment was marked as abuse.
|
mixed emotions |
|
awesome. |
|
My opinion is that stuff like this makes SS13 what it is, so yes 👍 |
Why? How does this make sense? Why make an exception if you want to prevent them from revealing their true identity? Or do you mean the opposite, to ENCOURAGE them to reveal their true identity, they are exceptions to this? Being protected from being forcefed shit for wearing normal masks, but penalized for wearing mime/clown masks, that's unfair |
|
To prevent clowns and mimes from revealing their true identity, their masks is an exception to this restriction. |
|
You could add eating through masks to SWAT masks too since they are On Sat, Mar 29, 2014 at 7:09 PM, ZeroZiat notifications@github.com wrote:
|
|
clown/mime masks are more like a wig and facepaint than actual masks though they work as internals fnr |
|
They work like internals so clowns and mimes don't have to take off their On Sat, Mar 29, 2014 at 7:26 PM, Anonus notifications@github.com wrote:
|
|
I like of this, more realism is better. Aside from that, I looked over the coding, it does not look like this applies to the space helmets, only children of the gas mask in clothing.dmi (space helmets are separate items in there). It might be easier to make use of the MASKCOVERSMOUTH and HEADCOVERSMOUTH flags somehow, but I don't know how to carry over the excepted masks in that case. That would imply you would have to redo the code target the mouth to eat though, which we do not already, probably due to convenience and/or laziness. It would be neat if we had to target the mouth with fluid containers to drink (or force drink) too, but one thing at a time I guess. |
|
I can remove the flags from those masks, but that also means things like CPR and all other things using the MASKCOVERSMOUTH (which it actually does) will change behaviour, I though this way is better. |
|
I am not a maintainer so I cannot really say if they would allow it this way, I suggest asking in the IRC for more immediate feedback. Alternatively you could @ request them here, but that is going to be slower. |
|
You can do @ tgstation/commit-access to ping every maintainer no matter who they are. Personally I would have used the slot flags to tell if you can eat something or not. If that means changing up other things, that's fine. It's kind of dumb that clown/mime masks block your face anyways. |
|
Don't all maintainers have the entire repo on notice anyway? I get mails
|
|
-snip |
|
Rip in peace donkie eaten by maintainers. |
|
Can't see anything wrong with the code here 👍 Why a var rather than a new flag though? |
|
I felt it produced more mess than was necessary, but I might been wrong. |
Pretty much this. 👎 |
You are on the list |
|
Always nice to see that people still hate mining. 👍 |
|
Never stopped |
|
someone on ooc said miner suits would have hamburger slots where you can just put a hamburger for the wearer to eat |
|
Very american |
|
👎 Gameplay should trump realism |
|
👎 Unless you somehow make stim pills and hivelord cores snowflake items that can be eaten through masks. |
|
Oh no I will have to TAKE MY MASK OFF.
|
|
Yeah I don't really get all the chagrin. It'll make eating rooms a bit more Just another reason to take your gear off. On Wed, Apr 2, 2014 at 8:09 AM, Miauw62 notifications@github.com wrote:
|
|
Other ideas to fix the beepskysmash issue:
|
|
@Man-Shroom- it'll require some effort to slap on something deathly poisoning on someone. Like removing their mask first. Holy shit antags today want everything on a goddamn silver platter. |
|
Force feeding should be must easier if the person is bucklecuffed. |
|
This would just make the game more tedious even from a non-antag point of view, bad idea. |
Then what the fuck is the point of this pull request. Is it realism? It's even more unrealistic for miners to have to take of their space helmet in space so they can use tools that are practically REQUIRED to do their job. |
|
eating through a spacesuit in space is stoopid |
|
3 maintainers agree its ok, its going in |
You can no longer eat/drink or consume pills while having a mask/helmet covering your mouth.
|
Damnit Raz, there were changes that could have been made ;_; On Wed, Apr 2, 2014 at 7:31 PM, Razharas notifications@github.com wrote:
|
|
Hivelord remains will still work because they're not actual food items but stim pills a useless now |
|
Terrible and adds nothing. |
This fixes annoying situations such as being tazered then forcefed a beepskysmash, also fixes my immersions.
To prevent clowns and mimes from revealing their true identity, their masks is an exception to this restriction.
I am fully aware that the whole logic behind my code is abit messy, I just didn't know how else I'd do it, especially with the clown/mime exceptions (alloweat var). I would be very glad if I got some constructive critism that I could improve the code with.