Fix MC tab showing for mentors

tgstation · Jul 26, 2023 · da73fde · da73fde
1 parent f060b09
commit da73fde
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/code/controllers/subsystem/statpanel.dm b/code/controllers/subsystem/statpanel.dm
@@ -49,13 +49,16 @@ SUBSYSTEM_DEF(statpanels)
 		if(!target.holder)
 			target.stat_panel.send_message("remove_admin_tabs")
 		else
-			target.stat_panel.send_message("update_split_admin_tabs", target?.prefs.split_admin_tabs)
+			target.stat_panel.send_message("update_split_admin_tabs", target.prefs.split_admin_tabs)
 
-			if(!("MC" in target.panel_tabs) || !("Tickets" in target.panel_tabs))
+			if(!("Tickets" in target.panel_tabs))
 				target.stat_panel.send_message("add_admin_tabs", target.holder.href_token)
 
-			if(target.stat_tab == "MC" && ((num_fires % mc_wait == 0) || target?.prefs.fast_mc_refresh))
-				set_MC_tab(target)
+			if(check_rights_for(target, R_DEBUG))
+				if(!("MC" in target.panel_tabs))
+					target.stat_panel.send_message("add_mc_tab")
+				if(target.stat_tab == "MC" && ((num_fires % mc_wait == 0) || target.prefs.fast_mc_refresh))
+					set_MC_tab(target)
 
 			if(target.stat_tab == "Tickets" && num_fires % default_wait == 0)
 				set_tickets_tab(target)

diff --git a/html/statbrowser.js b/html/statbrowser.js
@@ -965,10 +965,13 @@ Byond.subscribeTo('update_split_admin_tabs', function (status) {
 
 Byond.subscribeTo('add_admin_tabs', function (ht) {
 	href_token = ht;
-	addPermanentTab("MC");
 	addPermanentTab("Tickets");
 });
 
+Byond.subscribeTo('add_mc_tab', function () {
+	addPermanentTab("MC");
+});
+
 Byond.subscribeTo('update_sdql2', function (S) {
 	sdql2 = S;
 	if (sdql2.length > 0 && !verb_tabs.includes("SDQL2")) {