Add -map-threads parameter support + 510 backwards compatibility and testing #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cyberboss
added
Feature
Cyberboss
commented
Apr 29, 2023
src/Tgstation.Server.Host/Components/Byond/ByondInstallation.cs
Outdated
Show resolved
Hide resolved
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
2 times, most recently
from
d8eff16
to
32aaeca
Compare
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
from
32aaeca
to
e1f471b
Compare
Cyberboss
commented
Apr 29, 2023
src/Tgstation.Server.Host/Components/Byond/ByondInstallerBase.cs
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…nto 1458-AddMapThreadsParam
Merged
- New global CI cache for BYOND zips - VersionsTest now caches the BYOND versions it tests - Move some classes around
…nto 1458-AddMapThreadsParam
Fixed issues with testing bridge limits in 515. Added LiveTests helper to get all DreamDaemon processes. Assert Live tests port usage is >= 10000 to ensure we get maximum url length for bridge tests.
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
from
a755c7e
to
37316cc
Compare
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
from
adb60c5
to
ad26b28
Compare
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
from
ad26b28
to
f707d78
Compare
|
Need to bisect the version where the BYOND linux bug is fixed |
Cyberboss
force-pushed
the
1458-AddMapThreadsParam
branch
from
b909bfd
to
64564fa
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1464 +/- ##
==========================================
+ Coverage 92.68% 95.01% +2.33%
==========================================
Files 597 606 +9
Lines 122171 126336 +4165
==========================================
+ Hits 113229 120035 +6806
+ Misses 8942 6301 -2641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
Windows firewall rule names for DreamDaemon now include the BYOND version number.
Fix priority topic sends not being able to be interrupted.
/:cl:
🆑 HTTP API
Added the
mapThreadsfield to the DreamDaemon model. This can be set to 0 to use the default value or a higher number to be added to DreamDaemon command lines. Only applies to supported BYOND versions.Added DreamDaemon right
524288for changing themapThreadsfield./:cl:
Also preliminary DMAPI changes for BYOND backwards compatibility, but running into issues I need to narrow down.
Merge with
[APIDeploy][NugetDeploy]Closes #1458