Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -map-threads parameter support + 510 backwards compatibility and testing #1464

Merged
merged 84 commits into from
Jul 13, 2023
Merged

Add -map-threads parameter support + 510 backwards compatibility and testing #1464

merged 84 commits into from
Jul 13, 2023

Commits on Apr 29, 2023

  1. Add -map-threads parameter support

    @Cyberboss
    Cyberboss committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    e1f471b View commit details
    Browse the repository at this point in the history

  2. Add additional testing for BYOND features like dd.exe and -map-threads.

    @Cyberboss
    Cyberboss committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    a7a8c92 View commit details
    Browse the repository at this point in the history

  3. Windows firewall rules now specify which version of BYOND they are for.

    @Cyberboss
    Cyberboss committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    83ef8c5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    6b0a412 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' of https://github.com/tgstation/tgstation-server i… 

    …nto 1458-AddMapThreadsParam
    @Cyberboss
    Cyberboss committed Apr 29, 2023
    Configuration menu
    Copy the full SHA
    ec2e4be View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    3a63170 View commit details
    Browse the repository at this point in the history

  2. CachingFileDownloader now builds the cache 

    - New global CI cache for BYOND zips
- VersionsTest now caches the BYOND versions it tests
- Move some classes around
    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    51b7792 View commit details
    Browse the repository at this point in the history

  3. Backwards compatibility DMAPI tests

    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    f3df371 View commit details
    Browse the repository at this point in the history

  4. Fix secure.byond.com links

    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    69af0ac View commit details
    Browse the repository at this point in the history

  5. LUMMOX SAID 1609 FOR MAP THREADS 

    https://www.byond.com/forum/post/2873746
    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    76cc15a View commit details
    Browse the repository at this point in the history

  6. Merge branch 'dev' of https://github.com/tgstation/tgstation-server i… 

    …nto 1458-AddMapThreadsParam
    @Cyberboss
    Cyberboss committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    6ad5f62 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Configuration option to disable dd.exe usage 

    Fixed issues with testing bridge limits in 515.

Added LiveTests helper to get all DreamDaemon processes.

Assert Live tests port usage is >= 10000 to ensure we get maximum url length for bridge tests.
    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1a3e0fe View commit details
    Browse the repository at this point in the history

  2. Fix IrcProvider indentation

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    33d8dca View commit details
    Browse the repository at this point in the history

  3. Fix SessionController.SetRebootState return value

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    d441f50 View commit details
    Browse the repository at this point in the history

  4. Revert the config change for not using DD.exe 

    It presents complications with pre-existing TGS setup firewall rules.
    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    fb47ad5 View commit details
    Browse the repository at this point in the history

  5. Fix EDGE DMAPI check

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    541d37a View commit details
    Browse the repository at this point in the history

  6. 512 DMAPI compatibility

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    18c03a9 View commit details
    Browse the repository at this point in the history

  7. 511 DMAPI compatibility + CI

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    8dd181d View commit details
    Browse the repository at this point in the history

  8. 510 DMAPI CI

    @Cyberboss
    Cyberboss committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    5957095 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    a298ba4 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    6f598f3 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    9c6a806 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    f40a2c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Deal with that annoying file that appears after migration generation

    @Cyberboss
    Cyberboss committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    776c804 View commit details
    Browse the repository at this point in the history

  2. Regenerate MapThreads migration as it has drifted

    @Cyberboss
    Cyberboss committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    21e7986 View commit details
    Browse the repository at this point in the history

  3. Fix some ArgumetNullException checks

    @Cyberboss
    Cyberboss committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    a737238 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    13d5bde View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    72afd1f View commit details
    Browse the repository at this point in the history

  2. Change Processes to use .WaitForExitAsync() 

    - Remove custom exit handler.
- Move exit handling into `Tgstation.Server.Host.System.Process`.
- Adjust `IProcessExecutor.LaunchNew` signature.
- `IProcessBase.Lifetime` result now nullable to represent a detach.
- Await `Lifetime` in dispose.
    @Cyberboss
    Cyberboss committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4eb19e7 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary SessionConfiguration from WindowByondInstaller`

    @Cyberboss
    Cyberboss committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f2d70f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Merge branch 'dev' into '1458-AddMapThreadsParam'

    @Cyberboss
    Cyberboss committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    d47f671 View commit details
    Browse the repository at this point in the history

  2. Update README badges somewhat

    @Cyberboss
    Cyberboss committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    70f0033 View commit details
    Browse the repository at this point in the history

  3. Fix issues with CachingFileDownloader in actions

    @Cyberboss
    Cyberboss committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    89b3209 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Fix use after Dispose() race condition

    @Cyberboss
    Cyberboss committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4fb57b6 View commit details
    Browse the repository at this point in the history

  2. Adjust runsettings for GitHub test logger

    @Cyberboss
    Cyberboss committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d2939c4 View commit details
    Browse the repository at this point in the history

  3. More verbose test output for actions

    @Cyberboss
    Cyberboss committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7a91ab2 View commit details
    Browse the repository at this point in the history

  4. Test oldest compatible BYOND version in Live test

    @Cyberboss
    Cyberboss committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    c1f4393 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into 1458-AddMapThreadsParam

    @Cyberboss
    Cyberboss committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f31be02 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Fix issues with the GetCommandLine test helper

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    7e0af87 View commit details
    Browse the repository at this point in the history

  2. Fix usage of TopicClient in live tests

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    6e1b6a6 View commit details
    Browse the repository at this point in the history

  3. Fix possible race condition in DummyChatProvider

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    05a4f89 View commit details
    Browse the repository at this point in the history

  4. Fix test instance backwards naming

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    744e183 View commit details
    Browse the repository at this point in the history

  5. Suppress DMAPI tests warning

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    4bcb3c4 View commit details
    Browse the repository at this point in the history

  6. Error the DMAPI build if BYOND is too out of date

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    ccef09d View commit details
    Browse the repository at this point in the history

  7. Add an additional log message exception

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    e10f03e View commit details
    Browse the repository at this point in the history

  8. Make things slightly more debuggable

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    009b851 View commit details
    Browse the repository at this point in the history

  9. Only expect channels while we can guarantee them

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    0b92f63 View commit details
    Browse the repository at this point in the history

  10. Fix priority SendRawTopic erroring when cancelled

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    2b53227 View commit details
    Browse the repository at this point in the history

  11. Inconclusive map threads test until release. 

    Also fix lack of loggers in calls to InitializeByondVersion
    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    93cfea6 View commit details
    Browse the repository at this point in the history

  12. Fix a bunch of tests being inconclusive in CI

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    6ece669 View commit details
    Browse the repository at this point in the history

  13. Do not catch topic timeouts

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    b3fc355 View commit details
    Browse the repository at this point in the history

  14. Remove unnecessary reallocations

    @Cyberboss
    Cyberboss committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    d4470e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2023

  1. Bookend where the compat tests start and end

    @Cyberboss
    Cyberboss committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    9c8fc14 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of https://github.com/tgstation/tgstation-server i… 

    …nto 1458-AddMapThreadsParam
    @Cyberboss
    Cyberboss committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    b86837c View commit details
    Browse the repository at this point in the history

  3. Don't run compat tests in GitHub actions 

    Contention triggers the topic issue. If it breaks we can add it back and bug Lummox to try and figure out the cause of it.
    @Cyberboss
    Cyberboss committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    32c6533 View commit details
    Browse the repository at this point in the history

  4. Increase live tests topic timeout to 5s

    @Cyberboss
    Cyberboss committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    60bf46e View commit details
    Browse the repository at this point in the history

  5. Run compat test then edge test

    @Cyberboss
    Cyberboss committed Jul 9, 2023
    Configuration menu
    Copy the full SHA
    0745fef View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. Again, disable compat tests in GitHub actions

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    3ae1117 View commit details
    Browse the repository at this point in the history

  2. Revert bad merge

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0bcb985 View commit details
    Browse the repository at this point in the history

  3. Do not create processStartTcs unnecessarily

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9ce06dd View commit details
    Browse the repository at this point in the history

  4. Increase Live tests topic timeout to 10s

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8d09bc8 View commit details
    Browse the repository at this point in the history

  5. Add FifoSemaphore and test

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    a436233 View commit details
    Browse the repository at this point in the history

  6. Make session topic calls exclusive FIFO

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b6ced2b View commit details
    Browse the repository at this point in the history

  7. Increase timeout for compat test BYOND install

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c290e92 View commit details
    Browse the repository at this point in the history

  8. I am once again asking you to run the compat tests

    @Cyberboss
    Cyberboss committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0ab023f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Fix issues with event message queuing and detaches

    @Cyberboss
    Cyberboss committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1747f79 View commit details
    Browse the repository at this point in the history

  2. More logging when DD terminates in test

    @Cyberboss
    Cyberboss committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    aad09cc View commit details
    Browse the repository at this point in the history

  3. Do not cleanup temp dir at end of tests 

    Still cleans at beginning
    @Cyberboss
    Cyberboss committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    590faee View commit details
    Browse the repository at this point in the history

  4. Skip compat tests in GitHub actions for now 

    There's an issue with the cwd on Linux
    @Cyberboss
    Cyberboss committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0e9958f View commit details
    Browse the repository at this point in the history

  5. Additional testing for FifoSemaphore

    @Cyberboss
    Cyberboss committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0a492cb View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Additional logging when a topic request completes

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    dca716f View commit details
    Browse the repository at this point in the history

  2. Debug logging for DMAPI to hunt the dd topic issue

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    cf59163 View commit details
    Browse the repository at this point in the history

  3. Remove non-existent file from .sln

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    bd2872a View commit details
    Browse the repository at this point in the history

  4. Additional DMAPI test logging

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    13bc6ec View commit details
    Browse the repository at this point in the history

  5. Add missing DMAPI return

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    78d5a89 View commit details
    Browse the repository at this point in the history

  6. Fix compat tests chat job sometimes not being created in time

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8301e6b View commit details
    Browse the repository at this point in the history

  7. Additional /world/Export logging

    @Cyberboss
    Cyberboss committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    772e884 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Add a .NET update todo

    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0e43726 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary whitespace

    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9a1634e View commit details
    Browse the repository at this point in the history

  3. Add usings for redirected process std handles

    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    7dbcdce View commit details
    Browse the repository at this point in the history

  4. Re-enable compat tests in actions 

    Against my better judgement
    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    37316cc View commit details
    Browse the repository at this point in the history

  5. Fix /usr/bin/dotnet for systemd testing

    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    3159c4c View commit details
    Browse the repository at this point in the history

  6. Do not support 510 with system watchdog on Linux

    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f707d78 View commit details
    Browse the repository at this point in the history

  7. Disable system watchdog compat tests on Linux 

    TODO: #1592
    @Cyberboss
    Cyberboss committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    64564fa View commit details
    Browse the repository at this point in the history