Linting, docs, package updates, project cleanups, and swarm PublicAddresses
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Higher rate limit
- Move `Tgstation.Server.Host.Common.Constants` to `Tgstation.Server.Common`. - Use `Tgstation.Server.Common.Constants.CanonicalPackageName` in strings everywhere where it makes sense. - Add `SrcCommon.props` to dedupe more .csproj properties. - Rename `TgsNugetNetVersion` to `TgsNugetNetFramework` and move to `Version.props`. - Change Nugets packages' author to just `Jordan Dominion`. - Fix name of wix extensions namespace. - Update Octokit to `7.0.0`. - Add missing documentation comment for `PackageReference`.
- Switch back to programmatic installs with the help of the Nuget package we use in `Tgstation.Server.Migrator`. - Document usage of `Microsoft.Extensions.Hosting.WindowsServices`.
Every returned service must always be disposed.
- `ConfigVersion` to 4.7.0. - Add setup wizard prompt. - `README.md` update. - Update live tests.
Cyberboss
added
Refactor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Also .gitignore ALL `launchSettings.json`s
- Change `.dockerignore` to use a blacklist for `/build` instead of whitelist. - Add missing `SrcCommon.props` to initial `COPY`s.
Cyberboss
force-pushed
the
MoreFeaturesBecauseWhyNot
branch
from
bef098d
to
efadd9a
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1584 +/- ##
==========================================
- Coverage 92.70% 92.69% -0.02%
==========================================
Files 597 597
Lines 122139 122168 +29
==========================================
+ Hits 113227 113240 +13
- Misses 8912 8928 +16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃啈
Fixed a warning that could occur with GitHub deployments enabled.
/:cl:
馃啈 Configuration
The new configuration version is 4.7.0.
Added
Swarm:PublicAddressthis address is simply included in the response to/on the main HTTP API. Clients can use this as a hint to talk to other servers in the swarm without additional user input./:cl:
API version bump pending #1464