Skip to content

Commit

Permalink
Virtual Domains now have certain areas protected from ghost role inte…
Browse files Browse the repository at this point in the history
…rference (#82960)

## About The Pull Request

This touches up on the bitrunning ghost roles that come with some maps,
namely Corsair Cove and Syndicate Assault.

The gist of it is: Ghost role spawners and Digital Anomalies (the random
event boss mobs) are now restricted from entering the VDOM safehouse,
and other areas where critical equipment is stored.

Here's an example from Syndicate Assault -- The X-ed out area is
considered "out of bounds" for digital anomalies/ghost roles:

![image](https://github.com/tgstation/tgstation/assets/28870487/b0752dd4-102b-4b64-8c21-c100a58c1a96)

Additionally, this also fixes the matter of pirate ghost role spawns
creating their own antag datum/pirate team, which would carry into the
roundend report. Since these are no longer legitimate pirate spawners
and are now specifically designed spawners for virtual domains.

Naturally, emagging the server jailbreaks all of these restrictions and
notifies any virtual entities.

The new subtype of spawners should also be scalable enough that new
VDOMs should be able to implement new ghost role spawners with ease.
## Why It's Good For The Game

It's one thing to have sentient mobs to fight, which can shake up the
otherwise somewhat static nature of bitrunning maps, but when players
are tossing equipment, spawncamping, or otherwise making it impossible
for the runners to fight them it ends up being unfun for everyone
involved. You can't get into a good fight with a bitrunner avatar if
their only recourse is to wipe the map and everything (YOU) in it.

This ensures a level of fairness between the (typically vindictive)
ghost roles of a VDOM and the players.

Also, pirate spawns don't make a new pirate team/datum. That's one of
the fixes I was aiming for with this.
## Changelog
:cl: Rhials
balance: Virtual domain ghost roles can no longer enter the
safehouse/"equipment" areas of a domain.
fix: Pirate virtual domain ghost roles will no longer make a pirate team
antag datum.
/:cl:

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
  • Loading branch information
Rhials and jlsnow301 committed May 7, 2024
1 parent d6e492f commit 6aa0dee
Show file tree
Hide file tree
Showing 12 changed files with 528 additions and 344 deletions.
467 changes: 243 additions & 224 deletions _maps/virtual_domains/pirates.dmm

Large diffs are not rendered by default.

78 changes: 44 additions & 34 deletions _maps/virtual_domains/psyker_zombies.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"h" = (
/obj/structure/rack,
/turf/open/indestructible/dark,
/area/ruin/space/has_grav/powered/virtual_domain)
/area/virtual_domain/protected_space)
"i" = (
/obj/structure/sign/warning/directional/east,
/turf/open/chasm,
Expand Down Expand Up @@ -61,10 +61,20 @@
/obj/effect/mapping_helpers/airlock/abandoned,
/turf/open/indestructible/dark,
/area/ruin/space/has_grav/powered/virtual_domain)
"D" = (
/turf/open/indestructible/dark,
/area/virtual_domain/protected_space)
"F" = (
/obj/structure/mystery_box/guns,
/turf/open/indestructible/dark,
/area/ruin/space/has_grav/powered/virtual_domain)
/area/virtual_domain/protected_space)
"I" = (
/turf/closed/indestructible/binary,
/area/virtual_domain/protected_space)
"J" = (
/obj/machinery/door/airlock/abductor,
/turf/open/indestructible/dark,
/area/virtual_domain/protected_space)
"K" = (
/obj/effect/baseturf_helper/virtual_domain,
/turf/closed/indestructible/binary,
Expand Down Expand Up @@ -530,10 +540,10 @@ Y
Y
a
Y
a
a
a
a
I
I
I
I
a
a
a
Expand All @@ -557,10 +567,10 @@ Y
Y
Y
Y
a
I
h
Y
Y
D
D
t
t
t
Expand All @@ -584,10 +594,10 @@ X
Y
Y
Y
a
I
F
Y
Y
D
D
t
t
t
Expand All @@ -611,10 +621,10 @@ a
Y
Y
Y
a
Y
Y
Y
I
D
D
D
t
t
t
Expand All @@ -638,10 +648,10 @@ Y
Y
Y
Y
T
Y
Y
Y
J
D
D
D
t
t
t
Expand All @@ -665,10 +675,10 @@ Y
R
Y
Y
a
Y
Y
Y
I
D
D
D
t
t
t
Expand All @@ -692,10 +702,10 @@ Y
Y
Y
Y
a
I
F
Y
Y
D
D
t
t
t
Expand All @@ -719,10 +729,10 @@ a
a
Y
Y
a
I
h
Y
Y
D
D
t
t
t
Expand All @@ -746,10 +756,10 @@ a
a
a
Y
a
a
a
a
I
I
I
I
a
a
a
Expand Down

0 comments on commit 6aa0dee

Please sign in to comment.