Chaplain Maintenance Sect "Adapted Eyes" from Rites are too vulnerable and inconsistent.

[Learner10]

Round ID:

162799

Testmerges:

#59205: 'Lowers the cold temperature activation threshold for fire alarms/firelocks' by Yenwodyah at commit dac69ce
#59232: 'Integrated Circuits (Wiremod)' by Watermelon914 at commit 7cfa773

Reproduction:

Pick and choose Maintenance Sect as the Chaplain, build favor until you can achieve Adapted Eyes, then become blind from standing close to an APC.

The Adapted Eyes have an issue where having blindness caused by worn objects provide no protection from anything remotely lit. Even wearing a blindfold will cause your eyes to burn simply for standing next to a monitor, let alone being in a closet surrounded by walls. If light shines on the closet, your eyes burn.
On top of that, the eyes make no difference between a lighter, and a floodlight. If it's light, you go blind, regardless if you can even see it. This all adds to to a very punishing experience at the end of the day.

[ATH1909]

do your eyes still not unblind you properly once you get back into darkness for a while?

[Mooshimi]

do your eyes still not unblind you properly once you get back into darkness for a while?

I saw a chaplain around and they had to go onto the ice wastes to regain sight, breaking the lights on station wasn't enough of a full darkness for them to heal.

[timothymtorres]

Relevant code:

tgstation/code/modules/surgery/organs/eyes.dm

Lines 490 to 499 in e59e14a

	/obj/item/organ/eyes/night_vision/maintenance_adapted/on_life(delta_time, times_fired)
	var/turf/owner_turf = get_turf(owner)
	var/lums = owner_turf.get_lumcount()
	if(lums > 0.5) //we allow a little more than usual so we can produce light from the adapted eyes
	to_chat(owner, span_danger("Your eyes! They burn in the light!"))
	applyOrganDamage(10) //blind quickly
	playsound(owner, 'sound/machines/grill/grillsizzle.ogg', 50)
	else
	applyOrganDamage(-10) //heal quickly
	. = ..()

To fix this we need to do the following:

// isturf is used to check if we are in a locker or container
if(!HAS_TRAIT(owner, TRAIT_BLIND) && isturf(owner.loc) && owner.has_light_nearby(light_amount=0.5))
  //do damage calculations