Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Damage Detection for Maintenance adapted eyes. #72700

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

Mey-Ha-Zah
Copy link
Contributor

@Mey-Ha-Zah Mey-Ha-Zah commented Jan 14, 2023

About The Pull Request

Fixes the eyes by using the code timothymtorres suggested.

Changes an IF check to better detect light and apply damage to maintenance adapted eyes.

fixes #59285

Why It's Good For The Game

Fixes a buggy light sensitivity issue.

Changelog

🆑
fix: improved maintenance eyes light detection.
/:cl:

Fixes the eyes by using the code timothymtorres suggested.
@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Jan 14, 2023
@tralezab
Copy link
Contributor

good pr :^)

@timothymtorres
Copy link
Member

Don't forget to autolink the issue so it's closed when the PR is merged. Do this by including the following to your PR title.

Fixes #59285

Other than that, good work!

@Time-Green Time-Green merged commit 7005e89 into tgstation:master Jan 16, 2023
github-actions bot added a commit that referenced this pull request Jan 16, 2023
comfyorange added a commit that referenced this pull request Jan 16, 2023
Time-Green pushed a commit that referenced this pull request Jan 16, 2023
…72700 (#72761)

## About The Pull Request

#72700 made reference to a trait that doesn't actually exist, I've
swapped it out with the correct thingy.
## Why It's Good For The Game

To be honest its not, this fix allows the code to compile which means we
will continue playing this god forsaken game.
## Changelog
:cl:
fix: Maintenance adapted eyes no-longer prevent the game from compiling
/:cl:
@Mey-Ha-Zah Mey-Ha-Zah deleted the Maint-Eyes branch January 17, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chaplain Maintenance Sect "Adapted Eyes" from Rites are too vulnerable and inconsistent.
5 participants