Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello! New icons! #11

Merged
merged 1 commit into from
Jan 22, 2012
Merged

Hello! New icons! #11

merged 1 commit into from
Jan 22, 2012

Conversation

Doohl
Copy link

@Doohl Doohl commented Jan 22, 2012

No description provided.

Doohl added a commit that referenced this pull request Jan 22, 2012
@Doohl Doohl merged commit bb8c999 into tgstation:master Jan 22, 2012
caelaislinn pushed a commit to caelaislinn/-tg-station that referenced this pull request Sep 19, 2013
Test Commit - Reduced running speed to be similar to BS12. Increased
Giacom pushed a commit that referenced this pull request Jun 16, 2014
phil235 pushed a commit that referenced this pull request Jul 21, 2015
Razharas pushed a commit that referenced this pull request Oct 19, 2015
Core0verload pushed a commit to Core0verload/-tg-station that referenced this pull request Apr 5, 2016
Фикс для пары косяков из моего прошлого пулла
Iamgoofball referenced this pull request in Iamgoofball/-tg-station Mar 24, 2017
* Vending machine update initial commit.

* Template

* Fixes map errors?
Viol pushed a commit to VigilSS13/tgstation that referenced this pull request Apr 4, 2017
ShizCalev referenced this pull request in ShizCalev/tgstation Jul 24, 2017
ninjanomnom referenced this pull request in ninjanomnom/tgstation Nov 14, 2017
AKlimentyev pushed a commit to Shadowlightbackup/-tg-station that referenced this pull request Nov 28, 2017
Adds Dorf Clothes and Armor, fixes Booze Organ and NEW DORF RUIN
ghost pushed a commit to 4dplanner/tgstation that referenced this pull request Jul 12, 2019
ninjanomnom pushed a commit that referenced this pull request Jul 24, 2019
* Initial work

* more

* ass

* wsedfwedff

* asss

* test

* stuff

* fuck

* sss

a

* kms

* asdadwedwdfwefwef

* start

* test

* dwwdew

* ewefwfef

* Redemption machine (#8)

* Redemption machine

* Removes debug messages

* changes

* fuckmyshitup

* coin mint works with new material shenanigans (#10)

* Auto stash before merge of "materials" and "origin/materials"

* woops

* furnace (#11)

* autolathe manufacturing of toolboxes

* eggs in a basket

* some small changes

* matcolors

* documentation

* more documentation and effects

* done

* Color man bad (#12)

* fixes designs

* ass

* more fixes

* fuck me

* firestacks adder

* epic fixes

* fixes designs

* DONE DIDDILY DOO

* removes category macro

* ch-ch-ch-changes

* fixes some stuff

* Fixes display of ore values (#9)

* Redemption machine

* Removes debug messages

* Re-adds value display

* Replaces the fire stacking component with an element instead (#13)

* fixes examine

* fixes ligma bugs

* double ligma boofus

* fix

* misses some defines

* fixes ORM

* Update code/datums/components/material_container.dm

Co-Authored-By: Emmett Gaines <ninjanomnom@gmail.com>

* fixes

* Makes glass objects weaker (#14)

* Makes glass objects weaker

* uses correct proc

* fixes shit

* honk honk

* better

* oh shit oh fuck

* fixes

* fuck ORMs

* fixes the biogen

* documentation

* ass (#15)

* component

* changes

* ass

* ass

* doc

* Auto stash before merge of "materials-plasmacomponent" and "origin/materials-plasmacomponent"

* fixes rounding

* fixed
Dennok referenced this pull request in Dennok/Dennok_tgstation Jul 24, 2019
# This is the 1st commit message:

Lowers jetpack speed boost (tgstation#44777)

* Lowered jetpack speed boost

* -1 is now -0.25

# This is the commit message #2:

Automatic changelog generation for PR tgstation#44777 [ci skip]
# This is the commit message #3:

weak (tgstation#44894)


# This is the commit message #4:

Automatic changelog generation for PR tgstation#44894 [ci skip]
# This is the commit message #5:

Decrease BYOS cost to 2500 (tgstation#45083)

* Decrease BYOS cost to 500

About The Pull Request:
Pretty self explanatory. Changes the cost of the Build your own Shuttle from 5000 to 500.

Why It's Good For The Game:
It's completely ludicrous to have a shuttle that has to be called within the first 10 minutes of the shift cost more funds than the station starts with. However, considering it comes with supplies and has certain benefits, it definitely shouldn't be free or give money either. This corrects the overcorrecting done with the previous BYOS balance change.

   🆑 DeeDubya
   tweak: Decreased the cost of the BYOS from 5000 to 500, making the shuttle a realistic option once more. Have fun!
   /🆑

* Update shuttles.dm

# This is the commit message #6:

Automatic changelog generation for PR tgstation#45083 [ci skip]
# This is the commit message #7:

Fixes surgery runtime. (tgstation#45042)

* fixes surgery runtime

* ?

* Update surgery.dm

# This is the commit message #8:

Fixes experimentally cobbisected techwebs, and prevents it from happening again (tgstation#45096)

* fix techwebs

* proper fix

# This is the commit message #9:

Automatic changelog generation for PR tgstation#45096 [ci skip]
# This is the commit message #10:

Fix unreliability of dmdoc GitHub links

# This is the commit message #11:

Fixes whitespace issues with human and cult rune examines (tgstation#45094)

* cult runes

* humans

# This is the commit message #12:

Lets the kinetic crusher be one-hand carried (tgstation#45110)

* Onehands, need sprites.

* onehand icons, light action.

* light fix

# This is the commit message #13:

Automatic changelog generation for PR tgstation#45110 [ci skip]
# This is the commit message #14:

Changes how disease biotypes are added (tgstation#45099)

* Makes inorganic biology and necrotic metabolism work immediately.

* Uhhh dont need that.

# This is the commit message #15:

Automatic changelog generation for PR tgstation#45099 [ci skip]
# This is the commit message #16:

drinksprites (tgstation#45088)


# This is the commit message #17:

Automatic changelog generation for PR tgstation#45088 [ci skip]
# This is the commit message #18:

Convert some code docs into the auto doc format (tgstation#45101)

* Document datum, area,atom and some of the mob code

* Update

* Documented mob_helpers poorly

* Brief treatise on mob movement iself

* sdfasdf

* Add title to treaties

* Move readme file for say

* more say stuff for mobs

* Document login and status procs

* Add some goddan links like a boss

* Document some atom vars

# This is the commit message tgstation#19:

Removes slaughterlings. (tgstation#45087)


# This is the commit message tgstation#20:

Automatic changelog generation for PR tgstation#45087 [ci skip]
# This is the commit message tgstation#21:

Paperplanes no longer delete their paper twice. (tgstation#45074)

* Paperplanes paper

* yeah you're right. I'm wrong

# This is the commit message tgstation#22:

Fixes revolvers being spun when they fail to spin (tgstation#45092)


# This is the commit message tgstation#23:

Makes nuclear particles no longer give toxin damage directly. (tgstation#44990)

* Makes nuclear particles do stamina instead of toxin.

* Update nuclear_particle.dm

* Makes xray beams and nuclear particles roll for rad armour.

# This is the commit message tgstation#24:

Automatic changelog generation for PR tgstation#44990 [ci skip]
# This is the commit message tgstation#25:

Changes PKM examine (tgstation#44897)

* Changes PKM to use screwdriver to remove modules

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull request process. -->

## About The Pull Request
Uses a screwdriver instead of the crowbar(????) to remove modules from it

<!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! -->

## Why It's Good For The Game
Its more intuitive and a lot more consistent with other upgrades and weapons, which use a screwdriver. Also the imagine of using a massive crowbar to pry out a module, whilst funny, isn't really ideal.

<!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. -->

## Changelog
:cl:
tweak: PKM now uses screwdriver to remove modules
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->

* Update kinetic_accelerator.dm

* Update kinetic_accelerator.dm

* Update kinetic_accelerator.dm

* Rrrrrreview

# This is the commit message tgstation#26:

Automatic changelog generation for PR tgstation#44897 [ci skip]
# This is the commit message tgstation#27:

blocks shove knockdown is now a clothing flag. (tgstation#45107)

* blocks shove knockdown is now a clothing flag.

* comment only commit

# This is the commit message tgstation#28:

Welpsies.

# This is the commit message tgstation#29:

2

# This is the commit message tgstation#30:

comment fix

# This is the commit message tgstation#31:

let's hope this define works fine

# This is the commit message tgstation#32:

Automatic changelog generation for PR tgstation#45111 [ci skip]
# This is the commit message tgstation#33:

Better conscription kit, public lavaland mining vendor (tgstation#45089)

* Better conscription kit, public lavaland mining vendor

* no includes plx

* Removes pickaxe, adds seclite.

* Removes the cargo crate.

# This is the commit message tgstation#34:

Automatic changelog generation for PR tgstation#45089 [ci skip]
# This is the commit message tgstation#35:

Cyborg intro quips animations. (tgstation#45091)

* Animated cyborg symbols

* intro quips

# This is the commit message tgstation#36:

Automatic changelog generation for PR tgstation#45091 [ci skip]
# This is the commit message tgstation#37:

Makes the abductor healing gland more interesting (tgstation#44903)

* Makes the abductor healing gland more interesting

* Implant rejection

* .

* no vomit for blood regen

* Update code/modules/antagonists/abductor/equipment/glands/heal.dm

Co-Authored-By: moo <11748095+ExcessiveUseOfCobblestone@users.noreply.github.com>

# This is the commit message tgstation#38:

Automatic changelog generation for PR tgstation#44903 [ci skip]
# This is the commit message tgstation#39:

Swarming component now gets deleted properly. (tgstation#45108)

* ? It's worth an attempt.

* attempt 2

* attempt 3

* attempt whatever

* attempt whatever and 1

* attempt whatever + 2

* return

* Update code/datums/components/swarming.dm

Co-Authored-By: MrPerson <spamtaffic@gmail.com>

# This is the commit message tgstation#40:

nerfs hunger events (tgstation#45114)


# This is the commit message tgstation#41:

Automatic changelog generation for PR tgstation#45114 [ci skip]
# This is the commit message tgstation#42:

fixes liver? (tgstation#45067)


# This is the commit message tgstation#43:

actually removes byo shuttle timer (tgstation#45124)


# This is the commit message tgstation#44:

Bye bye animal hospital. (tgstation#45070)

* byebyeanimalsurgeons

* here we go

* config

* removesbeach

* a bit more compact

* updates some vars

* fixes walls getting destroyed by other generation stuff

# This is the commit message tgstation#45:

Automatic changelog generation for PR tgstation#45070 [ci skip]
# This is the commit message tgstation#46:

fixes bola weirdness (tgstation#45127)


# This is the commit message tgstation#47:

Automatic changelog generation for PR tgstation#45127 [ci skip]
# This is the commit message tgstation#48:

Fixes preference update runtime. (tgstation#45106)


# This is the commit message tgstation#49:

PDA now accepts ID card when in inventory (tgstation#45037)

* id card pda

* cleanup

# This is the commit message tgstation#50:

Automatic changelog generation for PR tgstation#45037 [ci skip]
# This is the commit message tgstation#51:

Swappers can no longer be sent  on cargo shuttle. (tgstation#45133)


# This is the commit message tgstation#52:

Automatic changelog generation for PR tgstation#45133 [ci skip]
# This is the commit message tgstation#53:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#54:

Adds stats to creation/destruction of cleanable decals and trash on station (tgstation#44989)

* Adds stat tracking to mess on station

* Checks for maint to make sure stats aren't counting maint trash which is irrelevant to the janitor

* adds mapload arg to init

* asdasd

# This is the commit message tgstation#55:

Automatic changelog generation for PR tgstation#44989 [ci skip]
# This is the commit message tgstation#56:

Disables adjust on burial garb

# This is the commit message tgstation#57:

Automatic changelog generation for PR tgstation#45154 [ci skip]
# This is the commit message tgstation#58:

Fixes clockwork armor armor

# This is the commit message tgstation#59:

Fixes gravitokinetic guardian effect lasting after death

# This is the commit message tgstation#60:

Documentation
# This is the commit message tgstation#61:

Automatic changelog generation for PR tgstation#45141 [ci skip]
# This is the commit message tgstation#62:

Fixes runtimes when eyeless mobs are hit by paper planes and last resort

# This is the commit message tgstation#63:

qm
# This is the commit message tgstation#64:

hos
# This is the commit message tgstation#65:

cmo
# This is the commit message tgstation#66:

rd
# This is the commit message tgstation#67:

cap
# This is the commit message tgstation#68:

ce
# This is the commit message tgstation#69:

hop
# This is the commit message tgstation#70:

budget
# This is the commit message tgstation#71:

budget
# This is the commit message tgstation#72:

budget
# This is the commit message tgstation#73:

budget
# This is the commit message tgstation#74:

budget
# This is the commit message tgstation#75:

Automatic changelog generation for PR tgstation#45130 [ci skip]
# This is the commit message tgstation#76:

properly uses up mindshield implant on unconvertables

# This is the commit message tgstation#77:

Automatic changelog generation for PR tgstation#45121 [ci skip]
# This is the commit message tgstation#78:

shuttle_manipulator load fix

shuttle_manipulator on load now send shuttle to transit

# This is the commit message tgstation#79:

Automatic changelog generation for PR tgstation#44889 [ci skip]
# This is the commit message tgstation#80:

fixes self repair runtime (tgstation#45065)


# This is the commit message tgstation#81:

Automatic changelog generation for PR tgstation#45065 [ci skip]
# This is the commit message tgstation#82:

fixes runtimes related to trash in nullspace (tgstation#45160)


# This is the commit message tgstation#83:

Stacking Status Effects (tgstation#44964)

* magic numbers in saw_bleed moved to class definition

* more saw bleed abstraction

refactors p2

various stacking effect refactors

saw bleed refactors again

moves stacking status class to status_effect.dm

misc stacking changes and documentation

reverts saw_bleed functionality to original

better var names, var name fix

removes extra proc

more sane handling of application

removes unused define

changes saw bleed back to original form

* another proc that can be ovverriden for falling stacks

* fixes path

* simpifies some checks

* feedback fixes

* spelling

# This is the commit message tgstation#84:

Runtimes fixes (tgstation#44885)

* fix meter work on un initialized pipe

* fix runtime in process_cell

whet it try to call to wrong type turf

* fix roundstart runtime in debug sungery disc

*  fix return_air() runtime

Runtime in pipes.dm, line 52: Cannot read null.air

* s

* Update surgery.dm

* Update pipes.dm

* Update meter.dm

* Update LINDA_turf_tile.dm

* Disable atmos processing in outer border on load.

* Update map_template.dm

* Update map_template.dm

* Update map_template.dm

* Update pipes.dm

more runtimes for good of runtimes

# This is the commit message tgstation#85:

Automatic changelog generation for PR tgstation#44885 [ci skip]
# This is the commit message tgstation#86:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#87:

Fix cargo BZ price exploit (tgstation#45145)

Costs 4000, sells at 7496.83. Now costs 8000.
# This is the commit message tgstation#88:

Automatic changelog generation for PR tgstation#45145 [ci skip]
# This is the commit message tgstation#89:

Fix scanning mutated seeds expending their value (tgstation#45158)

a little bit of dry run for all my thirsty gamers! 💦💦💦💦
# This is the commit message tgstation#90:

Automatic changelog generation for PR tgstation#45158 [ci skip]
# This is the commit message tgstation#91:

Add assimilation bans (#45149)


# This is the commit message tgstation#92:

Remove the VTEC module (tgstation#45147)

VTEC is currently broken (as in, completely non functional) and, quite
frankly, it wouldn't be very healthy for the game if it weren't. A -2
speedmod is no joke. What's more fun than no damage slowdown borg?
That's right, one with a movespeed -2 modifier.
# This is the commit message tgstation#93:

Automatic changelog generation for PR tgstation#45147 [ci skip]
# This is the commit message tgstation#94:

Chameleon ID and PDA improvements (tgstation#45113)

Chameleon IDs and PDAs will automatically update names and icons when
changing disguise. They will also change the displayed job when
switching outfits with the chameleon combo-action.

Chameleon IDs and PDAs reset to the default name if their appearance
changes and need to be updated manually to display the proper label,
which seems like a waste of time to me. Changing the entire chameleon
loadout is very sneaky and setting the appropriate job on the ID and
PDA makes it sneakier.
# This is the commit message tgstation#95:

Automatic changelog generation for PR tgstation#45113 [ci skip]
# This is the commit message tgstation#96:

Add a new Emergency Shuttle, Transport Zeta (tgstation#45100)

Adds a new abductor themed shuttle to the game, available for 8k 
credits! The shuttle is only unlocked after alien technology has been 
researched!

The shuttle offers some unique items and layout compared to others 
currently available. Two singular entrances with the brig in the back 
means security needs to walk prisoners to the brig area to secure them. 
Unique unlock mechanism encourages either bringing alien tech back from 
Lavaland or stealing some from an abductor.

A few unique items aboard, including alien tools, the experimental 
cloner, and a void core can provide interesting opportunity if utilized 
in the window of time that the shuttle is on station.
# This is the commit message tgstation#97:

Automatic changelog generation for PR tgstation#45100 [ci skip]
# This is the commit message tgstation#98:

Hacking APC alert status now uses newest icon for APC

# This is the commit message tgstation#99:

Automatic changelog generation for PR tgstation#45170 [ci skip]
# This is the commit message tgstation#100:

Job specific ID cards (tgstation#45112)

* Job based IDs attempt one

* This doesn't actually work

* Back to overlays

* The Comment Section

* Cached flat icons

# This is the commit message tgstation#101:

Automatic changelog generation for PR tgstation#45112 [ci skip]
# This is the commit message tgstation#102:

Makes luxury shuttle more user friendly (tgstation#45084)

* makes luxury shuttle more user friendly

* Makes it so change is placed in-hand, slimes aren't told to pull something when they can't and dragged IDs override worn IDs so a bank account is looked for on them instead

* Makes it so if the change doesn't go into a human's hands, they will be pulling it behind them instead.

# This is the commit message tgstation#103:

Automatic changelog generation for PR tgstation#45084 [ci skip]
# This is the commit message tgstation#104:

Change networked fibers blob color to brown (tgstation#45131)

The old color (almost white) was too similar to a dead blob.
# This is the commit message tgstation#105:

Automatic changelog generation for PR tgstation#45131 [ci skip]
# This is the commit message tgstation#106:

Run npm audit fix

# This is the commit message tgstation#107:

Compile tgui

# This is the commit message tgstation#108:

Proper lefhand chainsaw sprites

# This is the commit message tgstation#109:

Automatic changelog generation for PR tgstation#45159 [ci skip]
# This is the commit message tgstation#110:

Gives the HOP a ticket machine (tgstation#45095)

* Adds a ticket machine to the HOP's office so you can keep track of unruly hoardes of greyshirts while giving the clown all access.

* Fixes a logic error

* Whoops

* Idiot proofing

* Pt 2.

* Me make code less shit

* Fixes more badcode

# This is the commit message tgstation#111:

Automatic changelog generation for PR tgstation#45095 [ci skip]
# This is the commit message tgstation#112:

Reorders the items and weapons dmi. (tgstation#45128)

* Reorders the file

* Take 2

* Whoopsie

# This is the commit message tgstation#113:

Automatic changelog generation for PR tgstation#45128 [ci skip]
# This is the commit message tgstation#114:

Fixes potted plant damage.

# This is the commit message tgstation#115:

Automatic changelog generation for PR tgstation#45168 [ci skip]
# This is the commit message tgstation#116:

Uncurse take_damage and document obj_defense.dm (tgstation#45146)

The original take_damage proc defined vars for no good reason had some 
duplicate code and wasn't very readable.

If you are wondering why it calls obj_break every time it takes damage 
while below integrity_failure, that's the way it used to be. Most (if 
not all) stuff that takes advantage of this functionality already 
accounts for this.
# This is the commit message tgstation#117:

Automatic changelog generation for PR tgstation#45146 [ci skip]
# This is the commit message tgstation#118:

Tiny sound code tweak for bleed status effect (tgstation#45162)

I forgot to request these changes before merging the blood stack 
changes. Just changes the sound volume to 100 (it's capped to this 
anyways), and replaces the 1 with a TRUE def.
# This is the commit message tgstation#119:

Makes undeads and androids have no metabolism (tgstation#44846)

About The Pull Request

Added two new traits, TRAIT_NOMETABOLISM and TRAIT_TOXIMMUNE. Does what it says on the tin, making livers not process reagents at all (except liverless reagents) and gives immunity to toxin damage. Species with NOMETABOLISM spawn with no liver (NOLIVER is now redundant and has been removed). This trait also prevents liver failure damage, for obvious reasons.

These traits have been given by default to androids (artificial, they were already immune to chemical healing anyway), zombies (who have their own regeneration) and skeletons (milk still works).

Other changes:

    Species' handle_reagents proc now fires before checking for metabolization, so species can process chems even when liverless.
    Removed the calcium healer trait, making it into a species handle_reagents check for each affected species (skeletons, plasmamen, bone golems). Skeletons now also heal burn damage from milk, since it's one of the few forms of healing they have available.

Note:
These traits should logically be applied to plasmamen and golems, but i intentionally left them out for now since it would be a significant balance shift, and there should be a proper alternative way of healing them first.
Why It's Good For The Game

Balances the significant benefits of being undead with a significant negative: being immune to chemical healing. Since zombies don't really rely on it and androids were already heal-immune, this mostly affects liches, and i believe it should be fine: considering that the main point of the spell is the resurrection mechanism, the space, gas, pierce, and heat/cold immunity they also gain should be counterbalanced by having a harder time recovering from injuries.

There is also a silver lining to having this trait: poison immunity. Effectively this is a buff to androids and zombies, the latter especially because they can no longer process mutation toxins. While this tactic is creative, it also trivializes a very expensive investment of TC. I might still add a liverless way to apply mutation toxins later on, but zombies shouldn't be effectively one-shot by a syringe gun.
Changelog

cl
add: Androids, skeletons and zombies no longer metabolize reagents. As such they no longer benefit from healing reagents, nor are affected by poisons and toxins.
add: These species are now also immune to any other form of toxin damage.
tweak: Milk now also heals burn damage for skeletons.
/cl
# This is the commit message tgstation#120:

Automatic changelog generation for PR tgstation#44846 [ci skip]
# This is the commit message tgstation#121:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#122:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#123:

Fixes interaction between job-based IDs and agent cards (tgstation#45176)

* Job IDs and agent card fixes combined

* Fixes random wallet icons being visible

# This is the commit message tgstation#124:

Wallet QOL improvements (tgstation#45178)

* Wallet name includes displayed ID
Adds Alt-click to remove it

* Use regular altclick if it's in storage

# This is the commit message tgstation#125:

Automatic changelog generation for PR tgstation#45178 [ci skip]
# This is the commit message tgstation#126:

Lollipop rework (tgstation#45153)

* Fixed branch

* added missing comma

* removed from vending

# This is the commit message tgstation#127:

Automatic changelog generation for PR tgstation#45153 [ci skip]
# This is the commit message tgstation#128:

Replaces the slime extract in the clown biodome with a superlube sprayer. (tgstation#45134)


# This is the commit message tgstation#129:

Automatic changelog generation for PR tgstation#45134 [ci skip]
# This is the commit message tgstation#130:

Species important for life (tgstation#45179)

* important to live items

* outfit

* autodoc

* comment change

* return

# This is the commit message tgstation#131:

Automatic changelog generation for PR tgstation#45179 [ci skip]
# This is the commit message tgstation#132:

[READY] Contractor Hub (tgstation#45117)

* Contract Hub + Pinpointer + more contracts

* Show rep

* Better errors

* Dynamic hub

* Bug fixes

* Show items

* No html in desc

* compile

* contractor support

* limit

* allow limits of 1

web edit

* Equip and send partner + turf helper

* working reinforcements

* Cleanup

* removing debug

* blackout

* test

* Working buttons

* no debug

* prelight

* finalized interface

* better fit

* hub icon

* conflict

* text

* error

* kit tweaks

* items

* fixup

* fixup

* bugfix

* ui fix

# This is the commit message tgstation#133:

Automatic changelog generation for PR tgstation#45117 [ci skip]
# This is the commit message tgstation#134:

baseturf_helper fix (tgstation#44937)

* Update mapping_helpers.dm

* up

* up

* mod baseturf_helper

to have baseturf_to_replace = /turf/baseturf_bottom

* ups comma

* up

* Revert "up"

This reverts commit 7fb8a2e.

* up

* Revert "up"

This reverts commit e2e3db5.

* Revert "Revert "up""

This reverts commit eff83a9.

* Revert "up"

This reverts commit 7fb8a2e.

* Revert "ups comma"

This reverts commit 5829dd9.

* Revert "mod baseturf_helper"

This reverts commit f5a1c7f.

* Update mapping_helpers.dm

* Update mapping_helpers.dm

* Update mapping_helpers.dm

* Update mapping_helpers.dm

# This is the commit message tgstation#135:

Automatic changelog generation for PR tgstation#44937 [ci skip]
# This is the commit message tgstation#136:

fixed surgery being broken how did nobody notice this LOL (tgstation#45182)


# This is the commit message tgstation#137:

Automatic changelog generation for PR tgstation#45182 [ci skip]
# This is the commit message tgstation#138:

Sentient disease cures consistently harder, fixes uncurable diseases (tgstation#45148)

* Sentient disease cures consistently harder.

* Some comments.

* comment update.

# This is the commit message tgstation#139:

Automatic changelog generation for PR tgstation#45148 [ci skip]
# This is the commit message tgstation#140:

Mining Base Changes: Less empty office, more stuff, stuff that used to be is back (tgstation#45166)

* Changes to Mining Base to make it better, brings back the old storage closets

* Yes

* Changes lockers to locked, labels the cameras correctly

* does what cabby wanted

* fixed an oopsie

# This is the commit message tgstation#141:

Automatic changelog generation for PR tgstation#45166 [ci skip]
# This is the commit message tgstation#142:

Improving upon the Metastation bar design (tgstation#45169)

* Ok Work Redone

* Airalarm & Firelock moved, Windows added, newscaster added

* Puts the preperation table in a better place

* Adds a extra table and swaps for r-tables

# This is the commit message tgstation#143:

Automatic changelog generation for PR tgstation#45169 [ci skip]
# This is the commit message tgstation#144:

Fixes MMI's hearing cult chat sometimes. (tgstation#45187)

* Fixes MMI's hearing deadchat somtimes.

* Alright, less safe but also less expensive safety net.

# This is the commit message tgstation#145:

Fixed supply shuttle safety warning (tgstation#45164)

The safety warning preventing players from reaching centcom did not include any mention of cyborgs or the AI which however still trigger the warning.
# This is the commit message tgstation#146:

Automatic changelog generation for PR tgstation#45164 [ci skip]
# This is the commit message tgstation#147:

Gateway exiling counts for assassination/mutiny objectives (tgstation#45120)

* exiling someone via gateway now counts properly for mutiny/assassination objectives

* papers please

* ninja changes

* removes redundant else, istype

# This is the commit message tgstation#148:

Automatic changelog generation for PR tgstation#45120 [ci skip]
# This is the commit message tgstation#149:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#150:

Adds SHOULD_CALL_PARENT to Destroy() (tgstation#45188)

Timers, signals, and components need to know when the thing they're 
attached to is getting destroyed or bad things happen. Since any datum 
can make use of these every destroy needs to call parent.
# This is the commit message tgstation#151:

Add autodocs and linting tags to elements (tgstation#45189)


# This is the commit message tgstation#152:

Random pixel shift for dropped/thrown objects (tgstation#45155)

* pixels

* offset for any throw, critical bedsheet bugfix

* nyeh

* might as well (autodoc)

* renamed proc

* removed redundant src

* moved call from dropped() to dropItemToGround()

* handles storage dumping, customizable max offset

* adjusted values

* inline

# This is the commit message tgstation#153:

Automatic changelog generation for PR tgstation#45155 [ci skip]
# This is the commit message tgstation#154:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#155:

Clown Mutation (Clumsy) and Wizard Mutations can no longer be cured. (tgstation#45201)

* no mutadone cure

* no loop

* oops

* mutation fix

# This is the commit message tgstation#156:

Automatic changelog generation for PR tgstation#45201 [ci skip]
# This is the commit message tgstation#157:

Automatic changelog compile, [ci skip]

# This is the commit message tgstation#158:

Fix hitting unpowered ORM (tgstation#45203)

Now unpowered ore redemption machine can be attacked.
# This is the commit message tgstation#159:

Automatic changelog generation for PR tgstation#45203 [ci skip]
# This is the commit message tgstation#160:

Singlecard description change (tgstation#45205)

Changed the description for a single (playing) card to be more accurate.
# This is the commit message tgstation#161:

Automatic changelog generation for PR tgstation#45205 [ci skip]
# This is the commit message tgstation#162:

Ratvar callback no longer fires if item deleted by damage taken (tgstation#45215)


# This is the commit message tgstation#163:

fixes an incorrect area on donut

# This is the commit message tgstation#164:

Automatic changelog generation for PR tgstation#45223 [ci skip]
# This is the commit message tgstation#165:

Fixes (tgstation#45210)


# This is the commit message tgstation#166:

Automatic changelog generation for PR tgstation#45210 [ci skip]
# This is the commit message tgstation#167:

Medipen and regen cores can now be used in hand (tgstation#45161)

* Medipen and regen cores can now be activated in hand.

* Autodoc

* Old regen core description.

* Cyborg proc begone

* cleanup, no tk shenanigans.

* Removed unusable pen.

* better return.

# This is the commit message tgstation#168:

Automatic changelog generation for PR tgstation#45161 [ci skip]
Surrealaser pushed a commit to Surrealaser/tgstation that referenced this pull request Oct 6, 2019
Rohesie pushed a commit that referenced this pull request Jun 2, 2020
#51252)

* here goes nothing

no really this is basically nothing

* dme is less dumb

* aaaaa string files

* Card backend (#3)

* Adds card backend and hotloading

This is a combination of 2 commits.

OH SHIT THE SM IS ON FIRE

WE DONE LADS

* Woop

* Best we'll get

* fixed file system, courtesy of potato

* updated tools (thanks potato), now up to 40 cards

* Adds rarity (#4)

* Adds rarity

* just to be sure

* Adds it to cards

* Didn't read templates WHAT A NERD AMAROIGHT

* Commets

* Woop you'd think I'd know my own system

* There we go

* Fuck you EOF (#5)

* Makes rarity not suck (#6)

* Fuck you EOF

* Makes rarity not suck

* Auto stash before merge of "blueeyedwhitejumpsuit" and "origin/blueeyedwhitejumpsuit"

* Makes rarity work as expected, thanks dogman (#7)

* smolcards

* Adds datum cards (#8)

* Datum cards

* Some docs and a little bit of cleanup

* fuck

* problems be had

* Fuck (#9)

* fucko bungo RELASE ME FROM THIS HELL GIT

* datum FUCKING AHHHHHHHHHHH

* packs and games

* boomer mood (#10)

* Card debugging (#11)

* Adds debug vars

* that's a bit better

* shit

* unfucks rarity

* scales sorted

* That should do it

* Parity

* fun fact

* series 1 json

* and so it is done

* Don't need this, I'm dumb.

MacRo-Op???@?#?@??!#?!@

* BRAINDAMAGE

* resin redux, smaller cards

* shut up shut up shut up IT'S ASSUMED TYPE OK? *it's not all that bad*

* double rarity TABLELS, fixed the silly linter

* flippers and rarities

* guaranteed rarity, rarity tables

* fuck it let's ask

* resinfront

* 2560 core set

* fixes flippers

* template icon, extra variable juice

* ADDS SPEED (#12)

* FUCK FUCK FUCK SHIT I BROKE IT AGAIN

* Kills my dreams in the NAME OF SPEED

* and some cleanup

* Minor changes, some qol (#13)

* couple small changes, moved the datum procs around to make things cleaner, made some comments autodocced

* Let's be more clear,

* and a woooop

* Removing ids, carpel tunnel edittion (#14)

* Subsystem

* Carpel tunnel completed

* woop

* curator is no longer equipment

* I'm not dumb you're dumb (#15)

* minor rarity tweak

ladies and gents, it's finished

Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Jul 13, 2020
* revert 1

* Revert "Ms brig fixes (tgstation#48401)"

This reverts commit c3d43b1.

* reverts 2
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Sep 1, 2020
prodirus pushed a commit to prodirus/tgstation that referenced this pull request Nov 28, 2020
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 31, 2020
MrMelbert pushed a commit to MrMelbert/tgstation that referenced this pull request Feb 1, 2021
makes the compiler recognize module files
tralezab referenced this pull request in tralezab/tgstation Feb 26, 2021
* bflehgfwblilbrga

* Update TramControl.js

* --fix, --lint

* more ui

* brokendimmer now doesn't try to load content, static data updates, MORE sanity.

* finishing off tram sprites

* cleaning up dmis

* Portal Improv

* re-removes icons
EOBGames pushed a commit that referenced this pull request Mar 11, 2021
* cool map bro!

* security

* perma

* secfull

* secman

* medstart

* engine2

* atmos start

* barrrr

* bar2

* bar3

* civil

* lower

* barrrr

* barrrrrr

* start

* cargo

* sci

* j

* servicedecal

* civildecal2

* service decal2

* service decal 3

* service decal 4

* pip

* decal4

* decal8

* arse!

* arrivals

* arrivals 2

* ai

* aifix

* vault+techstorage

* medbay

* bridge 1

* sec 3

* sectest

* squish squish

* securitywork

* secmore

* config setup

* tram

* cargo work

* escape

* disposalfuck

* i hate pipes

* disposalsfull

* SEC

* grav

* bads

* researchwip

* caw

* hguhwhuh??

* apc+air_alarm

* engie

* sm

* stttt

* aisat

* areas

* camera wip

* camera 2

* secam

* shuttle shit or something idk

* aaaa

* path nodes + waypoint navs

* almost there

* pull

* unnecessary file

* standardize

* tram choo choo!!!

* tgm

* testmerge feedback fixes

* map work

* test

* test2

* i hate

* THERE

* trams without pulling upstream like an idiot (#3)

TRAM

* fast tram fast TRAM

* fuck turfs

* tram collisions, tram cooldowns (#4)

lol

* ass

* tram but real

* forgot the ,

* code improvements, fixes, and tram call buttons (#5)

* unnecessary check gone, nulls now scrubbed (#6)

* fancy tram

* feedback changes

* AT fix

* feedback changes

* incin+engine atmos wooo!

* missing grav gen cable

* more feedback changes + diagonal shuttle wall

* bottom floor explodes into airless asteroid instead of space now

* even more feedback changes

* area change

* update to iron sheets

* ore smelter wrong dirs

* path changes agagagagaga

* no more fabs

* atmos fixes + more general fixes

* Creates SStramprocess and Makes Movement Use That Instead of Timers (#7)

* makes SStramprocess a child of SSprocess and makes tram obj use it

* gets rid of continue_movement() in favor of SStramprocess

* remove fake tram

* tgm baby

* maintenance update + chode tram

* hopefully makes the tram choke the server out less (#9)

tries to put brakes on the tram

* bad id console

* more maint stuff

* Big bundle of fixes and additions for trams (#10)

* BANG TING OW

* fixes docs, makes everyone always take damage, fixes bump text and span

* control prevention... maybe?

* combat mode no longer triggers trams

* tram conflicts + tram console

* medical changes + tram lift console

* bot pathing in tunnels

* tram whiteship + bad area string fix

* -station fixes
-tram monorail
-tram monorail grinding + achievement

* trail these noots

* rail

* yee

* diner bots + xeno changes

* Tram TGUI FINALLY (#11)

* bflehgfwblilbrga

* Update TramControl.js

* --fix, --lint

* more ui

* brokendimmer now doesn't try to load content, static data updates, MORE sanity.

* finishing off tram sprites

* cleaning up dmis

* Portal Improv

* re-removes icons

* relay moved, map fix

* fixed? (#12)

* rd machines

* relay moved, upload moved to sci, service lathe access, typo

* maint stuff

* tgm

* medical overhaul, more maint junk

* comments out achievements for testing

* space hole + spare

* actual tram blender fix according to known blender method

* tgm

* trail these

* removes depreciated tram content + accidental changes during pulling

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
EdgeLordExe pushed a commit to EdgeLordExe/tgstation that referenced this pull request Jun 20, 2021
EdgeLordExe pushed a commit to EdgeLordExe/tgstation that referenced this pull request Jul 20, 2021
* null crate problemo

thanks TCEO

* Softsuit Resprite

DNM

* Update packs.dm

* Update uplink_items.dm

* Update uplink_items.dm

* Update uplink_items.dm

* Adds Bricks and Rubble

Adds bricks and rubble northeast of atmos...

* Fixes an /area having a desc somehow...

dun goof'd

* even more SDMM fixing

removed the area entirely and replaced it.

* Adds auxiliary engine to MetaStation

- Adds maintenance control room
- Adds secondary engine next to control room
- adds the secondary engine /area

* WIP Adds Engines

DNM, adds tesla, singulo and mrspacman

* Final Touches

Makes the PA's range longer and finalizes the setup.

* Revert "null crate problemo"

This reverts commit fde6a69.

* Run linter fix #1

* Run linter fix tgstation#2

* Run linter fix tgstation#3

* Another fix...

* Fix tgstation#5

* Fix tgstation#6

* Fix tgstation#7

LUCKY NUMBER, LETS HOPE IT SPLATS 2 ERRORS!

* Fix tgstation#8

FIX tgstation#7 NAILED 2, SWEET!

* Fix tgstation#9

* Fix tgstation#10

* Fix tgstation#11

GIVE IT UP FOR FIX NUMBER ELEVEN...

* Fix tgstation#12
sack-lunch pushed a commit to sack-lunch/soot that referenced this pull request Sep 25, 2021
Acensti referenced this pull request in HippieStation/HippieStation Dec 23, 2021
* cool map bro!

* security

* perma

* secfull

* secman

* medstart

* engine2

* atmos start

* barrrr

* bar2

* bar3

* civil

* lower

* barrrr

* barrrrrr

* start

* cargo

* sci

* j

* servicedecal

* civildecal2

* service decal2

* service decal 3

* service decal 4

* pip

* decal4

* decal8

* arse!

* arrivals

* arrivals 2

* ai

* aifix

* vault+techstorage

* medbay

* bridge 1

* sec 3

* sectest

* squish squish

* securitywork

* secmore

* config setup

* tram

* cargo work

* escape

* disposalfuck

* i hate pipes

* disposalsfull

* SEC

* grav

* bads

* researchwip

* caw

* hguhwhuh??

* apc+air_alarm

* engie

* sm

* stttt

* aisat

* areas

* camera wip

* camera 2

* secam

* shuttle shit or something idk

* aaaa

* path nodes + waypoint navs

* almost there

* pull

* unnecessary file

* standardize

* tram choo choo!!!

* tgm

* testmerge feedback fixes

* map work

* test

* test2

* i hate

* THERE

* trams without pulling upstream like an idiot (#3)

TRAM

* fast tram fast TRAM

* fuck turfs

* tram collisions, tram cooldowns (#4)

lol

* ass

* tram but real

* forgot the ,

* code improvements, fixes, and tram call buttons (#5)

* unnecessary check gone, nulls now scrubbed (#6)

* fancy tram

* feedback changes

* AT fix

* feedback changes

* incin+engine atmos wooo!

* missing grav gen cable

* more feedback changes + diagonal shuttle wall

* bottom floor explodes into airless asteroid instead of space now

* even more feedback changes

* area change

* update to iron sheets

* ore smelter wrong dirs

* path changes agagagagaga

* no more fabs

* atmos fixes + more general fixes

* Creates SStramprocess and Makes Movement Use That Instead of Timers (#7)

* makes SStramprocess a child of SSprocess and makes tram obj use it

* gets rid of continue_movement() in favor of SStramprocess

* remove fake tram

* tgm baby

* maintenance update + chode tram

* hopefully makes the tram choke the server out less (#9)

tries to put brakes on the tram

* bad id console

* more maint stuff

* Big bundle of fixes and additions for trams (#10)

* BANG TING OW

* fixes docs, makes everyone always take damage, fixes bump text and span

* control prevention... maybe?

* combat mode no longer triggers trams

* tram conflicts + tram console

* medical changes + tram lift console

* bot pathing in tunnels

* tram whiteship + bad area string fix

* -station fixes
-tram monorail
-tram monorail grinding + achievement

* trail these noots

* rail

* yee

* diner bots + xeno changes

* Tram TGUI FINALLY (#11)

* bflehgfwblilbrga

* Update TramControl.js

* --fix, --lint

* more ui

* brokendimmer now doesn't try to load content, static data updates, MORE sanity.

* finishing off tram sprites

* cleaning up dmis

* Portal Improv

* re-removes icons

* relay moved, map fix

* fixed? (#12)

* rd machines

* relay moved, upload moved to sci, service lathe access, typo

* maint stuff

* tgm

* medical overhaul, more maint junk

* comments out achievements for testing

* space hole + spare

* actual tram blender fix according to known blender method

* tgm

* trail these

* removes depreciated tram content + accidental changes during pulling

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Acensti referenced this pull request in HippieStation/HippieStation Dec 26, 2021
* cool map bro!

* security

* perma

* secfull

* secman

* medstart

* engine2

* atmos start

* barrrr

* bar2

* bar3

* civil

* lower

* barrrr

* barrrrrr

* start

* cargo

* sci

* j

* servicedecal

* civildecal2

* service decal2

* service decal 3

* service decal 4

* pip

* decal4

* decal8

* arse!

* arrivals

* arrivals 2

* ai

* aifix

* vault+techstorage

* medbay

* bridge 1

* sec 3

* sectest

* squish squish

* securitywork

* secmore

* config setup

* tram

* cargo work

* escape

* disposalfuck

* i hate pipes

* disposalsfull

* SEC

* grav

* bads

* researchwip

* caw

* hguhwhuh??

* apc+air_alarm

* engie

* sm

* stttt

* aisat

* areas

* camera wip

* camera 2

* secam

* shuttle shit or something idk

* aaaa

* path nodes + waypoint navs

* almost there

* pull

* unnecessary file

* standardize

* tram choo choo!!!

* tgm

* testmerge feedback fixes

* map work

* test

* test2

* i hate

* THERE

* trams without pulling upstream like an idiot (#3)

TRAM

* fast tram fast TRAM

* fuck turfs

* tram collisions, tram cooldowns (#4)

lol

* ass

* tram but real

* forgot the ,

* code improvements, fixes, and tram call buttons (#5)

* unnecessary check gone, nulls now scrubbed (#6)

* fancy tram

* feedback changes

* AT fix

* feedback changes

* incin+engine atmos wooo!

* missing grav gen cable

* more feedback changes + diagonal shuttle wall

* bottom floor explodes into airless asteroid instead of space now

* even more feedback changes

* area change

* update to iron sheets

* ore smelter wrong dirs

* path changes agagagagaga

* no more fabs

* atmos fixes + more general fixes

* Creates SStramprocess and Makes Movement Use That Instead of Timers (#7)

* makes SStramprocess a child of SSprocess and makes tram obj use it

* gets rid of continue_movement() in favor of SStramprocess

* remove fake tram

* tgm baby

* maintenance update + chode tram

* hopefully makes the tram choke the server out less (#9)

tries to put brakes on the tram

* bad id console

* more maint stuff

* Big bundle of fixes and additions for trams (#10)

* BANG TING OW

* fixes docs, makes everyone always take damage, fixes bump text and span

* control prevention... maybe?

* combat mode no longer triggers trams

* tram conflicts + tram console

* medical changes + tram lift console

* bot pathing in tunnels

* tram whiteship + bad area string fix

* -station fixes
-tram monorail
-tram monorail grinding + achievement

* trail these noots

* rail

* yee

* diner bots + xeno changes

* Tram TGUI FINALLY (#11)

* bflehgfwblilbrga

* Update TramControl.js

* --fix, --lint

* more ui

* brokendimmer now doesn't try to load content, static data updates, MORE sanity.

* finishing off tram sprites

* cleaning up dmis

* Portal Improv

* re-removes icons

* relay moved, map fix

* fixed? (#12)

* rd machines

* relay moved, upload moved to sci, service lathe access, typo

* maint stuff

* tgm

* medical overhaul, more maint junk

* comments out achievements for testing

* space hole + spare

* actual tram blender fix according to known blender method

* tgm

* trail these

* removes depreciated tram content + accidental changes during pulling

Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com>
Co-authored-by: Kylerace <kylerlumpkin1@gmail.com>
Cheshify added a commit to Cheshify/tgstation that referenced this pull request Feb 8, 2022
GeneriedJenelle added a commit to GeneriedJenelle/tgstation that referenced this pull request Feb 28, 2022
MassacreDemigirl pushed a commit to MassacreDemigirl/tgstation that referenced this pull request May 9, 2022
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Dec 28, 2022
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Mar 12, 2023
[MIRROR] Fixes issue with holographic paystands not dissipating in certain cases
LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this pull request Mar 12, 2023
RuByxarik pushed a commit to RuByxarik/tgstation that referenced this pull request Mar 18, 2023
Zonespace27 pushed a commit to Zonespace27/tgstation that referenced this pull request Jul 23, 2023
Jacquerel pushed a commit that referenced this pull request Aug 12, 2023
…nent (#77539)

## About The Pull Request

Hey there,

I've personally fallen for this stupid thing twice (in #77503 and #75627
(d357516)), so I decided to spend a few
hours to crack out a unit test to ensure that I (and no one else) falls
for this stupid thing again.

Let me know if there's a smarter way to code something like this, but I
couldn't figure out a better way to accomodate the current framework and
be as agnostic to certain oddities as possible.
## Why It's Good For The Game
Catches stuff like this:

```txt
[2023-08-11 21:10:04.019]     FAILURE #1: The mob Garden Gnome does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #2: The mob the morph does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #3: The mob the guard spiderling (946) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #4: The mob the ambush spiderling (255) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #5: The mob the scout spiderling (375) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #6: The mob the flesh spiderling (337) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #7: The mob the hunter spiderling (869) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #8: The mob the nurse spiderling (629) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #9: The mob the tangle spiderling (19) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #10: The mob the broodmother spiderling (855) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #11: The mob the viper spiderling (519) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #12: The mob the tarantula spiderling (963) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #13: The mob the spiderling (100) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
```

(ignore the part about gnomes and morphs, this was an earlier version of
the unit test. everything else was relevant and is fixed)
## Changelog
:cl:
fix: Growing spiders will now retaliate against you like they were
always meant to.
/:cl:
Zonespace27 pushed a commit to Zonespace27/tgstation that referenced this pull request Aug 30, 2023
…nent (tgstation#77539)

Hey there,

I've personally fallen for this stupid thing twice (in tgstation#77503 and tgstation#75627
(d357516)), so I decided to spend a few
hours to crack out a unit test to ensure that I (and no one else) falls
for this stupid thing again.

Let me know if there's a smarter way to code something like this, but I
couldn't figure out a better way to accomodate the current framework and
be as agnostic to certain oddities as possible.
Catches stuff like this:

```txt
[2023-08-11 21:10:04.019]     FAILURE #1: The mob Garden Gnome does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE #2: The mob the morph does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#3: The mob the guard spiderling (946) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#4: The mob the ambush spiderling (255) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#5: The mob the scout spiderling (375) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#6: The mob the flesh spiderling (337) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#7: The mob the hunter spiderling (869) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#8: The mob the nurse spiderling (629) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#9: The mob the tangle spiderling (19) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#10: The mob the broodmother spiderling (855) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#11: The mob the viper spiderling (519) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#12: The mob the tarantula spiderling (963) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
 -     FAILURE tgstation#13: The mob the spiderling (100) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45
```

(ignore the part about gnomes and morphs, this was an earlier version of
the unit test. everything else was relevant and is fixed)
:cl:
fix: Growing spiders will now retaliate against you like they were
always meant to.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant