Long actions (like resisting out of handcuffs) will no longer count space drifting as moving. #14187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So I was looking into atom/movable/Move() being high up on the profile when I stumbled upon inertia_dir and had ideas. Everything is SUPPOSE to set this to 0 when they stop space moving. I'm just gonna trust that to be the case (it is in base atom/movable/newtonian_move. I don't want to keep calling Process_Spacemove in the loop because that feels dirty.
| drifting = 0 | ||
| Uloc = user.loc | ||
|
|
||
| if(!user || user.stat || user.weakened || user.stunned || (!drifting && user.loc != Uloc) |
|
Changeling buff/10 |
|
its all relative brah |
tkdrg
added a commit
that referenced
this pull request
Jan 1, 2016
Long actions (like resisting out of handcuffs) will no longer count space drifting as moving.
tgstation-server
added a commit
that referenced
this pull request
Jan 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was looking into atom/movable/Move() being high up on the profile when I stumbled upon inertia_dir and had ideas.
Everything is SUPPOSE to set this to 0 when they stop space moving. I'm just gonna trust that to be the case (it is in base atom/movable/newtonian_move.
I don't want to keep calling Process_Spacemove in the loop because that feels dirty.
fixes #10235
馃啈
tweak: Long actions (like resisting out of handcuffs) will no longer count space/nograv drifting as the user moving.
tweak: This does not apply to the target of a long action if that target isn't you. Pulling something while space drifting and working on it intentionally won't work.
/:cl: