Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows timed actions to be performed while drifting (Winter Thaw 2017) #23384

Merged
merged 2 commits into from Jan 29, 2017
Merged

Allows timed actions to be performed while drifting (Winter Thaw 2017) #23384

merged 2 commits into from Jan 29, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jan 27, 2017

This feature was created as part of the Winter Thaw of 2017 regardless of consensus or if it gets merged.

馃啈 Xhuis
tweak: Some timed actions are no longer interrupted while drifting through space.
/:cl:

Video demo

Specifically, actions where the target is yourself or an object that you're holding aren't interrupted. You can't perform actions on other things while you're drifting.

@ghost ghost changed the title Allows timed actions to be performed while drifting Allows timed actions to be performed while drifting (Winter Thaw 2017) Jan 27, 2017
@anconfuzedrock
Copy link
Contributor

what if it is something you are pulling

@ghost
Copy link
Author

ghost commented Jan 27, 2017

Won't work. I could easily make it, though.

@MrStonedOne
Copy link
Member

MrStonedOne commented Jan 27, 2017

This isn't a feature, its a bug it ever stopped working like that.

@ghost
Copy link
Author

ghost commented Jan 27, 2017

This was in the game originally? Neat.

@MrStonedOne
Copy link
Member

Maybe not: #14187 it looks like i was rather limited in what i let it apply to.

@dannno
Copy link
Contributor

dannno commented Jan 27, 2017

Thanks man

@Cyberboss
Copy link
Member

Cyberboss commented Jan 27, 2017

Does this work with do_mob and do_after_mob?

Disclaimer: I don't know the difference between any of these procs

@ghost
Copy link
Author

ghost commented Jan 27, 2017

@Cyberboss I don't think so. do_mob checks if two mobs interact in some way.

@AnturK AnturK added the Tweak label Jan 27, 2017
@Haevacht
Copy link
Contributor

do_after had code for space drift last I saw so yeah. This used to work, probably.

@imtakingabreakdontatme imtakingabreakdontatme added Fix Rewrites a bug so it appears in different circumstances and removed Tweak labels Jan 28, 2017
@AnturK AnturK merged commit 24bacc8 into tgstation:master Jan 29, 2017
@ghost ghost deleted the actions_while_drifting branch January 29, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants