Adds both a verb and action button for drones to be able to view station alarms. #22859
Conversation
| @@ -91,6 +91,8 @@ | |||
| SF.Grant(src) | |||
| else | |||
| verbs -= /mob/living/simple_animal/drone/verb/toggle_statics | |||
| var/datum/action/generic/drone/show_alerts/SA = new(src) | |||
There was a problem hiding this comment.
cogscarabs shouldn't get this or the verb
There was a problem hiding this comment.
Ah, right, I forgot they were children of drones. I'le fix that tomorrow.
|
fuk drones |
| @@ -64,6 +64,7 @@ | |||
| var/obj/item/default_storage = /obj/item/weapon/storage/backpack/dufflebag/drone //If this exists, it will spawn in internal storage | |||
| var/obj/item/default_hatmask //If this exists, it will spawn in the hat/mask slot if it can fit | |||
| var/seeStatic = 1 //Whether we see static instead of mobs | |||
| var/seeAlerts = 1 | |||
There was a problem hiding this comment.
TRUE/FALSE please, same for seeStatic, if you would please.
There was a problem hiding this comment.
@RemieRichards Honest question. What exactly is the difference between using TRUE / FALSE and 1 / 0?
There was a problem hiding this comment.
@Firecage nothing, in the end it compiles down to 1 and 0
The important thing is that if we see TRUE/FALSE we can more easily make the assumption that the variable is a boolean on/off flag of some description
It also makes the code nicer to read.
There was a problem hiding this comment.
@optimumtact Atleast I don't have to go change all those on/off's in the code to TRUE/FALSE from 1/0!
|
👍 I recall trying to do this a while ago using the same system silicons had and failing horribly. |
|
@Shadowlight213 The AI or the Cyborg one? I used the system which Cyborgs had for this. |
|
Please don't use action buttons for static interface elements. If something should be always visible for the given mobtype just add dedicated ui element. |
|
Indeed, it should be a dedicated UI element. Even though it's much harder to make those than action buttons. |
|
@coiax not really, it's no harder. |
|
@AnturK I have no idea how to do any hud or UI stuff at all. (Besides....the hud/UI interface still can't be dragged around and moved. That makes me sad.) |
|
@Firecage the cyborg one. |
|
Enough maintainers said they wanted a built in UI item instead so closing this. |
Previously Drones, while receiving alerts about power, air, and something else I forgot, they were not actually able to view these alerts. This corrects that. It gives them both a verb and an action button to view their own limited station alerts.
Fixes #11598
🆑 Firecage
add: We at NanoTrasen R&D would like to announce a new software upgrade for all drones! They now have the capability to view station alerts!
/:cl: