Rebases to /vg/station13 code. #23087

PJB3005 · 2017-01-17T22:38:00Z

Bringing you hypothermia, MoMMIs, BEAMS, SM cascade, xenoarch and most importantly the R-UST.

🆑
rscadd: Rebased to /vg/station lighting code.
/:cl:

MrStonedOne · 2017-01-17T22:39:06Z

code/modules/mob/living/simple_animal/friendly/drone/extra_drone_types.dm

@@ -127,7 +127,9 @@

 /mob/living/simple_animal/drone/cogscarab/New()
 	. = ..()
-	SetLuminosity(2,1)
+	#warn a


Not sure what to do with cap is the issue.

cap is strength.

or more accurately, how strong from normal (10) is the center. and then lum (the first arg) is normally just radius

Yeah this is just supposed to be weak innate light, I was doing the best I could with the limited tool I had; ideally this would have been faint reddish light, like the scarab's eyes

Figured as such but there's no direct analog here.

ChangelingRain · 2017-01-17T22:44:32Z

code/game/gamemodes/clock_cult/clock_structures/tinkerers_cache.dm

@@ -18,7 +18,9 @@
 	START_PROCESSING(SSobj, src)
 	clockwork_caches++
 	update_slab_info()
-	SetLuminosity(2,1)
+	#warn falloff?


falloff was basically a cheap way to do light strength so just making this very weak light(which should be possible with this?), will be enough

I was midway through this and I didn't want to ask on IRC what the second argument was to ruin the surprise so.

ChangelingRain · 2017-01-17T22:46:50Z

How does this compare to our current lighting, besides the visual difference? Mainly, can you do very weak light over a wide area, and very strong light over a small area?

PJB3005 · 2017-01-17T22:50:03Z

@Razharas all of those are warnings I put in as TODOs

@ChangelingRain: non shit backend for one thing.

There's no direct analog for cap in baylights, there's light power which is similar.

I don't actually understand the formulas of the lighting system, Mloc wrote that.

ChangelingRain · 2017-01-17T22:53:42Z

code/modules/lighting/lighting_source.dm

+			if(!top_atom.light_sources)
+				top_atom.light_sources = list()
+
+			top_atom.light_sources += src // Add ourselves to the light sources of our new top atom.


Replace this and the if(!top_atom.light_sources) bit with LAZYADD(src, top_atom.light_sources) which will do the same thing

ChangelingRain · 2017-01-17T22:54:09Z

code/modules/lighting/lighting_source.dm

+		top_atom = source_atom
+		. = 1
+
+	if (istype(top_atom, /turf))


if(isturf(top_atom))

PJB3005 · 2017-01-17T23:44:21Z

Woosh

Incoming5643 · 2017-01-18T00:30:12Z

Anything that puts horrible gradients over our sprites is terrible and I dislike it unconditionally. Nearly all lighting system I've seen that aren't ours do this. I think we have the right idea now, keeping it simple and clean.

WJohn · 2017-01-18T01:44:55Z

I don't know I really like the smooth lighting as opposed to blockyness. Although this may make us lose our wonderful gradual fade in/out brightness which is very pretty in and of itself.

If this includes colored lighting then I'll say yes for sure.

GunHog · 2017-01-18T01:48:55Z

It is about time we updated to a prettier system! Darkness could be a lot more 'atmospheric', and colored lights can let us do prettier alarms and what not!

PKPenguin321 · 2017-01-18T02:06:53Z

This is gonna need a serious changelog.

Pretty excited for this.

silicons · 2017-01-18T05:21:58Z

Dancefloors no longer making light
:(

Incoming5643 · 2017-01-18T05:27:00Z

From a performance standpoint I essentially cannot be a ghost and not drop a large number of frames with this on. I mean thankfully I can turn it off but still.

francinum · 2017-01-18T05:27:03Z

Doesn't render for living mobs.

MrStonedOne · 2017-01-18T05:33:32Z

it didn't render because of our planemaster for lighting, removing that fixed it.

PJB3005 · 2017-01-18T15:03:23Z

All these people that are missing the joke.

Smh.

Razharas · 2017-01-18T21:07:03Z

I dont like how it looks, it makes snow loose all detail and just look like a uniform red colour

Fox-McCloud · 2017-01-18T21:08:42Z

...snow?

PJB3005 · 2017-01-18T21:11:40Z

That fire in the bottom right does kind of look like snow now that you mention it.

Razharas · 2017-01-18T21:19:24Z

It doesnt matter if its snow or some other white stuff covering the floor, originally it had some detail drawn on it but with this light it became straight red with nothing in it

PKPenguin321 · 2017-01-18T21:20:24Z

Well I mean it kind of makes sense, go stare at the sun and see if you can still make out the colors and details of the sky around it

PJB3005 · 2017-01-18T21:24:22Z

Also I think that may be the fire overlay itself blocking the snow somewhat too.

GunHog · 2017-01-18T21:40:11Z

It is probably foam, not snow!

Fox-McCloud · 2017-01-18T23:16:43Z

There is noooo snowww in the pictureee.

PJB3005 · 2017-01-18T23:21:04Z

Whoosh.

ghost · 2017-03-04T16:05:18Z

I assume that I'm not getting a cohesive answers then

XDTM · 2017-03-04T16:08:57Z

Yes, it is lighting only, which you could tell if you glanced at the code

ghost · 2017-03-04T16:16:12Z

I saw the lighting stuff but I didn't know if that was all. I don't know VG code. Thank you for the answer.

Incoming5643 · 2017-03-04T16:40:17Z

Please make the changelog entry actually correct. It's not the place for sarcasm.

GunHog · 2017-03-04T16:48:48Z

Yes, it is lighting only, which you could tell if you glanced at the code

Because we totally expect every player on Github, including non-coders, to read through ~1300 new lines of code across 159 files to determine that the only change is lighting.

This is akin to a renowned physicist hosting a high-school science class while having no experience as a teacher. His expectations are going to be severely off the mark.

Poojawa · 2017-03-04T16:49:44Z

I mean, you have to scroll completely through all comments to make a comment asking what's going on.

I'm sure he'll change it before it's merged.

ghost · 2017-03-04T16:55:02Z

Yeah, but you don't have to READ them

Bawhoppen · 2017-03-04T17:31:17Z

that is a nice hearty sized gif

also please don't merge this

PJB3005 · 2017-03-04T17:56:33Z

RIOT

ChangelingRain · 2017-03-04T18:06:31Z

You're gonna have to make it serious at some point!
And also seriously is the memory leak fixed or what

PJB3005 · 2017-03-04T18:29:36Z

There's no memory leak from what I can tell.

ChangelingRain · 2017-03-04T18:53:55Z

In that case, it's time forrrrrrr

ChangelingRain · 2017-03-04T18:54:32Z

I sure hope you're right!

PJB3005 · 2017-03-04T19:08:10Z

oh boy.

GunHog · 2017-03-04T19:21:00Z

YEEEEEEEEEEEEEEEEEEES

ghost · 2017-03-04T19:37:19Z

PogChamp

chanoc1 · 2017-03-04T19:43:41Z

we did it boys

imtakingabreakdontatme · 2017-03-04T19:46:56Z

Shouldn't we have tested this more if we thought there was a memory leak

Incoming5643 · 2017-03-04T19:49:28Z

@KorPhaeron
Yep

PKPenguin321 · 2017-03-04T20:05:17Z

Wooooooooooooooooo

Okand37 · 2017-03-07T06:43:32Z

Very pretty.

PKPenguin321 · 2017-03-07T06:58:02Z

Zombie!

GunHog · 2017-03-08T12:55:58Z

@PJB3005 How do I disable permanent lighting in a shuttle area?

PJB3005 · 2017-03-08T13:09:24Z

@GunHog give them dynamic_lighting = TRUE

GunHog · 2017-03-08T20:34:40Z

I did so locally for /area/shuttle/auxillary_base, but it seems that something at runtime is setting it back to FALSE.

MrStonedOne · 2017-03-08T21:25:12Z

just do a find for shit that sets that, i think something in shuttle code fucks with that

PJB3005 added 3 commits January 17, 2017 22:08

hey that should be everything except making it compile.

7356e80

Have some code

e2386a8

[airplane noises]

d0a574f

MrStonedOne reviewed Jan 17, 2017

View reviewed changes

ChangelingRain reviewed Jan 17, 2017

View reviewed changes

ChangelingRain added the Refactor Makes the code harder to read label Jan 17, 2017

Razharas added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Jan 18, 2017

ChangelingRain merged commit 3c08c4f into tgstation:master Mar 4, 2017

tgstation-server added a commit that referenced this pull request Mar 4, 2017

Automatic changelog generation for PR #23087 [ci skip]

c4a4951

MrStonedOne mentioned this pull request Mar 4, 2017

[DNM]Revert "Rebases to /vg/station13 code." #24692

Closed

Datraen mentioned this pull request Mar 13, 2017

Adds flashdarks Baystation12/Baystation12#16600

Merged

Rebases to /vg/station13 code. #23087

Rebases to /vg/station13 code. #23087

Conversation

PJB3005 commented Jan 17, 2017 • edited by ChangelingRain Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrStonedOne Jan 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChangelingRain commented Jan 17, 2017

PJB3005 commented Jan 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PJB3005 commented Jan 17, 2017

Incoming5643 commented Jan 18, 2017 • edited Loading

WJohn commented Jan 18, 2017

GunHog commented Jan 18, 2017

PKPenguin321 commented Jan 18, 2017

silicons commented Jan 18, 2017

Incoming5643 commented Jan 18, 2017

francinum commented Jan 18, 2017

MrStonedOne commented Jan 18, 2017 • edited Loading

PJB3005 commented Jan 18, 2017

Razharas commented Jan 18, 2017

Fox-McCloud commented Jan 18, 2017

PJB3005 commented Jan 18, 2017

Razharas commented Jan 18, 2017

PKPenguin321 commented Jan 18, 2017 • edited Loading

PJB3005 commented Jan 18, 2017

GunHog commented Jan 18, 2017

Fox-McCloud commented Jan 18, 2017

PJB3005 commented Jan 18, 2017

ghost commented Mar 4, 2017

XDTM commented Mar 4, 2017

ghost commented Mar 4, 2017

Incoming5643 commented Mar 4, 2017

GunHog commented Mar 4, 2017 • edited Loading

Poojawa commented Mar 4, 2017

ghost commented Mar 4, 2017 • edited by ghost Loading

Bawhoppen commented Mar 4, 2017

PJB3005 commented Mar 4, 2017

ChangelingRain commented Mar 4, 2017

PJB3005 commented Mar 4, 2017

ChangelingRain commented Mar 4, 2017

ChangelingRain commented Mar 4, 2017

PJB3005 commented Mar 4, 2017

GunHog commented Mar 4, 2017

ghost commented Mar 4, 2017

chanoc1 commented Mar 4, 2017

imtakingabreakdontatme commented Mar 4, 2017

Incoming5643 commented Mar 4, 2017

PKPenguin321 commented Mar 4, 2017

Okand37 commented Mar 7, 2017

PKPenguin321 commented Mar 7, 2017

GunHog commented Mar 8, 2017

PJB3005 commented Mar 8, 2017

GunHog commented Mar 8, 2017 • edited Loading

MrStonedOne commented Mar 8, 2017

PJB3005 commented Jan 17, 2017 •

edited by ChangelingRain

Loading

MrStonedOne Jan 17, 2017 •

edited

Loading

Incoming5643 commented Jan 18, 2017 •

edited

Loading

MrStonedOne commented Jan 18, 2017 •

edited

Loading

PKPenguin321 commented Jan 18, 2017 •

edited

Loading

GunHog commented Mar 4, 2017 •

edited

Loading

ghost commented Mar 4, 2017 •

edited by ghost

Loading

GunHog commented Mar 8, 2017 •

edited

Loading