Adds Gibtonite, the explosive ore! #2312
Conversation
| ..() | ||
|
|
||
| /turf/simulated/mineral/gibtonite/attackby(obj/item/I, mob/user) | ||
| if(istype(I, /obj/item/device/analyzer) && in_range(src, usr)) |
There was a problem hiding this comment.
Don't use usr here. You don't even need the in_range.
There was a problem hiding this comment.
I believe onclick handles all the range and adjactment checks before applying attackby
No need to recheck indeed
|
If your intentions were for miners to use it as mining explosives then you should try to make it more clear, add it in its description or something. You should also remove the code which makes explosions delete the fallen dug out ore. |
|
This will disappoint miners who want diamond. |
|
boo-hoo poor miners will be dissapointy-wointed. On Sat, Jan 11, 2014 at 1:16 PM, adrix89 notifications@github.com wrote:
|
|
It should gib on contact for maximum fun! |
|
Stop trying to shit on an already unpopular-yet-necessary job |
|
They get free explosives, I don't see how this makes the job worse ;_; On Sat, Jan 11, 2014 at 3:29 PM, ExplosiveCrate notifications@github.comwrote:
|
|
This actually changes ex_act, explosions are now actually useful for mining. |
|
Exposions no longer delete ore that's already fallen onto the ground, removed redundant checks and took the stupid .dme out, everything should be good to go. There is a new child of twohanded, twohanded/required, which means you need both hands free to pick up the object, put gibtonite under there. |
|
GIB TONIGHT ALL DAY. |
|
Personally I'd prefer it if w_class 5 required two hands, instead of having a special path for it, but that'd probably be harder to code. You should look into it, though. |
| var/turf/bombturf = get_turf(src) | ||
| var/area/A = get_area(bombturf) | ||
| var/log_str = "[src.activated_ckey]<A HREF='?_src_=holder;adminmoreinfo=\ref[usr]'>?</A> [src.activated_name] has triggered a gibtonite deposit reaction <A HREF='?_src_=holder;adminplayerobservecoodjump=1;X=[bombturf.x];Y=[bombturf.y];Z=[bombturf.z]'>[A.name] (JMP)</a>." | ||
| log_game(log_str) |
There was a problem hiding this comment.
Hyperlinks in the logs?
I remember there was issue by aran that they are bad
|
My concern is new miners not knowing how it work, expecting diamond and then randomly exploding. and dying |
|
But suddenly being gibbed is fun |
|
There's messages in red in the chat box, saying that it will explode. The sprite changes to something flashing red. Even if you somehow manage to ignore all that, you won't die from Gibtonite mineral deposits if you're at full health. You'll hit 4HP. You'll survive... barely. |
|
4HP, which is in crit, two ticks till death. |
|
Kaze you silly, he clearly means 104. |
|
104HP*, if we're considering 0 being death. You will not go into crit. |
|
👍 on this change, I mine occasionally and having some mining explosives I can get myself would be quite a neat little extra. |
|
Please merge before another conflict! Pretty please? |
|
why is this not merged yet |
|
4 times as common as diamond means it'll be more surprising to find diamond that's actually diamond, rather than 'disguised' gibtonite. Not sure if that's intended. |
|
There's actually a decently reliable trick to find out if it's diamond or not, if you can figure it out, though it won't work in all cases. |
|
MERGE CONFLICTS <3 |
|
Fixed conflicts...again. |
Adds Gibtonite, the explosive ore!
Gibtonite design doc:
-Gibtonite is a mineral found in deposits on the asteroid.
-Gibtonite is disguised as diamond deposits until the player attempts to mine them, at which point they activate
-After activating, a timer counts down, and the Gibtonite reserve will eventually explode if left alone.
-If you use an analyzer on Gibtonite, you can halt the countdown at any point, even immediately after activating it. However, the closer you were to it exploding before you defuse it, the better quality gibtonite ore you'll receive once you extract it. Effectively, if you do not like the thought of exploding, simply use your analyzer whenever you see a diamond deposit and you will never come to any harm, but risk takers get rewarded.
-Gibtonite mineral deposits (Ores behave differently), despite the name, will not gib you. You will instead take 96 damage, unless you're occupying the same space as gibtonite, so it's not an instant round removal in the event of failure.
-Gibtonite reserves CAN detonate eachother, but in my testing I have never seen more than 2 go off in sequence.
-Gibtonite ore cannot be pulled. You cannot pick up gibtonite without two free hands, due to its weight and awkard size. Gibtonite does not fit in a backpack. There is a very noticeable sprite. If you see a miner walking around the station with Gibtonite, I suggest alerting security and abandoning the area.
-Gibtonite ore can only be activated by striking it with a pickaxe/drill. You can still disable it with an analyzer to stop it from exploding, but keep in mind that this degrades the ore to its lowest quality.
-At this time, Gibtonite has no use R&D or Crafting, subject to change whenever.
Other changes:
-Changed ex_act() on asteroid mineral turf to not delete ores
-Reduced ex_act() on asteroid turf's chance to kick up sand, because it's more unnecessary clutter and nobody cares about sand.