Fixes gibtonite explosions producing flames and flashes #77344
Conversation
set gibby's flash and flame ranges to 0
tgstation-server
added
the
Fix
|
Do you know if it's REALLY "previous behavior" though Because the point of the fix pr, and the ORIGINAL pr, was to give explosions which do not explicitly set these flames and flashes So did gibtonite originally intend to not have flames or flashes? |
|
been playing since 2020 and yeah gibby didn't ever produce flames, neither did it produce flames a few weeks before. also considering that planetary atmos can still roll plasma sometimes it's probably a good idea to not make flames flashes are in around the same boat, have been blastes by gibby a few times point blank over the years and i don't recall being flashed by it in any case if it was intended for em to have flames and flashing, but they didn't for the longest time and nobody seemed to care, then lol add that to the list of stuff that didn't work for ages |
|
It seems like it was broken in #58015 2 years ago originally |
|
in the very first iteration of gibtonite flash act was just not working apparently the pr does not set any values to flames and flash ranges |
… flashes (#7217) Original PR: tgstation/tgstation#77344 ----- ## About The Pull Request On the tin. Was introduced in #77118 and uhh yeah ## Why It's Good For The Game Restoring previous behavior. To be quite honest I can live with the flames, as they mostly aren't that much of an issue for a competent miner. Avoiding them or bringing an extinguisher with you is easy enough; if anything, these flames may or may not cook loose ore and turn it into sheets, which isn't favorable for the miner. But for consistency's sake it's better if we restore it to the previous effects.  ## Changelog :cl: fix: fixed gibtonite explosions having flames and flash ranges /:cl: --------- Co-authored-by: Sealed101 <cool.bullseye@yandex.ru>
About The Pull Request
On the tin. Was introduced in #77118 and uhh yeah
Why It's Good For The Game
Restoring previous behavior.
To be quite honest I can live with the flames, as they mostly aren't that much of an issue for a competent miner. Avoiding them or bringing an extinguisher with you is easy enough; if anything, these flames may or may not cook loose ore and turn it into sheets, which isn't favorable for the miner. But for consistency's sake it's better if we restore it to the previous effects.
Changelog
🆑
fix: fixed gibtonite explosions having flames and flash ranges
/:cl: