Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ports sprites from Endless-Horizon/CEV-Eris #28285

Merged
merged 4 commits into from Jun 10, 2017
Merged

Conversation

Lexorion
Copy link
Contributor

@Lexorion Lexorion commented Jun 9, 2017

Ports a bunch of sprites from https://github.com/Endless-Horizon/CEV-Eris/tree/master/icons

(with their permission,thanks Bloodpriest!)

medkits/tcomm/goonsprites are no longer part of the PR

EDITED! Picture below shows the majority of the sprites

1: Washing machine
2: Seed extractor , biogenerator
3: Microwave
4: Photocopier, binder
5: Powersink, forensic scanner
6: Mechfab, autolathe, pipedispenser
7: Modular laptop
8: Rack, plasma/oxygen dispenser
9: Portable generators
10: Stacker, unloader (corner), furnace , unloader (corner 2), unloader
11: Stock parts (box_0-2,vbox_0-2)
12: Circuit imprinter, protlathe, analyzer, server, tdoppler
(13:) Charger

@Wutnold124
Copy link

oh hell yes

@lzimann
Copy link
Contributor

lzimann commented Jun 9, 2017

medkits and the recharger are ugly

@PKPenguin321
Copy link
Contributor

We've rejected the book binder one already, and the t ray is nasty

@lzimann lzimann added the Sprites A bikeshed full of soulless bikes. label Jun 9, 2017
@MMMiracles
Copy link
Contributor

3/4 perspective is uggggggghhhhhh

@GunHog
Copy link
Contributor

GunHog commented Jun 9, 2017

What are the machines in the bottom left three rows? I recognize only the recharger and Doppler array.

@Lexorion
Copy link
Contributor Author

Lexorion commented Jun 9, 2017

@PKPenguin321 #24230? Did not take the sprites from there
@GunHog Circuit imprinter,protolathe,analyzer and server (from left to right) , sorry I didn't take gifs since they'd make it more obvious

@PKPenguin321
Copy link
Contributor

It would be nice if you could go in MS paint or something and put text under the sprites saying what they are since a lot of these look almost nothing like the old sprites so we don't even know what's being replaced

@ShizCalev
Copy link
Member

I agree that the medkits and recharger are kinda meh compared to the current ones.

@ShadowDeath6
Copy link

ShadowDeath6 commented Jun 9, 2017

R&D machinery looks bad imo

actually- all the research machinery looks bad.

@ike709
Copy link
Contributor

ike709 commented Jun 10, 2017

Rip out the medkits and recharger.

@DoctoreMad
Copy link

@PKPenguin321 Where's the downvote on the PR? We will kind of need it in the long run someone will point out the votes.

@Chronitonity
Copy link

Those medkits are awful please

@WJohn
Copy link
Contributor

WJohn commented Jun 10, 2017

I like parts of it, and don't like other parts.

I DO like that it's aiming for 3/4th
I DON'T like how the medkits look, too thin and vertical, badly placed handle.
I DO like the mining equipment (loaders, redemption machine)
I DON'T like how bright the telecomms equipment is (needs to be darker).

So I dunno, needs some refinement all around. Should not merge as-is.

@WJohn WJohn added the Do Not Merge You must have really upset someone label Jun 10, 2017
@GunHog
Copy link
Contributor

GunHog commented Jun 10, 2017

The ones on the second row from the bottom left look plain and similar. Please make them more distinct. While I dislike 3/4, I would be okay with it if the sprite is a vast improvement!

@Bawhoppen
Copy link
Contributor

Why did we agree on 3/4ths as what we should be aiming for? I think most people don't like that as a general style, and it looks especially dicks on many things.

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

I think most people don't like that as a general style, and it looks especially dicks on many things.

Don't care, stupid.

:)

@MMMiracles
Copy link
Contributor

your avatar's face is stupid

@tortellinitony
Copy link
Contributor

tortellinitony commented Jun 10, 2017

I'm not a fan of ruining more machinery with these kind of sprites, but at least have the decency to put the sprites stolen from Goonstation in the goon/ folder.

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

FUCK YOU MIRACLES

@Expletive
Copy link
Contributor

Why did we agree on 3/4ths as what we should be aiming for?
Cause wjohn likes it apparently.

@Iamgoofball
Copy link
Contributor

@tortellinitony
The OP likely wasn't aware.

@Lexorion
A lot of these sprites are actually goon sprites, in specific all the kitchen/chemistry related sprites.

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

hmmmm our art director is deciding on what sprites get in??

HMMMMMMMM

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

not a democracy! stinky!

@Lexorion
Copy link
Contributor Author

I'll remove the medkits,tcomm machines and the (apparently?) Goonsprites later,not sure if I can do it today. I assumed they were made by cev-eris because it was not in a separate folder!

@WJohn
Copy link
Contributor

WJohn commented Jun 10, 2017

I mean I would appreciate if they were simply refined...

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

I think the medkits need changing as well
I can kind of tell just by looking which machines are probably goon (the blue-grey outlined ones top right) and those can definitely be changed to be more fitting with our stuff, along with tcomms machines stuff (why is it so fucking bright)

@Iamgoofball
Copy link
Contributor

@Lexorion
Keep the goonsprites, they're the good ones.

@WJohn
Copy link
Contributor

WJohn commented Jun 10, 2017

I'm the one who put the DNM tag on it though?

@TrustyGun
Copy link
Contributor

I like the washing machine, botany stuff, the plasma/oxygen container, or basically anything that is just a straight 3/4 transformation of the original sprite

I hate the racks, the chargers because they are too flat. I hate the forensic scanner and the powersink, not because of any spriting flaws but because they are basically unrecognizable as a forensic scanner and powersink

also merge ree

@WJohn WJohn removed the Do Not Merge You must have really upset someone label Jun 10, 2017
@Kraseo

This comment was marked as abuse.

@DoctoreMad
Copy link

12 downvotes, 9 upvotes
Merged

Metaclub confirmed

@WJohn
Copy link
Contributor

WJohn commented Jun 10, 2017

I expect lexorion to touch up most of the sprites in this PR, as well as readd the improved versions of the ones he already removed. As is, these are quite passable.

@TrustyGun
Copy link
Contributor

lol i like the sprites and i even upvoted the PR, im just voicing my dissatisfaction of some of the sprites

@dannno
Copy link
Contributor

dannno commented Jun 10, 2017

Look at them
They really think it's some kind of democracy

ahahahahahahahahhahaha

@Militaires
Copy link

they literally took my book binder sprite that got rejected and used it and didnt let me know rude as fuck

@Lexorion
Copy link
Contributor Author

Not the same despite similarities! (both look like the original anyway so...)

@Militaires
Copy link

@Lexorion they edited it, i know it's mine because the yellow hazard symbol is exactly where i put it

it wasnt on the original sprite i added that

@Militaires
Copy link

im cool with that i just wish they had told me so i can feel not wasted effort

@Militaires
Copy link

also power sink looks like a fidget spinner

@Lexorion
Copy link
Contributor Author

Lexorion commented Jun 10, 2017

The yellow hazard symbol is ooooold, https://github.com/tgstation/tgstation/blob/12bd728f192f033a1c2e9e0efc8e30dc3d261270/icons/obj/library.dmi is from 2013 and has it

@MMMiracles
Copy link
Contributor

in the future you won't be able to tell the difference between SS13 and something made in RPGmaker

@Militaires
Copy link

@Lexorion oh looks like it's just a mad coincidence of similarity tho

@PKPenguin321
Copy link
Contributor

I actually do like these except for the book binder (sprite we already had was better, more detail), power sink (just a confusing mess of a sprite, shading makes it look weirdly shiny and inconsistent with other sprites), and PACMAN generators (they are mostly solid colors and lack detail, pretty bad sprites by any standard).

I implore @WJohn to look at these three in particular.

@GunHog
Copy link
Contributor

GunHog commented Jun 11, 2017

The power sink should be reverted, that thing looks more like a bomb or some sort of atmos device than it does a power drain device.

The modular laptop looks really armored and weird to me.

The mech fab should be swapped for something that looks more "heavy duty". It looks more like some sort of testing machine.

@WJohn
Copy link
Contributor

WJohn commented Jun 11, 2017

Clearly the laptop was built by alienware and their stupid god damned chunky spiky design bullshit.

I think I'll take a crack at these soon, if lexorion doesn't.

@PKPenguin321
Copy link
Contributor

Also the book binder looks gross and the charger has less detail with this perspective, forgot to mention those

@RocKeD
Copy link

RocKeD commented Jun 11, 2017

These sprites are SOOO inconsistent. I do not like any of them except for the plasma/oxygen dispenser. TG has amazing sprites that are consistant. I don't think this consistency should be broken. Merge this and the game will look like the clown got hold of it.

@dannno
Copy link
Contributor

dannno commented Jun 11, 2017

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet