Adds another planetstation mob, the "Seedling" #29253

Ergovisavi · 2017-07-14T05:48:12Z

Adds another planetstation mob, the "Seedling". It's basically a gun turret that looks like a flower. It shoots large volleys of energy bullets, and has a laser attack that automatically hits you if you do not interrupt its attack by hitting it before it fires. It won't start shooting at you from offscreen, you have to be onscreen to catch its attention first. If you go offscreen after it starts charging up and you know the laser is incoming, it will hit you.

Bring a friend to stab it in the butthole while you dodge its fire, or be mlg pro and dodge the shots and hit it between volleys

It looks like this:

It kills you like this:

[
🆑
add: Adds the "seedling" planetstation mob to the backend
/:cl:

ChangelingRain · 2017-07-14T05:58:17Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+
+
+/datum/status_effect/seedling_beam_indicator/be_replaced()
+	owner.underlays -= beam_overlay


I am not a clever man

ChangelingRain · 2017-07-14T06:00:49Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+		update_icons()
+		var/datum/callback/cb = CALLBACK(src, .proc/InaccurateShot)
+		var/i
+		for(i=0, i<13, i++)


for(var/i in 1 to however_many_shots_this_is)

Tacolizard · 2017-07-14T07:11:39Z

ghost · 2017-07-14T07:20:03Z

now, i know it's an immobile creature but is this player controlled?

RemieRichards · 2017-07-14T07:50:37Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	hitsound_wall = 'sound/weapons/effects/searwall.ogg'
+	nondirectional_sprite = TRUE
+
+/obj/item/projectile/seedling/Bump(atom/A, yes)//Stops seedlings from destroying other jungle mobs through FF


This is Collide now.

RemieRichards · 2017-07-14T07:51:17Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	QDEL_NULL(beam_overlay)
+	return ..()
+
+/datum/status_effect/seedling_beam_indicator/tick()


holy shit the appearance churn is real.

also the indicator looks ugly anyway is this really necessary?
If it is, remove it for now, when 512 comes along there's a way to do this in a cheaper manner, and you can have it then.

If the seedling is offscreen, or you are engaged with two separate seedlings, or two seedlings are charging up at two separate people, there'd be no way to tell which one you need to smack to free yourself without an indicator.

I do think the churn is too high and so I'd like to use a cheaper method but this information needs to exist for the player

then, considering planestation will come way after 512, if ever, remove this for now and when the time comes I'll help you redo it with 512.

It can laser people offscreen?
WHY?

RemieRichards · 2017-07-14T07:52:36Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+			our_seedling.combatant_state = SEEDLING_STATE_NEUTRAL
+			our_seedling.death()
+
+/obj/seedling_weakpoint/proc/RandomizeScreenLocation()


??

Is the icon state the same sprite but in multiple locations? if so, just randomise pixel_x/pixel_y

also screen is a huge misnomer.

Icon isn't the same. It was originally a little dot on a random pixel_x/pixel_y but it looked kinda shit so I just made it in three separate locations with a specific sprite in each location

then rename everything.
PickVisuals(), RandomSprite() etc.

ChangelingRain · 2017-07-14T12:55:08Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	if(combatant_state == SEEDLING_STATE_ACTIVE && living_target && beam_id == solar_beam_identifier)
+		if(living_target.z == z)
+			update_icons()
+			solar_beam = new(src,target,time=5,beam_icon_state="solar_beam",maxdistance = INFINITY,btype=/obj/effect/ebeam/solarbeam,beam_sleep_time = 0.5)


I recommend making this from the turf to the target, since beam handles larger icon files weirdly.
You can see how in the gif.

Cyberboss · 2017-07-14T13:40:44Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

@@ -578,11 +578,336 @@
 	icon_state = "mook_leap_cloud"
 	layer = BELOW_MOB_LAYER
 	pixel_x = -16
-	pixel_y = -16
+	pixel_y = -12


What's with this mook change?

Cyberboss · 2017-07-14T13:41:03Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	anchored = TRUE
+	var/combatant_state = SEEDLING_STATE_NEUTRAL
+	var/obj/seedling_weakpoint/weak_point
+	var/datum/beam/solar_beam = null


remove the = null please

Cyberboss · 2017-07-14T13:41:21Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	hitsound_wall = 'sound/weapons/effects/searwall.ogg'
+	nondirectional_sprite = TRUE
+
+/obj/item/projectile/seedling/Bump(atom/A, yes)//Stops seedlings from destroying other jungle mobs through FF


/obj/item/projectile/seedling/Collide(atom/A)

Cyberboss · 2017-07-14T13:42:06Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	var/matrix/final = matrix()
+	final.Turn(target_angle)
+	beam_overlay.transform = final
+	owner.overlays += beam_overlay


add_overlay

Cyberboss · 2017-07-14T13:42:11Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+
+/datum/status_effect/seedling_beam_indicator/tick()
+	var/target_angle = Get_Angle(owner, target)
+	owner.overlays -= beam_overlay


cut_overlay

Cyberboss · 2017-07-14T13:42:20Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+
+/datum/status_effect/seedling_beam_indicator/Destroy()
+	if(owner)
+		owner.overlays -= beam_overlay


cut_overlay

Cyberboss · 2017-07-14T13:45:59Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+			face_atom(target)
+		if(solar_beam)
+			qdel(solar_beam)
+			solar_beam = null


QDEL_NULL(solar_beam)

Cyberboss · 2017-07-14T13:46:15Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	if(weak_point && !QDELETED(weak_point) && combatant_state == SEEDLING_STATE_REGENERATING)
+		revive(TRUE)
+		mouse_opacity = 1
+		weak_point.loc = src


Cyberboss · 2017-07-14T13:46:37Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+
+/obj/seedling_weakpoint/Destroy()
+	. = ..()
+	if(our_seedling && !QDELETED(our_seedling))


just !QDELETED(our_seedling)

Cyberboss · 2017-07-14T13:46:50Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+		if(!our_seedling.stat)
+			our_seedling.combatant_state = SEEDLING_STATE_NEUTRAL
+			our_seedling.death()
+


our_seedling = null

Why would I need to null out our_seedling? The object deletes itself as soon as this finishes.

ergo, it will TRY to qdel itself after this finishes, but since our_seedling is still pointing to the mob, there's a reference, and it won't qdel properly, so it'll sit in the qdel queue for a little while and THEN it'll trigger a harddel (a del() which is stupidly bad)

Mobs already don't qdel well, but I think simple animals can, so don't make it worse.

If your object/mob/etc. uses references to other objects/mobs/etcs then it MUST null them in Destroy()

Cyberboss · 2017-07-14T13:47:26Z

code/modules/mob/living/simple_animal/hostile/jungle_mobs.dm

+	playsound(src, 'sound/weapons/bladeslice.ogg', 50, 1)
+
+/mob/living/simple_animal/hostile/jungle/seedling/update_stat()
+	if(weak_point && !QDELETED(weak_point))


!QDELETED(weak_point)

…weak_point

Tacolizard · 2017-07-15T02:42:48Z

this seems kind of op. like, harder than leapers op. these should not spawn very often, or be bosses.

ghost · 2017-07-15T06:19:05Z

leapers are only strong alone and these are also the case

DoctoreMad · 2017-07-15T06:46:53Z

Come on mate, have you tried fighting it yourself or are you going off looks?
I could say it looks easy to me and it would be nonconstructive as fuck because I'm going off a .gif

DoctoreMad · 2017-07-15T07:25:53Z

Tbh this could be a boss if it was surrounded by rglass in a titanium wall dome so the projectiles kept reflecting everywhere.

KingPhilipIII · 2017-07-15T13:32:45Z

Alright. I'll be honest. I don't know what planetstation even is. Can someone please enlighten me.

ChangelingRain · 2017-07-15T16:02:36Z

I think the weak point/regen thing isn't necessary, maybe just have it explode briefly after killing it so you don't waste that sprite

Ergovisavi · 2017-07-15T17:41:07Z

Yeah I think at this point I'll just cut the weakpoint thing, it was just a spitballing idea and I don't think it actually has much merit, since it doesn't really change how you act against the mob unless you were shooting at it.

DoctoreMad · 2017-07-15T18:20:24Z

@KingPhilipIII ONE DAY A BUNCH OF IDEA GUYS THOUGHT IT WOULD BE COOL IF THE CREW COULD GO AROUND CONQUERING PLANETS IN THE NAME OF NANOTRASEN. ALSO THEY THOUGHT THAT IT WOULD ALSO BE PRETTY COOL IF THERE WERE MORE ENEMY MOBS WITH ADVANCED AI, TOO, AMONG OTHER THINGS.
AND SO "PLANETSTATION" WAS FORMED!

Ergovisavi · 2017-07-15T23:00:56Z

Removed the weakpoint gimmick it's just not something viable as a gameplay mechanic due to the way our combat works and is more suited for a game with a better aim system

DoctoreMad · 2017-07-15T23:48:16Z

That reminds me.
@KorPhaeron About your goal of having a planet-naming scroll on the planetstation project list, isn't it already done?

imtakingabreakdontatme · 2017-07-16T00:03:22Z

Yeah

Cheridan · 2017-07-16T04:58:25Z

An enemy that requires you juke waves of bullets in a game where any damage makes you go slower sounds like its not going to be very fun

ghost · 2017-07-16T15:50:12Z

the projectile sprite looks bad especially when it is firing multiple at once.
perhaps give it a completely different projectile instead of "solar energy" or make the projectile sprite smaller and/or make it fire less projectiles

Ergovisavi · 2017-07-16T19:33:00Z

@Cheridan The environment in which these are fought are assumed to have dense trees to use as cover, so if you're not confident in your ability to dodge volleys, use cover. Or bring a friend. Also, you have to be shot by four bullets before you suffer any slowdown, so getting clipped a little won't significantly hinder you.

@PraiseRatvar You're going to have to be more specific other than "looks bad". The projectile sprite size is so large so you can see the tile it's occupying a bit better due to our wonky "hitboxes" being a tile wide regardless of image used

silicons · 2017-07-17T08:07:20Z

making ebeam fake-hitscans

but i already made a beam rifle projectile that hitscans properly and has pixel and angle accurate sprites!!!

sigh.
@Ergovisavi

Ergovisavi · 2017-07-17T14:05:50Z

@kevinz000 Your beam rifle fires a projectile and can hit targets on the way to the actual target which is explicitly the behavior I do not want

It's not a true laser, all the visual effects are just set dressing.

silicons · 2017-07-17T16:39:24Z

@Ergovisavi ah ok.

RemieRichards · 2017-07-17T21:24:00Z

Ergo refuses to wait for 512 where his visual effect will be cheap enough to not cause painful client lag, so I am closing this until 512 is stable at which point we can reopen this PR or create a new one.

ghost · 2017-07-17T21:24:26Z

:(

ChangelingRain · 2017-07-17T21:24:51Z

Okay so the pointing to the seedling thing isn't viable until byond 512 and ergo doesn't want to add the mob without the laser beam and pointing thing, so, until Byond 512...
EDIT: wow rip Remie got it first

Ergovisavi · 2017-07-17T21:37:13Z

Guess this is on the backburner until after 512 without Kor or someone else stepping in, RIP

Tokiko1 · 2017-07-19T05:54:29Z

Mind elaborating what so expensive about the visual effect is?

RemieRichards · 2017-07-19T07:53:34Z

Every status effect tick() ergo is creating a new appearance for the visual effect (rotating it X degrees, as the effect is a compass), and then applying that effect to the target mob, that's 2 appearances per tick where with 512 it can be just 1 per tick, once 512 is also stable we can look into porting something like /vg/'s hook system so that the compass won't ever update unless either the seedling or the target move (which is the 100% best perfect case, meaning you have nothing happening on tick() which keeps things nice and cheap)

Creating and replacing appearances in DM is horrendously slow, it's why 510/11 introduced /mutable_appearance, every change to an appearance var creates a new one, eg:

bob.pixel_y = 32 //new appearance
bob.pixel_x = 32 //another new appearance
bob.color = "red" //another new appearance

That's 3 appearance, 2 of which didn't need to exist (the pixel_x/y ones only existed for a short time before being destroyed and replaced by the next one along)
With 510/11 and /mutable_appearances something like the above can instead be:

var/mutable_appearance/MA = new()
MA.pixel_y = 32
MA.pixel_x = 32
MA.color = "red"
bob.appearance = MA //This 'commits' MA, turning it from a /mutable_appearance into a real appearance, meaning only 1 was created per n-appearance variables changed, instead of n per n

With 512, there's visual_contents, which is like overlays and underlays, but the objects inside visual_contents REMAIN as objects, they don't get flattened into appearances, meaning any update to their appearance doesn't need to go through the whole overlay/underlay painful sorting process.

So tl;dr 512 will be one step closer to perfect, then a hook-system can make it 100% perfect.

…a kill-sat style one

Ergovisavi · 2017-07-21T02:51:00Z

Changed to using a screen object, which should serve roughly the same purpose without the need to constantly tweak overlays, changed the beam to behave more like a kill sat so it's more logical that it hits you behind cover

ghost · 2017-07-24T00:36:04Z

ok it's been open for two days lets merge it up guys

optimumtact · 2017-07-25T02:17:35Z

@RemieRichards did you review the latest version?

Ergovisavi · 2017-07-28T15:44:03Z

Can I get some traction on this?

My stuff's done

RemieRichards · 2017-08-02T20:29:18Z

Really? assigning me just so I can say "Yes it's fine"?

"Yes it's fine"

Cyberboss · 2017-08-02T20:37:26Z

:^)

Adds another planetstation mob, the "Seedling"

WIP seedling planetstation mob

1086afa

tgstation-server added Feature Exposes new bugs in interesting ways Sprites A bikeshed full of soulless bikes. labels Jul 14, 2017

ChangelingRain reviewed Jul 14, 2017

View reviewed changes

RemieRichards reviewed Jul 14, 2017

View reviewed changes

ChangelingRain reviewed Jul 14, 2017

View reviewed changes

Cyberboss reviewed Jul 14, 2017

View reviewed changes

Cyberboss previously requested changes Jul 14, 2017

View reviewed changes

Ergovisavi added 2 commits July 14, 2017 19:31

Seedling beam tweaks

6dbbe86

Merge branch 'master' of https://github.com/tgstation/tgstation into …

13e78d3

…weak_point

More seedling work

17c9e50

RemieRichards closed this Jul 17, 2017

Seedling uses a screen object instead of an overlay, beam changed to …

0538bc2

…a kill-sat style one

ChangelingRain reopened this Jul 21, 2017

Cyberboss assigned RemieRichards Aug 2, 2017

Cyberboss added the Ready for Review label Aug 2, 2017

Cyberboss removed the Ready for Review label Aug 2, 2017

Cyberboss merged commit bdc410e into tgstation:master Aug 2, 2017

tgstation-server added a commit that referenced this pull request Aug 2, 2017

Automatic changelog generation for PR #29253 [ci skip]

54b0e05

ghost referenced this pull request in HippieStation/HippieStationdeprecated2020 Aug 2, 2017

Merge pull request #29253 from Ergovisavi/weak_point

9d1387d

Adds another planetstation mob, the "Seedling"

ghost mentioned this pull request Aug 2, 2017

[MIRROR] Adds another planetstation mob, the "Seedling" HippieStation/HippieStationdeprecated2020#2634

Merged

CitadelStationBot mentioned this pull request Aug 2, 2017

[MIRROR] Adds another planetstation mob, the "Seedling" Citadel-Station-13/Citadel-Station-13#2233

Merged

FTL13-Bot mentioned this pull request Aug 2, 2017

[MIRROR] Adds another planetstation mob, the "Seedling" FTL13/FTL13#1813

Closed

crossonrose unassigned RemieRichards Dec 11, 2017



		/datum/status_effect/seedling_beam_indicator/be_replaced()
		owner.underlays -= beam_overlay

Adds another planetstation mob, the "Seedling" #29253

Adds another planetstation mob, the "Seedling" #29253

Conversation

Ergovisavi commented Jul 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tacolizard commented Jul 14, 2017

ghost commented Jul 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RemieRichards Jul 14, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RemieRichards Jul 15, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tacolizard commented Jul 15, 2017 • edited

ghost commented Jul 15, 2017

DoctoreMad commented Jul 15, 2017

DoctoreMad commented Jul 15, 2017

KingPhilipIII commented Jul 15, 2017

ChangelingRain commented Jul 15, 2017

Ergovisavi commented Jul 15, 2017

DoctoreMad commented Jul 15, 2017 • edited

Ergovisavi commented Jul 15, 2017

DoctoreMad commented Jul 15, 2017

imtakingabreakdontatme commented Jul 16, 2017

Cheridan commented Jul 16, 2017

ghost commented Jul 16, 2017

Ergovisavi commented Jul 16, 2017 • edited

silicons commented Jul 17, 2017 • edited

Ergovisavi commented Jul 17, 2017

silicons commented Jul 17, 2017

RemieRichards commented Jul 17, 2017

ghost commented Jul 17, 2017

ChangelingRain commented Jul 17, 2017 • edited

Ergovisavi commented Jul 17, 2017

Tokiko1 commented Jul 19, 2017

RemieRichards commented Jul 19, 2017

Ergovisavi commented Jul 21, 2017 • edited

ghost commented Jul 24, 2017

optimumtact commented Jul 25, 2017

Ergovisavi commented Jul 28, 2017

RemieRichards commented Aug 2, 2017

Cyberboss commented Aug 2, 2017

Ergovisavi commented Jul 14, 2017 •

edited

RemieRichards Jul 14, 2017 •

edited

RemieRichards Jul 15, 2017 •

edited

Tacolizard commented Jul 15, 2017 •

edited

DoctoreMad commented Jul 15, 2017 •

edited

Ergovisavi commented Jul 16, 2017 •

edited

silicons commented Jul 17, 2017 •

edited

ChangelingRain commented Jul 17, 2017 •

edited

Ergovisavi commented Jul 21, 2017 •

edited