Ports gloves of the north star from Hippie #37864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
>it doesnt make people explode after you punch them enough times |
|
you are already closed on the off-chance this isn't dropped immediately, I can make some sprites |
Cyberboss
reviewed
May 15, 2018
| var/mob/living/M = loc | ||
|
|
||
| if(M.a_intent == INTENT_HARM) | ||
| M.changeNext_move(CLICK_CD_RAPID) |
There was a problem hiding this comment.
Tempted... or I could give it an attack_hand to let them set a 5 char warcry.
There was a problem hiding this comment.
actually hm
we should count the number of clicks and generate it that way
There was a problem hiding this comment.
time to find out how many people use macros when they end up screeching "ATATATATAT" 900,000 times in a second
There was a problem hiding this comment.
Actually, M.say("AT", ignore_spam = TRUE)
There was a problem hiding this comment.
^ I'm serious about this btw, we have chat squashing
There was a problem hiding this comment.
Gonna add the custom four letter warcry at some point soonish...
There was a problem hiding this comment.
totally not just lifting this right from holoparasite code but whatever.
|
@epochayur if you sprite them and it gets closed anyway i'll happily port them to hippie as a consolation prize. |
|
OH YES PLEASE |
|
Love it, please add a version that only deals stamina damage but can punch even faster for adminspawn |
Wait a minute.... |
|
Make a way that you can punch without dealing damage, but after hitting a certain threshold maybe 20-30 punches it will cause them to explode without gibbing |
|
I would say definitely block sleeping carp usage with this. |
|
@Wilchenx It's already "soft blocked" by way of Carp costing 17 and this costing 8 needing a pretty decent discount on either in order to use both (or manage to convince a fellow traitor to hand over his tc so you can have all the fun but good fucking luck with that) so if the starts DO align being able to run a gimmick once in a while shouldn't be too bad. Not to mention that using both isn't as strong as you might think, firstly it only works with harm intent so carp combo's aren't executed any faster. Secondly spending pretty much all your TC on a gimmick that is ABOUT as strong as a dual-e but with no melee block chance is usually a good way to get yourself slipcuffed or just have one plucky sec officer lightly tap you with the business end of a baton and laugh at you. Not to mention borgs will think it just tickles and carry on their day, probably flashing you and dragging you to the sec office. Don't get me wrong you can beat people seven ways from sunday if you get a few good hits in and being able to act out your animeme fantasies on the station is a pretty big powertrip but over on hippie where you can get carp and gloves EVERY ROUND thanks to tc price rebalancing we very quickly found out that spending all your tc on a gimmick tends to go sour more times than it works out for you. |
|
the guy in that video isn't even robust though |
|
If I get this, sleeping carp, and a stand. Will I be the anime shitpost God? |
|
Good luck getting enough tc for that |
|
Here's some shit sprites until someone comes along with something better
|
|
those look pretty damn nice, better than what i was working on |
|
As part of an unintended side effect, someone wearing GOTN will shout their battlecry any time they click on something with harm intent. FEATURE!! |
|
Icons with diff: icons/mob/hands.dmi
icons/obj/clothing/gloves.dmi
|
![rapid[2]](https://share.lzimann.org/y9Tj.png)
![rapid[1]](https://share.lzimann.org/SDpM.png)
![rapid[3]](https://share.lzimann.org/iT9F.png)
|
What's next saitama mid round antag? so we can one punch everything? |
|
@LordSaladin Heres something else I coded for hippie |
|
@GuyonBroadway i like it |
|
This hasn't been merged yet because the maintainers know. Once this gets merged it is time for the hippie nooses PR. |
SpaceManiac
suggested changes
May 23, 2018
| if(M.a_intent == INTENT_HARM) | ||
| M.changeNext_move(CLICK_CD_RAPID) | ||
| if(warcry) | ||
| M.say("[warcry]", ignore_spam = TRUE) |
There was a problem hiding this comment.
The warcry sounds when clicking anywhere on-screen with harm intent, including machinery and areas out of vision, is this intended?
There was a problem hiding this comment.
It only does that when the touch action is applies which is when you click on something with an empty hand while wearing gloves.
Also yes very much intended as its funny, just the idea of someone yelling ATATATATATATATATATATATAT! while typing on the HoP computer made me giggle in a way an adult man shouldn't.
| @@ -55,3 +55,25 @@ | |||
| max_heat_protection_temperature = GLOVES_MAX_TEMP_PROTECT | |||
| resistance_flags = NONE | |||
| armor = list("melee" = 15, "bullet" = 35, "laser" = 35, "energy" = 20, "bomb" = 35, "bio" = 35, "rad" = 35, "fire" = 0, "acid" = 0) | |||
|
|
|||
| /obj/item/clothing/gloves/rapid | |||
| name = "Gloves of the north star" | |||
There was a problem hiding this comment.
"Gloves of the North Star" or change the uplink item name to match this.
SpaceManiac
suggested changes
May 24, 2018
| @@ -55,3 +55,25 @@ | |||
| max_heat_protection_temperature = GLOVES_MAX_TEMP_PROTECT | |||
| resistance_flags = NONE | |||
| armor = list("melee" = 15, "bullet" = 35, "laser" = 35, "energy" = 20, "bomb" = 35, "bio" = 35, "rad" = 35, "fire" = 0, "acid" = 0) | |||
|
|
|||
| /obj/item/clothing/gloves/rapid | |||
| name = "Gloves of the north Star" | |||
There was a problem hiding this comment.
North Star with an N, otherwise PR looks good.
SpaceManiac
approved these changes
May 26, 2018
tgstation-server
added a commit
that referenced
this pull request
May 26, 2018
Jalleo
added a commit
to Jalleo/-tg-station
that referenced
this pull request
Jun 1, 2018
* Automatic changelog generation for PR tgstation#37962 [ci skip] * Automatic changelog generation for PR tgstation#37984 [ci skip] * Fix flipping of trinary pipe fittings and related RPD tooltips (tgstation#37982) * Automatic changelog generation for PR tgstation#37982 [ci skip] * Stops luxury shuttle forcefields from vanishing * Automatic changelog compile, [ci skip] * Fix outdated R&D console comment (tgstation#38020) * Fix power tools being deleted if adjusted using TK * Fix TK sparkling in the corner of an area when clicking a turf * Fix bad TK interactions with material containers * Fix TK teleporting items out of the deep fryer * Fix TK teleporting filled sandbags * Examine the grabbed object instead of the TK grab * Fix click catcher math being wrong in widescreen * Fix lathes attempting to accept abstract items * Fixes mimery blockade showing up under spell tab (tgstation#38004) * Automatic changelog generation for PR tgstation#38004 [ci skip] * Fixes reactive repulse armour (tgstation#37999) * Removes a couple thousand empty lists (tgstation#38000) door.shockedby * Automatic changelog generation for PR tgstation#38000 [ci skip] * Adds a sprite for the "quit vr" action button (tgstation#37994) * is that a motherfucking 90s reference * WHEN YA FUCK UP BADLY ENOUGH ON ADDING A SPRITE TGHAT YA GOTTA MANUALLY CHANGE CHANGELOG.HTML * Automatic changelog generation for PR tgstation#37994 [ci skip] * Fix frost spiders injecting a nonexistent reagent * Fix Jacob's Ladder allowing access to VR * Magical Animations Update Part 2: Staffs (tgstation#37930) * Add files via upload * WHY IS THIS SO HARD * fuck books * Some circuitry fixes and qol (tgstation#37755) * some circuit fixes I removed the ability for you to save whether or not an assembly is open since you always want the assebly to be open when its printed so you can put a battery in. I fixed the other three issues because they were bugs. * tells user when they use a sensor or scanner * oops * revert last commit * usr -> user * Automatic changelog generation for PR tgstation#37755 [ci skip] * Replaces /atom.initialized and .admin_spawned with flags (tgstation#37981) kill .initialized and .admin_spawned from /atom * Automatic changelog generation for PR tgstation#37981 [ci skip] * [s] Power monitor tweaks and fixes (tgstation#38005) * Power monitor tweaks and fixes * Crouching tiger, hidden power monitor * flavor text * Fix ambient occlusion on xeno weeds and wall corners (tgstation#37987) * Automatic changelog generation for PR tgstation#37987 [ci skip] * Make CentCom not self-looping (tgstation#37979) * Automatic changelog generation for PR tgstation#37979 [ci skip] * Fix the destructive analyzer eating entire stacks (tgstation#37983) * Automatic changelog generation for PR tgstation#37983 [ci skip] * Fixes proximity sensors. (tgstation#37985) * Fixes proximity sensors. * comment -> removal * admin backup loading fix (tgstation#38034) * Fix gravity in one of Moon Outpost 19's areas (tgstation#37989) * bronze spelling * Security console fixes * Sync permanent admin removals to the players table immediately * Fixes fried items losing inhands (tgstation#38048) * Cargo Update: Cargo Supplypod Beacons! (tgstation#37345) (THE CODEX ASTARTES CALLS THIS MANEUVER: STEEL RAIN) [New sprite!] * file the boy asdh beacon overlays first pass complete bring out the drinks boys fixes! fixes! whups fix name speed makes coffin a crate to prevent runtimes sprite fuckup:the musical whups more fixes why tf was screengen modified??? TO THE FILE devices changes things p[omf pomf uhg alright fuk it issue fix pt 1 in which i make merge conflicts my bitch by fixing devices.dmi and tgui.js oh shit forgot about the items repath hm nah merge conflict a then all ya gotta do is whip * shiv review me code reeeeeeeeeeeeeeee * rebase conflict * anturk * asdf * wooooeeeeeeh makin bacon * dont forget about lil old me * id like to give a shoutout, to my man spacemaniac. on the soul plane. rip in peice, my bugs. rip in peice * spacy man what is ur spacy plan * 1st * 2nd * organization also a thing * so i figured out why defines didnt work sometimes across files. this fixes the last issue rn * forgot to cop the commit * fuck how am i so stupid * adds comments and agrees with spacemaniac * asdfghjk * Automatic changelog generation for PR tgstation#37345 [ci skip] * Adds VR Snowdin and Syndicate Trainer/VR Update roll up (tgstation#37915) * Adds VR Snowdin and Syndicate Trainer * Replace var edit * I did forget to add a few * Adds one full outfit spawn * internals too * closet * Extends same Z level check to monitor and emping * restricted uplinks * camera bug fixes don't talk about the bees outfit changes More items outfit fix * Adds vr sleepers to runtime station * More mapping fixes * Adds telecomms to taunt your enemies * More restrictions * Some fixes * badabing * More fixes * emag related changes * forgot the ract * Additions * griff resistance mode * minor changes * Removes old centcom away map * Pushes you out of VR if you try to ghost * this is🅱️ roke * this shit is not🅱️ roke * as requested * Automatic changelog generation for PR tgstation#37915 [ci skip] * Adds departmental wardrobe vendors to all maps (tgstation#37992) * pubby, omega, meta, deltastation * groups/sorts autodrobe packs and mining vendor items * moves delta bar vendor * expands omega+meta private studies * Automatic changelog generation for PR tgstation#37992 [ci skip] * Added an action button to change your entire chameleon outfit at once (tgstation#37953) * Added an action button to change your entire chameleon outfit at once * Made chameleon stamps actual chameleon items Added stamps to bonus chameleon items on outfits that should have them Made clothing work with hooded suits * Automatic changelog generation for PR tgstation#37953 [ci skip] * Enable SSping during the lobby * Fix grammar in admin varedit log * Shuffle Exited call to after loc is actually changed in forceMove (tgstation#38022) Fixes storage forcing everything to mouse opacity fulltile * Small QoL improvement on smartfridge item release (tgstation#37946) * item goes to hand * this will compile * Ugly hack give me a medal if this compiles. * This one is real ugly now, speedmerge please * Automatic changelog generation for PR tgstation#37946 [ci skip] * Fix template preview being invisible on space turfs (tgstation#37971) * Automatic changelog generation for PR tgstation#37971 [ci skip] * Disallow effects from being scanned by the chameleon projector (tgstation#38017) * henk * iseffect * Automatic changelog generation for PR tgstation#38017 [ci skip] * Reorder vars * Fixes drones being able to magically sense invisible revenants (tgstation#38019) * revfix * Update revenant.dm * Automatic changelog generation for PR tgstation#38019 [ci skip] * Fixes accidental empty ahelp replies (tgstation#38052) * Automatic changelog generation for PR tgstation#38052 [ci skip] * Automatic changelog generation for PR tgstation#38026 [ci skip] * req_one_access (tgstation#38068) * Automatic changelog generation for PR tgstation#38068 [ci skip] * Automatic changelog generation for PR tgstation#38023 [ci skip] * Automatic changelog generation for PR tgstation#37993 [ci skip] * Automatic changelog generation for PR tgstation#37960 [ci skip] * Automatic changelog generation for PR tgstation#38044 [ci skip] * Automatic changelog compile, [ci skip] * Adjust antag rep values * Automatic changelog generation for PR tgstation#38042 [ci skip] * Automatic changelog compile, [ci skip] * Only adjust input bar color on hotkey mode * Automatic changelog generation for PR tgstation#37963 [ci skip] * Eat the ice cream (tgstation#38028) * Eat the ice cream * Update robot_items.dm * Update robot_items.dm * Automatic changelog generation for PR tgstation#38028 [ci skip] * Bag of Holding Rework (tgstation#38010) * Bag of Holding Rework * RCDs work on chasms * No transit space nonsense * Fixes runtimes * No infinite chasm * Automatic changelog generation for PR tgstation#38010 [ci skip] * Default to not adjusting direction in Create Object (tgstation#37998) * Automatic changelog generation for PR tgstation#37998 [ci skip] * Circuitry lab changes (tgstation#38029) * circuitry lab changes * syndicate cell charger board * Automatic changelog generation for PR tgstation#38029 [ci skip] * Fix nullspace error room not working correctly * Allow into space diagonally (tgstation#38066) * Automatic changelog generation for PR tgstation#38066 [ci skip] * [s] Blacklists TB grenade from experimentor. (tgstation#38095) * Automatic changelog generation for PR tgstation#38095 [ci skip] * Gun overlays 2: Electric boogaloo. (tgstation#38003) * Reduces selfcharge gun processing/icon work * More efficient gun overlays, adds old_ratio var * oh my god it was calling the egun's update_icon? * percent proc * Attachment overlay overhaul * Cut overlays in egun update * ebow 1000% better overlay management * Update gun.dm * Pointless check * Giving KA and children consistent icon behavior * Update kinetic_accelerator.dm * Fixed * ..() readded * ..() readded * ..() readded * Antur didnt catch this one heck * Because confusing vars are apparently more maintainable * Gun overlays 2: Electric boogaloo * another one * Chameleon guns are removed * tentacles everywhere * Automatic changelog generation for PR tgstation#38003 [ci skip] * Fixes backslot not counting towards assess_threat (tgstation#38046) * Fixes backslot not counting towards assess_threat * fixed * Cleanup & commentary * Automatic changelog compile, [ci skip] * Gives effects to drinks Alexander, Between the Sheets, and Menthol (tgstation#37700) Drink effects! * Automatic changelog generation for PR tgstation#37700 [ci skip] * Ports gloves of the north star from Hippie (tgstation#37864) * Ports gloves of the north star from Hippie * Doing a white line * adds customiseable warcry and sprites by Notamaniac * star with a capital S * Nitpick grammar * Automatic changelog generation for PR tgstation#37864 [ci skip] * Eatting fried items actually consumes the item (tgstation#38054) * Eatting fried items actually consumes the item * destroy * Fix typo in Python dependencies file (tgstation#38080) * Fix premapped atmos machines turning on automatically when re-wrenched (tgstation#38065) * Fix premapped atmos machines turning on automatically when re-wrenched * Move on and open variables up to atmospherics base * Update maps for valve var change * Rename valve/open to valve/on, add valve/digital/on * Automatic changelog generation for PR tgstation#38065 [ci skip] * Add container_type to VV bitfields * Capitalizes CentCom (tgstation#38086) * Capitalized CentCom * neediful * Fix the escape pod safes always being unlocked * [s] Fixes TB nades for real now (tgstation#38113) * Automatic changelog generation for PR tgstation#38113 [ci skip] * Automatic changelog compile, [ci skip] * Those footprints are... moving? [Chameleon Proj will let you scan decals] (tgstation#38071) * Automatic changelog generation for PR tgstation#38071 [ci skip] * Custom Chaplain Armor Kits (tgstation#37569) * giant dad set * twop underway * initial * initial * no special armors :(((( * bye twop * no more special armors * f * more removals * fixes * normieizing the armors pt1 * ok, finally * I'M DONE I DID IT * removals * this will not compile but next commit in two commits it will * this will not compile but next commit it will * it compiles 20 dollars says it compiles * i am so sorry * fixes everything, >:( * *coughs up hairball* * cobby's suggestion * pbool'f fhttrfgvba * OOOOOOOOH YEAAAAAAAH BABY * quieter * AH OKAY THERE * Automatic changelog generation for PR tgstation#37569 [ci skip] * Adds better admin messaging to boh and fixes summons happening in the wrong places (tgstation#38096) * Adds better admin messaging to boh * Same for the logs * chumbis * I'm a chumbis * Automatic changelog generation for PR tgstation#38096 [ci skip] * Adds action features to the metastation beerkeg-nukes (tgstation#38084) * Hottomonkulu Pyynö mos kyren hepität. Nerse marentaat aluturnate. * Masennoo sum keuron väkeltäät vassem Pyynö er borsalitaat Urmas. * Tarnatat kuulor ustanitat vernes heuremasso seurutik Pyynör kanervo mahkatosimos. Atti ivakhan nutiv. * Surmustulet nasnas kyhille nes viuhuntut sepelitör arnisansatin. * Automatic changelog generation for PR tgstation#38084 [ci skip] * New Trait: Drunken Resilience (tgstation#38076) * drunk healing * balance, bugfix * more consistent wording * removed random chance and tweaked values * rounding values * 0 to FALSE, slightly lowered top values * Automatic changelog generation for PR tgstation#38076 [ci skip] * @Dril Jan 21 thinking of wrapping my entire body in barbed wire and becoming Sovereign * Borgs can now toggle rad collectors (tgstation#38100) * Automatic changelog generation for PR tgstation#38100 [ci skip] * Automatic changelog compile, [ci skip] * Refactor machinery/anchored to default to TRUE Deletes /obj/machinery/thruster. Changes the density of the following abstract types: - /obj/machinery/modular_computer - /obj/machinery/mineral - /obj/machinery/field - /obj/machinery/particle_accelerator - /obj/machinery/abductor - /obj/machinery/telecomms * Remove redundant anchored=TRUE from machines * fixes beebox from cargo starting wrenched tgstation#38119 * ss * Fixes "humans_need_surnames" applying to all races * [s] Fix observers being able to manipulate their target's screens (tgstation#38097) * Fix observers being able to move the action button toggle button * Fix observers using the target's ambient occlusion preference * Automatic changelog generation for PR tgstation#38097 [ci skip] * Fix runtimes when pipe placement fails due to overlap (tgstation#38104) * List catpeople and hulks as mutants in health scans * Fix: Negative blood levels now kill you (tgstation#38105) * Automatic changelog generation for PR tgstation#38105 [ci skip] * Adding logging for attempted disarms (tgstation#38107) * This time for sure * Reflect fix (tgstation#37964) Reflectors reflect at expected angles at long distances. * Automatic changelog generation for PR tgstation#37964 [ci skip] * Automatic changelog generation for PR tgstation#38121 [ci skip] * Automatic changelog generation for PR tgstation#38119 [ci skip] * Automatic changelog generation for PR tgstation#38115 [ci skip] * Automatic changelog generation for PR tgstation#38108 [ci skip] * Automatic changelog generation for PR tgstation#38090 [ci skip] * Delta toxins lab DLC (tgstation#38110) * deletes firing range * adds ignition chamber * reeeee * readds deleted valves * dv begone * removes blob spawn * Automatic changelog generation for PR tgstation#38110 [ci skip] * Automatic changelog compile, [ci skip] * Make typecache checks twice as fast, stop using single-type typecaches where appropriate (tgstation#38075) * Automatic changelog generation for PR tgstation#38075 [ci skip] * collector-examine (tgstation#38035) Now collector on examine shows real produced power and stored power. Rename last_power to stored_power. * Automatic changelog generation for PR tgstation#38035 [ci skip] * Automatic changelog compile, [ci skip] * Fixes some minor bugs with the syndicate trainer and IDs (tgstation#38127) * Automatic changelog generation for PR tgstation#38127 [ci skip] * Fix the destructive analyzer not revealing nodes (tgstation#38106) * Fix the destructive analyzer not revealing nodes * Fix references to deconstructive analyzer * Automatic changelog generation for PR tgstation#38106 [ci skip] * Fixes traitor AI purge objective * Makes a bunch of materials containers show contents on examine (tgstation#38133) * fixes people trying to fix the bangammer's grammar (tgstation#38129) * that means you, Michael-Ashfield * fixes grammer * blockquotes * Fixes flamethrowers not able to be crafted (tgstation#38139) Adds tools to [other] list so they can be included in crafting recipes * Automatic changelog generation for PR tgstation#38139 [ci skip] * Spew proc has an argument for amount of organs spewed (tgstation#38124) alright * Arrest diagonal movement when force-moved * Fixes Meta maint chemmaster (tgstation#38148) hhhh * Allow dynamically updating UI style, do so on mob login (tgstation#38089) * Automatic changelog generation for PR tgstation#38089 [ci skip] * Fixes Spirit Realm rune spawning braindead cult ghosts (tgstation#38138) * Fixes Spirit Realm rune spawning braindead cult ghosts * Keeps previous ghost limit * Automatic changelog generation for PR tgstation#38138 [ci skip] * Fix cyborg HUD not unhilighting when dropping a module (tgstation#38145) * Fix cyborg HUD not unhilighting when dropping a module * Remove redundant dropped call * Strip DROPDEL before dropping rather than after * Automatic changelog generation for PR tgstation#38145 [ci skip] * Fixes random-weighted AI laws (tgstation#38152) * Removes normal ways to obtain drones (tgstation#38101) I don't want this merged as soon as, I'd just rather normal drones to go away if no-one offers to fix their broken state. Going to see if I can find out from someone how to edit maps tomorrow to remove the dispensers from them since you can't make them and I swear I've seen them before. remove any way to obtain drones outside the dispenser remove dispenser from maps Edit: To better explain for the sake of a good PR body and a lack of a link to the PR a day ago, drones have been in the code in roughly the same state for 3 years (dispenser PR by Xhuis is missing from GitHub) and have gained laws admins enforce when they notice drones doing the wrong thing due to it being a ghost role. The code verbally dictates this will happen. The role hasn't been coded to prevent these many wrong things and has weak balance to begin with being a monkey with a vent ready backpack. Administration hasn't stopped caring about this role. It should be in their direct hands until the role is clearly not an administration problem and fixed to represent that. * Automatic changelog generation for PR tgstation#38101 [ci skip] * makes things that light plasma fires capable of heating the atmosphere (tgstation#37426) In layman's terms, this means welding tools, bonfires, igniters, etc, will now actually generate heat. Attempting to build a bonfire inside the station without taking precautions is now a very bad idea. cl deathride58 add: Things that are capable of igniting plasma fires will now generate heat if there's no plasma to ignite. Building a bonfire inside the station without taking safety precautions is now a bad idea. /cl * Automatic changelog generation for PR tgstation#37426 [ci skip] * Chemical Specific Heats (tgstation#37691) cl experimental: Chemistry now has something called specific heat. For the uninitiated, this is the thermal capacity of the reagent, much like how some atmospherics gases have different thermal capacities, making them able to absorb/release more energy per degree of temperature change! rscadd: Plasma specific heat is 500J/K*unit, everything else is 200 /cl * Automatic changelog generation for PR tgstation#37691 [ci skip] * Refactors how overlays handle the compile step (tgstation#38002) Robustin says: The very heart of our overlay code, a single line that basically boiled down to overlays = new_overlays, was the cause of so much overlay lag. Human overlay code was by far the biggest culprit. Most objects have 0-2 overlays but humans are marching around with 20+ most of the time and the current system was spending a LOT of effort comparing 20+ image with 20+ other images and then apparently rendering them all anyway. Human overlays are at least 10x the cost of any other overlay process and on a busy server the overlay compiling was 2x the cost of any other system. I compared the cost of overlay changes by picking up/dropping a PDA in the dorms 250 times, with a 50% chance to use our current overlay compiler and a 50% chance to use a "direct addition/removal (+=, -=) approach: CURRENT 1120ms 133 (avg:8.4210529327392578) SCRAPS 6ms 112 (avg:0.0535714291036129) Now this PR makes our whole overlay subsystem use that approach for overlay compiling and the early results look incredible. The best part is this is just the START of improvements. Humans benefits the most because their icon system was already designed for small, incremental overlay updates. By moving other code from "Cut everything, then put it all back" to only updating the necessary overlays (cough, APC's), we can see similar improvements. oranges says: I've picked up this PR because robustin vanished, but I do see the value in the approach, only things I added were the checks for the overlay list len changing I also retabbed the entire file because I am a brainlet and did it without thinking * Automatic changelog generation for PR tgstation#38122 [ci skip] * Adds module upgrades for the Janiborg (tgstation#38114) * Adds upgrades for the Janiborg. * Does the requested changes. * Automatic changelog generation for PR tgstation#38114 [ci skip] * Fix Pubby auxiliary mining base * AI Multicamera mode (tgstation#37695) * Added multicamera mode for AIs * Minor multicamera fixes * Cameras near an AI multicamera eye now light up red * Disabled AI multicamera mode without admin intervention * Fixed AIs being able to use multicamera mode when they should not * Automatic changelog generation for PR tgstation#37695 [ci skip] * Fix: Cyborgs can now use defibs with other modules equipped (tgstation#38158) * Adds a check to see if the user is a cyborg before referring to the offhand. * Update twohanded.dm * actually this is a bit more modular * Update twohanded.dm * Update twohanded.dm * Automatic changelog generation for PR tgstation#38158 [ci skip] * Fix family heirloom being lost on cloning * Set cult floor effects to be on the floor plane * Standardizes and cleans up some admin messages & logging (tgstation#38128) * Improved logging * Fixes & emitter logging * ded * Fix First Death not being remembered if DB is not in use * Removes drone overlays and the associated code (tgstation#38175) * Remove drone overlays 4* animated multidir overlays per mob is a bit much * to the orbit with you too * Adds config for monkey cap (tgstation#38165) * Automatic changelog generation for PR tgstation#38165 [ci skip] * Corrects bronze floor & table's name (tgstation#38164) * Automatic changelog compile, [ci skip] * Blacklist projectile effects from chasms * Automatic changelog generation for PR tgstation#38159 [ci skip] * Fix rank changing with legacy only rank loading (tgstation#38160) Legacy only rank loading would block any permanent rank changing. Now only blocks adding a new rank to the db. * Remove datum/action/generic (tgstation#38201) * Fix reagents being lost when vomit piles combine * Stock parts sorter now use get_parts_rating (tgstation#38191) * Automatic changelog generation for PR tgstation#38191 [ci skip] * Move NODROP_1, DROPDEL_1, ABSTRACT_1 and NOBLUDGEON_1 to item_flags where they belong (tgstation#38171) * (mostly) nodrop * (mostly) dropdel * (mostly) abstract * nobludgeon * things i missed * forgot one * unintended changes * energy handcuffs * Automatic changelog generation for PR tgstation#38171 [ci skip] * Automatic changelog compile, [ci skip] * Fix infinite soapstone uses exploit (tgstation#38195) * Automatic changelog generation for PR tgstation#38195 [ci skip] * allows changing the rank of players in the playerpanel (tgstation#38172) * allows changing the rank of players in the playerpanel * Update permissionedit.dm * Update permissionedit.dm * Automatic changelog generation for PR tgstation#38179 [ci skip] * Automatic changelog generation for PR tgstation#38180 [ci skip] * Automatic changelog generation for PR tgstation#38185 [ci skip] * Automatic changelog generation for PR tgstation#38198 [ci skip] * Marginal Sprite Improvements Part 2: Cigarette Lighter Boogaloo (tgstation#38161) * the rainbow of mediocrity rides again * whoops that wasn't supposed to be there * updated vending machine, burger, and donut sprites they've all been improved marginally * edits roborger a bit more "bun" is flatter, has an antenna that blinks in agony * does sprite things to lighters and cigar cases * darkened cigar case interiors * tweaks lighter flames * Automatic changelog generation for PR tgstation#38161 [ci skip] * Automatic changelog generation for PR tgstation#38210 [ci skip] * EMPs no longer pulse internal silicon wires * Fixed the clockwork helmet so it drops to the ground when used by a non-clock cultist like the other clock armor does. * Automatic changelog generation for PR tgstation#38170 [ci skip] * Automatic changelog generation for PR tgstation#38116 [ci skip] * Automatic changelog compile, [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑 GuyonBroadway
add: Adds gloves of the north star to the traitor uplink. Wearing these gloves lets you punch people five times faster than normal.
rscadd: Sprites for the gloves courtesy of Notamaniac
/:cl:
Discord told me to do it.
-It only applies to harm intent attacks.
-It does not increase attack speed with held objects.
-It does not increase hulk attack speed due to how hulks work (and its probably for the best)
-It does work with krav maga in theory but seeing as there isn't currently an in game way (on tg at least) to get krav maga without also wearing the krav maga gloves it doesn't work in practise.
-It DOES work with sleeping carp but at 8tc you will need some luck with discounts in order to be able to use both, also see here for why this might not be as overpowered as you might think. https://youtu.be/Kp09QB5-Z3E
Yes the sprites aren't hand-wraps like wot people tell me kenny boy wore in that thar anny may but I'm not a spriter and have less than 0 artistic talent. If you want to make some nice sprites to go with these then be my guest, I will however steal them for hippie.Disregard, Notamaniac made some nice sprites that serve as a decent visual indicator that someone is wearing gloves of beating the shit our of you... as if a guy screaming ATATATATATATATATATATATAT and punching faster than motorhead's drummer wasn't a big enough indicator.