Bag of Holding Rework

[imtakingabreakdontatme]

🆑 Kor
add: Bag of Holding detonations have been significantly reworked.
/:cl:

Why: Bags of holding are super easy to get, super destructive, and basically impossible to repair the damage from. They are my favourite item but they've continuously been a balance problem and an admin headache since they can't easily undo the damage people do when griefing. Went with the actual tabletop impact of bags of holding for inspiration

Bags of holding now create a large area of "chasms" that lead to a new area called the Tear in the Fabric of Reality with a singularity at the center.

Two ladders lead in/out of the Fabric of Reality area, and those ladders lead to random spots in lavaland/space.

Bags of holding are still very overpowered when detonating but theoretically survivable and repairable.

Further plans: Allow people to connect a third ladder there, maybe put special items so insane scientists can purposefully jump in there to try and loot. Maybe not have the other ladders active in lavaland/space until someone enters with a BoH and uses them (and consequences like anomalies or monsters appearing if you weaken the fabric of reality too much, use the ladders, etc)

[IconDiffBot]

Icons with diff:

icons/turf/floors.dmi

Key	Old	New	Status
binary[13]			Created
binary[8]			Created
binary[2]			Created
binary[12]			Created
binary[1]			Created
binary[10]			Created
binary[5]			Created
binary[14]			Created
binary[7]			Created
binary[6]			Created
binary[4]			Created
binary[16]			Created
binary[11]			Created
binary[3]			Created
binary[9]			Created
binary[15]			Created
binary			Created

icons/turf/floors/magic_chasm.dmi

Key	Old	New	Status
1-n			Created
2-n			Created
3-w			Created
3-f			Created
2-e			Created
4-e			Created
3-s			Created
1-nw			Created
3-i			Created
3-sw			Created
2-i			Created
1-i			Created
4-s			Created
2-f			Created
4-se			Created
1-f			Created
1-w			Created
4-i			Created
smooth			Created
2-ne			Created
4-f			Created

[imtakingabreakdontatme]

[Arianya]

What happens to the detonator? Do they just fall in as they would normally? And what happens if you BoH bomb in the tear?

[81Denton]

This looks good! I could even see people build bases down there.

A few things:

• RCDs aren't able to build on top of the tear, but metal rod into lattice -> floor tile is possible.
• Deconstructing lattice built on top of the tear won't drop the metal rod through the tear.
• Indestructible objs like the station self-destruct get transported to the centcom z-level, this is relevant for the next one:
• Edge case: You can put the nuke disk inside the self-destruct and detonate a BoH on top -> both will get transported to the centcom z-level, really screwing over nuke ops.
• Another edge case: If the crew is extra cheeky, they can build a path towards the center, put the nuke disk there and deconstruct all other tiles with an RCD. Looks like this:
  https://user-images.githubusercontent.com/32391752/40410060-0becd838-5e6d-11e8-9dcd-a5ff924a4296.JPG
• Sparks and other effects like flightsuit ion trails can fall through the tear, which could possibly get very spammy.
• Ladders sometimes don't link (/obj/structure/ladder/unbreakable/binary/unlinked) and give the The mysterious ladder doesn't seem to lead anywhere. message.
• Atmos machinery that falls through the tear causes a bunch of runtimes:

[09:02:06] Runtime in vent_pump.dm,253: Cannot execute null.return pressure().
[09:02:14] Runtime in LINDA_turf_tile.dm,57: Cannot execute null.merge().
[09:02:28] Runtime in airalarm.dm,597: Cannot read null.gases

@Arianya Yeah, they seem to fall down to a random tile. If they don't drop into the singularity, they can take a ladder out or walk off the edge, which dumps them in space.

If you detonate a bag inside, it won't affect the main area but will give the edge a "rim" like this:
https://user-images.githubusercontent.com/32391752/40410206-75625c34-5e6d-11e8-8f1c-e01bc73610e2.JPG

[imtakingabreakdontatme]

RCDs should be able to build on chasms, not sure why they cant

Sounds like another chasm bug

Bizzare, not sure how to fix off the top of my head

Shouldn't be too bad if they hide a disk on a chasm island since you can floor rod to it

Another chasm problem yeah, I'm sure regular chasms on station will reveal many

The unlinked ladder is not meant to be linked until a miner finds the other half in a box or RnD builds it or something

Atmos machines should stop runtiming once I figure out an alternative to blocks air yeah

[Arianya]

Sounds interesting all round.

Peak hilarity value: BoH bombing the bridge to get heads of staff off z-level in revs.

[Tlaltecuhtli]

does it mean you can sit there and count as "escaped" for green text?

[arsserpentarium]

Surprisingly nice idea

[DaxDupont]

Also please be mindful that gun beams also fall into chasms which is a currently open issue, when someone aims a particle accelerator over chasms everyone that sees it nearly gets crashed because of the 43000x falls in chasm.

[ExcessiveUseOfCobblestone]

/global/
New()

WHEN WILL THIS END

[ExcessiveUseOfCobblestone]

Also this is really fourth wall breaking but that can be fixed later :^)

[GhostEcho]

Wait, RCDs are SUPPOSED to be able to build over chasms? Holy fuck I just thought we were meant to just put up with em

[davethwave]

This seems interesting.

[xenon-difluoride]

Two things:

1. Will the tear area depressurize?
2. Can't people abuse this to get to centcom?

[imtakingabreakdontatme]

Alright turns out the disk just straight wont leave if its on centcomm at all so I'm gonna have to do some snowflake check or move this to another Z level

[davethwave]

Forgot, does the disk have a specific spawn point?

[imtakingabreakdontatme]

It does not

[81Denton]

Will the tear area depressurize?

The tear on the station doesn't, while the tear area on the centcom level initializes with no gases and blocks gas movement.
@KorPhaeron is it intended that it has air = null? You can't even use an analyzer or the "view gases" verb there, oddly enough.

Can't people abuse this to get to centcom?

I doubt it as it's surrounded by 7 tiles of transit space and has noteleport set to TRUE.

[ghost]

Super lame area it should be something that is a seizure warning not this LAMO shit

[ghost]

Or maybe just softly changing rainbow colors yknow something enjoyable to look at

[ExcessiveUseOfCobblestone]

Blob buff pls nerf

Bring the blob too, it's fun for the whole family!

[davethwave]

get the blob into tear, auto creates blob walls, auto-attack destroy walls that prevent going out of the area, spreads to everywhere in space.

[xenon-difluoride]

The only thing keeping you in is the transit space which I think affects blobs

Then again, those might spread through space

[Kromgar]

I guess blob dropped in the tear means crew loses? Unless they drop in to fight it as the blob can always transition zs back to station and transfer core

[GravitronBlue]

From earlier testing throwing more bags of holding into reality chasms usually means some will end up getting eaten by the tear in reality, causing a large 5/15/45 explosion, so I wouldn't be too concerned about blobs winning just because they manage to get inside it.

[Kromgar]

Aren't cores immune to explosions?

[PKPenguin321]

you know that wizard spell that just fucks everything up in like a 7x7 area and randomizes their positions or whatever
this whole area should have that all the time

[Shadowflame909]

The spacetime disruption spell? I think it'd fit with the theme.

[PKPenguin321]

yeah that one

[moonheart08]

Silly idea that just might improve the place: Figure out a way to proc gen this area in a similar manner to Lava Planet, and fill it with both dangerous hazards and really good loot. Make it potentially worthwhile to come over, but dangerous to stay unless you're really good at the game.

[imtakingabreakdontatme]

Expanding the area might be cool in the future but I'd rather have the basics working and let someone else expand on it than work on it forever with this PR

[zaracka]

you know that wizard spell that just fucks everything up in like a 7x7 area and randomizes their positions or whatever
this whole area should have that all the time

So a whole area becomes permanently unusable then? Back to square one. Actually kind of worse, because at least with a singularity you can rebuild the area.

[Dorsisdwarf]

zaracka, pkp means the alternate dimension i think

[PKPenguin321]

yeah

[xenon-difluoride]

That makes it impossible to build anything in there

[PKPenguin321]

and the massive singularity 3 feet away doesnt?

[xenon-difluoride]

yeah, the single doesn't suck things in and you can just build around it (and then build a tele to safely go in and out)

[xenon-difluoride]

*singulo (can't edit posts on this computer)

[DaxDupont]

Can you add a admin coord jump on the bag of holding detonation message? Before we could jump to the singu, but since there's no more singu it might be handy do have a coord jump to figure out instantly where it happened.

[Michael-Ashfield]

The jaunter does not protect you from failing into the tear in reality, I feel it should protect the user like it does for chasms.

[imtakingabreakdontatme]

Jaunter is broken for all chasms right now

[cacogen]

I really dislike this change.

[optimumtact]

nobody cares, make your own server

[davethwave]

Kind of too late to complain as well...