-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Port Custom hotkeys from TGMC" #47571
Conversation
This reverts commit 070bb5e.
i expect someone to fix the main PR, i just made this for headmins to testmerge while a fix is made |
there's only two issues relating to this on the tracker, can people please catalogue things they think are related here. Things explicitly not broken by this
known issues fixed by another pr unreproduced issues Not yet reported issues? |
@IndieanaJones @Yenwodyah etc, if you experienced issues with this can you please explain what you saw, and ideally your byond client version |
Another known issue is H hotkey for stopping pulling not working |
fixed in #47569 |
specific issue that i experienced with the PR in question: pressing t, o, or m opened 2 say, ooc, and me boxes respectively |
need more information, did you try clearing your BYOND cache? are you using a custom skin or macros? |
control freak is on, so nobody should be using custom skins or macros, that would be an unsupported configuration |
my ahk macros still kind of worked, just really clunkily, so u may wanna look into however cntrl freak works. probably unrelated to this pr though |
control freak is unrelated to external macros |
throwing out swapping between hotkeys and arrow keys was a mistake because there are no defaults for arrow keys which is a major inconvenience to rebind for any player who actually uses arrow keys |
@optimumtact this is my issue #47665 |
The defaults are the optimal keyset we want to carry on for the future |
not testmerged anywhere anymore, issues are being resolved |
mod edit: It was tested, your issue doesn't occur for everyone and we're having trouble reproducing it.
claiming no testing was done at all doesn't help anything