Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Port Custom hotkeys from TGMC" #47571

Closed
wants to merge 1 commit into from
Closed

Revert "Port Custom hotkeys from TGMC" #47571

wants to merge 1 commit into from

Conversation

imsxz
Copy link
Contributor

@imsxz imsxz commented Nov 4, 2019

mod edit: It was tested, your issue doesn't occur for everyone and we're having trouble reproducing it.

claiming no testing was done at all doesn't help anything

@tgstation-server tgstation-server added the Revert We all have regrets, but few get to make them vanish like this label Nov 4, 2019
@imsxz
Copy link
Contributor Author

imsxz commented Nov 4, 2019

i expect someone to fix the main PR, i just made this for headmins to testmerge while a fix is made

@optimumtact
Copy link
Member

optimumtact commented Nov 4, 2019

there's only two issues relating to this on the tracker, can people please catalogue things they think are related here.

Things explicitly not broken by this

  1. borg interaction at a distance
  2. your custom ahk scripts/macros not working

known issues fixed by another pr
add: new button that truly toggles move intent
fix: hotkeys using Alt, Shift and Ctrl now work correctly
fix: pressing h will allow you to stop pulling now

unreproduced issues
multiple ooc or say windows

Not yet reported issues?
Your stuff here

@optimumtact
Copy link
Member

@IndieanaJones @Yenwodyah etc, if you experienced issues with this can you please explain what you saw, and ideally your byond client version

@Couls
Copy link
Contributor

Couls commented Nov 4, 2019

Another known issue is H hotkey for stopping pulling not working

@optimumtact
Copy link
Member

fixed in #47569

@imsxz
Copy link
Contributor Author

imsxz commented Nov 4, 2019

specific issue that i experienced with the PR in question: pressing t, o, or m opened 2 say, ooc, and me boxes respectively

@Couls
Copy link
Contributor

Couls commented Nov 4, 2019

need more information, did you try clearing your BYOND cache? are you using a custom skin or macros?

@optimumtact
Copy link
Member

control freak is on, so nobody should be using custom skins or macros, that would be an unsupported configuration

@carlarctg
Copy link
Contributor

control freak is on, so nobody should be using custom skins or macros, that would be an unsupported configuration

my ahk macros still kind of worked, just really clunkily, so u may wanna look into however cntrl freak works. probably unrelated to this pr though

@actioninja
Copy link
Member

control freak is unrelated to external macros

@bobbah
Copy link
Member

bobbah commented Nov 8, 2019

throwing out swapping between hotkeys and arrow keys was a mistake because there are no defaults for arrow keys which is a major inconvenience to rebind for any player who actually uses arrow keys

@kopoba
Copy link
Contributor

kopoba commented Nov 8, 2019

@optimumtact this is my issue #47665

@optimumtact
Copy link
Member

The defaults are the optimal keyset we want to carry on for the future

@actioninja
Copy link
Member

not testmerged anywhere anymore, issues are being resolved

@actioninja actioninja closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Revert We all have regrets, but few get to make them vanish like this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants