Icebox Station #51090
Merged
Icebox Station #51090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds config options for choosing mining maps areas now have options that affect random generation on them weather now has an option to not target indoor areas adds base for icemoon ruins turns many 1's into booleans adds ice chasms adds ztraits for weather stuff
adds lower z level to the ice moon mine ice chasms now have a smoothed icon megafauna only spawn in the underground portion of ice moon now
Adds the abandoned village ruin for Ice Moon
you can no longer change the mining map before setup is complete
fixes a bug where multiz was impossible unless there were shared areas because of whitelisted areas adds multiple whitelist areas for ruin placement in a list all underground areas are now outdoors underground plasma lava rivers are now only spawned in unexplored areas so ruins don't get destroyed by them
adds 2 new mobs to icemoon the polar bear and wolf adds a clothing flag for shoes that dont slip on ice modifies mining site to be ready except for the boss adds the ability for tunnel width to be a specification, ice moon can have 1 tile wide tunnels and rarely 2 wide tunnels adds a no caves mineral for ice moon ruins
bears now enrage sooner bear spawners can now actually be created adds base for ice moon atmospherics adds base for a new boss and achievements / score really bad coder icon for ice boots added
megafauna recovery time can now be tailored to have different cooldowns to ranged or melee attacks by default sets both of them, with two arguments the first is ranged cooldown and the second is melee cooldown
adds tendrils from lavaland to the bottom of ice moon with the other megafauna
updates config entry default value for ice moon updates ice moon map to have new gulag
removes extra lavaland ported ruins updates to demonic frost miner adds ladder to icemoon map near station
plant flora dont spawn on the lower z level of ice moon now you get sand from mining rocks now buncha demonic frost miner changes holy cow
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@tralezab it was also easier to make a new fork instead of waiting on github to fix the old ones, but that has now also backfired. So I'd rather wait on github support to do their thing or have it be fixed by maintainers |
|
no merges, only sorrows. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
ok so i have a branch on my tgstation-1 fork, how do i get those changes to the current fork? |
|
Please consider this a friendly warning, your PR's must have a properly descriptive title and body content that explains the purpose of the PR. Your current title and or body content does not meet requirements, so please update it. |
Whoneedspacee
changed the title
|
are we sure that this one needs review |
|
Why box tho |
because people prefer staying outside boxstation |
|
icebox? more like beatbox @Shadowflame909 psst, it's your cue |
|
what? Good PR Hoping bubblegum gets replaced with a Yeti themed variant/10 |
|
Sounds better than Box. |
nah, beatbox is just a box station with our changes |
tgstation-server
added
the
Merge Conflict
optimumtact
added
the
RED LABEL
tgstation-server
removed
the
Merge Conflict
tgstation-server
added a commit
that referenced
this pull request
May 22, 2020
GoryMoon
pushed a commit
to Ravenholdt/hdstation
that referenced
this pull request
Oct 25, 2020
* there was an attempt * adds ice moon map adds config options for choosing mining maps areas now have options that affect random generation on them weather now has an option to not target indoor areas adds base for icemoon ruins turns many 1's into booleans adds ice chasms adds ztraits for weather stuff * fixes up ice ruins to be ice moon compatible adds lower z level to the ice moon mine ice chasms now have a smoothed icon megafauna only spawn in the underground portion of ice moon now * openspace fixes * adds new areas and underground specific ruins * Adds the abandoned village ruin for Ice Moon * adds abandoned village ruin and fixes some area and tile stuff to work with ice moon * random mining maps are no longer picked in the config you can no longer change the mining map before setup is complete * adds above and below ground ruin as a test * adds debug functionality for ice moon ruins fixes a bug where multiz was impossible unless there were shared areas because of whitelisted areas adds multiple whitelist areas for ruin placement in a list all underground areas are now outdoors underground plasma lava rivers are now only spawned in unexplored areas so ruins don't get destroyed by them * adds unique spawners to icemoon to replace tendrils adds 2 new mobs to icemoon the polar bear and wolf adds a clothing flag for shoes that dont slip on ice modifies mining site to be ready except for the boss adds the ability for tunnel width to be a specification, ice moon can have 1 tile wide tunnels and rarely 2 wide tunnels adds a no caves mineral for ice moon ruins * wolves no longer run into lava or chasms bears now enrage sooner bear spawners can now actually be created adds base for ice moon atmospherics adds base for a new boss and achievements / score really bad coder icon for ice boots added * ice moon now has it's own planetary atmos! (thank god) * new frost miner stuff megafauna recovery time can now be tailored to have different cooldowns to ranged or melee attacks by default sets both of them, with two arguments the first is ranged cooldown and the second is melee cooldown * converts a bunch of lavaland maps to be compatible with ice moon adds tendrils from lavaland to the bottom of ice moon with the other megafauna * updates mob drops for ice moon mobs updates config entry default value for ice moon updates ice moon map to have new gulag * updates station parallax for icemoon removes extra lavaland ported ruins updates to demonic frost miner adds ladder to icemoon map near station * updates ice moon map to have the ladder inside the mining base plant flora dont spawn on the lower z level of ice moon now you get sand from mining rocks now buncha demonic frost miner changes holy cow * adds the buried library * improves map, fixes comment * make this crap work with the station cause i have to lol it is pretty cool though and now i understand the mapping crap better * updates ice ruin blacklist * ice moon stop being too cold thanks icebox changes, now actually has its own z level that can spawn ruins and such instead of just being openspace tunnel width is now not stupid * fixes a demonic frost miner bug where orbs werent exploding after death atmosphere temp is now correct fixes library ruin for icemoon polar bear range is now fixed, only aggros in a short range and follows further than 3 tiles reverts necropolis chest change * Adds a new ruin: bathouse, barebones edition * adds many new ruins fixes a bug with tunnel creation that caused it to enter no tunnel allowed areas finishes the frost miner and adds loot to him you can now force a wabbajack option * main z level now always has gravity for ice box * hopefully the hot springs arent the buggiest thing in the world anymore protects areas near the station from having openspace * icebox takes less players fixes the ladder positioning on every icemoon map * snowstorms now only occur on the station level fixes some issues with the icebox z level having openspace over the lower level mining base * Update code/datums/map_config.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/datums/ruins/lavaland.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/game/objects/structures/lavaland/necropolis_tendril.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/game/turfs/closed/minerals.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/game/turfs/open/chasm.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/game/turfs/open/floor/plating/asteroid.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/modules/mob/living/simple_animal/hostile/megafauna/demonic_frost_miner.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/modules/mob/living/simple_animal/hostile/megafauna/megafauna.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/modules/mob/living/simple_animal/hostile/mining_mobs/polarbear.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/modules/mob/living/simple_animal/hostile/mining_mobs/wolf.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * Update code/modules/ruins/icemoonruin_code/hotsprings.dm Co-Authored-By: spookydonut <github@spooksoftware.com> * fixes areas on the lust ruin polar bears now drop a goliath plate equivalent wolfs now drop a watcher sinew equivalent adds snow legions adds a crusher trophy for the demonic frost miner that prevents movement fixes a bug with asteroid mobs where the aggro icon would never show adds ice to the snow cave tunnel generation * starts work on the wendigo megafauna * replaces snowball machine gun with more miner useful content adds gentle var for knockback to prevent stunning on hit polar bears move slower now new icon for phase 2 demonic miner now * fixes lust ruin areas fixes whitespace fixes nesting issues adds underground specific mobs * name / location fixes demonic frost miner doesnt stun on knockback now ice demons move faster * fixes icebox having the wrong baseturf * adds achievement defines to the wendigo snowstorm for the lower z level again adds a new helper for ranged target turfs theres now a specific subtype for rivers fixes a bug where ice and spawners spawned with rocks and other flora on top of them adds indestructible ice rock turf fixes a bug with ice demons teleport distance being incorrect adds the start of wendigos attacks * Apply suggestions from code review Co-Authored-By: Rohesie <rohesie@gmail.com> * Update code/modules/mapping/ruins.dm Co-Authored-By: Rohesie <rohesie@gmail.com> * Fixes a dumb bug with ruins from a webedit review The syndicate shuttle can now land on mineral turfs * the final commit, all that im going to change after this is documentation for procs lol makes both ice moon z levels below the station underground, and makes it so they generate rivers of their baseturf * adds nice animation to wendigo scream * small fixes * finishes autodoccing everything i could find * ok im done for real now * adds anywhere ruins does review stuff * review stuff * ok it removes the stuff now * fix removal * fixes from the git * adds surroundings to the asteroid and lavaland sites adds butchering gloves to wrath ruins the lower icebox levels are no longer station levels fixes capitals on blood drunk and frost miner boss medals adds engineering outpost ruin by trollbreeder adds boxstation job changes to icebox polar bear transformation no longer has immunity to lavaland mobs fixes ice whelp spelling mistake * fixes engi outpost atmospherics fixes missing plating on solar panels changes slowdown for icemoon turfs * fixes ruins areas so tunnels can spawn into some of them adds lights to icebox below area openspace turfs mine the thing below them now * fixes wall boundings on asteroid and lavaland domes * ur lame armhulen * adds public mining area to icebox adds computer vendors to icebox * minor fixes * fixes map type error * removes slowdown entirely increases ore chances fixes openspace on main map fixes a ton of active turfs at roundstart modifies demonic frost miner loot to be cooler and more useful since the boss was hardly killed during tests tunnels are wider underground now openspace now deletes itself if it spawns above a ruin * improve da ruins * tries to fix multiple atmos issues with ruins removes bz from the planetary atmos since it could cause unstoppable chain reactions which would cause massive lag demonic frost miner drill now automatically scans everywhere around you fixes tunnel generation issue makes it so randomly generated turfs inherit their no_ruins flags Co-authored-by: Jonathan Church <jchurch093@gmail.com> Co-authored-by: s <wesoda24@gmail.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: Rohesie <rohesie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Video: https://www.youtube.com/watch?v=kX-mH4k8b6k&t=
Thanks to @wesoda25 and @KomradeSpectre and @trollbreeder for making ruins for ice moon
Adds some cool cthulhu sprites by @jegub for a possible future megafauna.
Adds icebox, it's boxstation on top of the ice moon mine, lavaland and space ruins don't spawn on this map. There are 3 z levels, the top level with the station and some ruins and mobs, the middle level with some ruins, and the bottom level with megafauna and more dangerous ruins. No need for a gravity generator. Bombcap multiplier does not work on the station level because bluespace blah blah blah.
Icemoon has it's own unique atmos quite like lavaland, you need a winter coat, explorer suit, equal or better to withstand the cold temperature. It has a couple unique mobs and spawners for them with polar bears and wolfs, wolfs run away at low health and polar bears attack faster. There are also now snow legions for ice moon.
Refactors some parts of the weather system, adds ZTRAIT booleans for specific weather rather than targeting areas like the mining ZTRAIT, allowing for more fine control. You can now also make weather target outdoor areas automatically, making weather much easier to setup for a zlevel so you don't have to specify every area it targets.
Refactors many parts of the tunnel generation system for lavaland, you can now have areas specify whether tunnels, flora, mobs, or megafauna can be allowed in them. This makes it much easier to map in ruins and make sure generation won't mess with them. Also fixes a bug where tunnels were checking areas around the object creating the tunnel and not the front of the tunnel, which let tunnels move through areas it shouldn't have. You can also have a variable tunnel width if you desire now.
Rocks can now be mined for volcanic ash which can allow for glass creation on places that don't have basalt or sand turf.
Refactors a part of ruin spawning which allows for ruins to be placed in multiple areas. This makes multi-z ruin spawning much more possible since before you needed the top and bottom z levels to have the same area.
The wabbajack proc has an argument to specify the type of transformation now, (transform into a human, not a xenomorph, etc)
Fixes a bug where asteroid mobs never showed their aggro icon state.
Syndicate shuttle can now land on mineral turfs.
Adds minetype "none" so some stations can have their own custom minetype on the map json itself and not have errors logged.
Adds new blood drunk miner type that can be spawned from destroyed nether portals.
Adds anywhere ruins which are ruins that can be placed anywhere without messing with atmosphere and other things (generally ruins with turf passover everywhere, maybe some ruins could be converted to this if not already).
Nuclear Operative lockers now spawn with a diamond drill so they can drill through mineral turfs, especially needed for if they fall off the top z level.
Blobs can no longer place their starting core on a no blob allowed area, they already couldn't swap their core to such a position so it makes sense that they shouldn't be able to place themselves on it by default.
Why It's Good For The Game
It's pretty much a normal station except with a few turns that I think might make the game more interesting. There's planetary atmosphere so there's the potential for gas mining that is less feasible on the station. Power is going to be more of a concern since the supermatter can't automagically super cool everything with space, though using freezers for cooling is still an option if you want a normal SM setup, solars and the TEG might be more viable options.
The potential for multi-z exploration is interesting though I'm sure there will be some issues there because... it's multi-z. Chucking people down z-levels instead of into space will also be hilarious (and possibly more dangerous).
Overall I'm not really sure how it will go, but hey it's a votable map so if people don't like it the statistics will speak for themselves, at the very least something interesting for a bit or for admin events.
Changelog
🆑
add: Icebox Station has been added, explore the depths of the Ice Moon with boxstation right on top of it, don't forget your coat and internals!
add: You can now mine rock flora into volcanic ash to make glass.
/:cl: