Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal ghosts when the round ends #51572

Merged
merged 3 commits into from Jun 12, 2020
Merged

Conversation

Mothblocks
Copy link
Member

About The Pull Request

When the round ends, ghosts will now be revealed to the alive players.

Why It's Good For The Game

It sounds fun to me to see who the ghosts were all orbiting when the round ends without having to ghost myself and not take part in the end round grief.

Changelog

馃啈
add: Ghosts will now be revealed when the round is over.
/:cl:

@tgstation-server tgstation-server added the Feature Exposes new bugs in interesting ways label Jun 11, 2020
@Pumpkinoe
Copy link
Contributor

will you be able to hear the ghosts roundend or will they still be mute to the "living"

code/__HELPERS/roundend.dm Outdated Show resolved Hide resolved
@Mothblocks
Copy link
Member Author

Mothblocks commented Jun 11, 2020

@Pumpkinoe They'd still be mute, but I can fix that since it fits the spirit of the PR.

Co-authored-by: MrDoomBringer <emmanuelssr@gmail.com>
@Fox-McCloud
Copy link
Contributor

the spirit of the PR.

I see what you did.

@Mothblocks
Copy link
Member Author

Done!

@Fikou
Copy link
Member

Fikou commented Jun 11, 2020

it makes clicking at people harder

@Mothblocks
Copy link
Member Author

What makes you say that? Does clicking on a ghost as an alive person target the ghost and not just pass through it?

@MrDoomBringer
Copy link
Contributor

@Jared-Fogle Yes, but this is at the end of the round so it absolutely doesn't matter

@Tharcoonvagh
Copy link
Contributor

why hasn't anyone thought of this

@kriskog
Copy link
Contributor

kriskog commented Jun 12, 2020

This might be annoying, but lets give it a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants