Fixes #53290, puddles are now infinite again. #53311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
Fix
ghost
reviewed
Aug 29, 2020
ghost
reviewed
Aug 29, 2020
ghost
reviewed
Aug 29, 2020
ghost
reviewed
Aug 29, 2020
ghost
reviewed
Aug 29, 2020
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
Co-authored-by: Qustinnus <Floydje123@hotmail.com>
ghost
reviewed
Aug 29, 2020
As per Qustinnus' review
ghost
reviewed
Aug 29, 2020
|
Thanks a ton for your help Qustinnus! |
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Rohesie
reviewed
Sep 1, 2020
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
tgstation-server
added a commit
that referenced
this pull request
Sep 1, 2020
goober3
added a commit
to goober3/hi-github-portside
that referenced
this pull request
Jul 28, 2023
Tsar-Salat
added a commit
to Tsar-Salat/BeeStation-Salatland
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #53290
A code oversight of #52865 that also applied plumbing changes to puddles.
Avoided snow flaking by creating a new object type called water_source. Can be used in the future instead of the sink type.
Babies first PR
Why It's Good For The Game
Ashwalkers no longer have to wait for puddles to refill like station sinks.
Changelog
🆑
fix: Puddles are now infinite sources of water again.
/:cl: