Waterworks Port & Water Tweaks #2205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this includes an elusive fuel_high sprite as well. i'm not quite sure which PR that came from
this probably doesn't break anything
github-actions
bot
added
Sprites
Bjarl
reviewed
Jul 28, 2023
will add more / tweak later
…b-portside into revelation-21-6
github-actions
bot
added
the
Map Change
|
i'll finish the rest of this tomorrow. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
tmtmtl30
requested changes
Aug 4, 2023
| soundloop = new(list(src), FALSE) | ||
|
|
||
| AddComponent(/datum/component/plumbing/simple_demand) |
There was a problem hiding this comment.
I'm not a big fan of the plumbing integration, as discussed. It doesn't fit very well on shiptest. The other changes are fine; if they're isolated I think the PR will be fine.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
Merge Conflict
|
may perhaps potentially redo this in another form!! without plumbing. we'll see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
ports tgstation/tgstation#52865 (barring plumbing-enabled hydroponics)
and associated tweaks & fixes
tgstation/tgstation#53279
tgstation/tgstation#53377
tgstation/tgstation#54236
tgstation/tgstation#55895
tgstation/tgstation#53311
water can now be scooped from water tiles again (this was commented out in #1900)
water scooped from unpotable sources must be treated via boiling to become safe to drink.
Why It's Good For The Game
punished for his sins.
Changelog
🆑 ArcaneMusic, TemporalOroboros, Jack7D1, ported by goober3
add: sinks & showers are now compatible with plumbing, and have an internal water supply.
add: metal sheets can be used on reagent tanks to convert them into a plumbing-enabled tank.
add: water recyclers are now used to construct sinks & showers. print them at an autolathe.
fix: water can be sourced from water tiles again.
tweak: water from unpotable sources must be treated via boiling to become safe to drink.
/:cl: