Makes locking movement a hotkey

[ghost]

🆑 Qustinnus
code: Moves locking movement from being a hardcoded thing to being a customizable hotkey. The default for this is now Alt, moving movement toggle to C
/:cl:

still need to look into a bug that existed before this PR that causes the key to be let go even though you were holding it.

this pr was made in response to some of the comments in #53755

Fixes #50216

[Rohesie]

Fixes #50216
(Actually it doesn't yet, but you could get that fixed without much effort)

[ghost]

it does fix that, unless I misunderstood the issues.

[Rohesie]

If you hold ctrl while running, to click something, you'll stop where you are.
This does not seem to fix that.

Edit: I can't read. Disregard my comment. It does fix it.

Out of date review

[Tharcoonvagh]

Dont make it alt, its used to see the contents of a tile, I suggest changing it to something like pause, since locking movement is a niche thing that not many people use or know about imo

[Rohesie]

Dont make it alt, its used to see the contents of a tile, I suggest changing it to something like pause, since locking movement is a niche thing that not many people use or know about imo

You can rebind it to something else if you want.
Alt makes sense, if you want to see the contents of a tile in general you'll stop moving as well.

[ghost]

what roh said was my thought process, noone runs and checks a tile

[Tharcoonvagh]

Okay then, when I tried to bind stuff to alt and ctrl it refused to work, guess ill try again

[ATH1909]

what roh said was my thought process, noone runs and checks a tile

No, but they do run and alt+click an extinguisher to extinguisher slip people or run and alt+click a door to shock it as a silicon.

Still, THANK YOU for this PR, it'll be a GODSEND for diehard borg mains. I'm just worried that, due to the key that you chose to move it to, it's gonna be quite annoying for anyone who HASN'T reconfigured their hotkeys yet. Could you maybe assign movement locking to "c" and keep the temporary movement mode change hotkey where it currently is (alt)?

[ATH1909]

Wait, why have you kept the FaceNorth, FaceSouth, etc. hotkeys around? Aren't they now entirely redundant with this new movement locking hotkey?

[ATH1909]

Also, isn't there some weird stuff you have to do whenever you update the preferences menus? Like, you have to update a version or something? I ran into that with my PR that added extra quickdraw hotkeys.

[Rohesie]

Also, isn't there some weird stuff you have to do whenever you update the preferences menus? Like, you have to update a version or something? I ran into that with my PR that added extra quickdraw hotkeys.

No, they are just not updated automatically. Which means the users will have to either assign them manually or reset to hotkey mode if they don't have custom changes.

[Angustmeta]

Tested this now.

The 'turn north' etc bindings cause problems.

To bind 'block movement' to other keys than ctrl/alt/shift you must bind the "turn" keys to WASD, but that makes you turn oddly while walking diagonally.

[Rohesie]

The 'turn north' etc bindings cause problems.

To bind 'block movement' to other keys than ctrl/alt/shift you must bind the "turn" keys to WASD, but that makes you turn oddly while walking diagonally.

Could you expand on this / clarify?
What happens if you bind blocking movement to something like space? Do you still move?
Why do you need to bind facing to WASD to bind blocking movement to keys other than ctrl/alt/shift?

[ATH1909]

Tested this now.

The 'turn north' etc bindings cause problems.

To bind 'block movement' to other keys than ctrl/alt/shift you must bind the "turn" keys to WASD, but that makes you turn oddly while walking diagonally.

I've binded "block movement" to u (and then c) with no issues. Could you show us a video or something?