Rips out the old keybind system and ports a better version from /tg/

[ThatLing]

Document the changes in your pull request

At the start of the last rebase, I made a shitty keybind system that allowed you to rebind actions. 4 years later, it's about time to upgrade it.

This PR completely removes the old system and ports the new version used by /tg/. It adds more actions and a better way to assign keys.

I tested each keybind to ensure it works correctly, however there might be some issues still. Since it's such a big change, I decided not to convert existing keybinds to the new system. As such, people will need to re-assign their keys.

List of ports below, full credits to the original authors

• Port Custom hotkeys from TGMC tgstation/tgstation#47003
• Custom movement hotkeys and restore macros for T, O and M tgstation/tgstation#47626
• ports TGMCs click hack for non-hotkey players ports classic keybinds from TGMC tgstation/tgstation#47670
• Makes every emote keybindable tgstation/tgstation#47750
• keybindings save file fix tgstation/tgstation#47804
• Keybindable emotes followup tgstation/tgstation#47868
• Keybinding update fix tgstation/tgstation#48316
• Adds basic sanity to keybindings. tgstation/tgstation#49116
• Fixes keybind keyUp() not checking for can_use() tgstation/tgstation#52475
• Adds a keybind for resting tgstation/tgstation#53709
• Makes locking movement a hotkey tgstation/tgstation#53771
• Refactors the keys_held rolling buffer tgstation/tgstation#53773
• remove obsolete face-dir keybinds tgstation/tgstation#53925
• Rebindable communication(OOC, Say, Me) tgstation/tgstation#54035
• Makes every emote keybindable tgstation/tgstation#47750

Wiki Documentation

No clue if there is documentation on the wiki, but this system should work largely similar

Changelog

🆑
rscadd: Added a new keybind system, your old keybinds have been reset
rscadd: You can now bind a key to a specific emote
/:cl:

[RG4ORDR]

Flip bound to scroll wheel.

[ThatLing]

Flip bound to scroll wheel.

There's a cooldown, and if people abuse it I will just remove the emote keybinds

[Hopekz]

Epic

[Hopekz]

Flip bound to scroll wheel.

There's a cooldown, and if people abuse it I will just remove the emote keybinds

What's wrong with flipping fast?

[ToasterBiome]

we should not have bindable emotes

[ThatLing]

Why not?

[ToasterBiome]

Why not?

flip and spin spam is annoying

[Hopekz]

Why not?

flip and spin spam is annoying

Why not fix it with a different solution like " Flipping too quick gives a chance to knock you on your ass" or " spinning too fast makes your character dizzy"

Why do you think putting more user friendly features in the game like being able to bind things to a hotkey is the issue in this case?

[neeshacark]

id rather we not add macros, ive caught and banned or had banned a surprising amount of people using external clients that allow similar effects like flipping a bunch while moving (including one literal hours ago). these clients also come with exploits like aimbot that are much harder to find and prove.

if for some reason it must be added, at minimum logging so admins can see peoples macros and a max amount/cooldown of macro emotes that doesn't prevent spamming non-macro flips so I can still use this to weed out hacking griefers would be crucial.

[burn1cycle]

Game's broken #17646