Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation for stamps and some other stuff for paper #55028

Merged
merged 8 commits into from
Nov 20, 2020

Conversation

ThePotato97
Copy link
Contributor

@ThePotato97 ThePotato97 commented Nov 18, 2020

About The Pull Request

Attaches the event listeners to the document to make it smoother.

Fixed background color "white" being gray by making bg-lightness 25% in the paper theme.

Corrected multiple spelling mistakes.

Added stamp rotating while holding shift (faces where the cursor is)

Chat now says
"You stamp the paper with the clown's rubber stamp!"
rather than
"You stamp the paper with paper121x54 stamp-clown!"

Why It's Good For The Game

make paper stamping betterer

Changelog

🆑
refactor: Rotating stamps on paper by holding shift and moving your mouse.
fix: Fixed chat message for stamping paper.
/:cl:

@tgstation-server tgstation-server added Feature Exposes new bugs in interesting ways Fix Rewrites a bug so it appears in different circumstances UI We make the game less playable, but with round edges labels Nov 18, 2020
@Cyberboss
Copy link
Member

#54733

@Cyberboss Cyberboss closed this Nov 18, 2020
@stylemistake
Copy link
Member

stylemistake commented Nov 18, 2020

I disagree because:

  • It's an enablement of a previously broken feature which used a non-functioning scroll wheel to rotate the stamps, so it's a fix;
  • Contains decent refactoring;
  • Makes paper stamps actually usable.

@stylemistake stylemistake reopened this Nov 18, 2020
@stylemistake stylemistake removed the Feature Exposes new bugs in interesting ways label Nov 18, 2020
@tgstation-server tgstation-server added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2020
@tgstation-server tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2020
stylemistake
stylemistake previously approved these changes Nov 19, 2020
@stylemistake
Copy link
Member

Still needs a rebuild.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances UI We make the game less playable, but with round edges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants