Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Re-PR HoP Expansion Pack #829

Closed
wants to merge 1 commit into from

Conversation

SinguloMirrorbot
Copy link
Collaborator

Original PR: BeeStation/BeeStation-Hornet#8821

Re-PR of #8113

This PR was near perfect, it just needed a merge conflict fix and some more reviews. My review on it was basically complete, it turns out %s signing works fine in fields, so that's good. I've fixed the merge conflict and Re-PR'd it as is. I think it's good to merge now, we've testmerged it and it worked well. I would like to see better blanks and it seems there is a bit of community interest as I've seen some threads with them, so we can implement those via config change later.

About The Pull Request

Updates the Paperwork Module to the current version used by TG
This is accomplished by porting the Following PRs from TGstation

Issues

  • Stamp indicator can鈥檛 be moved around in the paper ui.
    • Stamp indicator can be rotated around by holding the Shift key and moving the mouse around, however it still fails to follow the mouse around when you move it while not holding the shift key.
    • For some reason stamping the paper puts the stamp at the very bottom of the paper in what seems to be a new box or section rather than in the top left corner where the stamp indicator is stuck.
  • Linters issues.
    • Linters bypassed for that one line that was causing an error, the code still functions ingame perfectly fine.

Why It's Good For The Game

A more up to date version of the Paperwork Module, allows people to see the result of what they're entering on a paper, fax machines to annoy admins with and other fun stuff!

Testing Photographs and Procedure

Screenshots&Videos

image

2022-11-30.08-55-23.mp4

Changelog

馃啈 Bobbanz1, Timberpoes, SteelSlayer, twilightwanderer, ShizCalev, timothymtorres, Imaginos16, dragomagol, Jacquerel, Mothblocks, ThePotato97, LemonInTheDark
del: Removed the ability to scan paper directly into the modular computer notes app as part of paper code rewrite.
qol: AIs now see the full paper interface when players show them papers through the camera, exactly what's written on the paper, fully rendered.
refactor: Paper code has been completely refactored.
fix: Fixes signatures not working at all. Signatures now only work when %s or %sign is put into an [___] input field.
fix: Input fields are now fixed and also work again.
fix: Fixes broken command report formatting for station goals.
fix: Fixes markdown paragraphing not working in paper code.
refactor: Photocopiers now use TGUI
tweak: You can insert any type of toner cartridge into photocopiers, and regardless of the currently inserted toner's charge level.
tweak: Toner cartridges can be ejected from photocopiers at any time
add: Added a system of forms and the ability to print them
fix: Hints in bureaucracy forms
add: Added new VOID stamp
fix: Photocopier paperforms
add: Fax Machine
fix: Fixes faxes playing the "fax_contain" animation and makes it actually use the "fax_receive" animation when receiving.
imageadd: Resprites fax machines!
admin: fax messages and book printings are now logged in paper.log
admin: renaming fax machines is logged in game log
add: You can now send photos or trading cards through the fax machine.
add: You can now hack the wires of a fax machine to have it throw items harder or accept additional flat input items such as material sheets, ID cards, and pizza slices.
add: Ability to send and receive administrator fax messages.
admin: Panel for easy viewing and sending messages to faxes.
fix: Fixes a crash of TGUI fax panel when there is no fax in the network
fix: Fixes a crash of the Fax Manager panel when there is no fax machines in the network.
refactor: Rotating stamps on paper by holding shift and moving your mouse.
fix: You can no longer remove the toner cartridge from a printer while it's busy printing.
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants