Reorder the list of items in more outfits. #57801

GuillaumePrata · 2021-03-18T13:53:06Z

About The Pull Request

On my quest to make outfits easier to read and fix some small mistakes by applying a priority order.

ID > uniform > suit > backpack > other clothing in alphabetic order > pockets > hands > others

Moved the base/assistant plasmaman outfit from the middle of the standard file to the top of the plasmaman outfit file.
Reorganized the plasmaman outfit order to have jobs within a department close to each other.
Moved the Death Commando outfit into the ERT file together with a line that adds mindshields to CentCom outfits because I had to dig to find that a long time ago...

Also fixes detective plasmaman spawning with a worse headset and plasmamen prisoners spawning with a different shoe.
Like... how no one has seen that plasmaman spawn with the wrong headset? Do we have no plasmaman sec? Yes I know the answer...

Why It's Good For The Game

Easier code to read, easier to find mistakes

Not being flashbanged by your fellow security members as a detective is pretty neat too!

Changelog

🆑 Guillaume Prata
fix: After investigation. NT found out that Plasmaman detectives were being supplied with "non-Bangproof" headsets to decrease expenses because "The bonehead's helmet protects their bone ears anyway." This misunderstanding on how the helmets work has been clarified and the Quartermaster involved was promptly fired.
/:cl:

1 line fixed...

More 1 line fixes...

Why I keep missing 1 lines mistakes aaaah...

github-actions · 2021-03-18T13:53:33Z

You currently have a negative Fix/Feature pull request delta of -3. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

Merge moment

ArcaneMusic · 2021-03-18T15:56:54Z

I appreciate you going through and doing that, could you throw your expected order of items on here into a comment? If it's not listed somewhere in the code, It'll just get tossed around again if/when new things are added.

GuillaumePrata · 2021-03-18T17:28:23Z

I also changed the order of the items on /code/datums/outfit.dm and have been following that as the base of it.

It is this big list here:

/datum/outfit
	name = "Naked"

	id = null
	id_trim = null
	uniform = null
	suit = null
	suit_store = null
	back = null
	list/backpack_contents = null
	belt = null
	ears = null
	glasses = null
	gloves = null
	head = null
	mask = null
	neck = null
	shoes = null
	l_pocket = null
	r_pocket = null
	l_hand = null
	r_hand = null
	
	accessory = null
	box
	list/chameleon_extras
	list/implants = null
	internals_slot = null
	list/skillchips = null
	toggle_helmet = TRUE
	datum/sprite_accessory/undershirt = null

Look, more things I missed earlier...

More... missed... things...

= 6, >=6,

I shouldn't organize things while sleepy, but hey, FIXED!

Removes the eng medkit

@Timberpoes

* Updating GBP from PR tgstation#57626 [ci skip] * Simple bots now use a different snowflake method for all access. (tgstation#57861) * Automatic changelog generation for PR tgstation#57861 [ci skip] * Updating GBP from PR tgstation#57861 [ci skip] * Automatic changelog compile [ci skip] * Defines the interrogation room as unique area and not 4 different var edits. (tgstation#57612) * Defines the interrogation room as unique area and not 4 different var-edits * Fixes the gaping hole in the wall * We added a new map at the very end. * Blaseball * Committing the changes * Rebuilds the deltastation setup in case it's actually breaking something... * Automatic changelog generation for PR tgstation#57612 [ci skip] * Updating GBP from PR tgstation#57612 [ci skip] * Bump pillow from 7.2.0 to 8.1.1 in /tools (tgstation#57906) Bumps [pillow](https://github.com/python-pillow/Pillow) from 7.2.0 to 8.1.1. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/master/CHANGES.rst) - [Commits](python-pillow/Pillow@7.2.0...8.1.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Adds right-click support to AIs/Cyborgs (tgstation#57881) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57881 [ci skip] * Updating GBP from PR tgstation#57881 [ci skip] * Ice cream revamp: Ice cream is a component and cones can hold multiple servings of ice cream now. (tgstation#57415) * Ice cream rework WIP * I'm done! * i'll deal with my verbose engrish at a later date. I'm dead tired. * linter aaaaaa * Take a bite! * FINALLY, A COMPONENT! * ghost macro. * Review, typos, beheading of a lame comsig. * Typo. Now I'm self-obliged to test it again. * It works. * Automatic changelog generation for PR tgstation#57415 [ci skip] * Updating GBP from PR tgstation#57415 [ci skip] * i shot my own phazon to death and i cry. (tgstation#57772) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR tgstation#57772 [ci skip] * Updating GBP from PR tgstation#57772 [ci skip] * Fixes admin immovable rods not hitting things (tgstation#57890) Timber did an oopsie in tgstation#57850 and made it so rods with a specific target (AKA any spawned by admins either through the trigger event button or the admin smite) quit out of their creation before they started listening for clonging things. Possibly this was partly intended, in case you wanted to spawn a rod that would only hit whatever you designated as your target and nothing else, but this current setup doesn't hit the target either soo something needs fixing. @Timberpoes let me know what you think and if you were intending for a soft rod option that would only hit the target. Fixes: tgstation#57888 * Automatic changelog generation for PR tgstation#57890 [ci skip] * Updating GBP from PR tgstation#57890 [ci skip] * Ghosts can now interact with the crew monitor console. (tgstation#57891) * Automatic changelog generation for PR tgstation#57891 [ci skip] * Updating GBP from PR tgstation#57891 [ci skip] * Fixes unbalanced flyperson leg (tgstation#57892) One of Flypeople's legs while facing up is missing a single pixel, causing it all to be unbalanced, this fixes that. * Automatic changelog generation for PR tgstation#57892 [ci skip] * Updating GBP from PR tgstation#57892 [ci skip] * undefined variable wtf *Dies of cringe* * tgui: ESLint and VSCode settings improvements (tgstation#57905) Added column 80 rulers to all javascript and scss files. Added a "prettier" config to have sensible defaults for those who prefer to use it. Added RadarJS (fork of SonarQube's SonarJS). Launchable only via bin/tgui --lint-harder for now. Disabled ESLint rule for parens around arrow function arguments, because in TypeScript they're pretty much always required, and I don't want to replace it throughout the codebase. Removed unused javascript extensions from tooling (jsx, mjs). * Automatic changelog compile [ci skip] * Fixing the undoable experisci arcade experiment. (tgstation#57898) * Automatic changelog generation for PR tgstation#57898 [ci skip] * Updating GBP from PR tgstation#57898 [ci skip] * [s] Fixing an infinite loop exception with Move() (tgstation#57895) * Replaces use of handle_atom_del() with Exited() in modular computer hardware. And fixes an issue. (tgstation#57387) Title. The issue being hardware/on_remove() calling /try_eject() even if the holder is being destroyed, which is quirky. I also replaced an instance of /New() with /Initialize() and deleted a troublesome /Destroy(). handle_atom_del() is awful. Nearly every (minus the storage component; it's a tangled trial of mental gymnastic) behavior implemented there can pretty much be moved to Exited() and it'll work just as fine, if not better against edge cases such as recall spells. But that's not the scope of this PR. I'm here to fix tgstation#57161. * Automatic changelog generation for PR tgstation#57387 [ci skip] * Updating GBP from PR tgstation#57387 [ci skip] * Highlander + Summon Guns and Magic now uses signals to equip new crewmembers (tgstation#57817) * Automatic changelog generation for PR tgstation#57817 [ci skip] * Updating GBP from PR tgstation#57817 [ci skip] * makes holodeck books a holo_effect so they get added to the spawned list (tgstation#57909) * Automatic changelog generation for PR tgstation#57909 [ci skip] * Updating GBP from PR tgstation#57909 [ci skip] * Dogs no longer take whatever they're holding/wearing to the grave (tgstation#57670) * Automatic changelog generation for PR tgstation#57670 [ci skip] * Updating GBP from PR tgstation#57670 [ci skip] * Turns off cache on docker publish action (tgstation#57912) Maybe it will stop it screaming in pain about missing dependencies. Publish action suggests alternative of running this as cronjob to update cached version so if this works but is too slow we can change to that. * Adds a plumbing layer manifold (tgstation#57494) Adds a multilayer plumbing manifold, I also murdered the multilayer duct You can now alt-click the plumbing RCD to change the layer it prints. I made a whole thing where right clicking changed the settings and you could use that to change machinery aswell. I even did that with the plunger, it was absolutely beautiful. Anyway that drained the life out of me because apparently there's no attack_obj_secondary and afterattack_secondary ALSO called attack_obj (left click). I just hate whoever made it with intensity Plumbing now uses three layers. They should be easier to navigate. I tried to make layer connecting the same as cross-color connecting, but that would take more of my soul then there is to take * Automatic changelog generation for PR tgstation#57494 [ci skip] * Updating GBP from PR tgstation#57494 [ci skip] * Makes stations more airtight (tgstation#57535) I've gone through delta, meta, and icebox and added some choice windoors, changed some areas around, added some more doors, and changed some other miscellaneous things. I'll list the full changes in drop downs, for both our sakes Delta: <details> Splits the central hallway into fore and aft central hallways Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Adds medbay access locked windoors to the back desk of the medbay reception area Adds airlocks to both the upper and lower parts of the main hallway </details> Meta: <details> Gives the storage wing another set of firelocks, and two fire alarms. It didn't have any alarms in the first place, so hopefully this helps things Adds the spaces that jut out of medbay and sci into the central hallway, rather then having them be a part of medbay and sci Replaces a small bit of the science area with nanite lab, to prevent a breach near xenobio causing fire alarms at the front of sci Adds a windoor in front of the ORM to block air Adds a wall behind a smart fridge in chemistry </details> Icebox: <details> Added airlocks between arrivals and the port hallway, and the escape hallway and the starboard hallway Added a windoor between the kitchen and the bar </details> ## Why It's Good For The Game Cuts delta's main hallway in half, with the goal of reducing fire alarm strain. Some thoughts on this would be nice, I don't want to make everything else that uses areas worse just because fire alarms are dumb, and I'm worried that's what I've ended up doing here. I've also added the portions of medbay/sci that jut out into the main hallway into the main hallway, I think? I could make these into lobby areas, but I'm not sure if that's appropriate or not. Adds a few windoors and airlocks to better section off portions of the station, this should reduce the amount of mass gas spreading that can occur. My goal here is to reduce the amount of uninteresting gas movement and make firelocks less hellish when there's a breach * Automatic changelog generation for PR tgstation#57535 [ci skip] * Updating GBP from PR tgstation#57535 [ci skip] * Move a signal that is randomly seperated from others of it's kind (tgstation#57914) Co-authored-by: actioninja <actioninja@criticalaction.net> * Fix plant trash from grown food not inheriting their proper seeds (tgstation#57924) This PR fixes plant trash not getting the seed from their parent. trash_type is a type path, not an instantiated object. istype always fails trying to use it on trash_type. ispath is the correct helper to use here, because it's a type path and not an object. * Automatic changelog generation for PR tgstation#57924 [ci skip] * Updating GBP from PR tgstation#57924 [ci skip] * Makes deadchat control's examine only shows up for ghosts (tgstation#57926) This PR early returns the on_examine proc for deadchat control if the examiner is not an observer. So, only ghosts (deadchat) are allowed to see if something is under deadchat control. Humans don't need to know (or shouldn't know) if deadchat is expanding its reach into the physical realm. * Automatic changelog generation for PR tgstation#57926 [ci skip] * Updating GBP from PR tgstation#57926 [ci skip] * Adds materials to PDAs (tgstation#57923) Puts a small amount of iron, glass, and plastic into a PDA 'cause that sort of material usage makes sense to me * Automatic changelog generation for PR tgstation#57923 [ci skip] * Updating GBP from PR tgstation#57923 [ci skip] * Automatic changelog compile [ci skip] * Adds sticking metallic kitchenware into APCs (tgstation#57910) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57910 [ci skip] * Updating GBP from PR tgstation#57910 [ci skip] * Bane AI (tgstation#57771) We take Gotham from the corrupt! The rich! The oppressors of generations who have kept you down with myths of opportunity, and we give it back to you...the people...Gotham is yours. None shall interfere, do as you please! * Automatic changelog generation for PR tgstation#57771 [ci skip] * Updating GBP from PR tgstation#57771 [ci skip] * Splits winter coats/hoods into their own sprite file (tgstation#57896) Moves the winter coats and their hoods into their own sprite file. 335 icons in one of the files got lowered to 289 after moving 46 wintercoat icons to their own file. Renames some icons because they had a long name. * Updating GBP from PR tgstation#57896 [ci skip] * remove double pen door from meta xeno (tgstation#57879) door double removal * Automatic changelog generation for PR tgstation#57879 [ci skip] * Updating GBP from PR tgstation#57879 [ci skip] * Resprites ventriloquist dummy (tgstation#57863) ## About The Pull Request Resprites the ventriloquist dummy #https://github.com/tgstation/tgstation/projects/6#card-2814241 ## Why It's Good For The Game The current sprite is just the assistant doll cut in half. This gives it a unique sprite and also makes it so that the hands line up with the item better than the current sprite. It's also a lot creepier (and animated!) * Automatic changelog generation for PR tgstation#57863 [ci skip] * Updating GBP from PR tgstation#57863 [ci skip] * Fixes missing pixel on envirosuits (tgstation#57849) ## About The Pull Request Adds 1 pixel to every evirosuit side sprite except the prototype. ## Why It's Good For The Game The current envirosuit sprites all have a single pixel missing on the foot, which causes the foot to be visible. This pixel is there on the prototype, but all the others are missing it. This PR adds 1 pixel to each side sprite to cover it up. * Automatic changelog generation for PR tgstation#57849 [ci skip] * Updating GBP from PR tgstation#57849 [ci skip] * Updates round tips (tgstation#57927) Deals with any mention of cloning, intents, and a few outdated mechanics * Automatic changelog generation for PR tgstation#57927 [ci skip] * Updating GBP from PR tgstation#57927 [ci skip] * Thermomachine update (tgstation#57918) This PR adds an UI button that allow the players to decide if use enviromental heat or red port pipe (it will have an error if the choice is not working for some reasons, like not having moles in the pipes/air, not having pipes connected at all, etc) This also fix the issue of having roundstart freezers heating up rooms because the waste pipe didn't have any gas * Automatic changelog generation for PR tgstation#57918 [ci skip] * Updating GBP from PR tgstation#57918 [ci skip] * Improves status bar coverage (tgstation#57916) This PR makes sure all MouseEntered() procs call their parent, which handles the status bar. This fixes instances where the status bar was missing, for example when you hovered over the ghost buttons, you would not be shown a name of the button, but completely different object, like "space", which was very misleading. This also means that the new status bar should have better parity the with the old status bar, which also showed these things. * Automatic changelog generation for PR tgstation#57916 [ci skip] * Updating GBP from PR tgstation#57916 [ci skip] * Create explicit warning if not building with CBT (tgstation#57931) Adds a new CBT define which is automatically created when building. If this define is absent, the build will fail. This is what Cyberboss tried to do with USE_BUILD_BAT_INSTEAD_OF_DREAM_MAKER.dm, but couldn't. The reasoning behind this is CBT is already a requirement to build a fresh project, otherwise the tgui bundle files won't exist. This gives a readable error to go along with that. However, you can currently build once then just use Dream Maker. This is a footgun - not only are we already adding new things to CBT like tgfont which will fail later on, but also it will create weird scenarios when we add tasks to CBT that don't immediately fail if not ran, or otherwise create out of sync builds. Also replaces rmSync with unlinkSync, which works on older Node versions. Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Additional CTF maps (tgstation#57230) This pull request adds a map loader as well as new maps to CTF. When a game starts a CTF map will be selected at random and will be playable by ghosts. As well as this new functionality CTF now fully supports 4 teams. A green and yellow team have been added complete with both standard and instagib gear. At current five maps are planned: Classic - the original map we all know and love Four Side - A four team CTF map where all teams compete over one flag Downtown - Terrestrial city themed map Limbo - Wizard themed map featuring portals and uses KOTH rather than CTF Cruiser - Space themed map utilizing the powerup system Random maps are selected on game load Support for four teams added Why It's Good For The Game CTF has been more or less the same on the surface since its creation. This PR allows for some much needed map variety which will increase replay value. CTF is far more regularly played then mafia due to its fast rounds and common use during round end delays and I believe that it deserves a boost in content. Changelog cl add: CTF can now selects a random map at game start add: CTF now supports four teams add: Gear for yellow and green CTF teams has been added add: CTF ID cards for all 4 teams have been added - courtesy of maxymax13 add: a new CTF map, Four Side has been added add: a new CTF map, Downtown has been added add: a new KOTH map, Limbo has been added add: a new CTF map, Cruiser has been added fix: KOTH capture points retain their sprites after being claimed /cl * Automatic changelog generation for PR tgstation#57230 [ci skip] * Updating GBP from PR tgstation#57230 [ci skip] * Implements Plant Biotype (tgstation#57108) Implements a plant biotype for plant based mobs. Changes the wood golem mob to be an organic, humanoid, and plant biotype---because wood is an organic substance, not a mineral. This additionally adds the ability for plantbgone/weedkiller to deal damage to plant biotypes. Why It's Good For The Game There's a curious lack of a defined plant biotype, despite plants sharing a unique number of traits. Ideally, this behavior can be more consistently implemented with something like biotypes. A minor example of this is utilized in this PR: weedkiller and plantbgone impacting plant-like mobs, which is what you'd expect. Changelog cl add: Plant-like mobs are now impacted and take damage from plant-b-gone and weedkiller reagents add: Plant-like mobs can be health scanned with a plant analyzer add: Plant-like mobs are impacted by the floral gun in the same manner pod people are /cl * Automatic changelog generation for PR tgstation#57108 [ci skip] * Updating GBP from PR tgstation#57108 [ci skip] * fix (tgstation#57900) Fix missing cable from upper atmos apc Fix wrong area in north-west corner resulting in airlock not working * Automatic changelog generation for PR tgstation#57900 [ci skip] * Updating GBP from PR tgstation#57900 [ci skip] * Add note about rust-g for building on Linux (tgstation#57622) This PR adds a minor note about needing to compile rust-g to Linux building instructions. I'm not sure if this is the appropriate place for it, but I don't see a better place to put it. * cyborg lollipop launchers can no longer spam timers (tgstation#57786) About The Pull Request Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. Why It's Good For The Game The self-deletion mechanism was apparently causing timer spam, so I reduced the amount of treats that cyborgs could spam out (and the rate of that spamming) so that the mechanism would no longer be necessary. I increased the damage of launched treats to compensate to keep the emagged treat launcher from becoming a very sad joke of a weapon. Floyd threw a fit when he learned that cyborgs could freely dispense lollipops that contained omnizine, so I replaced the omnizine with psicodine, a chem that is perhaps more appropriate for lollipops (it calms people down), doesn't do much of importance, and can't react to form any rare or interesting chems. The cookie dispenser thing is also an attempt to appease Floyd, since he doesn't like cyborgs being able to spam food everywhere. Changelog cl ATHATH balance: Cyborg treat dispensers now have a maximum treat storage capacity of 5 treats instead of 30 treats, and recharge their treats at a rate of one treat per 10 seconds instead of one treat per second. To compensate for this, the damage of gumballs and lollipops that have been launched from an emagged cyborg has been increased from 3 to 10. del: Launched gumballs and lollipops will no longer delete themselves after 2 minutes (if not equipped). balance: The 2u of omnizine in each cyborg lollipop has been replaced by 2u of psicodine. The contents of normal lollipops have not been modified. balance: Cyborg cookie dispensers can now only dispense a cookie once every 10 seconds (instead of once per second). Non-cyborg cookie dispensers no longer self-recharge, but can now accept compressed matter cartirdges for reloading purposes. Support has been added for other types of RSFs to have use cooldowns. /cl * Automatic changelog generation for PR tgstation#57786 [ci skip] * Updating GBP from PR tgstation#57786 [ci skip] * Minor tramstation and train-rail-fluff fixes (tgstation#57639) Fixes an incorrectly-shifted sprite for floor tram rails and adds some missing tram-rail fluff objects Also does some minor renaming (railing -> rail) cl fix: Nanotrasen railroad engineers have done some minor repairs to their in-station tram rails. /cl * Automatic changelog generation for PR tgstation#57639 [ci skip] * Updating GBP from PR tgstation#57639 [ci skip] * Automatic changelog compile [ci skip] * Paper bins show the paper inside them (atomised) (tgstation#57907) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57907 [ci skip] * Updating GBP from PR tgstation#57907 [ci skip] * Ref Tracking: Revengance (tgstation#57728) * Ref Tracking: Revengance Fixes reference tracking ignoring self references due to a poorly thought out tick checking system. Fixes reference tracking ignoring the contents of assoc lists Makes the reference tracking printouts actually describe what list the ref is in, rather then just saying "list" Adds REFERENCE_TRACKING_DEBUG, a define which toggles tracking info for the ref tracking procs, which allows for oversight on how the proc is working Allows for direct calls of qdel_and_find_ref_if_fail(), makes it use ref rather then REF(), fixing it breaking for mobs. (Ditto for the qdel hint which does the same thing) Moves REAGENTS_TESTING out of the reftracking define block Makes unit tests define REFERENCE_TRACKING, REFERENCE_TRACKING_DEBUG, and FIND_REF_NO_CHECK_TICK Adds a unit test that sanity checks the reference finder proc * Updating GBP from PR tgstation#57728 [ci skip] * fix (tgstation#57902) Fix missing tile under airlock above turbine in kilo station * Automatic changelog generation for PR tgstation#57902 [ci skip] * Updating GBP from PR tgstation#57902 [ci skip] * You can now put food on plates, and plate no longer materialize out of nowhere as you cook (tgstation#57770) * All plates removed. Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: DeAndre <robustness13@hotmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57770 [ci skip] * Updating GBP from PR tgstation#57770 [ci skip] * tgui strip panel + strippable element (tgstation#57889) Completely removes show_inv and replaces it with /datum/element/strippable. It takes a list of instantiated /datum/strippable_item which communicate which slots are available and how to interact with them. This element has been added to humans, alien humanoids, parrots, and corgis. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR tgstation#57889 [ci skip] * Updating GBP from PR tgstation#57889 [ci skip] * Adds explorer drones / adventures. (tgstation#57851) A new side-job for cargo. Prepare and launch exploration drones at distant sites to encounter weird adventures, collect loot and expand the station cargo network. Adventures - the main content type here, can be written by anyone without any knowledge of programming. The purpose here is creating an way of interesting way of delivering lore (and adding some new job content/cargo expansion method). Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Updating GBP from PR tgstation#57851 [ci skip] * Fermichem 2.6 - Adds the HPLC: a new roundstart method of detecting purity, as well as a method of partially purifying reagents (tgstation#57858) Adds the High-performance liquid chromatography machine - a new roundstart method of detecting purity, as well as a method of partially purifying reagents. A single machine has been added to each of the 4(5) maps - this lets people determine their purity based off the size of the green (pure portion) to the orange (impure portion) of a reagent's peak shown on the mas spectroscopy display. If a reagent is impure - it will be displayed as red. In addition to this function, the HPLC can purify reagents by selecting a range of them and pressing the purify button. This will cost some time depending on the mass of the reagent and will purify it up it's default purity (in the tweaked reagent cases - 75%, for the reagents I've yet to get to - 100%). It will also reduce the volume accordingly (so in essence you are reducing the volume of the impure parts). The sprite itself will indicate when it's running, so you don't need to be nearby it or use the UI to know when it's done * Automatic changelog generation for PR tgstation#57858 [ci skip] * Updating GBP from PR tgstation#57858 [ci skip] * Partially revert reaction chamber (tgstation#57855) * Automatic changelog generation for PR tgstation#57855 [ci skip] * Updating GBP from PR tgstation#57855 [ci skip] * Blobbernaut HUD improvements (tgstation#57922) * Automatic changelog generation for PR tgstation#57922 [ci skip] * Updating GBP from PR tgstation#57922 [ci skip] * Crops the cached ID card icon so it is less obnoxious in tgui chat. (tgstation#57935) * Automatic changelog generation for PR tgstation#57935 [ci skip] * Updating GBP from PR tgstation#57935 [ci skip] * Some minor atmos cleanup (tgstation#57933) Fixes mining not making turfs active, I forgot to add a type arg when I added one to AfterChange(). This isn't the only source of the issue, but it's the most prevalent one Cleans up total_moles_specific() slightly, there's no point iterating a list if you already have the gas id. Removes a null assignment and if check, they don't catch anything as things are now, and if someone passes null to the proc I want a runtime Oh and I reordered a bit of atmospherics.dm to make a comment make sense. Don't worry about it * Automatic changelog generation for PR tgstation#57933 [ci skip] * Updating GBP from PR tgstation#57933 [ci skip] * emissive blockers are now just an overlay (with kickass fucking graphs). FUCK YOU MAPTICK (tgstation#57934) currently emissive blockers are objects added to the vis_contents of every item. however mutable appearances as overlays can serve this role perfectly well and according to my tests should cause less maptick per item. for mobs mutable appearances dont work for reasons i dont understand so instead this adds the em_block object to overlays instead of vis_contents. these both use atom/movable/update_icon() now graphed test results in pr * Updating GBP from PR tgstation#57934 [ci skip] * Converts trait comments to doc comments (tgstation#57941) This converts the existing comments traits had `#define TRAIT_BLA "bla" // yadda yadda` to proper doc comments so that they show with SDMM and the codedocs website. People just reference old code when writing new code, and people not using doc-comments for traits is something that comes up often. * Automatic changelog compile [ci skip] * Gibs/Dead bodies no longer produce miasma (tgstation#57957) * Gibs/Dead bodies no longer produce miasma Miasma production as it is now is too little over too long a time span, and it just ends up spreading across the station and having little effect. My goal here is to remove a source of uninteresting gas from the station's air, and make corpses and gib piles more infectious. I've placed the cap on disease payout at a strength of 7, so there's a slight chance of a positive disease, but I think it's counteracted by the danger presented by just infecting yourself till you get what you want. I've rewriten the rot component to just run a percent chance to infect someone with a disease based on the type of rot, and moved almost all of its behavior to signals. There's one portion I can't rewrite without making significant changes to how I handle atmos sensitivity, so that'll come later. Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57957 [ci skip] * Updating GBP from PR tgstation#57957 [ci skip] * [Ready] Fermichem part 2.3 Adds a new reagent: Eigenstasium (tgstation#56918) Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#56918 [ci skip] * Updating GBP from PR tgstation#56918 [ci skip] * Bump pyyaml from 5.3.1 to 5.4 in /tools (tgstation#57956) Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3.1 to 5.4. - [Release notes](https://github.com/yaml/pyyaml/releases) - [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES) - [Commits](yaml/pyyaml@5.3.1...5.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Syndicate Shuttle Console cannot be deconstructed via tools (tgstation#57962) * Automatic changelog generation for PR tgstation#57962 [ci skip] * Updating GBP from PR tgstation#57962 [ci skip] * Metastation's Nanite lab RC is now named properly (tgstation#57952) * Automatic changelog generation for PR tgstation#57952 [ci skip] * Updating GBP from PR tgstation#57952 [ci skip] * Sentience fun balloon QoL (tgstation#57928) * Automatic changelog generation for PR tgstation#57928 [ci skip] * Updating GBP from PR tgstation#57928 [ci skip] * Examine atmos machinery will tell the piping layer (tgstation#57937) * Automatic changelog generation for PR tgstation#57937 [ci skip] * Updating GBP from PR tgstation#57937 [ci skip] * fix (tgstation#57917) move layer adaptors into another spot in engi and toxins to prevent distro and waste mixing * Automatic changelog generation for PR tgstation#57917 [ci skip] * Updating GBP from PR tgstation#57917 [ci skip] * Thermomachine balance (tgstation#57921) Changed how much internal heat_capacity the machine has, from 5000 to 7500, this to try and increase the speed of cooling/heating that was a bit slower than the old version Added a check that stops the machine from cooling when set to heater and heating when set to cooler Changed efficiency to be clamped between 0.65 and 1 (lessen the power spikes) Power usage reduce on lower efficiency if above a certain amount removed else if when checking to use enviroment heat (allow to use enviroment to cool even with the red port connected and with gas) * Automatic changelog generation for PR tgstation#57921 [ci skip] * Updating GBP from PR tgstation#57921 [ci skip] * Moth eyes now have their own obj and mob sprites (tgstation#57893) imageadd: Moth eyes now have a unique sprite that reflects on your mob. * Automatic changelog generation for PR tgstation#57893 [ci skip] * Updating GBP from PR tgstation#57893 [ci skip] * Improves spoon in hand sprites (tgstation#57938) fix: Spoons are consistently rendered in the correct hand on the player's sprite * Automatic changelog generation for PR tgstation#57938 [ci skip] * Updating GBP from PR tgstation#57938 [ci skip] * Fixes the apocalypse rune alt appearance for humans. (tgstation#57965) * Automatic changelog generation for PR tgstation#57965 [ci skip] * Updating GBP from PR tgstation#57965 [ci skip] * Cyborgs now use the same icon states for charge screen alerts as ethereals. (tgstation#57966) * Automatic changelog generation for PR tgstation#57966 [ci skip] * Updating GBP from PR tgstation#57966 [ci skip] * lazy tramstation fix (tgstation#57843) Fix an already fixed issue with xenos and other mid-round antags from spawning inside atmos chambers. Copy-paste very bad * Automatic changelog generation for PR tgstation#57843 [ci skip] * Updating GBP from PR tgstation#57843 [ci skip] * ai_behaviour cleanup ft. less chatty tourists (tgstation#57945) Each of these lines is punctuated by an audio sting every 8 seconds without refrain. So, this PR adds a new vocalisation limiter to tourist bots who can't find a seat. Instead of always vocalising every 8 seconds, they're now guaranteed to vocalise the first time and then have a 60% chance to have vocalised again each minute thereafter. Tourists waiting for food now have an approx 40% chance to have vocalised in any given minute. This should be considered alongside the fact that multiple (up to 10) tourists can be present at any given point in time and with the difficulty in players killing them, they can create a lot of unnecessary audio spam. If the tourists are being served rapidly, they're also giving regular guaranted audio stings on top of that which compounds the chances any given bot will output an audio cue. The AI controller now passes the larger value between the behaviour's `action_cooldown` in real seconds (as opposed to deciseconds) and delta_time when performing behaviours. This has no gameplay changes outside of those documented in this PR, since no AI behaviours with cooldowns greater than the AI controller's delta_time attempted to use delta_time. Finally, customers now have 10 minutes of patience before leaving instead of 100 minutes of patience due to a minor oversight where their patience was in deciseconds while delta_time was subtracted in seconds. * Automatic changelog generation for PR tgstation#57945 [ci skip] * Updating GBP from PR tgstation#57945 [ci skip] * Further updates the rounds tips (tgstation#57951) Removes and/or updates some more tips that tgstation#57927 missed. * Automatic changelog generation for PR tgstation#57951 [ci skip] * Updating GBP from PR tgstation#57951 [ci skip] * fixes jungle grass having wrong broken states (tgstation#57967) * Automatic changelog generation for PR tgstation#57967 [ci skip] * Updating GBP from PR tgstation#57967 [ci skip] * Switch tgui tooltips to popper.js (tgstation#57992) * Preliminary popper support * Switch tooltips to popper.js * Documentation, change DEFAULT_PLACEMENT * Automatic changelog generation for PR tgstation#57992 [ci skip] * Updating GBP from PR tgstation#57992 [ci skip] * Quick-Create-Antagonist tweaks (tgstation#57913) Gives admins control of how many antags they spawn, instead of assuming a maximum of (generally) 3. image * Automatic changelog generation for PR tgstation#57913 [ci skip] * Automatic changelog compile [ci skip] * Renames TRAIT_MONKEYLIKE to TRAIT_DISCOORDINATED_TOOL_USER and fixes an issu with jungle fever (tgstation#57897) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57897 [ci skip] * Updating GBP from PR tgstation#57897 [ci skip] * Corrects span and a typo with emagged pAIs (tgstation#57981) * Automatic changelog generation for PR tgstation#57981 [ci skip] * Updating GBP from PR tgstation#57981 [ci skip] * Removes total_moles_specific, just use gaslists normally. I don't know how I missed this (tgstation#57973) * Refactors pellet_cloud/create_cassing_pellets to not sleep (tgstation#57974) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR tgstation#57974 [ci skip] * Updating GBP from PR tgstation#57974 [ci skip] * Fix Tooltip documentation (tgstation#58013) * Remove SS_NO_TICK_CHECK (tgstation#57800) ## About The Pull Request This is a whopper, will need @MrStonedOne to review. In theory this flag shouldn't be needed and my own testing didn't find any issues, but I'd feel better with a lengthy test merge. ## Why It's Good For The Game Might make nightshift subsystem lag less, MC loop has less stuff to check. * Updating GBP from PR tgstation#57800 [ci skip] * Reorder the list of items in more outfits. (tgstation#57801) On my quest to make outfits easier to read and fix some small mistakes by applying a priority order. ID > uniform > suit > backpack > other clothing in alphabetic order > pockets > hands > others Moved the base/assistant plasmaman outfit from the middle of the standard file to the top of the plasmaman outfit file. Reorganized the plasmaman outfit order to have jobs within a department close to each other. Moved the Death Commando outfit into the ERT file together with a line that adds mindshields to CentCom outfits because I had to dig to find that a long time ago... Also fixes detective plasmaman spawning with a worse headset and plasmamen prisoners spawning with a different shoe. Like... how no one has seen that plasmaman spawn with the wrong headset? Do we have no plasmaman sec? Yes I know the answer... * Automatic changelog generation for PR tgstation#57801 [ci skip] * Updating GBP from PR tgstation#57801 [ci skip] * Fix sql changelog (tgstation#57972) Fixed bad SQL that I originally wrote in the changelog for 5.11, anyone trying to update their schema from < 5.11 up would notice this. * Test newest version of gbp-action (tgstation#57980) Read about it here: tgstation/gbp-action#28 TLDR: Less race conditions, and all logs are now pushed to a separate branch. The new location of gbp-balances.toml is in the gbp-balances branch. Will most likely be able to delete the one in master so people don't get confused. This required a workflow update, and so was not directly pushed to master. This currently uses my PR branch directly so that I can make changes for anything that doesn't work. When it is solid, I will push it to master and we will go back to gbp-actions@master, or some pinned version. * Fixes mech HUD's not being properly removed (tgstation#57964) Fixes mech hud's not being removed when leaving the odysseus or clarke * Automatic changelog generation for PR tgstation#57964 [ci skip] * Resprites the fork! (tgstation#57490) About The Pull Request This PR resprites the fork. image Why It's Good For The Game The old fork was really tall and black. Forks are really hard to sprite but i think this is an improvement. Changelog cl imageadd: The fork has a new sprite. /cl * Automatic changelog generation for PR tgstation#57490 [ci skip] * rpds can now interact with the unwrench upgrade (tgstation#57959) Adds the functionality to upgrade the RPD by 'slapping' the unwrench upgrade disk with the RPD itself It doesn't exactly revolutionize gameplay and at most allows engineering cyborg players to at least upgrade their RPD to unwrench saving them a headache and a module slot when doing their thing I suppose * Automatic changelog generation for PR tgstation#57959 [ci skip] * *begins beatboxing like the friday night funkin dad* pp pp ppkk pk pk pk pkpp pk pk ppk ppp p yeah * this made a whole area dissapear lole * Wtf TGU is done??? i think * my brain is so fucking large i am smart * Consider your unused variable SANITIZED *in a very low tone of voice* bitch * fIXES ME BEING DUMB Mirror bot fan VS TGU Enjoyers *insert that one funny video of the british guy all angry staring at the camera with the greyscale chad flexing his muscles to the right* * DEAD ATMOS WTF *dies of cringe* * POTATO WHY Lowers the disease chance for a bit this is just so we don't instantly die from disease * Does thingy Adds cameras to drone area, adds a light so freezer room feels less dark * light yeah * Gets the new fulp commits over here yeah * gets us updated with TG once more should have the commit that makes TGUI not lag you for so long :) * my life be like ooh aaahh oooh * ooh aaah oooh aah fulp update * e e eo a o eo e e e e e ao e o eo o o o o * m * when the linter is failing.. * Annotate L-ints * sickness for nothinggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggggg * m * sleep through self loaaaaaaaaaaaaaaaaaathing what remains of my emotionnnnnnnnnnnnnnnnn only serves to play this gameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee * 'cause you're the only one who'd understand (The meaning of this!) Oh My God I try and I try and I try to make you listen to me I try to call you every day I'm rehearsing what to say when the truth comes out (Of my very own mouth) I've been working on a unified theory If I make it through tonight everybody's gonna hear me out 'Cause I'm the right one On my touch-tone, touch-tone telephone I'm the only one, hey! On your A.M., A.M. radio Don't hang up yet, I'm not done I'm an expert, I'm the one The one who was right all along Better to be laughed at than wrong I'm an expert in my field UFOlogy, yes, it's all real Ancient aliens, it's all true I'm an expert just like you And like you, I'm a genius before my time Disbelieving, that's the real crime Pretty soon they'll discover me in the Super-Sargasso Sea * why * i swear to god Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Changelogs <action@github.com> Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arkatos1 <43862960+Arkatos1@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: MLGTASTICa <61350382+MLGTASTICa@users.noreply.github.com> Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: TheVekter <TheVekter@users.noreply.github.com> Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Time-Green <timkoster1@hotmail.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: actioninja <actioninja@criticalaction.net> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: Horatio22 <69338705+Horatio22@users.noreply.github.com> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Co-authored-by: Fox McCloud <Fox-McCloud@users.noreply.github.com> Co-authored-by: Cyprex <35031555+Cyprex@users.noreply.github.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com> Co-authored-by: cacogen <25089914+cacogen@users.noreply.github.com> Co-authored-by: Qustinnus <Floydje123@hotmail.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com> Co-authored-by: Rohesie <rohesie@gmail.com> Co-authored-by: bloons3 <bloons3@users.noreply.github.com> Co-authored-by: dragomagol <66640614+dragomagol@users.noreply.github.com> Co-authored-by: Seth Scherer <supernovaa41@protonmail.com> Co-authored-by: Randomguy523 <55070076+Randomguy523@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> Co-authored-by: DuffCreeper <treyparn@yahoo.com.au>

@MrStonedOne

* Updating GBP from PR tgstation#57981 [ci skip] * Removes total_moles_specific, just use gaslists normally. I don't know how I missed this (tgstation#57973) * Refactors pellet_cloud/create_cassing_pellets to not sleep (tgstation#57974) Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> * Automatic changelog generation for PR tgstation#57974 [ci skip] * Updating GBP from PR tgstation#57974 [ci skip] * Fix Tooltip documentation (tgstation#58013) * Remove SS_NO_TICK_CHECK (tgstation#57800) ## About The Pull Request This is a whopper, will need @MrStonedOne to review. In theory this flag shouldn't be needed and my own testing didn't find any issues, but I'd feel better with a lengthy test merge. ## Why It's Good For The Game Might make nightshift subsystem lag less, MC loop has less stuff to check. * Updating GBP from PR tgstation#57800 [ci skip] * Reorder the list of items in more outfits. (tgstation#57801) On my quest to make outfits easier to read and fix some small mistakes by applying a priority order. ID > uniform > suit > backpack > other clothing in alphabetic order > pockets > hands > others Moved the base/assistant plasmaman outfit from the middle of the standard file to the top of the plasmaman outfit file. Reorganized the plasmaman outfit order to have jobs within a department close to each other. Moved the Death Commando outfit into the ERT file together with a line that adds mindshields to CentCom outfits because I had to dig to find that a long time ago... Also fixes detective plasmaman spawning with a worse headset and plasmamen prisoners spawning with a different shoe. Like... how no one has seen that plasmaman spawn with the wrong headset? Do we have no plasmaman sec? Yes I know the answer... * Automatic changelog generation for PR tgstation#57801 [ci skip] * Updating GBP from PR tgstation#57801 [ci skip] * Fix sql changelog (tgstation#57972) Fixed bad SQL that I originally wrote in the changelog for 5.11, anyone trying to update their schema from < 5.11 up would notice this. * Test newest version of gbp-action (tgstation#57980) Read about it here: tgstation/gbp-action#28 TLDR: Less race conditions, and all logs are now pushed to a separate branch. The new location of gbp-balances.toml is in the gbp-balances branch. Will most likely be able to delete the one in master so people don't get confused. This required a workflow update, and so was not directly pushed to master. This currently uses my PR branch directly so that I can make changes for anything that doesn't work. When it is solid, I will push it to master and we will go back to gbp-actions@master, or some pinned version. * Fixes mech HUD's not being properly removed (tgstation#57964) Fixes mech hud's not being removed when leaving the odysseus or clarke * Automatic changelog generation for PR tgstation#57964 [ci skip] * Resprites the fork! (tgstation#57490) About The Pull Request This PR resprites the fork. image Why It's Good For The Game The old fork was really tall and black. Forks are really hard to sprite but i think this is an improvement. Changelog cl imageadd: The fork has a new sprite. /cl * Automatic changelog generation for PR tgstation#57490 [ci skip] * rpds can now interact with the unwrench upgrade (tgstation#57959) Adds the functionality to upgrade the RPD by 'slapping' the unwrench upgrade disk with the RPD itself It doesn't exactly revolutionize gameplay and at most allows engineering cyborg players to at least upgrade their RPD to unwrench saving them a headache and a module slot when doing their thing I suppose * Automatic changelog generation for PR tgstation#57959 [ci skip] * Automatic changelog compile [ci skip] * Fix collect changes (tgstation#58022) * Xenomorphs can now strip humans again (tgstation#58007) * Automatic changelog generation for PR tgstation#58007 [ci skip] * Fix back not respecting internals (tgstation#58012) * Automatic changelog generation for PR tgstation#58012 [ci skip] * Layer overhaul (tgstation#57915) ## About The Pull Request Changes up some layer and plane defines for no particular reason lol ## Why It's Good For The Game Planes actually override layers, and layers control ordering within planes. A lot of the usage of plane and layer was wholly unnecessary. This refactor helps future maintainability while also being needed staging for _future features._ * Resprites all gas vending machines (tgstation#57919) The existing sprites are an amalgamation of parts of existing sprites, this PR replaces them with original sprites designed for the devices Sprites were made by me and were recolored by maxymax13 * Automatic changelog generation for PR tgstation#57919 [ci skip] * Update arcade.dm (tgstation#57984) * Automatic changelog generation for PR tgstation#57984 [ci skip] * Hand Drill Sound is now smoother on the ear. (tgstation#58004) * Automatic changelog generation for PR tgstation#58004 [ci skip] * Fixes Orion bad messages (tgstation#58018) * Automatic changelog generation for PR tgstation#58018 [ci skip] * A non-functional heart no longer causes heart attack if you have Muscled Veins (tgstation#58016) * Automatic changelog generation for PR tgstation#58016 [ci skip] * Nerfs holodeck thunderdome suits (tgstation#58011) * Automatic changelog generation for PR tgstation#58011 [ci skip] * You can now manufacture bone gel (tgstation#58006) * Automatic changelog generation for PR tgstation#58006 [ci skip] * Fixes Antigravity Grenades (tgstation#57991) * Automatic changelog generation for PR tgstation#57991 [ci skip] * Fixes flying damage slowdown applying to the floating movetype instead. (tgstation#57994) * Automatic changelog generation for PR tgstation#57994 [ci skip] * Fixes lights on people (tgstation#58000) - Fixes light eaters not putting out lights on people. * Automatic changelog generation for PR tgstation#58000 [ci skip] * CTF spawner awareness in tips (tgstation#57995) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57995 [ci skip] * Fixes incorrect params passed into callback function causing server crashing numbers of runtimes. (tgstation#58020) [21:03:59] Runtime in change_turf.dm,301: type mismatch: /turf/closed/mineral/random/vo... (/turf/closed/mineral/random/volcanic) & 18 proc name: AfterChange (/turf/open/AfterChange) src: the volcanic floor (135,80,3) (/turf/open/floor/plating/asteroid/basalt/lava_land_surface) call stack: the volcanic floor (135,80,3) (/turf/open/floor/plating/asteroid/basalt/lava_land_surface): AfterChange(/turf/closed/mineral/random/vo... (/turf/closed/mineral/random/volcanic), null) /datum/callback (/datum/callback): InvokeAsync() Timer (/datum/controller/subsystem/timer): fire(0) Timer (/datum/controller/subsystem/timer): ignite(0) Master (/datum/controller/master): RunQueue() Master (/datum/controller/master): Loop() Master (/datum/controller/master): StartProcessing(0) x9000 Missing args in callback meant two runtimes each time a turf was mined, exploded, blown up etc. Causes openspace to mess up if the server runs low on memory. * Automatic changelog generation for PR tgstation#58020 [ci skip] * Automatic changelog compile [ci skip] * Lowers rot disease chance (tgstation#58034) Lowered the chance of disease creation by ~60% Every round was having horrible breakouts, this ought to fix that * Automatic changelog generation for PR tgstation#58034 [ci skip] * Fixes error sprite from pdas in exosuit storage slots (tgstation#58033) fix: putting a PDA into an exosuit storage slot won't cause the missing texture sprite any more. * Automatic changelog generation for PR tgstation#58033 [ci skip] * Enhance spray bottle logging while improving code and variable names. (tgstation#58070) * Improve and loog * Copybara * Testing feex * Extra doc * Feex * Range start from 1 instead of 0 * Automatic changelog generation for PR tgstation#58070 [ci skip] * Automatic changelog compile [ci skip] * Feex (tgstation#58073) * Automatic changelog generation for PR tgstation#58073 [ci skip] * trigger spacemandmm reparse in CBT 'Build All' task (tgstation#58061) * Fixes runtimes related to quick equip. (tgstation#58043) Basic sanity and ensure unequip is properly called before equipping again. * Fixes a moth wing sprite mistake (tgstation#58059) A wing sprite had a silhouette for the mob that I missed in tgstation#53969 * Automatic changelog generation for PR tgstation#58059 [ci skip] * Fixes cargo gas canisters not being purchaseable (tgstation#58028) * Automatic changelog generation for PR tgstation#58028 [ci skip] * Fixes Tips Message About Ctf To Be Properly Descriptive Of Ctf (tgstation#58050) * Automatic changelog generation for PR tgstation#58050 [ci skip] * Mansus grasp now can ignite cigars (tgstation#58055) * Automatic changelog generation for PR tgstation#58055 [ci skip] * fix missing atmos features from various station (tgstation#57936) Adds bluespace vendors to tramstation Setup freezers to use waste loop Connect delta station freezers to waste loop Connect kilo station freezers to waste loop * Automatic changelog generation for PR tgstation#57936 [ci skip] * Revert "Switch tgui tooltips to popper.js" (tgstation#58078) * Revert "Switch tgui tooltips to popper.js (tgstation#57992)" This reverts commit 206c821. * Revert "Fix Tooltip documentation (tgstation#58013)" This reverts commit e692b05. * Fixes a way of obtaining metal in the CTF map downtown (tgstation#58041) * Automatic changelog generation for PR tgstation#58041 [ci skip] * Resprites the lightning orb (tgstation#58065) * Resprites the lightning orb * Fixes the lightning orb hud icon * Automatic changelog generation for PR tgstation#58065 [ci skip] * autofire no longer does SIGNAL_HANDLER_DOES_SLEEP (tgstation#58066) * Automatic changelog generation for PR tgstation#58066 [ci skip] * Puts a HPLC in chemistry on tramstation (tgstation#57987) * Automatic changelog generation for PR tgstation#57987 [ci skip] * CTF players are no longer 13 year olds (tgstation#58040) * Automatic changelog generation for PR tgstation#58040 [ci skip] * reverts map_format changes (tgstation#58051) reverts map_format changes done in tgstation#57915 * [READY] Adjusting/porting chemical toxins to fermichem (+Seiver fix) (tgstation#57606) * Automatic changelog generation for PR tgstation#57606 [ci skip] * Internal Affairs actually works as intended now (tgstation#58021) Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58021 [ci skip] * changes most uses of SSvis_overlays.add_vis_overlay() inside of update_overlays() to true overlays (tgstation#57985) * Automatic changelog compile [ci skip] * Lights up the alien chambers on the CTF map cruiser (tgstation#58042) * Automatic changelog generation for PR tgstation#58042 [ci skip] * Upgrade tgui dependencies, make yarn task skippable (tgstation#58081) * Upgrade tgui dependencies, make yarn task skippable * Use a phony target to avoid double rebuilds * Modifies SecTech ad from beating capitalists to communists (tgstation#58083) * Automatic changelog generation for PR tgstation#58083 [ci skip] * Fixes a minor oversight with eigenstasium (tgstation#58069) * Automatic changelog generation for PR tgstation#58069 [ci skip] * Update dependencies installed for TGSv4 precompile scripts (tgstation#58108) * add libssl1.1 * i was told to add myself to this as well * Automatic changelog generation for PR tgstation#58108 [ci skip] * Automatic changelog compile [ci skip] * Prevents morph toxin oversight (tgstation#58095) * Automatic changelog generation for PR tgstation#58095 [ci skip] * TGUI Limbgrower + Limbgrower refactoring and design expansion (tgstation#57955) Refactors the limbgrower to modernize the code. Now, the limbgrower can accept any type of reagent in limbgrower designs. Adds simple plumbing demand to the limbgrower, so you can pipe synthflesh into it. Adds monkey tails, felinid ears and tails, lizard digitigrade legs, lizard tongues, fake lizard tails (unusable in lizard-wine and similar recipes), plasmaman organs, and ethereal organs (minus the heart) to the limbgrower via limbgrower design disks. These disks can be printed from the medical lathe once the required technology has been researched. Adds a technology node to unlock the limbgrower design disks after advanced biotech, xenoorgan biology. In the future, this could have an experiment requirement - maybe to scan multiple types of species. Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> * Automatic changelog generation for PR tgstation#57955 [ci skip] * Fixes several exosuit storage slot and back slot worn icon bugs (tgstation#57946) * Adds teleprod exosuit slot worn icon * ... Really expands what the pr does * Automatic changelog generation for PR tgstation#57946 [ci skip] * Adds emergency meetings during april fools (tgstation#58098) 🆑 add: The captain can now sometimes call emergency meetings using the communications console! Hopefully the crew will be able to sus out any imposters who might be among them! /🆑 * Automatic changelog generation for PR tgstation#58098 [ci skip] * Allows you to ignite cigars with cauteries and recently-fired revolvers. (tgstation#58109) About The Pull Request tgstation#58055 added this for Mansus Grasp and I thought why the hell not, this is also badass. Fifteen seconds sounds like long enough to do this after firing the gun. Also EOB noticed you can't ignite cigars with the cautery and that seems odd, so I added that too. Not sure who'd want to do that, but here you go. Why It's Good For The Game Gun hot after firing also badassery Changelog 🆑 add: Recently-fired revolvers can now be used to ignite cigars like a fucking badass. add: Cauteries can now be used to ignite cigars like a very irresponsible doctor. /🆑 * Automatic changelog generation for PR tgstation#58109 [ci skip] * Automatic changelog compile [ci skip] * spelling (tgstation#58103) * Automatic changelog generation for PR tgstation#58103 [ci skip] * Fixes oversight with eigenstasium which teleports you before saving your location (when purity is greater than 90% and ingested) (tgstation#57986) * Fixes oversight * Why is this so convoluted * Final fix and test * Expose is strange * exposure to reagents may result in confusion, bafflement and hunger. If you feel any of these effects, consult with your doctor. * lil cleanup * Automatic changelog generation for PR tgstation#57986 [ci skip] * You can now print cable coils and welding helmets from scilathes and engilathes (tgstation#57762) * Automatic changelog generation for PR tgstation#57762 [ci skip] * Thermomachine have full temperature range on both modes (tgstation#57990) * qol * better changes * Update code/modules/atmospherics/machinery/components/binary_devices/thermomachine.dm Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57990 [ci skip] * Persistence now cleans up json entries (fixes a lot of runtimes involved) (tgstation#58084) * super duper persistence cleaning * compiles now, much better written * Processable and grillables and microwavables now give helpful examines, some condiment containers also do (tgstation#57694) * IM DONE LOOKING AT THE WIKI FOR BASIC SNIZZLE * microwaved, too * HOOH * LINT, review * review but this time im not lying

* maybe i should just like test or something * reviews i missed * 🐑 * Automatic changelog generation for PR tgstation#57694 [ci skip] * Fixes a critical accidental early return (tgstation#58128) Emergency meetings work now This loop shouldn't give up so quickly Makes emergency meetings work when there are new players about Also sets the 'show when dead' var to true so ghosts get the full experience * Automatic changelog generation for PR tgstation#58128 [ci skip] * Fixes toxin parent reagent purity affecting unintentional reagents (tgstation#58107) * Automatic changelog generation for PR tgstation#58107 [ci skip] * Add extools compilation to the TGS4 precompile scripts for linux (tgstation#58113) * Automatic changelog generation for PR tgstation#58113 [ci skip] * Add the seeds to the permabrig (tgstation#58019) * Automatic changelog generation for PR tgstation#58019 [ci skip] * lone carpet subtype now doesnt smooth, adds back star carpets (tgstation#58104) rohesie removed star carpets when they added the new smoothing system i think, this brings them back and gives both lone and star carpets a purpose, they no longer smooth, also lone carpets now use the symbol sprite again which has some customization in dirs * Automatic changelog generation for PR tgstation#58104 [ci skip] * emergency meetings now dont call in mobs with no client (tgstation#58133) * Automatic changelog generation for PR tgstation#58133 [ci skip] * Automatic changelog compile [ci skip] * Some quick fixes for the dark gygax icon and its uplink description (tgstation#58121) * Automatic changelog generation for PR tgstation#58121 [ci skip] * Makes canister pressure capabilities a bit random and more unstable (tgstation#57818) This is mainly to make bomb making just a little bit less of a formulaic activity. Canister base capacity is 8% lower but is increased by up to 20% from that amount, roughly resulting in the same average capacity. You can experiment to figure out each one's individual limit or just stick to safe minimum pressures. To counter balance this somewhat, canister failure is a bit more violent. Damaged canisters will slowly leak gas, and a canister that breaks with internal pressure greater than it's capability will explode. Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#57818 [ci skip] * RCD now rebuilds existing constructs faster and with less resources (tgstation#58029) * RCD now rebuilds faster * Reconstructing now costs less * Fix _ * Remove unused flag, use helper proc * Add sound * Remove previously useless, now inaccurate comment * Add MIN_COMPILER_VERSION warning * Automatic changelog generation for PR tgstation#58029 [ci skip] * Injectors, vents and scrubbers no longer work when placed on walls (tgstation#57971) fixes gas deletion exploit by stopping injectors, vents and scrubbers from being placed on walls * Automatic changelog generation for PR tgstation#57971 [ci skip] * Xenobio outlet fix (tgstation#58002) About The Pull Request Fixes air outlet injector outside of Xenobiology Lab not being powered Why It's Good For The Game Unpowered outlet makes it difficult to siphon air out of Xenobiology Lab Changelog 🆑 fix: Fixed air outlet injector outside of Xenobiology Lab not being powered /🆑 * Automatic changelog generation for PR tgstation#58002 [ci skip] * Removes a single stray-pixel on slice of vanilla cake (tgstation#58142) * Automatic changelog generation for PR tgstation#58142 [ci skip] * Shorten april fools to 3 days (tgstation#58144) this way it covers all the timezones * Automatic changelog generation for PR tgstation#58144 [ci skip] * Automatic changelog compile [ci skip] * Adds moffins, a whimsical breakfast pastry (tgstation#58110) * Adds moffins * slightly different check as requested * Update code/game/objects/items/food/pastries.dm I have been got got. Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Update code/game/objects/items/food/pastries.dm Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: Iamgoofball <iamgoofball@gmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58110 [ci skip] * remove input pass-through from stat panel and just try not to keep focus instead (tgstation#58143) About The Pull Request The input pass-through didn't work anyway, as it would pass through lower-case keys which our input code doesn't understand (unless you were holding shift or hadcaps lock on.) It also didn't translate arrow keys to NORTH, etc. which is how BYOND expects them. If you double clicked on the stat panel it would eat all following input from you. If you happened to have caps lock on, you might not notice this because the correct WASD values get passed to BYOND. If you were then to stop walking while holding shift because you want to examine something, your key release would be sent to BYOND as lowercase, causing it to be ignored. Under all of those conditions, your movement would get stuck in one direction. It's more likely than you think!!! A similar chain of events could cause Alt releases to not be sent to BYOND due to this as well. -- The fix is to just give back focus to the map similarly to how TGUI does it. It's not quite as majestic as TGUI, but it seems to have fine results. Why It's Good For The Game Nobody likes sticky keys Changelog 🆑 fix: Stat panel no longer captures input (potentially causing keys to get stuck down) /🆑 * Automatic changelog generation for PR tgstation#58143 [ci skip] * Actually fixes bots wrongfully failing to pathfind (tgstation#58064) I botched tgstation#57873 and made the wrong part of the code return an empty list, so instead of it being part of the wrapper proc (like it was before), it was part of the core pathfinding proc. This meant that sometimes a non-list return value would make it by the wrapper proc when a list was expected, eventually causing bots to fail to respond to summons from AIs/PDAs as I detailed in the last PR. This solves it by ensuring all returns are lists, with the exceptions of invalid callers or endpoints, which should error. * Automatic changelog generation for PR tgstation#58064 [ci skip] * makes slapping someone in the face more intuitive (tgstation#58137) * Automatic changelog generation for PR tgstation#58137 [ci skip] * Stripping a disconnected player will tell them when they come back (tgstation#58129) * Automatic changelog generation for PR tgstation#58129 [ci skip] * Snappier Firelocks (tgstation#57943) Firelocks are kind of annoying to open since it relies on a 10 second area based timer that is difficult to predict, this tries to solve that. When forced open with the primary attack, the firelock now checks if you are adjacent to it or not. Our dearest Manuel players can think of it as you manually holding the door back. It is also made to close when you are no longer adjacent or went horizontal (resting, etc.) This sort of made firelocks snappier and close faster too, and I hope this might help it seal off areas better. The door will be stuck closed when you leave it however, and that's where the old behaviour comes in. Secondary attack is used to toggle the firelock and surrender it to the timer if an alarm is triggered. Primary attack without a fire alarm triggering cannot keep the door open after you walk away. I hope this is intuitive enough. * Automatic changelog generation for PR tgstation#57943 [ci skip] * Refactors shielded hardsuits into a component, fixes kisses consuming shield charges (tgstation#57797) Shielded hardsuits (like the syndie ones) and shielded cult robes, despite functioning very similarly, were actually implemented twice in their own pockets of clothing code. This merges them into one component that lets you block a certain number of attacks while your suit has charges, and have the suit recharge itself after going so long without being hit (optional, cult robes still don't regain lost charges). This PR also fixes harmless kiss projectiles consuming charges on shielded suits, I'm sure to much disappointment. They'll now pass directly through though, so you can still try your luck to see if love truly conquers all (it probably won't). One casualty of this is that you can no longer toggle the shield color of syndie hardsuits with a multitool since that it was annoying to componentize, not something that affected gameplay, and probably something noone knew you could do anyway. Fixes: tgstation#57723 * Automatic changelog generation for PR tgstation#57797 [ci skip] * Placing a fireman carried person onto a table no longer harms them (tgstation#58147) Previously, clicking on a table with a fireman carried person while not in combat mode would start a do_after(), then harmfully smash the person you fireman carrying into the table. This harmful smash has been replaced by your character merely placing the fireman carried person onto the table, like what happens when you click on a table while not in combat mode while you have someone in a grab. You can still click on a table with a fireman carried person while in combat mode to perform a limb smash, if you wish. * Automatic changelog generation for PR tgstation#58147 [ci skip] * adds the console (tgstation#58127) * Automatic changelog generation for PR tgstation#58127 [ci skip] * Adds proper logging to Holodeck safeties and programs (tgstation#58149) * Adds proper logging to Holodeck safeties and programs * a more elegant solution * Automatic changelog generation for PR tgstation#58149 [ci skip] * Recolors bucket inhand and adds omega soap inhand (tgstation#58148) * ' * Fixed stray pixel * Automatic changelog generation for PR tgstation#58148 [ci skip] * Automatic changelog compile [ci skip] * Smart Pipes(reborn) (tgstation#58038) How these new pipes work. -Smart pipes autoconnect to nearby smart pipes -They are now color coded, so they only connect to the same colored pipe, the GREY pipe is the wildcard and can connect to every other color, so be aware of this -ALL components spawned by the RPD can be colored (from pumps to connectors, from pipes to manifolds), if you leave them GREY they can connect to every other color. Color adapters can be colored, but they'll still connect two pipes with different colors. BUILDABLE machines are GREY (thermomachines, cryo, HFR) so be aware of this -Trying to go across another smart pipe will now build a bridge pipe automatically already colored of the color you choose, so you don't have to place it yourself anymore (is still available in the RPD tho) -ALL binary components, layer manifolds, color adapters and bridge pipe can be put ONTOP of a smart pipe, but not on another of these. Smart pipes can't be placed on top of these pipes, so you have to build them first. -Lcrossings can't be made anymore (sorry y'all i tryed, if someone have a way of doing them ping me on discord) -REMEMBER you still have 5 layers to go, these rules apply to the same layer pipes, so if you do a crossing on different layers you won't see a bridge pipe appear. * Automatic changelog generation for PR tgstation#58038 [ci skip] * resprite water cooler (tgstation#58117) * Automatic changelog generation for PR tgstation#58117 [ci skip] * Fixes a few roulette wheel runtimes. (tgstation#58139) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58139 [ci skip] * Stethoscopes now require hearing instead of vision to use (tgstation#58169) * Automatic changelog generation for PR tgstation#58169 [ci skip] * added colour picking to VV (tgstation#58173) Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk> * Automatic changelog generation for PR tgstation#58173 [ci skip] * Fixes smoker stacking unremovable negative moodlets (tgstation#58170) * Automatic changelog generation for PR tgstation#58170 [ci skip] * Add youtube-dl to tgs4 precompile scripts for Linux (windows users on suspicious individuals watch) (tgstation#58135) Adds the ability for the TGS4 precompile script on Linux platforms to resolve the youtube-dl dependency. This essentially is for Docker deployments, but can also apply to regular TGS4 deployments as well. * Automatic changelog generation for PR tgstation#58135 [ci skip] * Fixes multiple issues related to suicides (tgstation#58178) * Automatic changelog generation for PR tgstation#58178 [ci skip] * Armless people can no longer buckle people (tgstation#58176) Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58176 [ci skip] * Terror in the Toybox: The Rouny Plushie (tgstation#58221) * rouny plushie * rouny prizes * loar * Automatic changelog generation for PR tgstation#58221 [ci skip] * fix pipe (tgstation#58120) * Automatic changelog generation for PR tgstation#58120 [ci skip] * Automatic changelog compile [ci skip] * After revolutionaries win, one living headrev (if any are able to) will be allowed to rename the station with a revolutionary banner (tgstation#58165) Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58165 [ci skip] * Delete useless toFixed import in TimeDisplay (tgstation#58215) * Fix a missing icon (tgstation#58219) * Deletes unreachable line for tools/dmi (tgstation#58213) Resolves tgstation#58211 * Fixes the borg hug module being able to harm and shove simple mobs (tgstation#58175) * Automatic changelog generation for PR tgstation#58175 [ci skip] * Pacifists can no longer swat bugs (tgstation#58177) Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> * Automatic changelog generation for PR tgstation#58177 [ci skip] * Fix PreCompile.bat failing with spaced paths (tgstation#58184) * Fix PreCompile.bat failing with spaced paths * Undo spacification * Give miners cargo access on icebox, removes QM office access from cargo techs (tgstation#58167) * Automatic changelog generation for PR tgstation#58167 [ci skip] * revamps meta incinerator (tgstation#58198) * revamps meta incinerator cleans pipes in meta incinerator * Update MetaStation.dmm * [s] Restores Cargo Shuttle Blacklist Enforcement (tgstation#58201) Removed an inappropriate as anything inside the cargo shuttle's blacklist check that was breaking it. * Automatic changelog generation for PR tgstation#58201 [ci skip] * Player Lobstrosities Can Right-Click To Charge (tgstation#58199) * Automatic changelog generation for PR tgstation#58199 [ci skip] * stat panel focus reset happens _before_ verb commands are ran (tgstation#58196) * Automatic changelog generation for PR tgstation#58196 [ci skip] * Fixes spelling errors in misc.dm (tgstation#58194) * Automatic changelog generation for PR tgstation#58194 [ci skip] * layer manifolds visual fix (tgstation#58193) * Automatic changelog generation for PR tgstation#58193 [ci skip] * Automatic changelog compile [ci skip] * Moves code managing mobs getting shocked from disease code to mob status code (tgstation#58202) * Venus human traps no longer take cold damage (tgstation#58185) * Automatic changelog generation for PR tgstation#58185 [ci skip] * Deletes duplicate export property (tgstation#58212) * Reduces the amount of unsorted chat messages (tgstation#58192) * Automatic changelog generation for PR tgstation#58192 [ci skip] * et * Update README.md * Update beefman.dm * . * oh no i just realized i have to map * Update mobspawner.dm * Update tgstation.dme * Update Heliostation.dmm * fixes heliostation pipes Probably. Fuck smartpipes * Update Heliostation.dmm * TGU * dme * Update build.js * tgu stuff * sorry beefmen * no * fixes the pipes and other stuff. probably * last of the fixes * digi lol * Update deputy.dm * TGU * fixes helio pipes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: MLGTASTICa <61350382+MLGTASTICa@users.noreply.github.com> Co-authored-by: MLGTASTICa <ak9bc01d@yahoo.com> Co-authored-by: tgstation-server <tgstation-server@tgstation13.org> Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com> Co-authored-by: spookydonut <github@spooksoftware.com> Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com> Co-authored-by: Bobbahbrown <bobbahbrown@gmail.com> Co-authored-by: Krysonism <49783092+Krysonism@users.noreply.github.com> Co-authored-by: DuffCreeper <treyparn@yahoo.com.au> Co-authored-by: Changelogs <action@github.com> Co-authored-by: Rob Bailey <actioninja@gmail.com> Co-authored-by: NamelessFairy <40036527+NamelessFairy@users.noreply.github.com> Co-authored-by: Fikou <piotrbryla@onet.pl> Co-authored-by: FernandoJ8 <80640114+FernandoJ8@users.noreply.github.com> Co-authored-by: tralezab <40974010+tralezab@users.noreply.github.com> Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com> Co-authored-by: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com> Co-authored-by: ishitbyabullet <deathzombine@outlook.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com> Co-authored-by: TemporalOroboros <TemporalOroboros@gmail.com> Co-authored-by: Iosyf <iosyf123456@abv.bg> Co-authored-by: Timberpoes <silent_insomnia_pp@hotmail.co.uk> Co-authored-by: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com> Co-authored-by: William Wallace <me@wiox.me> Co-authored-by: AnturK <AnturK@users.noreply.github.com> Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com> Co-authored-by: Kokonut <38844529+maxymax13@users.noreply.github.com> Co-authored-by: EdgeLordExe <42111655+EdgeLordExe@users.noreply.github.com> Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com> Co-authored-by: Aleksej Komarov <stylemistake@gmail.com> Co-authored-by: Thalpy <33956696+Thalpy@users.noreply.github.com> Co-authored-by: LordVollkorn <66637090+LordVollkorn@users.noreply.github.com> Co-authored-by: SgtHunk <68669754+SgtHunk@users.noreply.github.com> Co-authored-by: Kylerace <kylerlumpkin1@gmail.com> Co-authored-by: Swept <sweptwastaken@protonmail.com> Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com> Co-authored-by: Emmanuel S <mrdoomboyo@gmail.com> Co-authored-by: TheVekter <TheVekter@users.noreply.github.com> Co-authored-by: Seth Scherer <supernovaa41@protonmail.com> Co-authored-by: ATH1909 <42606352+ATH1909@users.noreply.github.com> Co-authored-by: Capsandi <38051413+Capsandi@users.noreply.github.com> Co-authored-by: necromanceranne <40847847+necromanceranne@users.noreply.github.com> Co-authored-by: Jordan Brown <Cyberboss@users.noreply.github.com> Co-authored-by: norill <norill@wp.pl> Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Iamgoofball <iamgoofball@gmail.com> Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com> Co-authored-by: BootlegBow <69032410+BootlegBow@users.noreply.github.com> Co-authored-by: Thunder12345 <Thunder12345@users.noreply.github.com> Co-authored-by: Thunder12345 <stewart@critar.demon.co.uk> Co-authored-by: Time-Green <timkoster1@hotmail.com> Co-authored-by: EOBGames <58124831+EOBGames@users.noreply.github.com> Co-authored-by: Tom <tomforde4@gmail.com> Co-authored-by: ZeWaka <zewakagamer@gmail.com> Co-authored-by: InsaneRed <47158596+InsaneRed@users.noreply.github.com> Co-authored-by: IndieanaJones <47086570+IndieanaJones@users.noreply.github.com> Co-authored-by: Imaginos16 <77556824+Imaginos16@users.noreply.github.com> Co-authored-by: Seris02 <49109742+Seris02@users.noreply.github.com> Co-authored-by: Ben S <tomfhardy@yandex.com>

GuillaumePrata added 4 commits March 18, 2021 10:33

Organize the order of outfits

46153a8

Organize the order of outfits

654417f

1 line fixed...

Organize the order of items in outfits

6668f2a

More 1 line fixes...

Organize the order of items in outfits

3a905d8

Why I keep missing 1 lines mistakes aaaah...

GuillaumePrata added 2 commits March 18, 2021 11:04

Merge pull request #1 from tgstation/master

3cd8a51

Merge moment

Outfit reorder with 1 S fixed now

17ed55d

coiax added the Code Improvement Code is now easier to copy paste. label Mar 18, 2021

GuillaumePrata added 6 commits March 19, 2021 00:02

Organizes ERT outfit order

f254367

Look, more things I missed earlier...

Updates ERT outfit order

f5d479b

More... missed... things...

Organizes standard outfits

c93db49

= 6, >=6,

Update ERT outfit order

5dc8e67

I shouldn't organize things while sleepy, but hey, FIXED!

Update ERT outfit order

5ce884f

Removes the eng medkit

Fixes the detective headset being a worse one.

5ba4862

Cyberboss added the Fix Rewrites a bug so it appears in different circumstances label Mar 28, 2021

Cyberboss merged commit f38c8b1 into tgstation:master Mar 28, 2021

tgstation-server added a commit that referenced this pull request Mar 28, 2021

Automatic changelog generation for PR #57801 [ci skip]

7da7a0b

github-actions bot added a commit that referenced this pull request Mar 28, 2021

Updating GBP from PR #57801 [ci skip]

bbb4202

SkyratBot mentioned this pull request Mar 28, 2021

[MIRROR] Reorder the list of items in more outfits. Skyrat-SS13/Skyrat-tg#4484

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reorder the list of items in more outfits. #57801

Reorder the list of items in more outfits. #57801

GuillaumePrata commented Mar 18, 2021 •

edited

github-actions bot commented Mar 18, 2021

ArcaneMusic commented Mar 18, 2021 •

edited

GuillaumePrata commented Mar 18, 2021

Reorder the list of items in more outfits. #57801

Reorder the list of items in more outfits. #57801

Conversation

GuillaumePrata commented Mar 18, 2021 • edited

About The Pull Request

Why It's Good For The Game

Changelog

github-actions bot commented Mar 18, 2021

ArcaneMusic commented Mar 18, 2021 • edited

GuillaumePrata commented Mar 18, 2021

GuillaumePrata commented Mar 18, 2021 •

edited

ArcaneMusic commented Mar 18, 2021 •

edited