New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balloon alerts - Text for minor actions w/o other feedback #59130
Conversation
I'd like to see this applied to mining in some way since the chat tends to clog badly with 1000x different "you smash the rock" messages |
It does both for now, though there's no need to have both. For something like mining, I don't see any problem in replacing the chat message with it. |
Though to add on, while it's fine to add it to that, the ultimate goal here is for things that don't have any feedback other than chat. Mining a rock has the feedback of a sound + the do_after prompt, so it doesn't particularly need this. |
One potential point of confusion I see here is I assume that these transfer amount changes aren't shown to people next to me? |
They are only shown to you. Also, I'm removing the chat message since it's now unnecessary and I want to keep the chat box uncluttered. |
There's gotta be some convenient way we can indicate that, as this might become confusing as this gets used more and more |
That'll be 5% of your revenue in patent licensing, thanks. |
I don't think there is, but I also don't think it'll be much of a problem 🤷 |
Does mining even need a message about smashing rocks? |
Probably not, no. |
This looks really nice, I'm surprised we can pull it off in byond |
They're pretty slow. |
Slower than in the video, or just slow in general? If the former, I have no idea why--the client sides should be done 100% client-side. If the latter, I'd have to see it in game, since I thought I got a good sweet spot here. |
## About The Pull Request Port of tgstation/tgstation#59130 ![image](https://github.com/f13babylon/f13babylon/assets/8881105/0d1037c8-74fc-4938-9c35-37b347074f28) TDLR Little bits of text that float up above your head to notify you of things. Added it to reagent containers as an example, will probably make another PR for more conversions ## Why It's Good For The Game Less looking to and from chat for things that don't need it, harder to miss stuff ## Pre-Merge Checklist - [x] You tested this on a local server. - [x] This code did not runtime during testing. - [x] You documented all of your changes. ## Changelog :cl: add: Added balloon alerts - messages that appear above your character's head instead of clogging chat /:cl:
<!-- Пишите **НИЖЕ** заголовков и **ВЫШЕ** комментариев, иначе что то может пойти не так. --> <!-- Вы можете прочитать Contributing.MD, если хотите узнать больше. --> ## Что этот PR делает <!-- Вкратце опишите изменения, которые вносите. --> <!-- Опишите **все** изменения, так как противное может сказаться на рассмотрении этого PR'а! --> <!-- Если вы исправляете Issue, добавьте "Fixes #xxxx" (где xxxx - номер Issue) где-нибудь в описании PR'а. Это автоматически закроет Issue после принятия PR'а. --> Портирует с ТГ балун алерты: tgstation/tgstation#59130 Как пруф-оф-концепт реализация на пейн-крит и поднятие/спуск по лестнице ## Почему это хорошо для игры <!-- Опишите, почему, по вашему, следует добавить эти изменения в игру. --> Красивое ## Тестирование <!-- Как вы тестировали свой PR, если делали это вовсе? --> Поднял ## Changelog :cl: add: Balloon Alerts! /:cl: <!-- Оба :cl:'а должны быть на месте, что-бы чейнджлог работал! Вы можете написать свой ник справа от первого :cl:, если хотите. Иначе будет использован ваш ник на ГитХабе. --> <!-- Вы можете использовать несколько записей с одинаковым префиксом (Они используются только для иконки в игре) и удалить ненужные. Помните, что чейнджлог должен быть понятен обычным игроком. --> <!-- Если чейнджлог не влияет на игроков(например, это рефактор), вы можете исключить всю секцию. --> --------- Co-authored-by: Gaxeer <44334376+Gaxeer@users.noreply.github.com>
About The Pull Request
2021-05-15T05-30-52.mp4
2021-05-15T05-15-59.mp4
(The text going underneath the potted plant was fixed)
Currently only applies to beakers changing amounts as a proof of concept of an action that we can't really provide any non-text feedback on, as opposed to something you could have different sounds for.
Inspired by SS14.
Why It's Good For The Game
In the right place, balloon alerts will let you keep your eyes on the game itself, rather than constantly looking at the chat. This is especially important when chat messages will collapse into each other. This is in most cases warranted, but can make other cases (such as changing beaker amounts) confusing.
Changelog
🆑
qol: Changing a reagent container's transfer amount will now give you feedback in the form of text on the container itself.
/:cl: