Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon Alerts #12020

Merged
merged 1 commit into from Jul 21, 2021
Merged

Balloon Alerts #12020

merged 1 commit into from Jul 21, 2021

Conversation

Geevies
Copy link
Contributor

@Geevies Geevies commented Jun 9, 2021

  • Added balloon alerts, messages that appear on the screen to convey information quickly without using the chat.
  • Added balloon alerts to gun jamming and unjamming so you don't need to look at the chat.

Ported from: tgstation/tgstation#59130 and tgstation/tgstation#59256

@Geevies
Copy link
Contributor Author

Geevies commented Jun 9, 2021

!review

@Geevies
Copy link
Contributor Author

Geevies commented Jun 9, 2021

Example: https://gfycat.com/limpingfragrantleafhopper

@TheDanseMacabre
Copy link
Contributor

I really feel like this should be made a preference option instead of being enabled for everyone always.

NonQueueingMatt
NonQueueingMatt approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@NonQueueingMatt NonQueueingMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit wary because I don't want these to be overused, but we'll see how it goes. Fine for onomatopeias, though.

@NonQueueingMatt NonQueueingMatt merged commit b04be7b into Aurorastation:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

@Doxxmedearly Doxxmedearly Doxxmedearly approved these changes

Assignees
No one assigned
Labels
Awaiting Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Geevies @TheDanseMacabre @NonQueueingMatt @Doxxmedearly @BotBOREALIS