Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desouls the legion #64174

Merged
merged 8 commits into from Jan 27, 2022
Merged

Desouls the legion #64174

merged 8 commits into from Jan 27, 2022

Conversation

Sheits
Copy link
Contributor

@Sheits Sheits commented Jan 17, 2022

About The Pull Request

I really hope I didnt fuck the pr up lol
also big thanks to SgtHunk and JohnWillard for code help

legion.1.mp4

Legiontest
Middle
Legion
Legionright
Legion1

Core1
Legion1
Legion2
Legion3
Legion4

Why It's Good For The Game

I feel like the current "skull mitosis" in the legion fight is just a lazy way to avoid adding more sprites. With the introduction of more subtypes with different sprites, this opens the possibility of adding more attacks or phases to the boss.

Changelog

馃啈
imageadd: Resprites the mega legion and all legion related mobs
/:cl:

@tgstation-server tgstation-server added the Sprites A bikeshed full of soulless bikes. label Jan 17, 2022
@tralezab
Copy link
Contributor

sick

@remove32
Copy link
Contributor

fantastic bit of cosmic/body horror

@TemporalOroboros
Copy link
Contributor

TemporalOroboros commented Jan 17, 2022 •
edited

Very nice sprites.
Did you manage to get the big legion as well? I know it's somewhere in the larger icon files. I'll see if I can track it down.

EDIT: Found it https://github.com/tgstation/tgstation/blob/master/icons/mob/lavaland/64x64megafauna.dmi
legion
It's not actually used so if you want to I think you could just remove it. Otherwise it might need sprites, lest it remain soulful.

@Sheits
Copy link
Contributor Author

Sheits commented Jan 17, 2022

Very nice sprites. Did you manage to get the big legion as well? I know it's somewhere in the larger icon files. I'll see if I can track it down.

EDIT: Found it https://github.com/tgstation/tgstation/blob/master/icons/mob/lavaland/64x64megafauna.dmi legion It's not actually used so if you want to I think you could just remove it. Otherwise it might need sprites, lest it remain soulful.

idk im not respriting it so the soul can stay lol

@Shadowflame909
Copy link
Contributor

Very nice sprites. Did you manage to get the big legion as well? I know it's somewhere in the larger icon files. I'll see if I can track it down.
EDIT: Found it https://github.com/tgstation/tgstation/blob/master/icons/mob/lavaland/64x64megafauna.dmi legion It's not actually used so if you want to I think you could just remove it. Otherwise it might need sprites, lest it remain soulful.

Dwarf Legions could use it!

Also these sprites make me feel sick. Now I know what the miners feel like! 10/10 PR. Im immersed

@D4C-420
Copy link
Contributor

D4C-420 commented Jan 17, 2022 •
edited

The skull trophy that drops from legion and their cores should also probably be changed to match these sick new sprites.

Edit: I鈥檓 dumb you changed the cores. Missed that by mistake.

@SmArtKar
Copy link
Contributor

Core effect alert also needs to be changed, it's located in icons/hud/screen_alert.dmi

@Sheits
Copy link
Contributor Author

Sheits commented Jan 17, 2022

Core effect alert also needs to be changed, it's located in icons/hud/screen_alert.dmi

iirc its the same icon for another status effect when you take lots of damage so the icon shouldnt be the same as the core imo, but thx for bringing it up ill look into it

@SmArtKar
Copy link
Contributor

Core effect alert also needs to be changed, it's located in icons/hud/screen_alert.dmi

iirc its the same icon for another status effect when you take lots of damage so the icon shouldnt be the same as the core imo, but thx for bringing it up ill look into it

I think it would be nicer if you changed it(the alert) to the core instead of the skull sprite

@SgtHunk
Copy link
Contributor

SgtHunk commented Jan 17, 2022

Soulless

@Sheits
Copy link
Contributor Author

Sheits commented Jan 17, 2022 •
edited

I think it would be nicer if you changed it(the alert) to the core instead of the skull sprite

reasoning behind doing so was because the same sprite is used for determination which happens when youre close to death or somethin, so having a random organ wouldnt make as much sense

Fikou
Fikou requested changes Jan 17, 2022
View reviewed changes
Copy link
Member

@Fikou Fikou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems you fucked up the legionnaire's icons

@Sheits
Copy link
Contributor Author

Sheits commented Jan 18, 2022

it seems you fucked up the legionnaire's icons

good catch lmao

@Coastfront

This comment has been minimized.

Sign in to view
@theta006
Copy link

nice it looks like terrarias crimson

@tralezab tralezab merged commit b7c1c31 into tgstation:master Jan 27, 2022
tgstation-server added a commit that referenced this pull request Jan 27, 2022
@tgstation-server
Automatic changelog generation for PR #64174 [ci skip]
b55eed5
github-actions bot added a commit that referenced this pull request Jan 27, 2022
@github-actions
Updating GBP balances for #64174
8d628a8
@SkyratBot SkyratBot mentioned this pull request Jan 27, 2022
Merged
@Sheits Sheits deleted the Legion-resprite branch February 9, 2022 06:22
@Sealed101 Sealed101 mentioned this pull request Nov 14, 2022
Merged
@Sun-Soaked Sun-Soaked mentioned this pull request Apr 6, 2023
Merged
MarkSuckerberg pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Apr 9, 2023
@thgvr
General fauna sprite update (#1871)
c9fa719 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This PR updates the sprites of most fauna.
Ports tgstation/tgstation#74299
Ports tgstation/tgstation#64174

## Why It's Good For The Game

Better sprites make me happy :)

## Changelog

:cl:
imageadd: New fauna sprites by Sheets
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Apr 9, 2023
@thgvr
General fauna sprite update (#1871)
d2b9fec 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This PR updates the sprites of most fauna.
Ports tgstation/tgstation#74299
Ports tgstation/tgstation#64174

## Why It's Good For The Game

Better sprites make me happy :)

## Changelog

:cl:
imageadd: New fauna sprites by Sheets
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
MarkSuckerberg pushed a commit to shiptest-ss13/Shiptest that referenced this pull request Apr 11, 2023
@thgvr
General fauna sprite update (#1871)
8afb440 
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request

This PR updates the sprites of most fauna.
Ports tgstation/tgstation#74299
Ports tgstation/tgstation#64174

## Why It's Good For The Game

Better sprites make me happy :)

## Changelog

:cl:
imageadd: New fauna sprites by Sheets
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
@tattax tattax mentioned this pull request Apr 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fikou Fikou Fikou requested changes

@Twaticus Twaticus Twaticus approved these changes

@Imaginos16 Imaginos16 Awaiting requested review from Imaginos16 Imaginos16 is a code owner

@Krysonism Krysonism Awaiting requested review from Krysonism Krysonism is a code owner

Assignees
No one assigned
Labels
Sprites A bikeshed full of soulless bikes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet