Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

new lavaland mobs sprites (majority of them) #18597

Closed
wants to merge 9 commits into from

Conversation

tattax
Copy link
Contributor

@tattax tattax commented Apr 18, 2023

Updates lavaland sprites (that are i believe over 7 years old to this point) to new ones from TG.

Some sprites are up for the debate so i left old sprites that i believe would be most controverisal on the file for easy re-implementation just in case, since some of these can be argued with.

Ports:
tgstation/tgstation#64174
tgstation/tgstation#74299

Spriting

x5nqQh4L5h

hmmmm

image

image

image

image

image

image

image

image

image

closes: #19257

馃啈 Sheets
tweak: tweaked how legion splitting works so it allows sprites, splitting into more little skulls than before
imageadd: added new sprites for all lavaland mobs!
bugfix: tweaks some balloon alerts to be show up correctly
/:cl:

@tattax tattax requested a review from a team as a code owner April 18, 2023 22:51
@Yogbot-13 Yogbot-13 added Sprites This PR has spriting changes Tweak This PR contains changes to the game. labels Apr 18, 2023
@Cartlord
Copy link
Contributor

These look terrible and incongruous with the rest of the game's sprites

@Smudged
Copy link

Smudged commented Apr 18, 2023

These sprites do bring a breath of fresh air into the game, and I do implore people to give them a try

@Marmio64
Copy link
Contributor

i think the sprites look cool but the original sprites still look pretty neat regardless, but I'd prefer the current style of the Necropolis and tendril over the fleshy style that the new sprites seem to go for though im neutral over all.

@milk-is-cool
Copy link
Contributor

dont we have a pretty strict guide for sprites or something regarding art style. i also have personal bias cause i never liked how the tg sprites looked.

@Tempolx
Copy link
Contributor

Tempolx commented Apr 18, 2023

IMO these sprites are incredibly bad, and heavily clash with what lavaland should be and its current theme. Legion alone looks more like a cartoon boss than a infectious magic necromancy thing, goliaths look like a pile of flesh? Bubblegum looks like a character from doom, gold grub looks more like a snowman made of gold, why does colossus have a gun? Herald looks like another doom enemy

@tattax
Copy link
Contributor Author

tattax commented Apr 18, 2023

my brother in christ you want to say "bubblegum looks like it's from doom" when the original sprite had that intention in the first place

@Marmio64
Copy link
Contributor

I do think the hierophant and Pandora do look pretty cool though and the ash drake looks great too but looks less threatening and smaller, looks like a baby version. Colossus lobster looks pretty dumb though.

@Moja10
Copy link
Contributor

Moja10 commented Apr 19, 2023

Cool shit! I dig it

@MajManatee
Copy link
Contributor

MajManatee commented Apr 19, 2023

No baby ashdrake sprite?
I do think BG looks a bit too bright, but maybe that's just me.
Also seems like colossus is missing the last frame of his animation.

@cuackles
Copy link
Contributor

OK so to address some comments, no this shit aint bad, if you are incapable of distinguish between badly made sprites and sprites that are bad u stupid, we do have some relatively strict rules about the art style, but its mostly that doesn't clash or stands out to much in against its surroundings with its surroundings, this ones dont specially cus its a major resprite so it makes most of the most lavaland creatures look with a similar art style, on the note of the moves i will make actual change request a bit later today if i dont forget, but the ones where i think the old ones work better and feel more grounded as their original designs would be colossus and bg, new colossus looks to humanoid, it looses the aberration factor of his lanky arms and being slightly on the uncanny valley of looking humanoid but not enough, the new one just looks monstrous but more human for some reason, the new Bg looks to pink and the extra spikes and horns seems a bit to much for me so it reaches the overburdened mark, new drake i could go for both as both look good, tho i think the new one gets a lot more of an animal feel, that being said i do agree he looks less imposing due to being a lot closer to the ground, so they loose the imposing factor for more of an animal predating look, legion looks a bit goofy in the new look but only as at max integrity, after being divided it looks a lot more serious, for the normal fauna i like a lot the new goliaths, they look a lot more clear and readable, new tentacle also looks great, legions look good too tho i have to take a closer look at them, what im not a fan of is goldgrub and watchers, making them wider doesn't fit right with me and also watcher looks doesn't fully convince me, also people saying it looks ugly without a further argument on why it does will not be taken into account for my decision to approve/not approve

@Mqiib
Copy link
Contributor

Mqiib commented Apr 20, 2023

Herald kinda looks like just some kind of red gobliny demon dude, not a huge fan of that. Everything else looks cool though. Cuackles may not be a fan of the watchers but I like the new look tbh.

@Yarinoi
Copy link
Contributor

Yarinoi commented Apr 21, 2023

yeah no i think maybe lavaland could do with a resprite but not.. not these. no.

this wins an [EXTREMELY LOUD BUZZER]/10

@RG4ORDR
Copy link
Contributor

RG4ORDR commented Apr 22, 2023

These aren't bad.
But holy fuck they literally do not fit the art style at all, animated 2.5 sprites??

@Necrosium
Copy link
Contributor

I don't have a problem with those being added in at all, they look vivid imo

Copy link
Contributor

@MajManatee MajManatee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please document all of the other minor changes you made.

@neeshacark
Copy link
Contributor

they stick out a lot, but that's fine imo. the only ones i dislike are ash drake and colossus. colossus only because he has a gun???

i dont like the gat but hes cool besides

@tattax
Copy link
Contributor Author

tattax commented Jun 10, 2023

please document all of the other minor changes you made.

all the other changes are non player facing except for the legion one

and the other one just corrects some balloon alerts that were setup incorrectly

@Mqiib
Copy link
Contributor

Mqiib commented Jun 11, 2023

they stick out a lot, but that's fine imo. the only ones i dislike are ash drake and colossus. colossus only because he has a gun???

i dont like the gat but hes cool besides

The crusher trophy from the colossus is called "blast tubes" because its right arm is actually a bunch of barrels. Its arm IS a gun.
image

@ynot01 ynot01 added Stale I'm closing this in like a week if you don't push a new commit Purgatory pr limbo, Jamie look at this labels Jul 2, 2023
@ToasterBiome
Copy link
Contributor

reopen when cuackles does stuff on here

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix This fixes an issue. Please link issues in fix PRs Purgatory pr limbo, Jamie look at this Sprites This PR has spriting changes Stale I'm closing this in like a week if you don't push a new commit Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet