Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix status displays hard-del'ing #65026

Merged
merged 2 commits into from
Feb 21, 2022
Merged

Fix status displays hard-del'ing #65026

merged 2 commits into from
Feb 21, 2022

Conversation

Mothblocks
Copy link
Member

sd_parent had a reference holding onto it, which was not nulled.

The only reason this existed was to sd_parent.vis_contents -= src.

Destroy() already does this with vis_locs = null, so I removed the variable entirely.

Not tested, this is a web edit moment.

@Mothblocks Mothblocks added Fix Rewrites a bug so it appears in different circumstances Verified ✔️ Yeah, i'm a coder. What about it? Hard Deletes Whac-A-Mole with blackjack and cpu time labels Feb 19, 2022
@Mothblocks Mothblocks marked this pull request as draft February 20, 2022 00:03
@Mothblocks
Copy link
Member Author

My cleanup here doesn't make any sense since I removed the loc stuff, but why is this using New anyway? Needs to be moved to Initialize.

LemonInTheDark
LemonInTheDark reviewed Feb 20, 2022
View reviewed changes
code/game/machinery/status_display.dm Outdated
@@ -127,7 +127,9 @@
if(overlay)
qdel(overlay)

return new/obj/effect/overlay/status_display_text(src, line_y, message)
var/obj/effect/overlay/status_display_text/new_status_display_text = new/obj/effect/overlay/status_display_text(line_y, message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this syntax gives me hives

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point i didn't even notice i did that

@Mothblocks Mothblocks removed the Verified ✔️ Yeah, i'm a coder. What about it? label Feb 20, 2022
@Mothblocks Mothblocks marked this pull request as ready for review February 20, 2022 23:22
@AnturK AnturK merged commit 054d42a into master Feb 21, 2022
@AnturK AnturK deleted the fix-hard-del-with-status-displays branch February 21, 2022 20:42
github-actions bot added a commit that referenced this pull request Feb 21, 2022
@github-actions
Updating GBP balances for #65026
f7be5aa
@SkyratBot SkyratBot mentioned this pull request Feb 21, 2022
Merged
MassacreDemigirl added a commit to MassacreDemigirl/tgstation that referenced this pull request Feb 22, 2022
@MassacreDemigirl
Squashed commit of the following:
76c95b1 
commit 9dd5cf8
Author: Kyle Spier-Swenson <kyleshome@gmail.com>
Date:   Mon Feb 21 22:20:33 2022 -0800

    The mc now detects if its priority budget gets out of sync with reality and soft resets. (tgstation#64498)

    Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

commit 0ab7b8b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Feb 21 20:41:36 2022 -0800

    Automatic changelog generation for PR tgstation#64834 [ci skip]

commit 5863fe4
Author: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
Date:   Mon Feb 21 21:41:31 2022 -0700

    Fixes ody sleeper patient loc bugs (tgstation#64834)

commit cf3d101
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Feb 21 20:33:59 2022 -0800

    Automatic changelog generation for PR tgstation#64888 [ci skip]

commit 59bcead
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon Feb 21 20:33:55 2022 -0800

    Adds Ratfish to moisture traps. (tgstation#64888)

    * ratfish

    * ratfish

    * ratfish

    * ratfish

    * ratfish

commit 106136c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Feb 21 20:32:28 2022 -0800

    Automatic changelog generation for PR tgstation#64989 [ci skip]

commit 0191c80
Author: Wallem <66052067+Wallemations@users.noreply.github.com>
Date:   Mon Feb 21 23:32:24 2022 -0500

    Makes prisoners' heads a little warmer. (tgstation#64989)

    * D-BOYYYYSSSSSS

    * the rare experience of being experimented on

    * forgot a dot

    * flavor textttt

    * I learned something new today

    * I am still learning something new today

commit 4c1e960
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon Feb 21 18:12:55 2022 -0800

    Automatic changelog generation for PR tgstation#65051 [ci skip]

commit 686e29c
Author: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Date:   Mon Feb 21 21:12:44 2022 -0500

    Fixes ghosts orbit animations not being reliable for the no floating trait (tgstation#65051)

    Moved all the logic of adding the TRAIT_NO_FLOATING_ANIM to the orbiter component.

commit 396a065
Author: Changelogs <action@github.com>
Date:   Tue Feb 22 00:16:35 2022 +0000

    Automatic changelog compile [ci skip]

commit 054d42a
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Mon Feb 21 12:42:48 2022 -0800

    Fix status displays hard-del'ing (tgstation#65026)

    * Fix status displays hard-del'ing

    * Fix status displays hard dels, tested

commit 8d1fd5b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 21:48:18 2022 -0800

    Automatic changelog generation for PR tgstation#64900 [ci skip]

commit c953210
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Mon Feb 21 05:48:13 2022 +0000

    Resprites power cells, fixes and cleans up power cells and power cell derivatives (tgstation#64900)

    imageadd: Power cells and the cell charger have been resprited, the charger will now look correct with a much wider variety of non-standard power cells
    del: Removed the uncraftable 15k charge high-capacity power cell+, all instances have been replaced with the regular 10k charge high-capacity cell
    fix: Erroneous power cell charge indicators have been removed from many non-standard types of power cells
    fix: All varieties of marauder mech including the nuke ops mauler come with a bluespace power cell, consistent with other nuke op mechs
    fix: Power cell charge indicators will now update while in a cell charger
    fix: Potato and other crop batteries will not have their wires disappear when on cell chargers

commit 70bf65a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 21:32:16 2022 -0800

    Automatic changelog generation for PR tgstation#65014 [ci skip]

commit 93d7b5f
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Sun Feb 20 22:32:12 2022 -0700

    Fixes Area Turf Definition of The Courtroom on IceBoxStation (tgstation#65014)

    Fixes an incorrectly extended area of the courtroom on Icebox Station.

commit 44fbe26
Author: cake xensen <dan@xen.garden>
Date:   Mon Feb 21 05:31:18 2022 +0000

    Fix chainlink fence doors having incorrect icon/density (tgstation#64882)

    Fence doors used a var to track if they were opened or not, but it doesn't sync consistently with the density var. Density was getting set when updating icon state instead of when toggling the door. This removes the unneeded open var and flips density only during toggle.

commit 9540532
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 20:43:48 2022 -0800

    Automatic changelog generation for PR tgstation#65023 [ci skip]

commit ee3d306
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Mon Feb 21 01:43:45 2022 -0300

    Resprites The HoS Greatcoat (tgstation#65023)

    imageadd: Resprites the Head of Security Greatcoat!

commit 655a8bb
Author: Changelogs <action@github.com>
Date:   Mon Feb 21 00:18:17 2022 +0000

    Automatic changelog compile [ci skip]

commit 258618c
Author: Kyle Spier-Swenson <kyleshome@gmail.com>
Date:   Sun Feb 20 15:24:29 2022 -0800

    Make the repeated messages spam filter give a clearer warning (tgstation#65029)

    Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>

commit 3820c96
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sun Feb 20 15:08:53 2022 -0500

    edits the recent ruling from headcoders (tgstation#64977)

    About The Pull Request

    I found this out while reading through the contributing file today and thought I should change it before goof uses it as an excuse to label a ton of PRs again.
    For those unaware: https://github.com/orgs/tgstation/teams/issue-managers/discussions/10
    Why It's Good For The Game

    github thing, not a game one.
    Changelog

    Not needed.

commit 48069e0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 11:17:24 2022 -0800

    Automatic changelog generation for PR tgstation#64948 [ci skip]

commit a0eb411
Author: Toastgoats <63932673+Toastgoats@users.noreply.github.com>
Date:   Sun Feb 20 14:17:21 2022 -0500

    Space dragon resprite. (tgstation#64948)

    Changes the sprite of the space dragon

commit 6353879
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 10:25:49 2022 -0800

    Automatic changelog generation for PR tgstation#65000 [ci skip]

commit 01ff8af
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Sun Feb 20 19:25:45 2022 +0100

    adds allowed suit storage items to every modsuit theme (tgstation#65000)

    adds a list of allowed suit storage items to every modsuit, instead of every (other than loader and mining) having the default of a flashlight and internals tank

commit 5adc9ea
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sun Feb 20 01:23:22 2022 -0800

    Automatic changelog generation for PR tgstation#64909 [ci skip]

commit a6fca05
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Sun Feb 20 03:23:18 2022 -0600

    Fixes heretic target assignment, also adds a debug verb to help debug objectives and similar (tgstation#64909)

    Closes tgstation#64897

    This PR adds a new debug button to spawn in a bunch of human dummies, assign them to one of each station job, and add them to the manifest to simulate a "full crew" on a live server.

    This PR also fixes heretic target assignment. shuffle_inplace() doesn't return the list it shuffled, so the loops never functioned, and all targets were randomly picked instead of picked with the logic.

commit f37044a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 19:49:33 2022 -0800

    Automatic changelog generation for PR tgstation#65002 [ci skip]

commit 6e2296e
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Sun Feb 20 04:49:30 2022 +0100

    fixes arm implants breaking the drop key (tgstation#65002)

    fixes tgstation#65001 (Surgical Toolset Implants (possibly integrated toolset implants too?) cause the drop hotkey to stop working properly)

    The dropkey signal always gets called, even when the item isnt extended.
    Comsig_kb_activated cancels the key from being sent

    We were doing our check inside retract, but we always assumed the dropped item was us. bad

commit c56b1de
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 19:45:02 2022 -0800

    Automatic changelog generation for PR tgstation#65005 [ci skip]

commit 6287f40
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Sun Feb 20 04:44:59 2022 +0100

    fixes setting bound width/height to 0 breaking smooth movement for everyone (tgstation#65005)

    0 % 32 is 0, but byond cant have 0 width, it automatically switches to 1, breaking the game

commit 853fbc3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 19:43:47 2022 -0800

    Automatic changelog generation for PR tgstation#64929 [ci skip]

commit 753980d
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Sat Feb 19 21:43:44 2022 -0600

    Fixes the void Ritual of Knowledge + unit tests main path lengths  (tgstation#64929)

    Void ritual of knowledge should be of the void path. This fixes that.

    Also adds a unit test to ensure all main paths are of the same length.

    Funnily I think this was causing the main route calculations to be off, so the knowledge objective should be easier by one.

commit 5520ab0
Author: Changelogs <action@github.com>
Date:   Sun Feb 20 00:19:33 2022 +0000

    Automatic changelog compile [ci skip]

commit 1ca8ee4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 14:43:20 2022 -0800

    Automatic changelog generation for PR tgstation#64994 [ci skip]

commit 9e8b179
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Sat Feb 19 17:43:15 2022 -0500

    Changes asay ping sound (tgstation#64994)

commit d19680e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 14:33:21 2022 -0800

    Automatic changelog generation for PR tgstation#64716 [ci skip]

commit 681f00b
Author: Mickyan <38563876+Mickyan@users.noreply.github.com>
Date:   Sat Feb 19 23:33:18 2022 +0100

    Adds Moth Fashion (tgstation#64716)

    * Adds two suits and one hat based on moth lore and culture, available at the clothesmate. They are set up with GAGS and can be freely recolored
    * Adds one curator bundle based on construction, themed after moth engineers. It gives a few tools, materials, and a suit with hidden pockets

commit e4043e7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 12:35:10 2022 -0800

    Automatic changelog generation for PR tgstation#64969 [ci skip]

commit 7cde416
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sat Feb 19 15:35:06 2022 -0500

    removes paramed cargo/aux base/engine/EVA access, adds mining access instead (tgstation#64969)

commit 9a28306
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 12:34:50 2022 -0800

    Automatic changelog generation for PR tgstation#64973 [ci skip]

commit 7ccdd83
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Sat Feb 19 20:34:47 2022 +0000

    The CRAB-17 is now indestructible, but it's waaaaaay easier to swipe your ID card (tgstation#64973)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit 2a8c904
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 08:10:43 2022 -0800

    Automatic changelog generation for PR tgstation#64984 [ci skip]

commit 7c70c68
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Sat Feb 19 09:10:32 2022 -0700

    Fixes IceBoxStation's Secure Tech Storage (tgstation#64984)

commit 14a37b1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 08:00:58 2022 -0800

    Automatic changelog generation for PR tgstation#64953 [ci skip]

commit 14022a7
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Sat Feb 19 09:00:51 2022 -0700

    The Science Lobby; Or, How I Learned To Embrace Congruence. (tgstation#64953)

commit e7210a2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 02:39:38 2022 -0800

    Automatic changelog generation for PR tgstation#64874 [ci skip]

commit 11e9899
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date:   Sat Feb 19 02:39:35 2022 -0800

    Malf AIs and Combat-Upgraded AIs can now use the borg console to detonate borgs (again). (tgstation#64874)

    Allows Malf/Combat AIs to detonate borgs, to fulfill their various goals. Non-emagged borgs will leave a possibly angry and vengeful brain behind.
    This was removed when the robotics console was reworked a bit ago, with the assumption that Malf AIs could use Machine Overload to accomplish the same task. This is incorrect (and also, having to use 20 malfbux to get rid of a borg that's braindead or sloppy enough to reveal you is lame). So we re-add this one thing.

commit 658863b
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Sat Feb 19 05:35:55 2022 -0500

    Adds bitflag defs for flags_inv (tgstation#64993)

    Simple little PR that adds bitflag defs for the flags_inv var on /obj/item, so editing it in VV shows you the values as a toggle instead of the raw number.

commit 36bedd0
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sat Feb 19 03:50:09 2022 -0500

    facehugger slight code improvement + logs facehuggers (tgstation#64976)

    * facehugger slight code improvement + logs facehuggers

    * Updates dumb comment that shouldn’t exist

commit b8d25b3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat Feb 19 00:49:11 2022 -0800

    Automatic changelog generation for PR tgstation#64982 [ci skip]

commit 4a84334
Author: Tastyfish <crazychris32@gmail.com>
Date:   Sat Feb 19 03:49:04 2022 -0500

    Makes air alarm and keycard authenticator emissive (tgstation#64982)

    * emissive air alarm

    * Makes keycard authentication emissive

    * tweak keycard blink sprite

commit 1d8bbb7
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sat Feb 19 02:14:04 2022 -0500

    greentext code improvement (tgstation#64941)

commit 020af10
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Fri Feb 18 23:06:43 2022 -0800

    add 49 titanium sheets to the BYOS (tgstation#64990)

commit 7ee5ed9
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date:   Sat Feb 19 06:31:18 2022 +0100

    Move most mecha actions to their respective mech files (tgstation#64918)

commit 41ae850
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 21:28:20 2022 -0800

    Automatic changelog generation for PR tgstation#64986 [ci skip]

commit 2209c36
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Fri Feb 18 22:28:17 2022 -0700

    Fixes Weird Area Definition on DeltaStation (tgstation#64986)

    So, there I was. Pondering the blobbosity of Auxiliary Base Construction. Deciphering and unclothing the issue in my mind in order to better comphrehend it. I was there for a few moments, until this ugly beast of a fucking area definition caught my eye:

    Hideous. Repugnant. I was relishing the thought of dissecting Auxiliary Base Construction into fifteen million more areas (it _will_ lessen obtusities) when that scraggletooth of an utterly mortifying error forced me into a visceral rage: the likes of which have never been experienced on this planet Earth.

commit f13061f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 21:26:40 2022 -0800

    Automatic changelog generation for PR tgstation#64983 [ci skip]

commit 3a0a8d4
Author: Tastyfish <crazychris32@gmail.com>
Date:   Sat Feb 19 00:26:36 2022 -0500

    Fixes windoor access to Delta Station's ORM (tgstation#64983)

commit 32a0138
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 21:19:16 2022 -0800

    Automatic changelog generation for PR tgstation#64928 [ci skip]

commit 324f98c
Author: Watermelon914 <37270891+Watermelon914@users.noreply.github.com>
Date:   Sat Feb 19 05:19:12 2022 +0000

    Fixed progression traitor uplinks suddenly changing owners (tgstation#64928)

    They could change if someone implanted themselves with an uplink from an uplink that didn't belong to them.

commit 6332561
Author: Changelogs <action@github.com>
Date:   Sat Feb 19 00:18:33 2022 +0000

    Automatic changelog compile [ci skip]

commit a8e4b67
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 15:59:04 2022 -0800

    Automatic changelog generation for PR tgstation#64848 [ci skip]

commit 51e1a82
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Fri Feb 18 16:58:55 2022 -0700

    Science Breakroom Area Turf Spriting (tgstation#64848)

    imageadd: Science Breakroom now has a new area turf sprite

commit 52e2881
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 15:04:10 2022 -0800

    Automatic changelog generation for PR tgstation#64765 [ci skip]

commit 1f657ca
Author: death and coding <58394696+thestubborn@users.noreply.github.com>
Date:   Fri Feb 18 23:04:07 2022 +0000

    Gives the Saints Suit Cold Protection (tgstation#64765)

commit 065dca7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 15:01:46 2022 -0800

    Automatic changelog generation for PR tgstation#64960 [ci skip]

commit a3a01cd
Author: Wallem <66052067+Wallemations@users.noreply.github.com>
Date:   Fri Feb 18 18:01:42 2022 -0500

    Sign Language in space & cuffs fix (tgstation#64960)

    One normally can't talk in space because pressure is too low to move sound far, but since sign language is visual that doesn't matter for them.
    Also, apparently being cuffed makes your hands blocked so I had to move it up a little

commit f1fffeb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 15:00:36 2022 -0800

    Automatic changelog generation for PR tgstation#64974 [ci skip]

commit 1d65a29
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri Feb 18 18:00:32 2022 -0500

    Icebox surgery room requires surgery access (tgstation#64974)

commit 8a0bb2d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 15:00:14 2022 -0800

    Automatic changelog generation for PR tgstation#64979 [ci skip]

commit ad94ca9
Author: Tim <timothymtorres@gmail.com>
Date:   Fri Feb 18 17:00:10 2022 -0600

    Fix cigarettes icons not updating properly (tgstation#64979)

commit e2bab69
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 01:06:16 2022 -0800

    Automatic changelog generation for PR tgstation#64954 [ci skip]

commit 8fb928b
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Fri Feb 18 03:06:11 2022 -0600

    Adds some contextual screentips to botany related things (tgstation#64954)

commit 9d49380
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 01:03:51 2022 -0800

    Automatic changelog generation for PR tgstation#64895 [ci skip]

commit f9428e0
Author: Timberpoes <silent_insomnia_pp@hotmail.co.uk>
Date:   Fri Feb 18 09:03:47 2022 +0000

    Fix BYOND-related runtime in SDQL2 _new wrapper (tgstation#64895)

commit 86dfb85
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 01:02:51 2022 -0800

    Automatic changelog generation for PR tgstation#64881 [ci skip]

commit 71fdc5d
Author: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Date:   Fri Feb 18 04:02:48 2022 -0500

    Replaces the Brimdemon laser sound. (tgstation#64881)

commit 49fa2f1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 01:02:03 2022 -0800

    Automatic changelog generation for PR tgstation#64858 [ci skip]

commit d9df0b6
Author: Tastyfish <crazychris32@gmail.com>
Date:   Fri Feb 18 04:01:59 2022 -0500

    backlit newscaster, status display, request console. status display refactor to newer overlay system (tgstation#64858)

commit 36f4395
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Fri Feb 18 04:00:44 2022 -0500

    replaces uses_integrity with just setting a very high integrity (tgstation#64873)

commit 5e07306
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 00:49:09 2022 -0800

    Automatic changelog generation for PR tgstation#64949 [ci skip]

commit 214e99f
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date:   Fri Feb 18 00:49:06 2022 -0800

    Makes extinguisher sprays look nicer (tgstation#64949)

    Rather then sticking around till their 7 second delay, they dissipate
    once they finish their movement. This dissipation comes with a fading
    and such to make things look nicer.

    I've applied the fading behavior to sprays too, since they could also
    use the help.

    I really hate how things look currently, makes me break out in hives

commit a7278fb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 00:48:23 2022 -0800

    Automatic changelog generation for PR tgstation#64962 [ci skip]

commit ab653bf
Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Date:   Fri Feb 18 00:48:20 2022 -0800

    Fixes Orion Trail reloading static data (tgstation#64962)

commit c86ed7c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri Feb 18 00:47:24 2022 -0800

    Automatic changelog generation for PR tgstation#64971 [ci skip]

commit f4caefe
Author: Vire <66576896+Maurukas@users.noreply.github.com>
Date:   Fri Feb 18 01:47:19 2022 -0700

    Adds a modsuit to Kilo medbay (tgstation#64971)

commit 3520383
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri Feb 18 03:46:54 2022 -0500

    tramstation surgery requires surgery access (tgstation#64972)

commit 588faf5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 23:05:43 2022 -0800

    Automatic changelog generation for PR tgstation#64783 [ci skip]

commit 4ed169b
Author: Ghom <42542238+Ghommie@users.noreply.github.com>
Date:   Fri Feb 18 08:05:37 2022 +0100

    Fixes an issue with station pets and the multiple_lives component (tgstation#64783)

    * Fixes an issue with the multiple_lives component

    * Ah yes, suicide cases.

    * rephrases a sentence

commit abc13fb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 21:39:46 2022 -0800

    Automatic changelog generation for PR tgstation#64964 [ci skip]

commit fb757da
Author: ArcaneDefence <51932756+ArcaneDefence@users.noreply.github.com>
Date:   Thu Feb 17 22:39:43 2022 -0700

    Puts the kinetic crusher's projectile firing on rmb (tgstation#64964)

    * Puts crusher projectile firing on rmb

    * Ranged proc melee click cooldown

    * Implements code review

    * implements further code review

commit 7ffafc3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 21:38:28 2022 -0800

    Automatic changelog generation for PR tgstation#64966 [ci skip]

commit d656be0
Author: SMOSMOSMOSMOSMO <95004236+SmoSmoSmoSmok@users.noreply.github.com>
Date:   Fri Feb 18 07:38:25 2022 +0200

    Fixes clownborg soap (tgstation#64966)

commit 3213e90
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 17:47:25 2022 -0800

    Automatic changelog generation for PR tgstation#64959 [ci skip]

commit 1b8c60d
Author: MMMiracles <lolaccount1@hotmail.com>
Date:   Thu Feb 17 20:47:22 2022 -0500

    meta atmos apc + kilo bar apc (tgstation#64959)

commit b4d5db8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 17:39:10 2022 -0800

    Automatic changelog generation for PR tgstation#64957 [ci skip]

commit 18b31ee
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Thu Feb 17 18:39:07 2022 -0700

    Fixes Area Definitions on KiloStation Engineering (tgstation#64957)

commit 24fd5c6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 17:37:47 2022 -0800

    Automatic changelog generation for PR tgstation#64946 [ci skip]

commit ed32e99
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Thu Feb 17 18:37:44 2022 -0700

    Fixes IceBox Station Surface Ruin Snow (tgstation#64946)

    This is an extension of my other PR that hacked together a solution to fixing snow on the surface of IceBox.

    I forgot ruins were a thing, so this is just an extension pass that fixes all of those.

commit 75e7f80
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 17:36:49 2022 -0800

    Automatic changelog generation for PR tgstation#64937 [ci skip]

commit d9df307
Author: Tim <timothymtorres@gmail.com>
Date:   Thu Feb 17 19:36:45 2022 -0600

    Add wizoff and tarot card deck to wizard ship (tgstation#64937)

    * Add wizoff to wizard ship

    * Add tarot card deck to wiz shuttle

commit 2180508
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 17:35:42 2022 -0800

    Automatic changelog generation for PR tgstation#64908 [ci skip]

commit 11e56d1
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Thu Feb 17 18:35:37 2022 -0700

    Fixes the AI Upload Chamber's Surrounding on KiloStation (tgstation#64908)

commit 1ac5d04
Author: Changelogs <action@github.com>
Date:   Fri Feb 18 00:16:31 2022 +0000

    Automatic changelog compile [ci skip]

commit a9ab43c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 14:08:33 2022 -0800

    Automatic changelog generation for PR tgstation#64889 [ci skip]

commit e9b28a2
Author: Wallem <66052067+Wallemations@users.noreply.github.com>
Date:   Thu Feb 17 17:08:30 2022 -0500

    Adds colored stripes to departmental protolathes/techfabs (tgstation#64889)

    Gives protolathes/techfabs colored stripes to make it easier to tell them apart if they're moved for whatever reason.

commit 8092f89
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 12:38:11 2022 -0800

    Automatic changelog generation for PR tgstation#64864 [ci skip]

commit aa520b5
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Thu Feb 17 14:38:07 2022 -0600

    Refactors anomanly neutralizer to use the effect remover component (tgstation#64864)

    Anomalies are effects, effect remover is made to remove effects, might as well make use of it?

    Also makes some cool sparks around it now so that's neat

commit 0629259
Author: alphanerdd <60521518+alphanerdd@users.noreply.github.com>
Date:   Thu Feb 17 13:52:11 2022 -0500

    fixes silhouette (tgstation#64855)

    Fixes visual of empty mod control slot in SSUs

commit 9b5dac7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 10:51:01 2022 -0800

    Automatic changelog generation for PR tgstation#64885 [ci skip]

commit 844b7ac
Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Date:   Thu Feb 17 10:50:50 2022 -0800

    fixes resizing (tgstation#64885)

commit b7f7d72
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu Feb 17 00:04:18 2022 -0800

    Automatic changelog generation for PR tgstation#64790 [ci skip]

commit 7b1132f
Author: san7890 <34697715+san7890@users.noreply.github.com>
Date:   Thu Feb 17 01:04:15 2022 -0700

    Variety of Area Turf Sprite Fixes (tgstation#64790)

    imageadd: Cytology Lab and two different variations of the Central Hall have had their sprites corrected

commit 7c26cb6
Author: Changelogs <action@github.com>
Date:   Thu Feb 17 00:13:46 2022 +0000

    Automatic changelog compile [ci skip]

commit 1577991
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Feb 16 15:54:19 2022 -0800

    Automatic changelog generation for PR tgstation#64854 [ci skip]

commit bf1a351
Author: TemporalOroboros <TemporalOroboros@gmail.com>
Date:   Wed Feb 16 15:54:13 2022 -0800

    Fixes gunpowder and teslium explosion scaling. (tgstation#64854)

    At some point chemical reaction explosions were moved to their own handler proc and gunpowder and teslium were changed to use timers instead of sleeps.
    It turns out that whoever did one of them forgot to pass the relevant explosion scaling arguments.
    As a result both gunpowder and teslium were using the default 0 + [V/10] power.
    This makes them actually pass the scaling args as intended.

commit adc0694
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Feb 16 15:40:15 2022 -0800

    Automatic changelog generation for PR tgstation#64856 [ci skip]

commit a0a33d3
Author: Doctor Pope <84367152+Dr-Pope@users.noreply.github.com>
Date:   Wed Feb 16 18:40:12 2022 -0500

    Changes Loader Mod core text to include "non-airtight" (tgstation#64856)

    Changes the Loader modcore text to better explain that it is not airtight or a sealed environment.

commit 2fe4b49
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Feb 16 13:01:16 2022 -0800

    Automatic changelog generation for PR tgstation#64934 [ci skip]

commit 79963a0
Author: Cursed <47064429+Amrabol@users.noreply.github.com>
Date:   Wed Feb 16 22:01:12 2022 +0100

    Pepper spray module for sec modsuits, Atmos resin module and nukie pyro bundle flamethrower made into module (tgstation#64934)

    Pyro bundle was broken as when you brought it you would get modsuit and pyro backpack forcing you to either use armor or use backpack without fire protection(which modsuit has). Thanks to Fikou work it became a module
    Anti-Tider on the other hand is rarely used(i have never seen it used when i was playing sec or observing) and needed a little buff so now it will also became a module while i will make normal Anti-Tider stream wider(still working on it).

commit 8d82556
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Feb 16 11:35:17 2022 -0800

    Automatic changelog generation for PR tgstation#64926 [ci skip]

commit f6aec6c
Author: Josh <Josh.Powell@softwire.com>
Date:   Wed Feb 16 19:35:12 2022 +0000

    Mobs on CentCom will not be selected as valentines. (tgstation#64926)

    * No love at centcom

    * Okay, nuke ops can have a little valentines

commit ce75f44
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed Feb 16 11:34:59 2022 -0800

    Automatic changelog generation for PR tgstation#64932 [ci skip]

commit 961e710
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Wed Feb 16 13:34:55 2022 -0600

    admin completion counts for heretic objectives (tgstation#64932)
@Tsar-Salat Tsar-Salat mentioned this pull request Apr 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LemonInTheDark LemonInTheDark LemonInTheDark left review comments

Assignees
No one assigned
Labels
Fix Rewrites a bug so it appears in different circumstances Hard Deletes Whac-A-Mole with blackjack and cpu time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mothblocks @LemonInTheDark @AnturK