Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob mobs use astar/jps for automated movement pathing, no longer get blocked by blob tiles #65598

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

MrStonedOne
Copy link
Member

@MrStonedOne MrStonedOne commented Mar 21, 2022

I could easily make all hostile mobs do this, but there are concerns. behavior isn't the same, performance would be bad, requires more careful testing.

Whereas overriding this just for blobs fixes a mob that is functionally broken right now as they think they can't cross blob tiles because they use byond's walk_to and that checks density

🆑
fix: blob spores and game-controlled blobbernuts no longer get stuck thinking they can't walk thru blob tiles. This has been broken for over a year and so you should expect blob spores to be more of a threat then you are used to.
/:cl:

fixes #56742

… blocked by blob mobs

I could easily make all hostile mobs do this, but there are *concerns*. behavior isn't the same, performance would be bad, requires more careful testing.

Where as overriding this just for blobs fixes a mob that is functionally broken right now as they think they can't cross blob tiles because they use byond's walk_to and that checks density
@tgstation-server tgstation-server added the Fix Rewrites a bug so it appears in different circumstances label Mar 21, 2022
@MrStonedOne
Copy link
Member Author

MrStonedOne commented Mar 21, 2022

as an aside, you know how blob spores zombify bodies. Well they are now like 5 lines away from being able to open doors using said body's id.

@MrStonedOne MrStonedOne changed the title Blob mobs use astar/jps for automated movement pathing, no longer get blocked by blob mobs Blob mobs use astar/jps for automated movement pathing, no longer get blocked by blob tiles Mar 21, 2022
@bruhlookatthisdood
Copy link

as an aside, you know how blob spores zombify bodies. Well they are now like 5 lines away from being able to open doors using said body's id.

do it

@MrStonedOne
Copy link
Member Author

maybe in another pr after this one gets merged.

@wraith-54321
Copy link

finally, now spores will be usable again

@ShizCalev ShizCalev merged commit e352d60 into tgstation:master Mar 22, 2022
@ShizCalev
Copy link
Member

Looking forward to them opening doors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob Spores don't rally
5 participants