Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced tools are medium sized, toolboxes can carry medium sized items. #66900

Merged

Conversation

GuillaumePrata
Copy link
Contributor

@GuillaumePrata GuillaumePrata commented May 11, 2022

About The Pull Request

Makes the tier 2 tools be Medium sized instead of Small.
To be clear, this doesn't affect them being carried inside belts in any way.

The toolboxes were literally a reskinned box that did more damage while being bulky.
A box was better at carrying tools than a toolbox... letting them carry medium sized items should shift that around cleanly.

Heirloom toolbox doesn't get the buff to carry size since they can be carried inside a bag.

Why It's Good For The Game

Oh boye here comes a long Item Economy talk sponsored by "Being sick and doing something "meaningful" as distraction"!

We have multiple ways to balance an Item "desirability" and I feel the advanced tools score too high on that field.
But lets explain that "desirability" properly first, it would be some weird equation between intended use/effectiveness, cost to acquire and cost to use.

  • 1: Intended use/effectiveness is a giant can of worms and different for each item but I'm sure you get it's core.
  • 2: Cost of acquiring on SS13 is a few things, material cost, research cost, credit cost to purchase, time to acquire AKA asking/stealing/just walking to a vending machine, etc.
  • 3: Cost to use would be energy/ammo, cooldowns, limited use/replacing, weight to carry, etc.

Now let's look at the Tier 2 tools and... Most of them don't have a cost that the end user actually cares about, so they are meaningless to them...

  • Intended use... they score high on that, print 30 jaws of life/laser saws and put them outside the bar, see how quickly they get grabbed by people. It's pseudo AA or a 17 force sharp weapon that goes into your pocket.
  • Material cost is something that miners deal with, research is with science, lathe tax to print is too small.
  • They don't use energy/ammo, have no cooldown, don't degrade...

So what the end user has to deal with is their weight... Which is basically nothing since you can carry 49 of them in a bag at the moment. No one is making the hard decision of "To carry or not to carry?" a Jaws of Life in a round, they just do it.

With this change, going for an upgraded tier 2 tool won't be an 100% improvement for everyone at every time and instead a choice that you have to make and will change from round to round. You might have room to keep a laser saw for self defense in a shift and opt to throw it away for a baton in another instead of just keeping the baton AND the laser saw inside your box.

Why It's Good For The Game not a wall of text edition:

The current version of these items is something that 99% of the players would opt in to grab every shift if they can.

All upsides with no downsides is bad design, encouraging the players to make the choice of grabbing tools or not makes more interesting rounds when something go wrong and they think: "I'm glad I sacrificed some inventory space for this jaw, it saved my life." or "I should have grabbed a Jaw, I wouldn't have died if I did." instead of every round being "Hahaha Jaws go brrrrr!"

Changelog

🆑 Guillaume Prata
balance: Tier 2 tools (Jaws of life/Laser scalpel/Experimental welder) are changed from Small to Medium sized so now you can't carry 49 Jaws of life in your backpack.
/:cl:

@tgstation-server tgstation-server added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label May 11, 2022
@TemporalOroboros
Copy link
Contributor

Will this still permit a full toolset in the relevant belt/a toolbox?

@GuillaumePrata
Copy link
Contributor Author

Will this still permit a full toolset in the relevant belt/a toolbox?

It won't affect toolbelts but it will affect toolboxes as they are a generic box basically.

@Gandalf2k15
Copy link
Contributor

Toolboxes should probably be able to hold powertools

@GuillaumePrata
Copy link
Contributor Author

GuillaumePrata commented May 11, 2022

Toolboxes should probably be able to hold powertools

They are just reskined boxes code wise at the moment, if they should be buffed to carry medium sized items or just eng gear like toolbelts do it should be in another PR defending reasons to do that.

I do think it would be a nice change tho.

@kopoba
Copy link
Contributor

kopoba commented May 11, 2022

I read this request 3 times and still don't understand why its good for the game. Can you say it more simple way without wall of text please.

@GuillaumePrata
Copy link
Contributor Author

I read this request 3 times and still don't understand why its good for the game. Can you say it more simple way without wall of text please.

Fucking fair point and I will fix that lol

@D4C-420
Copy link
Contributor

D4C-420 commented May 11, 2022

This looks like it affects the nukies version of the jaws of life. Given how much nukies already carry I don't think that their jaws of life should be made larger .
Also this will just lead to people finding and grabbing belts to carry advanced tools instead.

@GuillaumePrata
Copy link
Contributor Author

This looks like it affects the nukies version of the jaws of life. Given how much nukies already carry I don't think that their jaws of life should be made larger .

Good point on the nukies, I will fix that.

Also this will just lead to people finding and grabbing belts to carry advanced tools instead.

You can't print 30 toolbelts from a lathe so I don't see this as an issue for this case specifically.
The belt has it's own pros/cons and price to acquire.

@ilikesaying
Copy link

You can't print 30 toolbelts from a lathe so I don't see this as an issue for this case specifically. The belt has it's own pros/cons and price to acquire.

Public Botany

@GuillaumePrata
Copy link
Contributor Author

Public Botany

If people want to spend a few minutes growing toolbelts at public botany, power to them.
Even with a toolbelt you are still forcing yourself to carry a medium sized item (the toolbelt) instead of a small sized item inside a box so the goal still is achieved either way.

@private-tristan
Copy link
Contributor

medical nerf :(
can no longer jam my gamer gear into my medkit and still have some stuff in there

@GuillaumePrata
Copy link
Contributor Author

medical nerf :(
can no longer jam my gamer gear into my medkit and still have some stuff in there

It actually won't affect them (as much) because they work like toolbelts and have an allowed list.

@Shadowflame909
Copy link
Contributor

Is this actually a problem? The only one with jaws of life are usually just the CE/Engi.

With multiple ways of getting into a department, by the time this is printable. Someone going around jaws of lifing doors shouldn't be an issue, because the shift should be either extended lite. Or on the verge of destruction and its necessary to have such power-tools.

@GuillaumePrata
Copy link
Contributor Author

GuillaumePrata commented May 12, 2022

Is this actually a problem? The only one with jaws of life are usually just the CE/Engi.
With multiple ways of getting into a department, by the time this is printable. Someone going around jaws of lifing doors shouldn't be an issue, because the shift should be either extended lite. Or on the verge of destruction and its necessary to have such power-tools.

This has nothing to do with to goal of the PR, tools are meant to be used and if people are using Jaws of life and others to survive/make their lives easier, they are working as intended.
If making less people use it was the goal, a PR making them harder to unlock/print or bulky sized would be the right move.
This PR was made to push a decision into the end player, if they will "spend" a slice of their inventory that is more in line with the power of those tools.

@Palpetinus
Copy link

I don't really understand. Why can't an upgrade just be an upgrade? Why do upgrades need drawbacks for some reason?
What's the drawback (after printing etc.) of t4 stock parts? Crew Pinpointer over Proximity Crew Pinpointer? BS Body Bag? Advanced Health Analyzer? To go further, advanced wound tending surgeries are also just upgrades without drawbacks. Advanced Plasmacutter? Mining Satchel of Holding?

They're time gated, cost more resources, need Sci to cooperate, need Mining to not sit on its hands this shift and after all that.. they're not even just upgrades anymore, but tradeoffs? Weird, definitely leaves a sour taste in my mouth just thinking about it.

@GuillaumePrata
Copy link
Contributor Author

GuillaumePrata commented May 12, 2022

I don't really understand. Why can't an upgrade just be an upgrade?

You are missing the point of the PR, most of your examples are useful only for 1 department.
They aren't something that 99% of the players would want to have on them all the time so there is a decision making into opting to carry an advanced plasma cutter/crew pinpointer/BS bodybag. "Will this help me this round?"
There is no decision making on a Jaws/Laser saw, they are too valuable for anyone that can get one regardless of job.

@Palpetinus
Copy link

they are too valuable for anyone that can get one regardless of job

They are valuable because they can fit into boxes easily. Nobody will take a laser scalpel anymore for 17 force, they'll take a saw for 15 because it's easy to get or a spear for 18-20 instead. I already see them used very rarely because it still needs people to tide into medbay, hope the research is done and hope the miners actually mined.
Jaws of Life are just a tool for convenience, hacking and knowing which wire to pulse is de facto faster than the jaws, so jaws are just noob bait anyway
And all of this doesn't even address the rest: I get the scalpel for force or jaws for convenience, but the hand drill? Nobody would ever get a tool over just a box with two tools and 5 spare spaces. Same with the experimental welding tool, sure it's infinite but in its place I could just carry an industrial welding tool and have - again - 6 spare spaces for other small items. I could go on.
All this PR will ultimately do is punish players that later into the round just want to help where they can by storing a full set of tools in boxes and helping out other departments.
You're seeing a problem where there is only one on paper by just comparing a few items in a vacuum, instead of seeing the full picture. Besides Jaws - which arguably could be normal, that one I agree on - none of the advanced tools are used by people outside of the department, unless they specifically want to fill that department's role.

I suppose if this goes through, I'll have to roundstart tide the departments for belts (one of which is very limited). Oh well.

@Pickle-Coding
Copy link
Contributor

Pickle-Coding commented May 12, 2022

The problem is everyone can get every tool easily and fit them into their storages easily, then be able to do everything. Hopefully toolbelts are bulky one day, because it's really cringe seeing a security officer with a full set of engineering and medical tools fit into their bag.

Just because something is convenient, doesn't mean it's good for the game. Sometimes you shouldn't be able to get everything with no cost, and it would be better if people had to make choices if they wanted to powergame with their tools, instead of fitting an entire workshop and hospital in their bag.

I don't want to argue in someone else's PR, so I'll leave it at that.

@GuillaumePrata
Copy link
Contributor Author

They are valuable because they can fit into boxes easily.

Thanks for defending my PR.

@Palpetinus
Copy link

Thanks for defending my PR.

Sooo.. you're just trying to make some tools near useless? Weird. I don't see how this positively adds to the game, or ever could.

@SkeletalElite
Copy link
Contributor

SkeletalElite commented May 12, 2022

So your logical conclusion to the problem that the Jaws of Life are overpowered ("psuedo all access") is to nerf every power tool so hard that the jaws of life are the only one anyone who doesn't have a toolbelt will even consider carrying?

The experimental welder and the hand drill will literally never be used unless the person has a toolbelt, they have minor benefits, but they are not worth the lost space at all.

Your entire "why its good for the game" literally only mentions the jaws of life

@wesoda25
Copy link
Contributor

Being able to load boxes with essential gear (and then fill your bag with many of those) is stupid and will undoubtedly be nerfed one day.

@JohnFulpWillard
Copy link
Member

What's the drawback (after printing etc.) of t4 stock parts?

The higher parts in a machine, the more power it needs to run, it was part of Ghilker's power rebalancing.
It seems like after we learned our lesson, recent PRs actually DO give drawbacks to lategame stuff, rather than just being 'thing but better in every single way with no downsides'.

@LemonInTheDark
Copy link
Member

I've been kinda tempted to up normal tool sizes, this is chill tho

@GuillaumePrata
Copy link
Contributor Author

If the material and research costs are really negligible, then we can take those out as part of this change, right?

Feel free to make that PR if you think so because again, that isn't exactly what I said but at least it has been quite funny to talk here to be fucking honest.

@Pandarsenic
Copy link
Contributor

Pandarsenic commented May 13, 2022

If the material and research costs are really negligible, then we can take those out as part of this change, right?

Feel free to make that PR if you think so because again, that isn't exactly what I said but at least it has been quite funny to talk here to be fucking honest.

Material cost is something that miners deal with, research is with science, lathe tax to print is too small.

If the item is being balanced around the end user not caring about those costs, then the irrelevant costs should be removed so that lacking miners, R&D focusing on other branches of research, etc., doesn't become a burden on the end user, no?

Because, sure, I've thought that maybe Jaws of Life should be larger, not for balance reasons but for fluff reasons (their IRL size and their SS13 ability to force open an airlock that can fit a mech through it). But if they're being bigger primarily because minerals and research aren't a concern, why not just make the mineral costs not be a thing, or make it titanium only so someone sufficiently determined can disassemble a pod's walls for it if there are no miners around?? Or move the doorjack function to, say, a power cell or gas tank stored in the Jaws?

(Also, re: Welder/LaserScalpsaw as weapons, I would posit that they're only so desirable because so many things have been nerfed so aggressively that anything reaching even basic combat efficacy is desirable. Few items you can obtain have the force of the laser scalpsaw, at ANY size--there's just a general lack of anything in the force bracket between the T1 Saw/Drill/Cleaver and the spear variants. The experimental welding tool isn't even significantly better as a weapon than the basic welding tool, with fuel basically never being a serious limiting factor in a fight between carbons. If there is a problem to address there, it's a lack of real weapons in the crew's hands and dangerous antag alternatives, not the size of the improved surgical tools.)

@CMDR-Gungnir
Copy link
Contributor

Why can't an upgrade just be an upgrade?

@Orchian
Copy link
Contributor

Orchian commented May 13, 2022

I don't quite agree with enlarging the majority of the T2 tools. However, I see no issue with enlarging the T2 welder. I think you should go further with the Jaws (Large perhaps?), and I feel that it'd be better to nerf the laser scalpel by making it require batteries as opposed to increasing its size

@Palpetinus
Copy link

I find it funny how you keep contradicting yourself in circles

>They are desirable for the crew because they are good weapons
>But I am not considering them as weapons, but tools
>Despite this, I will still nerf them because they are good weapons

So what is it now, are you nerfing them because they are good weapons or do you not want to consider them weapons? You can't have both. Literally, in the same comment, you say "everyone gets them for combat" and "not everything revolves around combat". You're contradicting yourself here.

@Miczu555PL
Copy link

Miczu555PL commented May 13, 2022

They are valuable because they can fit into boxes easily.

Thanks for defending my PR.

I disagree that this statement defends your PR.

I mean they are more valued BECAUSE they are UPGRADE? Making them take more space literally nullfies that upgrade. And WHY would that be changed?

And yes, nearly everyone wants to powergame one jaws for themselves, because no one likes to die to atmos issues due to lack of airlock access or lack of three separate tools. (tiding aside) That's cringe.

Any more uses for the Jaws?

@GuillaumePrata
Copy link
Contributor Author

GuillaumePrata commented May 13, 2022

I find it funny how you keep contradicting yourself in circles...

No, you just keep bending what I say because you want to win the internet argument but let's go over what you say as "my quotes" again:

Scarecrow Guillaume: They are desirable for the crew because they are good weapons

This is a fact and I agree.

Scarecrow Guillaume: But I am not considering them as weapons, but tools

This is wrong, I said I'm not balancing them around their weapon values as it was suggested to nerf their damage because I like when crew uses job specific weapons to fight instead of stealing the almighty baton.

Scarecrow Guillaume: Despite this, I will still nerf them because they are good weapons

Wrong again, I said it pretty cleanly, the change is good because they are a desirable item for everyone regardless of their job.

So what is it now, are you nerfing them because they are good weapons or do you not want to consider them weapons? You can't have both. Literally, in the same comment, you say "everyone gets them for combat" and "not everything revolves around combat". You're contradicting yourself here.

"Everyone gets them for combat" and "Not everything in the game revolves around combat" are both correct and I don't see why you can't understand it.
Again, I'm rebalancing them because they are an item that everyone would have on every shift if they can opt in.

When Ghilker nerfed the Insuls (another desirable item by 99% of the crew) by giving them chonky fingers... do you think that instead they should have nerfed it's item slap damage?
Oh no... they should have nerfed it's shock resistance because that is what everyone uses it for by your logic and then everyone would suffer, including the engineers that use it for their job.

@Palpetinus
Copy link

because they are a desirable item for everyone regardless of their job

"Everyone gets them for combat" and "Not everything in the game revolves around combat" are both correct and I don't see why you can't understand it.

Wrong. People who simply do not care about combat will also not care about laser scalpels and such. I'd say that on the MRP servers, the majority doesn't care much about combat and on LRP, still about half the crew doesn't. I know there's this meme that every player is just a validhunter waiting to valid someone, but that's clearly just another case of the loud minority being noticed the most.

they are an item that everyone would have on every shift if they can opt in

Hard to prove or disprove. If you look at the numbers, present them in the hallways and tell everyone "this is better than a butcher's cleaver and here's one for free" then absolutely. However, most of the crew doesn't know of its force and even less will go out of their way to, for example, go into medical and print one even if the way is bolted open. People simply do not care this much about minmaxing their damage/inventory.
There are so many more items that are relatively easy to get and everyone who cares about minmaxing will take one if offered. Health analyzers, BS body bags, magboots, ATMOS holofans, combat knives, pepper spray,..
Just "if someone could opt into getting one, they'd take it" isn't a very good argument considering there's dozens of those items.

insuls

Entirely irrelevant here. Insuls are a roundstart item that had absolutely no effort (except gotta tide) or drawbacks involved, it's not comparable. Everyone beelined for them because there wasn't a single drawback to wearing them. Experimental tools need research, the right materials (=effort) and have no discernable drawbacks because they are hard to get upgrades.

Maybe I simply cannot comprehend your arguments. I just play this game daily and I have yet to see a single shift where people are mass-outfitted with either of the tools you're nerfing. Their high material costs often make them a well-kept treasure by their respective department, so even in a blob situation, people tend to print industrial welding tools instead of experimental ones from engineering.

I do, however, 100% agree on the Jaws. Their functionality (1 small item AA) heavily outweighs the cost.

@GuillaumePrata
Copy link
Contributor Author

Entirely irrelevant here.

Sure, let's see how the argument goes then.

Insuls are a roundstart item that had absolutely no effort (except gotta tide) or drawbacks involved

So the difference is just that one needs research, got it.

Everyone beelined for them because there wasn't a single drawback to wearing them.

Exactly like tier 2 tools, got it.

Experimental tools need research, the right materials (=effort) and have no discernable drawbacks because they are hard to get upgrades.

And this is again, something I said at the main post, the average crew member that wants a tier 2 tool doesn't do the research or the mining for it and that is why I'm adding something they actually will care about on their decision making, inventory management.

@kopoba
Copy link
Contributor

kopoba commented May 13, 2022

Wrong again, I said it pretty cleanly, the change is good because they are a desirable item for everyone regardless of their job.

And?
Crowbar is "desirable item for everyone" are you gonna nerf it too in next pr so more spacemens die from suffocation or burns behind fire airlock?
I know this game about suffering but where is the line beyond which survival rate drops to 0?

PR is not about advanced tools is good weapon. who the heck use jaw of life as weapon? Circular saw and laser scalpel have 15 and 16 damage wich is like no difference at all.

Its not about all access pass. Since you can hack faster.
So whats the point?

When Ghilker nerfed the Insuls

This is worst change that affect only engineers that is working with computer consoles to monitor SM and powernet.

@CMDR-Gungnir
Copy link
Contributor

But why can't an upgrade just be an upgrade? I can't tell you the last time I had T2 Surgery or Engineering tools outside of being in that department, being given them, or Actively Helping The Department (all of those being cases where I SHOULD have them anyway).

Palp's entirely right, you're punishing the vast majority of the playerbase for the actions of the minority.

How does this benefit the game? What exactly makes an 'upgrade' if it's got just as major of a downside as its benefit? What's the point of the mineral and research requirement if they aren't better than the roundstart stuff?

@GuillaumePrata
Copy link
Contributor Author

But why can't an upgrade just be an upgrade?

It still is just an upgrade over the basic tools, if you have a toolbelt, so I don't know what you are going on about "you're punishing the vast majority of the playerbase" when it was made to not hurt the main department in any way and instead discourage people that have a full set of engineering + medical tools inside a cardboard box.

It's literally the second line in the PR but imagine reading.

@CMDR-Gungnir
Copy link
Contributor

It's literally the second line in the PR but imagine reading.

I'll imagine reading if you imagine making a good PR.

@GuillaumePrata
Copy link
Contributor Author

I'll imagine reading if you imagine making a good PR.

lol

@CMDR-Gungnir
Copy link
Contributor

I'll imagine reading if you imagine making a good PR.

lol

Ok cool now that we've both given it a shot; fair point, but I still dislike it because I don't like this growing trend that "something's good for some reason or another, so we need to nerf it."

If it's something you only get late into the round, it should still be better than what you get at the start. That's the entire point of a tier system, otherwise T2 tools would just be A Different Tier 1 Variant, y'know?

@SkeletalElite
Copy link
Contributor

SkeletalElite commented May 13, 2022

Where are all these people running around with full sets of upgraded engineering and medical tools in a single box. Most people aren't even running around with a set of regular tools, much less upgraded ones. I can't help but feel this is a change trying to address a non-existent problem.

I get the feeling most of the people who support this PR, plain and simply support increasing the size of the regular tools too and this is just a proxy of that and that they couldn't care less about what the PR is actually trying to accomplish, which is this idea that that upgraded tools should primarily be for the department that specializes in using them and not any old person who stumbles across them in bar.

@Fikou
Copy link
Member

Fikou commented May 13, 2022

please let toolboxes hold them

Copy link
Member

@JohnFulpWillard JohnFulpWillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let them fit in toolboxes and I'll be happy with this

code/game/objects/items/tools/crowbar.dm Outdated Show resolved Hide resolved
@GuillaumePrata
Copy link
Contributor Author

let them fit in toolboxes and I'll be happy with this

I will change the size of items that they can carry to medium them as they are still worse than a generic bag when carried by hand.

@GuillaumePrata GuillaumePrata changed the title Advanced tools are medium sized now. Advanced tools are medium sized, toolboxes can carry medium sized items. May 13, 2022
@JohnFulpWillard JohnFulpWillard merged commit 04ecd0a into tgstation:master May 13, 2022
github-actions bot added a commit that referenced this pull request May 13, 2022
@GuillaumePrata GuillaumePrata deleted the Tools_weight_rebalance branch May 13, 2022 16:37
Y0SH1M4S73R added a commit to Y0SH1M4S73R/tgstation that referenced this pull request May 31, 2022
commit 0df5f93cbde3fbd444b27dfb8f5640b4c6a5b19a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 15:59:09 2022 -0700

    Automatic changelog generation for PR #66885 [ci skip]

commit 54ce923a6cc9cb11906674a84ecd5023f7b509b2
Author: VioletN <violetnottellin@gmail.com>
Date:   Sat May 14 18:59:06 2022 -0400

    Fixes traitor reputation being calculated and displayed incorrectly at round end (#66885)

    Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

commit f42c4eb28bdb20ca52cec5a892dbda83dbbbf15c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 14:47:27 2022 -0700

    Automatic changelog generation for PR #66956 [ci skip]

commit bb8b4d1e63ad4a0aaf04a282b75f0c173e713ef9
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sat May 14 17:47:24 2022 -0400

    removes double-tom from Delta brig (#66956)

commit 7dd6f1634798a6e2b952caa033df8cb1170f0da3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 14:46:38 2022 -0700

    Automatic changelog generation for PR #66957 [ci skip]

commit 90ef8fbe200bb723a75d4b9694be0953ed523abe
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Sat May 14 17:46:35 2022 -0400

    Adds Vault access to Icebox vault (#66957)

commit 6a42f5cfa822d9b991aa377dec156e7c141308b6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 14:28:01 2022 -0700

    Automatic changelog generation for PR #66958 [ci skip]

commit fa271795dac9f1850e818bc8053cfe6bd76b3420
Author: YakumoChen <king_yoshi42@yahoo.com>
Date:   Sat May 14 21:27:58 2022 +0000

    Gives boritos more flavour (#66958)

    About The Pull Request

    Rewrites the descriptions for Boritos flavours
    Also makes them taste better too like the code comment implied
    Why It's Good For The Game

    All the descriptions were bland, like plain Boritos
    Changelog

    cl
    spellcheck: Boritos flavours have more flavour!
    /cl

commit 07c0a1c219c842268d2663d737ddbf727f15321f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 12:46:55 2022 -0700

    Automatic changelog generation for PR #66942 [ci skip]

commit 81470962ce988042d599279a53993c489f6ef55f
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Sat May 14 16:46:51 2022 -0300

    Extinguishers From Shiptest: A port of a port of a port... Of a port! (#66942)

    imageadd: Resprites the fire extinguishers once more!

commit 5ed0f7c81a114827567874829cbc67b8a1e9b8ec
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 11:16:22 2022 -0700

    Automatic changelog generation for PR #66952 [ci skip]

commit acbba3e3a5455c26d2381a3ca2989006115a82cd
Author: PestoVerde322 <75247747+PestoVerde322@users.noreply.github.com>
Date:   Sat May 14 20:16:19 2022 +0200

    Fixes odd icons on the manual valve (#66952)

    This PR fixes the odd icon flip-flopping direction and also nudge by 1 pixel of the manual valve, which is kinda bothersome to watch to.

commit ef2a9916fb15e3776a20f30d146e9ef5da3e5bed
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 10:11:41 2022 -0700

    Automatic changelog generation for PR #66955 [ci skip]

commit dc9a8b988836e7c52cb761e8020432033d50c95e
Author: FlamingCheese <75639936+FlamingCheese@users.noreply.github.com>
Date:   Sat May 14 20:11:37 2022 +0300

    Removes one annoying firelock in icebox xenobio (#66955)

commit 8dfd1180bb78af15c6987727ed7a4ca4e798f484
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 10:09:33 2022 -0700

    Automatic changelog generation for PR #66941 [ci skip]

commit 0fff4cfc63592255dd74ee47543505a3e77fbad2
Author: san7890 <the@san7890.com>
Date:   Sat May 14 11:09:30 2022 -0600

    Fixes 968 Active Turfs on MultiZ-Debug (and more) (#66941)

commit 216c9736ca7b31a055d913dd30b65a8c0a8a04a7
Author: Tom <8881105+tf-4@users.noreply.github.com>
Date:   Sat May 14 17:27:57 2022 +0100

    Allows BS gas sender to be unwrenched, minor gas sender code improvement (#66903)

    * Update bluespace_sender.dm

    * Update thermomachine.dm

    * Update unary_devices.dm

commit b500a5b188f7cd1592024f6919bc302659b1079b
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Sat May 14 13:15:38 2022 -0300

    `belt.dm` lists are in alphabetical order now. (#66943)

commit 3047a1f5c55b8e8e68aa4e0e036d08bfbe3fba08
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 09:01:46 2022 -0700

    Automatic changelog generation for PR #66895 [ci skip]

commit e53a3152a280ba03ebb57f1330cb0934c7977278
Author: Thunder12345 <Thunder12345@users.noreply.github.com>
Date:   Sat May 14 17:01:42 2022 +0100

    massively improves the readability of stripping related attack logs (#66895)

commit 8aa8de6f198cc638ae1bc3b06dc17debb164bb63
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 08:59:56 2022 -0700

    Automatic changelog generation for PR #66891 [ci skip]

commit b3c624914d23fc25a25b4c90c23d7cf249a43c38
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Sat May 14 18:59:53 2022 +0300

    [NO GBP] Fixes hierophant trophy damage (#66891)

commit ac2b7a7be58cd76c42ff979a3403c6a8dd667cee
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Sat May 14 12:55:57 2022 -0300

    Clean some small details on most vending machine product lists. (#66934)

    * Cleans a lot of wardrobes.

    * Small extra changes.

commit 3481c495ebe24cf5f48fc0d75edd157dbab39b3c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 08:50:22 2022 -0700

    Automatic changelog generation for PR #66937 [ci skip]

commit 16076f69abf771e24f3d13acaff6ef86fb150178
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date:   Sat May 14 11:50:18 2022 -0400

    Fix biogenerator using 10 times more power than it should (#66937)

commit 5a83cfbf0974ec6491bb2da214029b58bca7ede2
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Sat May 14 12:14:36 2022 -0300

    `bags.dm` lists are in alphabetical order now. (#66951)

commit b918c6b338071dc243dd770b84da8c04ba8bdcc9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Sat May 14 02:14:41 2022 -0700

    Automatic changelog generation for PR #66875 [ci skip]

commit bbabf816f4957a0f2df4d1d5c2e55082d6e21c7d
Author: David Walker <d0sboots@gmail.com>
Date:   Sat May 14 02:14:37 2022 -0700

    Protect against floating-point inaccuracy in log() (#66875)

    This was causing issues with indexing icon slots (the main user of TOBITSHIFT). See BeeStation/BeeStation-Hornet#6842 for more details.
    Probably fixes #66197 and fixes #65652. (In all my tests, I could never get anything to show in suit_storage, whereas those bugs are reporting intermittent issues.)
    Originally made for BeeStation/BeeStation-Hornet#6842 (which also affects TG).

commit a2a3c267cdf74de94aa573085cd24175ece13b1a
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Sat May 14 06:47:45 2022 +0300

    Fixes multiple orbiting blades being used at once (#66817)

    Multiple orbiting blades will no longer be used to protect you from the same attack in case you have multiple instances of the status effect

commit 1a292bc136de1f8eb7e93d56706a30c0d6a84836
Author: Changelogs <action@github.com>
Date:   Sat May 14 00:25:42 2022 +0000

    Automatic changelog compile [ci skip]

commit 0971cc0e7dc48dc87d8c4f0531daf9d32579ba0f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 11:50:39 2022 -0700

    Automatic changelog generation for PR #66924 [ci skip]

commit c61d6dc3cb6d3927b64fe3aecdf38da8be0af33a
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri May 13 14:50:35 2022 -0400

    Removes CPU, Sensors and Identify ModPC parts. (#66924)

    Removes CPU, Sensors and Identify parts from modulra computers.
    This is in effort to simplify how tablets and tablet apps are, while removing barriers to download specific apps. Limiting apps needed for your job, through hardware, is a terrible idea, and just limits departmental stuff to being there roundstart/latejoin, punishing people who job change through the in-game HoP system, devaluing the job as a whole.

commit b17bfad5b5f2a2dbce5241d479b27ef887982b34
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 11:49:06 2022 -0700

    Automatic changelog generation for PR #66930 [ci skip]

commit a53f926078ccf8f8706578612ef1c193ee81d24f
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Fri May 13 15:49:02 2022 -0300

    Makes whistles be small sized. (#66930)

    Just that, they were inheriting their size from the root /obj/item.

commit 7a32a614d6a4f9d2f004db1402a12f0c14178035
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 09:34:29 2022 -0700

    Automatic changelog generation for PR #66900 [ci skip]

commit 04ecd0ab723b3965f6ca1651c0107b363ef683d8
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Fri May 13 13:34:26 2022 -0300

    Advanced tools are medium sized, toolboxes can carry medium sized items. (#66900)

    * Advanced tools are medium sized now.

    * Moves `w_class` 1 line down

    * Moves `w_class` MORE DOWN

    * Syndie Jaw pocket edition.

    * Toolboxes can carry medium items, pocket syndie jaw in desc.

commit f99d82dd91b5a8b32ec3ffefa1f1e3d06a4a9aac
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 08:15:31 2022 -0700

    Automatic changelog generation for PR #66876 [ci skip]

commit b0c8eb5a3a15ede8c9bff39cdf8b848315b9dd92
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri May 13 11:15:27 2022 -0400

    Fixes Cook CQC + job change config fixes (#66876)

    Allows configs to once again change job positions of jobs, and additionally allows them to completely disable some jobs. In the past, Pubby didn't have Lawyers and Curators, I doubt this would be the case in the future, but I find having this as an option for config is still good.

    I also properly logged jobs not loading due to removal from mapping config, to be in job debug instead of testing.

    Finally, I removed the old config_job, and made all configs use title instead. It was suggested I use typepath instead of title, but I am against doing it for the time being, as I don't expect Mappers to look for typepaths if all they want to do is make mapping stuff, though arguments can be made against that (like how its case sensitive so it's easy to break).

commit 12c0e754d6f68a7ff9488cfb32928b465e3664f1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 07:59:29 2022 -0700

    Automatic changelog generation for PR #66911 [ci skip]

commit 0a4d82046a406372abcbd8cac1fa60d8e1db01d0
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri May 13 10:59:26 2022 -0400

    Fixes pants altars being spammable (#66911)

    The cooldown doesn't start until the pants is finished being made, so while its still making the pants, you can spam the shit out of it

commit 2af1b6567c6f2353203f3f3619337f753991749c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 07:57:50 2022 -0700

    Automatic changelog generation for PR #66908 [ci skip]

commit cfca867cf8a975d4ba98000afadd81ced8486b1f
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri May 13 10:57:46 2022 -0400

    Fixes the captain's PDA (#66908)

    I screwed it up and didn't make the Captain's PDA a subtype of heads, so captain was spawning with the wrong PDA.

commit 7628ef7f96a211054bf896753efb16926650c7f2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 07:56:58 2022 -0700

    Automatic changelog generation for PR #66910 [ci skip]

commit 6bddf82ad8ffcd1fd38a57af5943815ff48921fa
Author: magatsuchi <88991542+magatsuchi@users.noreply.github.com>
Date:   Fri May 13 09:56:55 2022 -0500

    fixes admin ticket linking bad href (#66910)

    Fixes a bad admin href in help tickets

commit 9d19d0dcc94f0713e8d75d210cd3ff1aaced7812
Author: AnturK <AnturK@users.noreply.github.com>
Date:   Fri May 13 16:55:11 2022 +0200

    Makes update paths remove keys left after merging. (#66916)

    Fixes #66914

commit d81f18d8b063e7e0568e3bc7ac992560be28e0a0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 07:53:07 2022 -0700

    Automatic changelog generation for PR #66918 [ci skip]

commit 041eb1824c273c4cf3a2b2ed8565be01d6a7518f
Author: Sylphet <58074918+Sylphet@users.noreply.github.com>
Date:   Fri May 13 15:53:04 2022 +0100

    fixes kilo air alarms(#66918)

    Removed extra air alarm in bar maint

commit be63b4d0df1a967af9b2b91fa1450836d3b969eb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 07:51:33 2022 -0700

    Automatic changelog generation for PR #66922 [ci skip]

commit 62281befe35d8a8347d6ee521404fede0f9934e3
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Fri May 13 10:51:29 2022 -0400

    makes minifridges able to hold more stuff (#66922)

    Due to mini-fridges being in the pool for spawning instead of crates/lockers, if there's too many things meant to spawn in said fridge, unit tests will fail because it cannot hold it.
    To fix this, I simply added more storage capacity.

commit cc3a136733085ee7b7e6a432f741bf364eec7258
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 01:15:55 2022 -0700

    Automatic changelog generation for PR #66904 [ci skip]

commit 3d5a36308e35f03763c8ace5bc6a022c3d129586
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Fri May 13 03:15:51 2022 -0500

    Reduces the chance of spawning a pants altar (#66904)

    * reduces the chance of spawning a pants altar

commit 6348bdb035b5e105e2e61082475cd159282a6dbb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Fri May 13 01:10:57 2022 -0700

    Automatic changelog generation for PR #66913 [ci skip]

commit c4a9043fa8901edc0eaf1363697412ae76af696e
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Fri May 13 03:10:54 2022 -0500

    Fixes some minor formatting issues with vote text (#66913)

    * Fixes some minor formatting issues with vote

    * Wrong thing.

    * Actually I think this is supposed to be here

commit 09d92d7133171312c07b1b791a927e6eee68e3cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 23:09:05 2022 -0700

    Automatic changelog generation for PR #66877 [ci skip]

commit 1039db78f54db09c2bf4ef08d32116c947a5d981
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Thu May 12 23:09:00 2022 -0700

    Access Helpers Pt. 5/6 - Tram Station (Station Proper) (#66877)

    This PR continues to replace door accesses with mapping helpers with the same design standards as #66588, #66753, #66805, and #66871 but this time with TramStation. This does not touch the ~20 different modular maintenance designs which will be done in a future PR.

    Standardizes access requirements for the map and reduces changes for inconsistent mapping to happen by use of mapping helpers. Makes access requirements easier to audit.

commit da4fb3770952996bd44553f63538b4f5c0bb5ec8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 22:55:49 2022 -0700

    Automatic changelog generation for PR #66912 [ci skip]

commit 6525ca44720e3204afb404c203cd02ccf5a0b3d9
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Thu May 12 22:55:46 2022 -0700

    Removes log_cloning (#66912)

    Right now there is only 1 source of cloning: pod cloning-- and pod cloning is exceedingly rare. I don't think this warrants its own file anymore with the death of regular cloning a few years back.

commit 89a7fde4ea6dd5a1925fd141028d63373836ad3e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 22:36:08 2022 -0700

    Automatic changelog generation for PR #66819 [ci skip]

commit 73daa9dc668fdbad91509ca7c845708bbb6e1143
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Fri May 13 08:36:04 2022 +0300

    Fixes staff of storms not aggroing mobs (#66819)

commit 37ee17503ff7edae54beef02cde211d9200e2969
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 20:24:59 2022 -0700

    Automatic changelog generation for PR #66902 [ci skip]

commit 0c729d99a2471edf30ed831bbdeb51e7ead0ad82
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Thu May 12 20:24:55 2022 -0700

    Fixes Airlock Name in EVA on KiloStation (#66902)

    Fixes the maintenance airlock in EVA on KiloStation

commit aec3adc0e13a696e6d3080d4b2207b44c4cea6f3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 20:23:42 2022 -0700

    Automatic changelog generation for PR #66839 [ci skip]

commit 364c9c08b7fc760be27993f53de41e96f2ba6689
Author: fippe <julius.salonen@cs.tamk.fi>
Date:   Fri May 13 06:23:39 2022 +0300

    Take 2: Adjust the firelocks in service sector of Icebox (#66839)

    From the top and all over again. Re-do of the #66820, this time from a branch instead of being a stupid dummy. :)

    Orig description:
    Removes firelocks from botany and service airlocks on the 2nd Z-level, puts firelock on botany maint instead. This stops the constant fire alert spam. Besides, what are we trying to protect from with these firelocks, the snow?

commit 5a07c16a42a027ccf3d56f282a224eab2e9c6e42
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 19:41:53 2022 -0700

    Automatic changelog generation for PR #66901 [ci skip]

commit 4904ac7fa71660091bd7a02d85afd6b3a4bc44a8
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Thu May 12 23:41:50 2022 -0300

    Surgery tools can be recycled for silver. (#66901)

commit 60d4fd6caa382d08a8efe390eeaf9bf2a7869c98
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 18:49:00 2022 -0700

    Automatic changelog generation for PR #66871 [ci skip]

commit 49821fe8ca7701d0b80ff5a52039af31de4c4053
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Thu May 12 18:48:56 2022 -0700

    Access Helpers Pt. 4/6 - Delta Station (#66871)

    This PR continues to replace door accesses with mapping helpers with the same design standards as #66588 , #66753 , #66805 but this time with DeltaStation

    Standardizes access requirements for the map and reduces changes for inconsistent mapping to happen by use of mapping helpers. Makes access requirements easier to audit.

commit 476617b1ab5c0acc66b5451d2ebc7297aff71e25
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 18:39:44 2022 -0700

    Automatic changelog generation for PR #66538 [ci skip]

commit 6f450d93a6bfcc94e9c43ef7938e85bda49f7b6f
Author: ErdinyoBarboza <erdinyobarboza@gmail.com>
Date:   Fri May 13 04:39:40 2022 +0300

    New drink sprites aka Drink Desouling (#66538)

    - All drinks and bottles have been resprited

commit 44d8bce60a78cbd1d271b797d796d09c17072075
Author: Changelogs <action@github.com>
Date:   Fri May 13 00:24:51 2022 +0000

    Automatic changelog compile [ci skip]

commit b9b262ba8d3d527ebe0b78f405a04b651168c203
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 17:06:47 2022 -0700

    Automatic changelog generation for PR #66886 [ci skip]

commit 9335b72d16f8b9ceb934ec61922883e9572a6ce9
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Thu May 12 17:06:43 2022 -0700

    [NO GBP] Fixes maint access on cargo doors on MetaStation (#66886)

    Replaces the maintenance access on the cargo rooms on Meta with the appropriate ALL accesses. Not sure if it was a holdover from the previous PR or was something I messed up on so I'm marking as NO GBP.

commit 4d39af91ca2682c0362e18f1132626c75b4aaaa9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 17:06:11 2022 -0700

    Automatic changelog generation for PR #66905 [ci skip]

commit a3085d3be3fcd3bb2feeae898ba9d4ed308b1d32
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Thu May 12 17:06:07 2022 -0700

    Fixes DeltaStation Holodeck placement (#66905)

    This PR fixes the alignment of the DeltaStation holodeck so that holodeck templates spawn properly. Alignment was changed to best adhere to the recent changes done to the space:

    Allows holodeck templates to function properly on all maps and adhere to the same restrictions

commit 6acfc42f27e4a36e9858ef96ee6ca5782bf63f0d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 12:12:34 2022 -0700

    Automatic changelog generation for PR #66853 [ci skip]

commit ba9b1d478666ba5179b57e6874d2d38f10650b97
Author: wesoda25 <37246588+wesoda25@users.noreply.github.com>
Date:   Thu May 12 15:12:30 2022 -0400

    Allows ethereals to ghost out of crystallization (#66853)

    * moves around tgui question so it doesnt piss off linter or someting idk

    * code clean up

commit ef93454e9a52e770106d58eff2072c2a5e86ff41
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 11:56:20 2022 -0700

    Automatic changelog generation for PR #66898 [ci skip]

commit a2d135c456bb8c5407c80e7535713c138374f616
Author: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Date:   Thu May 12 15:56:16 2022 -0300

    Goodbye stack/medical (#66898)

    Okay, why removing instead of giving it a sprite?

    Simply put, those items are all small and there is no reason that you need to quick draw a suture/ointment and if you do, the medical belt can carry 7.
    Allowed/exoslot items should be either medium/big/bulky sized items (Syringe gun) to make it worth inventory wise or items that you can quickdraw multiple times (Health Analyzer) to make your life easier.
    Medical stacks are neither and would just get in the way if you try to quickly put them into a bag/pocket/belt and instead it goes into your exoslot where you would normally want to carry more valuable things like the syringe gun.

    This doesn't feel big enough for a fix, spending 5 seconds making a list alphabetical doesn't few worth of code improvement, I will label this as QoL and if someone say it is a balance change I will follow you in game and keep placing shitty small items in your inventory via reverse pickpocketing.

commit ae839fd1ea6c059909f0d27e36c90682f26ff99c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 11:55:53 2022 -0700

    Automatic changelog generation for PR #66899 [ci skip]

commit daf3fd611950eed7d3f8536eaead005f70ebb8fd
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Thu May 12 14:55:49 2022 -0400

    Makes cult's objectives load before their antag ui (#66899)

    Makes Cultists get their objectives from their team BEFORE their parent's on_gain runs, giving and triggering their antag UI. This means players no longer have to close and reopen the page to see their actual objectives.

commit 43345e79ec59c9e43657ba6ae7bff26f6f918fce
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 11:30:18 2022 -0700

    Automatic changelog generation for PR #66836 [ci skip]

commit e38300ac2d94f609f4754383424b03b8521a11e1
Author: san7890 <the@san7890.com>
Date:   Thu May 12 12:30:14 2022 -0600

    Adds Ceilings To IceMoon Ruins (#66836)

    Hey there,

    On IceBox, sometimes, ruins could spawn below chasms that we had, or below a ruin that spawned in more openspace chasms. This would cause numerous Active Turfs on initialization, and I've seen the number go up to 150 active turfs. This change should reduce the number by a good margin.

    I decided to make the ceiling mineral-rich snow to ensure it had that "buried" appearance, and would hopefully look nice to have that odd chance for a underground ice ruin create a natural bridge that just needs to be excavated.

commit c5b3d04e40cd7dcebd22b955d885790f78cc44d7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 09:22:49 2022 -0700

    Automatic changelog generation for PR #66896 [ci skip]

commit 9ae3ef56a90d939267cdb100530199e144a4da8e
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Thu May 12 12:22:46 2022 -0400

    Lathe taxes now checks departmental flags (#66896)

    Lathes and designs now use departmental flags rather than some random misc define that wasn't used anywhere else (which this PR is deleting), this allows us to cross-reference it with job bitflags to check whether or not a job should pay lathe taxes. Nothing else is effected by this change. Important changes are in code/modules/research/machinery/_production.dm if you want to get straight to the point.

commit 3639378585cdcc9c377265a55ef81008b583d37d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 08:09:20 2022 -0700

    Automatic changelog generation for PR #66888 [ci skip]

commit f134d777caace292736089556aa1688496c0263f
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Thu May 12 17:09:15 2022 +0200

    Remove organs from delimber anomaly  (#66888)

    * Remove organs from delimber anomaly

    * Remove organs from reactive armour

commit 035373e746e14f3a8e0d7f663a8feb53ff059750
Author: Seth Scherer <supernovaa41@gmx.com>
Date:   Thu May 12 10:49:02 2022 -0400

    Repaths `/obj/item/clothing/mask/animal/rat` to make more sense (#66860)

    * Repaths `/obj/item/clothing/mask/animal/rat` to make more sense
    It was used as the parent for a lot of other small animal masks simply
    because of its flags and a single proc, so i repathed it to
    `/obj/item/cltohing/mask/animal/small/...` to make more sense

    * adds an updatepaths

    * fixes the got damned maps

commit 5b456f63b1a51c288ce8d48cebe0ad2587fb4938
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 07:46:59 2022 -0700

    Automatic changelog generation for PR #66890 [ci skip]

commit 13d044cff70fea455329309de1f059906d0d6c70
Author: Tim <timothymtorres@gmail.com>
Date:   Thu May 12 09:46:55 2022 -0500

    Fix wizard modsuit not having antimagic protection (#66890)

    * Fix wizard modsuit not having antimagic protection

    * Change TRAIT_ANTIMAGIC_NO_SELFBLOCK comment

commit da293c5333346af6ac3530e8976451819bffaca6
Author: Fikou <23585223+Fikou@users.noreply.github.com>
Date:   Thu May 12 16:45:52 2022 +0200

    deletes our psd folder (#66892)

    deletes our psd_files folder, which contained mostly really outdated icons
    moves one useful thing from it, the grille template into structurespawners.dmi

commit d93124dcc9752d3559f52dd1819ae71e0837efa8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 03:24:53 2022 -0700

    Automatic changelog generation for PR #66859 [ci skip]

commit da8934cbcb9a2ff05fcd5ccd998f3a5008984eed
Author: Ebb-Real <95765134+Ebb-Real@users.noreply.github.com>
Date:   Thu May 12 12:24:50 2022 +0200

    Vape GAGS (#66859)

    * what am i gonna do with the open panel overlay

    * subtypes and color presets

commit a7070d7ee3942c103047024aaf56f74e1a7f866c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Thu May 12 01:01:07 2022 -0700

    Automatic changelog generation for PR #66883 [ci skip]

commit 31a2160680e1a32563524e8ffb57bb694eeb43b1
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Thu May 12 01:01:03 2022 -0700

    make pride ruin front door friendly (#66883)

    Co-authored-by: tattle <article.disaster@gmail.com>

commit d8d29f6701987af2de3117373baf936c5441f4ef
Author: Tastyfish <crazychris32@gmail.com>
Date:   Thu May 12 03:12:02 2022 -0400

    Test all maps in parallel integration tests (#66864)

commit 20c6c11943dcb78c75b18f5225453607b623eb42
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 20:01:53 2022 -0700

    Automatic changelog generation for PR #66292 [ci skip]

commit 3b6aac31790ca1d43f7bb3d8f0c74a854079809e
Author: Tim <timothymtorres@gmail.com>
Date:   Wed May 11 22:01:49 2022 -0500

    Randomize lockers, reagent tanks, and atmospherics equipment in Meta maint (#66292)

commit cd5e928e771e09f0e6f16ae18ad732e06d344bbe
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 17:54:46 2022 -0700

    Automatic changelog generation for PR #66861 [ci skip]

commit 7f79efb2bd0ed08021454445257131df415743b7
Author: MacBlaze1 <33578623+MacBlaze1@users.noreply.github.com>
Date:   Wed May 11 20:54:43 2022 -0400

    fixes dizziness causing hard crashes (#66861)

    this pr fixes dizziness causing hardcrashes and sending your view 50 tiles in both x and y

commit 6f3f8bc882555ce6e2960f8448e470cb90a1725f
Author: san7890 <the@san7890.com>
Date:   Wed May 11 18:50:22 2022 -0600

    Removes "gbasood.byond-dm-language-support" from Extensions.json (#66862)

    I read ZeWaka's recommendation here: https://github.com/tgstation/tgstation/pull/66834#pullrequestreview-966871661, and I thought it was a fair point. I also spoke with oranges about this same extension last month while I was writing my guide to mapping, and he confirmed the same thing ZeWaka was saying.

commit d2123a2a22891d4153bbd93e738e3f23e68800df
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 17:47:48 2022 -0700

    Automatic changelog generation for PR #66872 [ci skip]

commit 15034505b9de3382ad5edcef2df2f4dba329769b
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Wed May 11 20:47:44 2022 -0400

    Makes constable helmet a subtype of head (#66872)

    Moves constable hats to be a subtype of head directly, rather than head/helmet, because they aren't helmets, they're hats, and helmet block your hair which looks odd for something that isn't actually covering it.

commit 8bf1e27aa8699b460d5c7f8fc3084451ae176cc8
Author: Changelogs <action@github.com>
Date:   Thu May 12 00:22:16 2022 +0000

    Automatic changelog compile [ci skip]

commit 9e6d45601de6fdda4c5844f7670b5f6890f74374
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 16:55:53 2022 -0700

    Automatic changelog generation for PR #66868 [ci skip]

commit 85895ff5300f4996845c21ed161adf664673b9a8
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Wed May 11 16:55:50 2022 -0700

    [NO GBP] IceBox access fix for service hall (#66868)

commit 17c8721b5083b667a0ec6f6478c67fa1373708e4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 16:55:29 2022 -0700

    Automatic changelog generation for PR #66866 [ci skip]

commit 3acef52c365c8e8220eeffe816ef4d0b4f698706
Author: san7890 <the@san7890.com>
Date:   Wed May 11 17:55:25 2022 -0600

    Fixes Duplicate APC on IceBoxStation's Prison Wing (#66866)

    Hey there, it's on the tin.

    I believe the original intent was to have one APC for the Prison Wing, and then another APC for the Prison Wing cells, but I believe an oversight occurred to the point where this APC was not located in the "Safe Prison" area. To rectify this, I put that whole room in that aforementioned area.

    This should be a good prerequisite to #66864.

commit b4cb324c3b26225674222f1f3eea789963691c1f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Wed May 11 09:04:14 2022 -0700

    Automatic changelog generation for PR #66505 [ci skip]

commit cc57407c79a90d1ff7fc025fb2e1367750bb5c87
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date:   Wed May 11 12:04:11 2022 -0400

    [MDB IGNORE] Removes tablet cartridges + reworks a ton more (#66505)

    - All tablets who previously had apps in a cartridge now has them built-into their tablet instead. This means it costs space for it.
    - Rebalances the sizes of several apps to help them fit on Command tablets (Cargo ordering costed 20!!)
    - Removes tablet cartridges, they've been reworked into a regular old portable disk (the same you use for toxins/borgs)
    - Removes Signaller (the module required to run the signaller app) from tablets (likely will remove more in the future)
    - Refactors the health/chem scanning app to not be as bad
    - Dehardcodes detomatix resistance
    - Ability to send PDA's to all is now tied to your access rather than a cartridge
    - Moves 'eject disk' button to the very top of the UI

commit 95e72851c8c2ba54fbcd477a264700df0b0d689c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 23:49:10 2022 -0700

    Automatic changelog generation for PR #66607 [ci skip]

commit a3c8013b45c92fdb8efec7ba827d7b00191e2d55
Author: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>
Date:   Wed May 11 02:49:06 2022 -0400

    Refactors how legs are displayed so they no longer appear above one-another when looking EAST or WEST (#66607)

    So, for over 5 years, left legs have been displaying over right legs. Never noticed it? Don't blame you.
    Here's a nice picture provided by #20603 (Bodypart sprites render with incorrect layering), that clearly displays the issue that was happening:

    It still happened to this day.
    Notice how the two directions don't look the same? That's because the left leg is always displaying above the right one.

    Obviously, that's no good, and I was like "oh, that's a rendering issue, so there's nothing I can do about it, it's an issue with BYOND".

    Until it struck me.

    "What if we used a mask that would cut out the parts of the right leg, from the left leg, so that it doesn't actually look as if it's above it?"

    Here I am, after about 25 hours of work, 15 of which of very painful debugging due to BYOND's icon documentation sucking ass.

    So, how does it work?

    Basically, we create a mask of a left leg (that'll be explained later down the line), more specifically, a cutout of JUST the WEST dir of the left leg, with every other dir being just white squares. We then cache that mask in a static list on the right leg, so we don't generate it every single time, as that can be expensive. All that happens in update_body_parts(), where I've made it so legs are handled separately, to avoid having to generate limb icons twice in a row, due to it being expensive. In that, when we generate_limb_icon() a right leg, we apply the proper left leg mask if necessary.

    Now, why masking the right leg, if the issue was the left leg?
    Because, see, when you actually amputated someone, and gave them a leg again, it would end up being that new leg that would be displayed below the other leg. So I fixed that, by making it so that bodyparts would be sorted correctly, before the end of update_body_parts(). Which means that right legs ended up displaying above left legs, which meant that I had to change everything I had written to work on right legs rather than left legs.

    I spent so much time looking up BYOND documentation for MapColors() and filters and all icon and image vars and procs, I decided to make a helper proc called generate_icon_alpha_mask(), because honestly it would've saved me at least half a day of pure code debugging if I had it before working on this refactor.

    I tried to put as much documentation down as I could, because this shit messes with your brain if you spend too long looking at it. icon and image are two truly awful classes to work with, and I don't look forward to messing with them more in the future.

    Anyway. It's nice, because it requires no other effort from anyone, no matter what the shape of the leg is actually like. It's all handled dynamically, and only one per type of leg, meaning that it's not actually too expensive either, which is very nice. Especially since it's very downstreams-friendly from being done this way.

    It fixes #20603 (Bodypart sprites render with incorrect layering), an issue that has been around for over half a decade, as well as probably many more issues that I just didn't bother sifting through.

    Plus, it just looks so much better.

commit d5072a7e2c5abb9ebd09fd6387b7a3e0ba625976
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 22:00:01 2022 -0700

    Automatic changelog generation for PR #66848 [ci skip]

commit 6f5f0124419377cec50a88eb6c1f755db7ac05f0
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue May 10 23:59:58 2022 -0500

    fixes withdraw stages, sort of (#66848)

    So, addiction checks the current_addiction_cycle exactly to see if it can enter a new stage of addiction.
    current_addiction_cycle starts at 1 and increased by delta_time (2) every tick.

    Do you see the issue here?

    current_addiction_cycle would never be equal to 60, and it would never enter stage 1 of addiction.
    It skips from 59 to 61.

    The other addiction stages take this into account, but stage 1 doesn't.

commit 8b3f128fd489ee53e71ac7bdcfbcf123ff1d1819
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 21:58:24 2022 -0700

    Automatic changelog generation for PR #66842 [ci skip]

commit 9ea34bcfaa73c35a9169df8cea5dcc4097b61cfc
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date:   Wed May 11 00:58:20 2022 -0400

    Fix erroneous 'the' in some clown car messages (#66842)

commit f914dd89072ed5475e9f1f40f0ed2e0479945532
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 21:57:19 2022 -0700

    Automatic changelog generation for PR #66849 [ci skip]

commit 86f11d96a71e2c83b8db1b43dae81bc608105df4
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue May 10 23:57:15 2022 -0500

    Fixes "high blood pressure" status effect, and corrects the spelling of "opioid" (fixing another bug) (#66849)

    Status effects that are intended to be added, are actually added.
    Opioid is now spelled correctly, consistently.

    This actually caused a bug: Opioid end_withdrawal was never called because it's path was spelled correctly and the others weren't.

commit a93e356de87bbdd0cf79127f6e1f6944d839e8be
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 21:56:33 2022 -0700

    Automatic changelog generation for PR #66852 [ci skip]

commit 29bfa42779d7061565aecd474dfbe4d6260a7bc2
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Tue May 10 23:56:29 2022 -0500

    Converts jittering to status effect, striking yet another mob level status value (#66852)

    Converts jittering to status effect, striking yet another mob level status value

commit 528074e050908e845b7dfa6e9dd52f11a71bc202
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 21:53:47 2022 -0700

    Automatic changelog generation for PR #66850 [ci skip]

commit a0f79f1466b8776d5ff341408245b3b709b8d536
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Tue May 10 21:53:44 2022 -0700

    [NO GBP] Fixes library maint access on IceBox (#66850)

    Switches the maintenance door in the library from librarian only access to maintenance and librarian access, as well as adds an unrestricted access one way helper to the door - per decisions from a maptainer in #66847

commit c2f0c44bd45853a1cf415a4b9523c17116a2f6ba
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date:   Wed May 11 00:30:37 2022 -0400

    Fix teleport rune portals harddeleting (#66841)

    * Fix teleport rune portals harddeleting

commit d1606bcae45dbb102f73bf44e8a4effeb086ce65
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 17:45:09 2022 -0700

    Automatic changelog generation for PR #66828 [ci skip]

commit 3dac11dc3a7f3d9be56629ebe734c724fb88c9a2
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date:   Wed May 11 01:45:06 2022 +0100

    Removes AOE hit detection from fireball (#66828)

commit 948e98f2eaf6574ab28b8d7bdfdb9c075124ab00
Author: Changelogs <action@github.com>
Date:   Wed May 11 00:21:26 2022 +0000

    Automatic changelog compile [ci skip]

commit e8f2441630423e7c56c72562f2403e685fb42f8f
Author: Ryll Ryll <3589655+Ryll-Ryll@users.noreply.github.com>
Date:   Tue May 10 20:09:23 2022 -0400

    Minor twohanded component refactor (#66791)

    The two handed component, while useful, has quite a bit of bloat that gets replicated whenever a new class of 2h items is added.

    This PR cuts that bloat by replacing the use ofCOMSIG_TWOHANDED_WIELD and COMSIG_TWOHANDED_UNWIELD as ersatz callbacks with actual callbacks, the replacement of various var/wielded defs on items with a check for HAS_TRAIT(src, TRAIT_WIELDED), and the removal of any now-unnecessary on_wield()/on_unwield() procs that simply toggled those wielded vars

commit 6eba3dbcfdfe11c75f51da661e852da06f0944bf
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 16:26:48 2022 -0700

    Automatic changelog generation for PR #66847 [ci skip]

commit c6e8bccf34576f1c5d450b184e2d52db148c7419
Author: Charlotte <98856144+orthography@users.noreply.github.com>
Date:   Tue May 10 16:26:44 2022 -0700

    Metastation Library Maintenance Airlocks Access Fix (#66847)

commit 2b981a9e05ed2372f609370cf5012f50987e37c0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 15:50:12 2022 -0700

    Automatic changelog generation for PR #66805 [ci skip]

commit 3f9e35c55ceefa5647f04631ab92bff8a9c0b421
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Tue May 10 15:50:07 2022 -0700

    Access Helpers Pt. 3/6(?) - Kilo Station (#66805)

    This PR continues to replace door accesses with mapping helpers with the same design standards as #66588 and #66753 but this time with KiloStation

    Some removed inconsistencies:
    -Random centcomm codes on maintenance doors leading from the centcomm docking port
    -Chaplain access on the sec cremator
    -Lawyer access to the gear room lobby, medbay, evidence, interrogation, and gulag areas
    -Chaplain access on morgue doors (If we want this they should just have morgue access)
    -Research and Mining on the aux base
    -Research Director on the tech room
    -Heads on the secure tech room
    -Slew of accesses on service maints instead of general service access

    Standardizes access requirements for the map and reduces changes for inconsistent mapping to happen by use of mapping helpers. Makes access requirements easier to audit.

commit d70a99ba61cef9d1de6da7e67e0dde7f45b3258b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 15:40:02 2022 -0700

    Automatic changelog generation for PR #66678 [ci skip]

commit d423937bd8937b12d86f7e980afaa277bd2b660a
Author: Tim <timothymtorres@gmail.com>
Date:   Tue May 10 17:39:59 2022 -0500

    [NO GBP] Fix mapped cardhands not initializing (#66678)

    * Fix mapped cardhands not initializing

    * Refactor cardhand Initialize proc to be readable

commit 86e1ddca5e126624b6ed55242f7b9c50a9ba5419
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 12:07:35 2022 -0700

    Automatic changelog generation for PR #66835 [ci skip]

commit 26e7cf546a3cb51a4579bba2edc2dee19c636464
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Tue May 10 21:07:30 2022 +0200

    fix delimber anomaly making not being made in refinery (#66835)

    * fix delimber anomaly in refinery

commit e5c03a09272ab52a9300090e8dd6f83cd9126287
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 12:04:42 2022 -0700

    Automatic changelog generation for PR #66832 [ci skip]

commit 2306b93c3ef77819338c6f9f28639f55d0b62934
Author: Iamgoofball <iamgoofball@gmail.com>
Date:   Tue May 10 12:04:38 2022 -0700

    The supermatter cascade now takes one minute to end the round instead of 5 minutes to end the round, to put it on par with Blob and such. (#66832)

commit 64bbbcd1d01a7a8d7eea043e8fc0aba34aa77724
Author: AnturK <AnturK@users.noreply.github.com>
Date:   Tue May 10 21:02:13 2022 +0200

    Switches vscode dmi editor to new one. (#66834)

    https://marketplace.visualstudio.com/items?itemName=anturk.dmi-editor

commit 277bc69966b749b89e1fc21027d177673d3785a4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 11:52:54 2022 -0700

    Automatic changelog generation for PR #66800 [ci skip]

commit 5713b4fb7750b5dc063ea3845ef2176f0767b2bc
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Tue May 10 20:52:50 2022 +0200

    improve speed of cascade walls, better description for them + CL for cascade antag (#66800)

    Cascade walls were processing on object subsystem, they are now in their own subsystem that ticks once per second and should be more reliable even in case of high td
    better description for the walls to be more interesting

commit 11cd823ec6e6dc3b9d479c68868fd21815461804
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date:   Tue May 10 11:46:02 2022 -0700

    Add lint to validate tgstation.dme is in the proper order (#66831)

    Adds validate_dme.py to the CI suite to verify that tgstation.dme is in proper alphabetical order

    And by alphabetical order I mean the ass-backwards specific rules that Dream Maker enforces

commit 5abffba8541f9edf2e92f4beeb50e5e0b4f51597
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 11:44:48 2022 -0700

    Automatic changelog generation for PR #66824 [ci skip]

commit bdc6804680b0eb40cb86c84bc809655b7aeefa68
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Tue May 10 20:44:44 2022 +0200

    Powerfist code improvement (#66824)

    I wanted to add some nuance to the used gasmix in the powerfist but i want to do some cleanups first so here we are, i've also added some more text in examine and item use for a bit of quality of life

commit c541922506fe919520edfc4cdec7f7e8fc1c1644
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 11:41:13 2022 -0700

    Automatic changelog generation for PR #66830 [ci skip]

commit d604bc6b8c0a077a1594a531e218c21d7d340d18
Author: san7890 <the@san7890.com>
Date:   Tue May 10 12:41:09 2022 -0600

    Fixes Marker Beacons Not Having an Icon (#66830)

    FUCK.

    In #66736 (7517e79), I forgot to change this line. It worked fine in the screenshot because the screenshot came from before I spun it out into it's own DMI. Whoops.

commit 78bf8dd2b084aef75c998079f13f944422b23bd9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 11:37:28 2022 -0700

    Automatic changelog generation for PR #66825 [ci skip]

commit 021ad98fce029acd31933f45068a2f3e40a6814a
Author: Ghilker <42839747+Ghilker@users.noreply.github.com>
Date:   Tue May 10 20:37:24 2022 +0200

    atmos layers update (#66825)

    Updates atmosmachines layering in a way that they keep the same layer in all piping_layer and colors. dense machines have a static OBJ_LAYER that doesn't change regardless of color/layer

commit e4030376172a9cc049bbb1c895889938f5280f32
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 10:19:14 2022 -0700

    Automatic changelog generation for PR #66827 [ci skip]

commit 30b84afc4827fa9d8458ec0245c9666b017e3dc8
Author: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
Date:   Wed May 11 00:19:10 2022 +0700

    Fix a missing bold tag in the omega soap poem (#66827)

    Its only missing an opening b tag

commit 23c89fd22ab006b8183a57b467aceb0277093eee
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 09:01:08 2022 -0700

    Automatic changelog generation for PR #66589 [ci skip]

commit 4aa01082653f286307ffeec09d1c69c1c9873346
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue May 10 09:01:04 2022 -0700

    Adds lore terminals for mappers (#66589)

    This adds the ability to use Fallout-style terminals for maps

commit d30b8e54eb3bcd168fe61198985c1f7caee49099
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 08:40:02 2022 -0700

    Automatic changelog generation for PR #66823 [ci skip]

commit 41c9bb33750c94f96834d4055055098649e98099
Author: OperativeLyn <42174630+OperativeLyn@users.noreply.github.com>
Date:   Tue May 10 17:39:58 2022 +0200

    Fixes misplaced sofa in the Icemoon village ruin. (#66823)

commit c8a5ad9ce7bb65cc7c334fa4c7f5129aeab81957
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 08:38:51 2022 -0700

    Automatic changelog generation for PR #66815 [ci skip]

commit 9633dbd42437da93702d67879d22903e26edc813
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Tue May 10 18:38:47 2022 +0300

    Fixes heretic marks working on corpses (#66815)

    marks shouldn't apply to corpses

commit a61783066e35cbc52df84dc89f7d0b0070189ebd
Author: Tastyfish <crazychris32@gmail.com>
Date:   Tue May 10 11:32:25 2022 -0400

    Fix destroy_machinery runtime (#66810)

    Added a check for if the applicable_jobs list got completely eliminated. The if(!length(possible_machines)) check immediately after this while loop with then cause the objective generation to cleanly fail.

commit b2ca64a28cc14117c849596b94b5a906832b6caf
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 06:28:34 2022 -0700

    Automatic changelog generation for PR #66816 [ci skip]

commit 66aeae6b8471d24edcceb3c83427cff3a0bbe0da
Author: Cauã dos Santos Rebelo <cauarebelo@gmail.com>
Date:   Tue May 10 10:28:31 2022 -0300

    Fixes duplicate hairstyles replacing the original ones (#66816)

    Fixes mohawk, short hair 5, short hair 6 and pigtails 2

commit 3e5a294c66891d08a0680c50f3812d9fd4d624fc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 04:45:48 2022 -0700

    Automatic changelog generation for PR #66625 [ci skip]

commit 37e575750c7ac9495e09ab131c2ff9c0f6ea85f9
Author: Zonespace <41448081+Zonespace27@users.noreply.github.com>
Date:   Tue May 10 04:45:45 2022 -0700

    Rebalances, adds, and removes certain bounties (#66625)

    * Splits Engineering and Atmospherics bounties

    * Lowers the rewards from Medical bounties

    * Adds refined anomaly, Assistant and Engineering bounties

    * Removes Sunglasses and Briefcase bounties

    Co-authored-by: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>

commit c3944ee2de567204421274e9a990aa44f0abba0c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 03:32:13 2022 -0700

    Automatic changelog generation for PR #66754 [ci skip]

commit 8764893593ff63496277eac8bcca0f93a2941a75
Author: dragomagol <66640614+dragomagol@users.noreply.github.com>
Date:   Tue May 10 03:32:09 2022 -0700

    [MDB Ignore] Mapping directional helpers for signs + sign naming conventions (#66754)

    * Add mapping helpers for signs, make names snakecase

    * Update maps

    * Couple of lost signs in the elephant graveyard

    Co-authored-by: tattle <article.disaster@gmail.com>

commit cd3745f2e206093be8584ede5897b7adfacc4356
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Tue May 10 02:52:45 2022 -0700

    Automatic changelog generation for PR #66818 [ci skip]

commit e9e4998316fa1e234f954041bc291cf7d0274b8f
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Tue May 10 12:52:41 2022 +0300

    Fixes charged greens displaying species types instead of names (#66818)

    Closes #66724

commit 9d45f9d8faa1259029fe4b8f42298f4dd124dd47
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 22:03:43 2022 -0700

    Automatic changelog generation for PR #66807 [ci skip]

commit e423ec768a16b43d7868d67037b3dc0245c9c809
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Mon May 9 22:03:40 2022 -0700

    Fixes some overlapping wall objects on the IceBox Minisat (#66807)

    Some of the AI turret controls on the minisat were overlapping with intercomms making it impossible to tell the state of the turrets as an AI or someone is watching cameras.

commit 1748a6fb74341c07c4e8a84ca1159d4914a7b16f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 21:38:07 2022 -0700

    Automatic changelog generation for PR #66371 [ci skip]

commit 549ba0ee9e28c2bbd70b0a9df671a4fd0c1319d4
Author: Tim <timothymtorres@gmail.com>
Date:   Mon May 9 23:38:04 2022 -0500

    Fix books to only give mood bonus when read the first time (#66371)

    * Fix book rereading exploit

    * Refactor book_title_read to be for mind datum

    * Remove reader var from on_read

    * Add sanity check for mind

commit aaef54596894dfd4540b7241215d55014d4816ce
Author: Tim <timothymtorres@gmail.com>
Date:   Mon May 9 22:28:10 2022 -0500

    Revert "Add stamped requisition forms now give bonus credits (#66230)" (#66851)

    This reverts commit f021767645ffa4ce0a3f71f1c53b32beece2a9bf.

    This reverts commit f021767 from:

        Add stamped requisition forms now give bonus credits #66230

    This bug was encountered when we were testing this PR but I thought it got fixed.
    Why It's Good For The Game

    Cargo crates will now reappear.

commit e63d556d83d789cb3829906292300c6c4253a902
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon May 9 20:59:33 2022 -0500

    Confusion status effect is now duration based instead of magic number based (#66801)

    Refactors the confusion status effect. Removes "confusion strength" and replaces it with duration, which is measured in seconds.
    This also allows them to use the adjust_timed_status_effect procs instead of their own.

    Fun fact! 2 years ago when confusion was refactored into status effects, all confusion effects in the game were halved in duration. They were changed to status effects, which tick every 1 second by default, from life, which tick every 2 seconds by default, without any values changing.

commit b9ba2d2dae617fe4698c58ec3839ef3d62a896cc
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon May 9 20:53:39 2022 -0500

    Removes (now unused) sandbox related config and variable (#66803)

    I don't know when we removed sandbox but this datum doesn't exist anymore and this var is unused

    Also the config does nothing anymore so might as well throw that out

commit 36fe78f988149df9ef9f09c49efbe27a3420d676
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 18:48:54 2022 -0700

    Automatic changelog generation for PR #66107 [ci skip]

commit a6583845e56a9ad759d6490d0057fd612a0709b4
Author: zxaber <37497534+zxaber@users.noreply.github.com>
Date:   Mon May 9 18:48:50 2022 -0700

    Ripley mechs (and other mechs that are missing an air tank) can no longer toggle the air source. (#66107)

    Disables the button on the UI if the mech has no internal tank. Also early returns on procs if the UI somehow lets the click through.

    Fixes #66005

commit 3adc60e96186a1b8e1139cc7bb64d1280bdb4a5f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 18:45:26 2022 -0700

    Automatic changelog generation for PR #66804 [ci skip]

commit 572d273ff64911d83912b07437f2651d4058859f
Author: Y0SH1M4S73R <legoboyo@earthlink.net>
Date:   Mon May 9 21:45:22 2022 -0400

    Supermatter Cascades are not Universe-Destroying Events (#66804)

commit 221775ce3e7ff635ddb0c999e52abfd8334455de
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 18:41:29 2022 -0700

    Automatic changelog generation for PR #66806 [ci skip]

commit d33b7bc67cd284a73a38a9f6f5e92485db0838db
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Mon May 9 18:41:26 2022 -0700

    Fixes food progression on oldstation ruin (#66806)

    Adds a griddle and oven to the oldstation ruin.

commit b683e4fd399d5cf4307f158b7ae9166fa6f43751
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 18:38:31 2022 -0700

    Automatic changelog generation for PR #66229 [ci skip]

commit 6f58040394f5c3752f3bb96fa399690cea146e7e
Author: wesoda25 <37246588+wesoda25@users.noreply.github.com>
Date:   Mon May 9 21:38:27 2022 -0400

    Fixes mulligan not randomizing ethereal color, removes default_color for every race except ethereals (#66229)

    Judging from code this is a fix, although I initially thought it would be a feature. It tried to update color but there was nothing in ethereal code to make that do anything. Now it does.

    Moth wings also do not update. I tried to figure it out but species code makes me want to hit my head against a wall so I gave up on that.

    default_color wasn't used anywhere except for ethereals, so I made it a var unique to ethereals.

commit d944f69a9f24443ca0de480686414daa6897ae2c
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date:   Mon May 9 21:02:57 2022 -0400

    More codeowners housekeeping (#66843)

    I looked at #66813 (215dfeb18500893641989b52322b468a97f10e4a) and found more housekeeping to do:

    Combines Lemon's and Ghilker's atmos sections into the same line in the multiple owners section
    Formats oranges' citrium.dm line to be like the rest of the file

commit d1ebe596857c9a5ab935a82c22563ee101a9e001
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 17:47:11 2022 -0700

    Automatic changelog generation for PR #66707 [ci skip]

commit 2dd0b427ef6873d34f0ca4604a8ea0dd7319b283
Author: san7890 <the@san7890.com>
Date:   Mon May 9 18:47:07 2022 -0600

    Resculpts IceBox's Exterior (Plasma River Edition) (#66707)

commit 29cc7ae91537b5029276023b38eebbcc5094e85e
Author: Changelogs <action@github.com>
Date:   Tue May 10 00:21:34 2022 +0000

    Automatic changelog compile [ci skip]

commit 8e7a755f640d6cef602563dec72129ea18d65a52
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 14:43:12 2022 -0700

    Automatic changelog generation for PR #66636 [ci skip]

commit d1a597e97af90d3e6a91fac41a7349868e86b49c
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date:   Mon May 9 14:43:08 2022 -0700

    Sorts ai_laws.dm, adds Dungeon Master, The Painter and Their Canvas, and Nutimov lawsets (#66636)

    Sorts ai_laws.dm, adds Dungeon Master, The Painter and Their Canvas, and Nutimov lawsets (They aren't obtainable by players at the moment)

commit aa9bdacd9996df2bebed0e9243c2258eb702be82
Author: Kyle Spier-Swenson <kyleshome@gmail.com>
Date:   Mon May 9 14:05:52 2022 -0700

    Add guidelines to ensure the maintainers and issue jannies understand the place and purpose of templates. (#66673)

    Why It's Good For The Game Repo

    Preemptively preventing a fork threat.

commit ed406c95880010ec2130748521a579f0d509ff9a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 11:25:09 2022 -0700

    Automatic changelog generation for PR #66753 [ci skip]

commit 44284a438c31c7ee44a751135648ea1e314e17c6
Author: Son-of-Space <63861499+Son-of-Space@users.noreply.github.com>
Date:   Mon May 9 11:25:04 2022 -0700

    Access Helpers Pt. 2/6(?) - IceBox Station (#66753)

    This PR continues to replace door accesses with mapping helpers with the same design standards as #66588 but this time with IceBox

    Some inconsistencies that were removed:
    -General engineering access on secure tech storage
    -heads access on engineering foyer (someone really wanted heads to get that engineering lathe smh)
    -brig access on sec portion of evac (changed to general sec)
    -Red alert access (yeah I know, like, what?) on evac eva, just eva now
    -Huge list of accesses on the door to maintenance in the bar
    -Kitchen from the outside garden in hydroponics
    -Construction access on part of the mining base
    -Some niche accesses from themed rooms in maints (like a piping room, etc.)

commit ea5cf11d693369f5d7b61efea3de6d9c5c7e9e2f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 10:58:59 2022 -0700

    Automatic changelog generation for PR #66797 [ci skip]

commit edc507285251a3727bef8eb7871bbace7326231f
Author: RandomGamer123 <31096837+RandomGamer123@users.noreply.github.com>
Date:   Mon May 9 13:58:54 2022 -0400

    Fixes deltastation toxins tank compressor direction (#66797)

commit 215dfeb18500893641989b52322b468a97f10e4a
Author: san7890 <the@san7890.com>
Date:   Mon May 9 11:57:02 2022 -0600

    Codeowners Housekeeping (#66813)

    I standardized some stuff regarding Codeowners (space between the names and the files they own), and since Maps/Sprites are managed seperately than the other "Multiple Codeowners" Section, I decided to split that out as well (let me know if that was cringe or not).

    I also put Jordie in the Contributors section as well (:cry:) .

commit d78b36fc0135ac8de61bf9babf07bef4839fa959
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 09:58:24 2022 -0700

    Automatic changelog generation for PR #66779 [ci skip]

commit 126d81e5d21f5236d1187518d2a774a4cf0867fe
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date:   Mon May 9 13:58:18 2022 -0300

    New Camera Sprites from Eris! (#66779)

    Resprites the old polaroid camera sprites into ones seen in CEV Eris by Watlerje! (in PR: #3698 of Eris). It also changes the film roll into a film cartridge, akin to classic polaroid cameras.

commit 15ee779cf75b3f4c2e574aee9af2e2cb22530243
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 09:58:08 2022 -0700

    Automatic changelog generation for PR #66711 [ci skip]

commit a020e28305a6154ca771f68133ad1fbcf4f82a45
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date:   Mon May 9 11:58:00 2022 -0500

    Removes "strandling" status effect from a bunch of random places / refactors it (#66711)

    Refactors /datum/status_effect/strandling to utilize signals so that it's not present in a bunch of random places via hard checks and traits.

commit a0cac12e74f4f3d02f7d71ab13bd030987923823
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 09:47:34 2022 -0700

    Automatic changelog generation for PR #66793 [ci skip]

commit 5cef111088adfefdb0b78efc0453f843e5708594
Author: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Date:   Mon May 9 19:47:31 2022 +0300

    Titan's Final Lament - Colossus and hierophant crusher trophy rework (#66793)

    This is somewhat a port of BeeStation/BeeStation-Hornet#6805 with slight changes, credits to Rukofamicom for the original PR.

    Kinetic crusher is supposed to be a high risk high reward weapon, but with current hiero wall trophy it just ends up with the player cheesing mob and boss AIs. To fix this, here we change hiero trophy to spawn a hierophant chaser instead of a wall, which will increase player's DPS without offering them any protection.

    However, this creates another issue: right now colossus is unbeatable with crusher without cheesing it with the wall due to it's shotgun attack which kills and dusts you point blank or 1 tile away, which is extremely unfair and unfun. To fix this, I add what should've been done from the start - make colossus telegraph it's attacks before starting them. Player has 1.5 seconds to react(unlike 3 seconds in the original PR which made the fight much easier) and dodge the attack or at least get away from the colossus to have a chance to survive.

    Since this does make the fight significantly easier, colossus gets a special final attack during which it shouts "Perish" and uses different attacks. Unlike in the original PR, he can only use it once, so it's not as deadly and bullshit. This should make the fight more epic and similar to other bossfights which get cool attacks near the end of the battle.

    Goodbye 4 GBP, you served me well.

commit 70db15d9ecf869e62ae6a388d4ba7f835a4a36ef
Author: tgstation-server <tgstation-server@tgstation13.org>
Date:   Mon May 9 09:31:51 2022 -0700

    Automatic changelog generation for PR #66782 [ci skip]

commit d1d9fe7c733b40bcd2ebf4c2fd9c483dbd0524dd
Author: Pickle-Coding <58013024+Pickle-Coding@users.noreply.github.com>
Date:   Mon May 9 17:31:47 2022 +0100

    Freon combustion burn rate is now based on oxygen moles if there isn't enough oxygen for full burn. Fixes freon hotspots. (#66782)

    For some reason the sign on the if check was reversed, which causes freon burn rate to be based on freon moles instead of oxygen moles if there is lacking oxygen for full burn. Not sure why it got flipped, but I'm just flipping the freon burn rates to correct it, so it should be based on oxygen moles if there isn't enough oxygen for fullburn.

    Also for some reason freon fires checked if the holder was in a turf before reac…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet