End Of Creating Map Votes with One/Zero Options. #70340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there, I read oranges thoughts here: https://tgstation13.org/phpBB/viewtopic.php?t=32549, and I thought it was a pretty good idea. The system itself always coped well with the concept that you could have only one (or none) choices, but there really was never any user feedback in regards to how these played out. So, let's dive into it by just making so that you can't call a map vote if you have 1 or 0 choices, gotta have at least two options to vote, of course.
From a UX standpoint, it makes no sense to call a forced map vote with only one option in this new framework, so let's pass in something to track that as well.
tgstation-server
added
the
Quality of Life
msgerbs
suggested changes
Oct 6, 2022
let's hope this works Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
LemonInTheDark
requested changes
Oct 17, 2022
Watermelon914
removed
the
Stale
Mothblocks
reviewed
Oct 19, 2022
tgstation-server
added a commit
that referenced
this pull request
Oct 19, 2022
Sealed101
added a commit
to Sealed101/tgstation
that referenced
this pull request
Oct 23, 2022
commit a3c791acfe047f82653da1f695ce8ff1371b56bb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 22:24:04 2022 -0700
Automatic changelog generation for PR #70707 [ci skip]
commit a3749cb548d6044ce3ab896d8090999980bafedf
Author: ArcaneMusic <41715314+ArcaneMusic@users.noreply.github.com>
Date: Sun Oct 23 01:24:00 2022 -0400
Fixes the black market uplink path. (#70707)
About The Pull Request
So, it turns out the crafting recipe for the black market was using obj/item/market_uplink to make black market uplinks. Now, as it stands, we only have one market, the black market. As a result, the parent pulls that as well.
However, that doesn't change the fact that the description for the parent is quite literally one of those "You shouldn't have one of these!" sorts of descriptions that we've usually try to report.
Why It's Good For The Game
Cleans up the item paths for future usage of the market system for potentially civilian markets and also makes it seem like the black market uplink actually works. (It does).
commit 4d881a51f56a5e08946314a5858b79f8bd8b9357
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 21:43:41 2022 -0700
Automatic changelog generation for PR #70723 [ci skip]
commit 5a6cd5b7acb6537339033bd8ee842ea6233ee394
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sat Oct 22 23:43:38 2022 -0500
Fixes an edge case heretic sacrifice runtime (#70723)
* Ensures this does not runtime
* Comment
commit 1f3efcd78829ec1af252ba1ff5cf6cff830c7301
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Sun Oct 23 05:43:29 2022 +0100
Fixes infinite bloody bastard swords (#70721)
commit 649aff66acf59cf4b3413c374a0cf6158eb26648
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 21:43:19 2022 -0700
Automatic changelog generation for PR #70720 [ci skip]
commit 6a447bc3a0ffb2a8ec4393ec606777443fc89b30
Author: Rhials <Datguy33456@gmail.com>
Date: Sun Oct 23 00:43:16 2022 -0400
Head pikes now drop their mounted heads upon destruction (#70720)
* wow this doesnt look right
* better idea
commit bad08cd926ed1b9f0453007531f732d951327906
Author: Changelogs <action@github.com>
Date: Sun Oct 23 00:33:29 2022 +0000
Automatic changelog compile [ci skip]
commit 665b80405f750552f78b589e6a5c394e594b347a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 16:22:51 2022 -0700
Automatic changelog generation for PR #70724 [ci skip]
commit 3990152f38fe97015079fd88e5938490bc21fe15
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sat Oct 22 18:22:47 2022 -0500
Fixes runtime with wendigo slam (#70724)
commit a74f77f4ba8cdaa96cc5f3387ab5aac1387be639
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:31:02 2022 -0700
Automatic changelog generation for PR #70661 [ci skip]
commit 218ecaad234a7147401fd7a7a64b6c8d3f741ec8
Author: Major0911 <62590678+Major0911@users.noreply.github.com>
Date: Sat Oct 22 23:30:59 2022 +0300
New popcorn (#70661)
* New popcorn
Two new types of popcorn have been added - salted and with caramel.
* Update code/game/objects/items/food/misc.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Update code/game/objects/items/trash.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Update code/modules/food_and_drinks/recipes/tablecraft/recipes_misc.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Update code/modules/food_and_drinks/recipes/tablecraft/recipes_misc.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Update code/modules/food_and_drinks/recipes/tablecraft/recipes_misc.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* Update code/modules/food_and_drinks/recipes/tablecraft/recipes_misc.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* New popcorn
The structure of the new files has been slightly changed in favor of convenience.
* Update code/game/objects/items/food/misc.dm
* New popcorn
Minor code fixes
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
commit c2f124a3d298c68c72bf8711edd1b8103cc48716
Author: Tastyfish <crazychris32@gmail.com>
Date: Sat Oct 22 16:10:48 2022 -0400
Fixes monkey AI runtimes (#70696)
* Fixes monkey combat runtime
* better monkey subtree
commit 51751a4ffda85cd6b211a22726778c80864a9de0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:10:26 2022 -0700
Automatic changelog generation for PR #70709 [ci skip]
commit 3582aa77bb68d43c1ebbff9e06226bf3089cb07a
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Sat Oct 22 13:10:22 2022 -0700
Slightly optimizes reagent splashing (#70709)
* Slightly optimizes reagent splashing
Ok so like, before, splashing a reagent performed a rudimentary
floodfill based off atmos connectivity.
This was really slow, because it did it using orange(), and repeated
orange()s to cut out JUST the rim, because we
needed to ensure things were ordered.
I've changed this to use floodfill. I've also moved some code that was
in a second loop into the first one, and replaced a repeated in check
with a single use of &
This is still not optimal for large ranges, because we filter by connectivity first
and THEN view, but it's faster for smaller ones.
BTW I'm also capping the max spread range at 40x40 tiles. If you want
more then 1600 you can rot in hell.
This takes the (uncapped range) cost of deconstructing a highcap tank
from 40 seconds to 0.16.
I hate this codebase
* god damn it
Co-authored-by: san7890 <the@san7890.com>
* whoops that's redundant
Co-authored-by: san7890 <the@san7890.com>
commit b5cbdeb3ea87c6e3e1bbb21f2030099bdc4a7d3f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:07:06 2022 -0700
Automatic changelog generation for PR #70700 [ci skip]
commit c8bd98098bc61b4d645938d14179f234b97c2f02
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sat Oct 22 15:07:02 2022 -0500
Fixes minor fleshmend runtime from clearing scars (#70700)
All scars is a lazylist.
commit d1abd37091f57ccd2508c33e86ed47d227820c1e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:06:58 2022 -0700
Automatic changelog generation for PR #70702 [ci skip]
commit 401759771071af1ea479498d3c8d83bc8472be25
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sat Oct 22 15:06:55 2022 -0500
Fixes runtime from voting action `Remove()` (#70702)
Fixes runtime from voting actions due to calling remove on ownerless actions
commit 9aeac447512b2dc9a94ba76a1b79f461fd7aadd2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:06:49 2022 -0700
Automatic changelog generation for PR #70703 [ci skip]
commit 704b81fcd8b9a5899091c54c3664fb44fa64112b
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Sat Oct 22 15:06:46 2022 -0500
Fixes cult dagger grant runtime. (#70703)
Fixes cult dagger grant runtime. Owner is not guaranteed to be non-null.
commit f00fb9e5a155442ef90c3c4c1c283505901aa084
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 13:06:35 2022 -0700
Automatic changelog generation for PR #70713 [ci skip]
commit fc9024d35daf421a0ba69ad0fc1cc4b1921ddded
Author: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Date: Sat Oct 22 15:06:31 2022 -0500
Refactors radios to not use the prison_radio var (#70713)
* done
* typos
* condense
Co-authored-by: Candycaneannihalator <candycane@thisisnotarealaddr.com>
commit 1e2b5601614570a83c618c9eb516d44d9c173c72
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Sat Oct 22 04:42:17 2022 -0700
Automatic changelog generation for PR #70714 [ci skip]
commit 6e3ee074c79cd3c97b8b77908164c85b7e0c2a9d
Author: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
Date: Sat Oct 22 06:42:14 2022 -0500
The H.O.N.K. can be built again. (#70714)
Fixes an error causing the HONK mech to be unbuildable.
commit f36c5f82f50164051f7a7080c6df1b811c504509
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 21:28:03 2022 -0700
Automatic changelog generation for PR #70704 [ci skip]
commit 50db307d2ec862fe7d0538b319f8c96704c8aa2e
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Fri Oct 21 23:27:59 2022 -0500
Fixes nutition reagents healing robotic limbs (#70704)
commit 7089ad7046c1f42bf266f24f2d26c5d8edbdf462
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 21:25:00 2022 -0700
Automatic changelog generation for PR #70705 [ci skip]
commit a5e579e0c8539cd0d6f7098980d96d923d553214
Author: Funce <funce.973@gmail.com>
Date: Sat Oct 22 17:24:57 2022 +1300
Admins can now safely cancel the "Admin PM" verb (#70705)
commit 6ad55f70e84097baeb6e45bdcd3d008777b83545
Author: Changelogs <action@github.com>
Date: Sat Oct 22 00:31:44 2022 +0000
Automatic changelog compile [ci skip]
commit cbd035888b9aa06b06d7f6f3364b3f500db579f2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 15:11:02 2022 -0700
Automatic changelog generation for PR #70680 [ci skip]
commit 960a245c7a3ce01ce98fcb565e73b8d64fb43775
Author: DannyBoy3642 <98357253+DannyBoy3642@users.noreply.github.com>
Date: Fri Oct 21 15:10:59 2022 -0700
Allows flasks to be stored in shoe pockets (#70680)
* Added flasks to pocket.dm shoes
Adds flasks to the valid item storage list for jackboots, clown shoes, and other similar shoes
* Added flasks to pockets.dm shoes
Adds flasks to the valid item list for storage inside jackboots, clown shoes, and similar shoes
Co-authored-by: AeronaDF <aeronadf@gmail.com>
commit bd7e87c8ea5e70f353836f262cdd76a03c94885c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 15:10:36 2022 -0700
Automatic changelog generation for PR #70693 [ci skip]
commit ee77e17fff49f33f659fd0ca29257ab524784b8b
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Fri Oct 21 18:10:32 2022 -0400
Fixes ungenerated turf on Clockwork's ruin (#70693)
The area used in the clockwork ruin didn't have cave generation on it, so I swapped it for the /unexplored subtype of it, which does. No more ungenerated turfs! Hopefully.
commit 59aca454803d80958e84b63b1119e689711b18ae
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 15:09:58 2022 -0700
Automatic changelog generation for PR #70679 [ci skip]
commit 1619a5fe84d581f5469ef3e02ce3f4af2ea45f33
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Fri Oct 21 18:09:54 2022 -0400
Fixes some inconsistencies with computers (#70679)
* Modular computers now have their initial name if they don't have an idenfitication and job, which previously meant they would have the name ()
* Removes MACHINE modular computer's process, because all it did was update the name, then call computer's process. Now it just does what every computer does, BUT UpdateDisplay on ITEM modular computers will now update the machine's name.
* Additionally, I moved the modular computer processor's New to an Initialize, and removed the shutdown_computer code, because we already register update_icon signal to update the computer's appearance, why do we need to do it twice?
commit 4d2df6db93f22502a488f46a3d27b75f14ba9b21
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 15:05:26 2022 -0700
Automatic changelog generation for PR #70683 [ci skip]
commit e1ab5c56cdbb4cd40fcefbd9ab8c20eec97ff28a
Author: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Date: Sat Oct 22 00:05:22 2022 +0200
gygax no longer resets movespeed when ending overloading (#70683)
gygax no longer resets movespeed when overloading
Co-authored-by: TiviPlus <572233640+TiviPlus@users.noreply.com>
commit d701f17b68dc431d6e9aaca16744319be5441bc3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 15:04:37 2022 -0700
Automatic changelog generation for PR #70686 [ci skip]
commit df01c42838822c52e89f5a159d05d31f77a4b609
Author: Tim <timothymtorres@gmail.com>
Date: Fri Oct 21 17:04:33 2022 -0500
Add AltClick context screentip to IDs (#70686)
Add alt click context screentip to IDs
commit 6e2a8fb593dafe066c69c2e529f3277fa1564b8c
Author: Tastyfish <crazychris32@gmail.com>
Date: Fri Oct 21 18:04:27 2022 -0400
Fixes autodoc for orbit_icon (#70695)
Fixes doc for orbit_icon
commit ef7796b4515c3b21b94a64537722d7b2b985641b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 13:50:33 2022 -0700
Automatic changelog generation for PR #70478 [ci skip]
commit d709141412ae808be2e505dd813cde8ec529aae9
Author: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Date: Fri Oct 21 13:50:30 2022 -0700
Tram door and destination enhancements (#70478)
About The Pull Request
We had the code in lift master to open and close doors on lift objects like the elevator or tram, but we didn't actually have it applying to the tram.
This fixes it by associating windoors to the tram when the map initialises, and then the open/close door procs can be run on that list.
tramdoors
Why It's Good For The Game
The tram windoors work properly. You can still bump them open them manually and jump out like an action hero.
Changelog
cl LT3
fix: Tramstation's tram doors now work properly.
add: The tram has a destination sign, and the call buttons have a status display for where the tram is and if it's operational or not.
/cl
M3hillus, CourageTheCat, Twaticus, FedTheCat, Zergspower, and DannyBoy3642 reacted with thu
commit 7088bdc2c85285ceb660b554188afab13b0341e1
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 12:51:42 2022 -0700
Automatic changelog generation for PR #70637 [ci skip]
commit fc8d84a3aeb3e9350d425ff1d0120bb6b23a22a8
Author: tralezab <40974010+tralezab@users.noreply.github.com>
Date: Fri Oct 21 12:51:38 2022 -0700
Splattercasting, an offensive, sanguine equivalent to Lichdom. (#70637)
A spell similar to lichdom, though with different conditions.
Dramatically reduces your cooldowns
Cooldown saved is converted into blood lost
You are now a vampire, drinking blood refills your bloodwell, and you're naturally slowly running out.
New school, Sanguine spells, which aren't affected by splattercasting and generally involve blood.
Species change allowed by @SuperNovaa41
commit 8cfcb98b885c5735c3677ef84446980125405d90
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Fri Oct 21 09:57:12 2022 -0700
Automatic changelog generation for PR #70685 [ci skip]
commit 21a07ddf81ecb917e4f10b888155c58dc045caec
Author: Sealed101 <75863639+Sealed101@users.noreply.github.com>
Date: Fri Oct 21 19:57:08 2022 +0300
Fixes AIs `on_click` failing where it isn't supposed to fail (#70685)
About The Pull Request
As stated in #70664, AIs were unable to interact in any way with any object that was located on coordinates that were divisible by 16. See the walk-through in the issue, tl;dr is: math was adding +1 where it shouldn't have, which resulted in coords that are multiples of 16 to be mistakenly counted a part of another camera chunk
Why It's Good For The Game
UPDATE: Fixes #70664 actually, as the issues in that report were tied to the AI running can_see on its own loc in some way, shape or form and THE AI GRID OF DOOM was breaking it.
No more invisible grid that completely blocks AI interactions along with any issues that would be triggered by either the AI itself or the objects being located in THE AI GRID OF DOOM.
commit 577022df0c66ad238802e4cc11af36c41643410b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 23:42:02 2022 -0700
Automatic changelog generation for PR #70467 [ci skip]
commit e05699709338e30ecde1bcd8f61d559ed2d7798e
Author: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Date: Fri Oct 21 01:41:58 2022 -0500
Screwdriver Pen (#70467)
* base
* bam
* icon and element fix
* terminate
* Update code/modules/paperwork/pen.dm
* Update code/modules/paperwork/pen.dm
* sigh
* Update code/_globalvars/lists/maintenance_loot.dm
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
* Update code/modules/paperwork/pen.dm
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
* Update code/modules/paperwork/pen.dm
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
* factoring
* escapism
* balloon notif
* bottom vars
* Update code/modules/paperwork/pen.dm
* Update code/modules/paperwork/pen.dm
* Apply suggestions from code review
* updates the sprite to be based on new pen icon
* pushes the comsig call to an attack_self
* Update code/modules/paperwork/pen.dm
* Update code/modules/paperwork/pen.dm
* imagos icon
Co-authored-by: etherware-novice <candy@notarealaddr.com>
Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Candycaneannihalator <candycane@thisisnotarealaddr.com>
commit cbb7f14e53a930920657379d1cab127ef08d6f18
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Fri Oct 21 07:39:35 2022 +0100
Fixes turbine console runtime (#70653)
commit 585f8fc1c3e1a579b7c37372a7669910a6e0138f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 23:31:33 2022 -0700
Automatic changelog generation for PR #70674 [ci skip]
commit 240b3c301d7fefbe5fb1798b32480271912eb096
Author: Pumpkinoe <61306435+Pumpkinoe@users.noreply.github.com>
Date: Fri Oct 21 19:31:29 2022 +1300
Adds a new poster in the form of a movie poster: THE BLOOD GEOMETER (#70674)
Adds the bloodcult poster
We rockin now....
commit 8c72176668c1349fe0e8c4b2249fd4b3276d0da0
Author: SeigaSeiga <seigashearwood@gmail.com>
Date: Fri Oct 21 07:30:29 2022 +0100
fixes some extremely minor graphical consistency issues with the bible icons (#70677)
bible consistency fixes
Co-authored-by: SeigaSeiga <seigacomm@gmail.com>
commit efb55c82feaf494cb015a52c68023db2412db6fe
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 21:51:47 2022 -0700
Automatic changelog generation for PR #70671 [ci skip]
commit 83c22210c38abfcbe9315ad3b2a761c1896bb8b1
Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Date: Thu Oct 20 21:51:43 2022 -0700
Fixes prisoner icon on orbit ui (#70671)
fixes prisoner icon
commit 71450ef923467812b7a4d123918bef225f675f84
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Thu Oct 20 20:04:42 2022 -0700
/mob/living/simple_animal is now frozen. Add a unit test to block all new simple_animal subtypes. (#70669)
* Add a unit test to block all new simple_animal subtypes
* Remove TEST_FOCUS
* Just To Be Sure
commit 27be7afdf1332f307cf37f7b493558c78a27092f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 19:08:30 2022 -0700
Automatic changelog generation for PR #70650 [ci skip]
commit 0bf88c075fe8acfc2ff6b3b66b4b8aeecf3a46a9
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Thu Oct 20 21:08:26 2022 -0500
Fixes Sneaksuit not hiding sec huds (#70650)
commit ecc1ee7dd8732770aac5677b613deb8cd3c6ebbc
Author: wixoa <wixoag@gmail.com>
Date: Thu Oct 20 22:02:32 2022 -0400
Fix an error message in `ReadLayerGroup()` (#70666)
commit ca50c3cf1a8ce56667d4f7cfe3853ab1d9c239cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 19:02:07 2022 -0700
Automatic changelog generation for PR #70668 [ci skip]
commit de48b6a1abb883c7532954eed031399b1397b4df
Author: dawsonkeyes <76002401+dawsonkeyes@users.noreply.github.com>
Date: Thu Oct 20 20:02:03 2022 -0600
makes wendigo ground slam not a global proc (#70668)
commit 3d62d797e873a30b039ae04d28abe59c15158c17
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Fri Oct 21 02:03:46 2022 +0100
Fixes runtime when empty PAI gets emp'd (#70660)
commit 85e24c154f13bf5e44ca2c2f2612757d38fbcc54
Author: ShizCalev <ShizCalev@users.noreply.github.com>
Date: Thu Oct 20 20:33:53 2022 -0400
Inhand unit test modularity support p2 (#70497)
commit 391d173fe40767c5d9c02919349034fa3b7a7ccc
Author: Changelogs <action@github.com>
Date: Fri Oct 21 00:27:54 2022 +0000
Automatic changelog compile [ci skip]
commit add57bf11bafb76667808e2ab1d422f7b9aedd46
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 14:57:10 2022 -0700
Automatic changelog generation for PR #70530 [ci skip]
commit f1215a12b4996a566891de9f31f07258310f27a0
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Thu Oct 20 16:57:07 2022 -0500
Changing species now maintains Brain traumas, Cybernetic implants, Liver traits, organ damage, and Heretic Living Heart (#70530)
About The Pull Request
Implements additional code in before_organ_replacement in additional places, to better maintain cohesion when species changes take place.
Brain traumas will now carry over on species change
Having synthetic / cybernetic organs will now carry over on species change
Liver job traits will also carry over on species change
Organ damage will, in most cases, carry over on species change (only if the new organ is identical to the old)
The heretic's Living Heart will attempt to carry over to species change, if it's valid
Some species will still not, as it will attempt to give heart -> liver or something and be invalid
Heretic Living Heart is now a cooldown action. Still not really content with the current state of it, it could use some improvements.
Fixes #42308
Fixes #35539
Fixes #69574
Why It's Good For The Game
Removes a lot of exploits involving using forced species change to get rid of stuff like quirks / permanent brain traumas and similar.
commit b5320ceef016da38ea6bd746302f06a9414e1f01
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 14:56:57 2022 -0700
Automatic changelog generation for PR #70649 [ci skip]
commit 04418087fd0f4db2aab64a96b63c30604488713a
Author: RaveRadbury <3204033+RaveRadbury@users.noreply.github.com>
Date: Thu Oct 20 16:56:54 2022 -0500
Emergency energy shield balloon alert (#70649)
About The Pull Request
Replaces the to_chat securing messages for the Emergency Energy Shield with balloon_alert
Why It's Good For The Game
It's a good candidate for balloon alerts, less chat spam.
commit d03b1f4579d22f9ba50734859c6fc7c362924241
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 14:53:30 2022 -0700
Automatic changelog generation for PR #70657 [ci skip]
commit 06d93b64be75b3ddd8991300f5c42181f391e54e
Author: RaveRadbury <3204033+RaveRadbury@users.noreply.github.com>
Date: Thu Oct 20 16:53:26 2022 -0500
Reading the mime book produces the correct visible message (#70657)
* Adds title book_data precursor to mime book
fix: People can now see when you begin reading the Guide to Dank Mimery
commit 6d12dc69ef97090b2a0bf5b4333540a7e884f63c
Author: Tim <timothymtorres@gmail.com>
Date: Thu Oct 20 10:48:12 2022 -0500
Refactor `/mob/living/carbon/alien/humanoid` to be `/mob/living/carbon/alien/adult` (#70481)
commit 0c34636b0b9a3f8188515f27347b98cdd43849e2
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Thu Oct 20 05:36:33 2022 -0700
Automatic changelog generation for PR #70644 [ci skip]
commit 6e6dbbabe0c34e3adf69cdc6acddb9402feeae90
Author: ShizCalev <ShizCalev@users.noreply.github.com>
Date: Thu Oct 20 08:36:28 2022 -0400
Fixes incorrect mine examine span (#70644)
commit 17b6de8b814826ccea58ecce366f4868f7418ef7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 20:35:30 2022 -0700
Automatic changelog generation for PR #70670 [ci skip]
commit 1a536ed0003b4c33081f432d61f2f3f42bb87d31
Author: san7890 <the@san7890.com>
Date: Wed Oct 19 21:35:26 2022 -0600
Fixes Type Mismatch Causing Infinite Irrevocable Welding (#70670)
* Fixes Type Mismatch Causing Infinite Irrevocable Welding
(and plasma cutters too, because that seemed to be broken as well).
Hey there,
Behavior introduced in #70235 caused this shit to break, causing infinite welding that you could never undo, with an overlay that could never be removed. This was due to a type_mismatch runtime that plagued servers for a bit, I just stole the pattern from Lemon and used LAZYADD/LAZYREMOVE and that seemed to have fixed the issue.
* fixes plasmacutter since it had the same broken pattern
commit 940d96d5ad4e0f6dcf56725702e4493f5b95a692
Author: Kylerace <kylerlumpkin1@gmail.com>
Date: Wed Oct 19 20:27:41 2022 -0700
fixes _queue_verb() runtiming from /client/Click() thousands of times (#70647)
* fixes _queue_verb() runtiming from /client/Click() and adds info
* Update code/controllers/subsystem/verb_manager.dm
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 79859807ac39421431b180b179e48e095628d0a5
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 20:27:05 2022 -0700
Automatic changelog generation for PR #70646 [ci skip]
commit f82ee681e28959edbb240ad9a94695fd0b638a0a
Author: Rhials <Datguy33456@gmail.com>
Date: Wed Oct 19 23:27:01 2022 -0400
[NO GBP] Re-adds the sprite for the command intercom (#70646)
WHOOPS
commit 70a4133889dbdd289a21b7612e6a08574e100351
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 20:02:20 2022 -0700
Automatic changelog generation for PR #70645 [ci skip]
commit 3e52d8016a90aff88b1afc021a2400bc277d3aad
Author: Rhials <Datguy33456@gmail.com>
Date: Wed Oct 19 23:02:17 2022 -0400
Fixes a mounted sleeper runtime related to log_combat (#70645)
* lets try it
* adam driver from getting over it w/ benny foddy
commit 6e51dcc98c991f3666d7d3920ce692dce1899fb4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 19:51:40 2022 -0700
Automatic changelog generation for PR #70521 [ci skip]
commit b3e0a91905006c76092517240b6e881b45dfa0a0
Author: SeigaSeiga <seigashearwood@gmail.com>
Date: Thu Oct 20 03:51:37 2022 +0100
Adds a new Shinto-themed Chaplain robe and holy book (#70521)
Co-authored-by: SeigaSeiga <seigacomm@gmail.com>
commit 5ae912d0ea83dee7a3be0c3ac95add753d7a4bf3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 19:33:02 2022 -0700
Automatic changelog generation for PR #70622 [ci skip]
commit d08e0e23ddecda2159e24908a9dc3011129871fc
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 21:32:59 2022 -0500
Fixes being unable to old a paper up to AI cameras if you are "unknown" (#70622)
* Fixes runtime error due to passing a ref into a string concatination macro
* Name
commit f34be104f15cbe0c83930795ef945ced9f699551
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 19:23:17 2022 -0700
Automatic changelog generation for PR #70580 [ci skip]
commit 03f2f3e2b0cd0066955f7201b33fa09998a5a661
Author: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Date: Wed Oct 19 19:23:13 2022 -0700
Orbit refactor + features part dos: Icons, health bars. (#70580)
* orbit refactor + features
* Via suggestion
Co-Authored-By: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-Authored-By: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
* cleanup
* readds heatmap optional + bug fix
* fixes bugs
* naming conventions
* what
* indeed
* modular via suggestion
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
* nice
* pai fix
* misc searching
Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
commit 986d9516e7dddaccd5618f2d1518292bd799eb29
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 19:18:21 2022 -0700
Automatic changelog generation for PR #70578 [ci skip]
commit 2011c8586d4b9768f998686dfd39cde11554f98b
Author: Tastyfish <crazychris32@gmail.com>
Date: Wed Oct 19 22:18:17 2022 -0400
Fixes directional light overlay leaking the lighting mask and not updating direction correctly (#70578)
Fixes light direction/overlays when changing holder of light overlay
commit 9bf96c77630b39cb4251866d474770e59c488f7c
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Wed Oct 19 22:16:57 2022 -0400
Misc PDA code improvements (#70555)
* How to conflict with PRs: A guide
* Removes unnecessary support for the now-removed job disks from Tablet's TGUI menu, and tablet's ui_act.
* Adds autodoc comments to computer files
* Removes the unused 'unsendable' var on computer files
* Generally improves code on tablets, now process isn't looping through every idle thread twice!
* Moves the check for program in idle_threads above checking if supported by hardware, because it's already running, so there's no need to check.
* eh
* revert a scipaper change
commit c70d47787f5b13c151f5017f9edcdcd94a54e6b5
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Wed Oct 19 18:58:55 2022 -0700
Codeowns rendering (#70667)
Gives myself codeowner over the visuals guide, all hud stuff (including
rendering) and layers.dm
It's all stuff I'm familiar with, and I especially want updates on
layers.dm changes, and plane master related things
commit a9e8504b1a450db7ffee73b1681249c407058e96
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 18:54:35 2022 -0700
Automatic changelog generation for PR #70500 [ci skip]
commit 1fe9528b803fa39a2cb795112273b76794e346ff
Author: Kyle Spier-Swenson <kyleshome@gmail.com>
Date: Wed Oct 19 18:54:32 2022 -0700
Fix admin transforms transfering the wrong client (#70500)
* Fix admin transforms transfering the wrong client
Ghost copies of minds should not get cloned onto a new mob because the original body could have been taken over (via offer body to ghost or other fuckary) and then transfer_to will transfer the controller of the og body instead of the ghost body.
I could fix this bug from happening with more with raw ckey checks, like the debug line I added, but this is part of code that controls when antag status transfers between bodies while admin bussing, and so i want it's behavior to either be intentional or clearly buggy, no in between, so i'm not adding a check to verify the mind key is the same as the mob key.
* Say the mob's name for log correlation
commit a87d6c7e317def9546c3125db580a7af0a93cb7f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 18:19:09 2022 -0700
Automatic changelog generation for PR #70591 [ci skip]
commit a7aeb9c48e4028eec6e7e8e3fa0896beca2b6e45
Author: ShizCalev <ShizCalev@users.noreply.github.com>
Date: Wed Oct 19 21:19:05 2022 -0400
Janicart refactor (#70591)
Showing this oldie a bit of love with some minor modernization.
cl ShizCalev
refactor: Modernized the janicart!
fix: Fixed janicart examine message not mentioning how to dump it when it was almost empty, but not completely empty.
fix: Fixed varedited janicarts having no caution signs visible when they went over 4 signs.
/cl
commit f7db90f566f841d5fe766fde938e44e7fe440f3a
Author: Tastyfish <crazychris32@gmail.com>
Date: Wed Oct 19 20:54:48 2022 -0400
Updates GH actions to use GITHUB_OUTPUT (#70633)
commit 219907757946efcbf88771a27e9c204aa6826dc7
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Wed Oct 19 17:50:15 2022 -0700
Document NAMEOF and put it in a proper file (#70634)
* Document NAMEOF and move it outside of varset_callback.dm
* Update documentation for consistent spacing, and remove now inaccurate comment
commit c2cf3bf46a602ef44ae323eb4eb4cc6aa8aecfa7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:49:30 2022 -0700
Automatic changelog generation for PR #70636 [ci skip]
commit dbe08425141ab036a4e7dfd021fdf317ba80d2c5
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 19:49:27 2022 -0500
Fixes runtime with eye of god on destroy (#70636)
commit 58dfac6e8fcb76c0b62e96097d1e328ff108d012
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:46:41 2022 -0700
Automatic changelog generation for PR #70638 [ci skip]
commit db66590e7ecf0b5c4db86cef04c7d6b58b56b3b0
Author: san7890 <the@san7890.com>
Date: Wed Oct 19 18:46:37 2022 -0600
Fixes Some Incredulously Fucked Up Recycler Behavior (#70638)
* test one
Hey there!
Did you know that if you toss someone into a recycled emagger, that we delete _all_ of that mob's contents? You probably didn't because this shit is broken broken. Like, ow.
That's because we manually moved an item to nullspace, which caused a _slew_ of odd behavior in the Destroy chain for `obj/item` since it moves it to nullspace at a very specific point in time and makes all of it's assumptions on when you move the thing to nullspace. If it's in nullspace before you call qdel, you would shit out the ass with hanging references stuck on the mob (like `w_uniform` pointing to something in nullspace, like the image above).
All fixed now, though.
* I FUCKING LOVE UNIT TESTS
THIS SHIT WILL NEVER BREAK AGAIN!!!
* i blanked
my guy hasn't moved for twenty minutes
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
* wrong documentation
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit a990d0888aa384b311cc1be2e0195f6ed9d8507f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:42:31 2022 -0700
Automatic changelog generation for PR #70639 [ci skip]
commit 62da5fa3d4a912beb4f89dd582f4323691f76bec
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 19:42:27 2022 -0500
Fixes some ling sting jankiness (#70639)
commit cdb16fcb47a911a21500c9837e8852eb1a0b6027
Author: Changelogs <action@github.com>
Date: Thu Oct 20 00:39:21 2022 +0000
Automatic changelog compile [ci skip]
commit 1fe0a9f60a0f82c53d49440b3906ddd9aa463973
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:34:37 2022 -0700
Automatic changelog generation for PR #70641 [ci skip]
commit 51ea51e9e4e6ca84a0e21caa492ed270fc6f3924
Author: Ebb-Real <95765134+Ebb-Real@users.noreply.github.com>
Date: Thu Oct 20 02:34:34 2022 +0200
Chairs now get placed in the direction you are facing (#70641)
chair direction fix
commit 218a153464bd52bbd4320a0b345e426f5664200e
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Wed Oct 19 20:34:08 2022 -0400
Removes a ton of unused tablet vars, re-organizes the rest (#70344)
* Removes a ton of unused vars, re-organizes the rest
Removes a ton of unused vars from Modular computers
Re-organizes the rest, and adds autodoc comments to most of them
Moved 2 vars (saved_image and invisible) from the tablet to the messenger app, since that's where it was used. I didn't see the point of having these vars be on every computer anyways, only PDAs have the app.
Renames Clown's honk virus var
Makes Messenger app's saved image, actually used.
* static list and NODECONSTRUCT_1 check
* oops
commit 6e95475519101fd0187daebe8b90ef0fd7eb9e4d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:32:39 2022 -0700
Automatic changelog generation for PR #70385 [ci skip]
commit b1ed2d03f252179dc11da4ff3e35307aef6ffa36
Author: Sealed101 <75863639+Sealed101@users.noreply.github.com>
Date: Thu Oct 20 03:32:35 2022 +0300
Fixes AI camera static not updating when the AI enters a mecha (#70385)
* it just works
* kick the eye out of the mecha on mob_exit
commit b8214cedfc7708e93e1ab390e19fc0a16b0b1753
Author: orange man <61334995+comfyorange@users.noreply.github.com>
Date: Thu Oct 20 13:28:16 2022 +1300
Automatic TGS DMAPI Update (#70662)
Update TGS DMAPI
Co-authored-by: tgstation-server <tgstation-server@users.noreply.github.com>
commit 1a787e8dc606adfeefc4c1f3c5e951619adb7ef0
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:26:24 2022 -0700
Automatic changelog generation for PR #70483 [ci skip]
commit b59cc135ab8d2874df76a8039525a51ca450fb4d
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 19:26:20 2022 -0500
Moving around while non-existent will not give you a message saying you're buckled to the concept of non-existence (#70483)
* Being removed from existence no longer provides strange feedback messages
* Immortality talisman, too
commit 83734e84bc01810c3d493fb38c476f9c86b5add9
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:25:12 2022 -0700
Automatic changelog generation for PR #70631 [ci skip]
commit cf6008bbe6a239ed7b9335be450a713fa6ef98fd
Author: ShizCalev <ShizCalev@users.noreply.github.com>
Date: Wed Oct 19 20:25:09 2022 -0400
Fixes invalid bodypart on nature shuttle (#70631)
Fixed broken/missing gibs on the nature shuttle.
commit 7bacc92c84561dd9be10c12e7163de0f25820069
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:24:54 2022 -0700
Automatic changelog generation for PR #70609 [ci skip]
commit 0958ebb7e84fbd38a5096ea8e58d36415e1498c2
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Thu Oct 20 01:24:50 2022 +0100
Removes CO2 filters from kilo and icebox (#70609)
Removes the CO2 filters in kilo and icebox atmos that would pump CO2 back into scrubbers.
These were removed from every other map after the ballast was removed from thermomachines in #66411 and serve no purpose after that change.
commit 245dbb9da5433aca5f3c6ab803e05854ffaaba47
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:24:13 2022 -0700
Automatic changelog generation for PR #70621 [ci skip]
commit 60d12faed5bffc2da4b2137d5def13700d0aa063
Author: Cass <109886893+Cass-Bitchcoin@users.noreply.github.com>
Date: Wed Oct 19 19:24:08 2022 -0500
Icebox Book Scanner Placement Adjustment (#70621)
nudges the position of the book scanner in the library to look better with the new sprite for it.
commit f51256df2e4287562c65dc07e48fc334d1028feb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:23:49 2022 -0700
Automatic changelog generation for PR #70620 [ci skip]
commit ea6bb0ed854ff462e44a2d2c015ef50c2514610c
Author: Cass <109886893+Cass-Bitchcoin@users.noreply.github.com>
Date: Wed Oct 19 19:23:45 2022 -0500
Icebox Aft Primary Hallway Camera Adjustment (#70620)
This repositions a camera in Icebox's aft primary hallway so that it has better coverage of the hallway. It is now located one tile north of the fire doors there instead of the very end of the hallway. I have also moved the fire alarm one tile north to accommodate this change.
commit 8ac5e5e61c3690cfddd0cdef29bf19cbe7023e10
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 17:23:22 2022 -0700
Automatic changelog generation for PR #70603 [ci skip]
commit b4827ad2d8ce90922188b90946c26246fc84a204
Author: Cass <109886893+Cass-Bitchcoin@users.noreply.github.com>
Date: Wed Oct 19 19:23:19 2022 -0500
Icebox Service Unrestricted Helper Fix (#70603)
This removes unrestricted helpers in service maintenance on Icebox that led to the service hall, potentially trapping people without access to the doors there. Additionally, I have added unrestricted helpers that will allow those without service access to be led out of maintenance and the service hall to areas with public access.
commit a625fc8038f264c7fdb978bbde3e533aaba20373
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Wed Oct 19 13:00:02 2022 -0700
Cleans up the fallout from plane cube (#70235)
* Cleans up the fallout from plane cube
Alright.
Makes cleaning bubbles respect planes
Adds support for updating overlays on move, fixing an issue with pointing at items
Adds better error messages for failing to provide args for mutable_appearance()
Fixes a bug where string overlays were not respecting insertion order
* Adds documentation for offset spokesman and offset_const
* Better stack trace
* Removes some redundant uses of cached MAs
At this scale, attempting to cache MAs like this has 0 impact on anything
And just makes things more messy then they need to be
* ensures fullscreen objects START offset, so things are always proper
* ensures chatmessages always have the right offset
* fixes compile
* whoops, the above lighting plane should actually be ABOVE the lighting plane
* fixes compile, also cleans up the fire overlay a tad
* Adds a unit test for plane masters that are shrunk by multiz being double shrunk
This is slightly hacky because of how I'm handing the plane master
group, but it's not THAT bad, and gives me some real good coverage
* Properly targets the seethrough plane at the game world plate. This fixes unit tests, and also just makes more sense
* whoops
* oh
* adds datum support for allocate(), cleans up a harddel from testing
* Makes camera chunks index at 1, and also makes them support non powers of two sizes, since that was unneeded
* fixes runtime in allocate
commit 4b51eb2504c1c11ee3e5cada96d83a5b9460bc4f
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 12:43:22 2022 -0700
Automatic changelog generation for PR #70630 [ci skip]
commit c693c9a5161e9e41ed57192bfbf7f056afa54475
Author: RikuTheKiller <88713943+RikuTheKiller@users.noreply.github.com>
Date: Wed Oct 19 22:43:19 2022 +0300
Fixes lung swapping giving you false air alerts and slightly improves their descriptions (#70630)
commit f566d3de72c6958a059613aab50501410d923a4c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 11:44:39 2022 -0700
Automatic changelog generation for PR #70635 [ci skip]
commit 78ac928b54d071404e01327823afa3cfdf47b208
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 13:44:36 2022 -0500
Fixes organ `on_death` being called for alive mobs (#70635)
commit ada65e7575776be7e2470efa61eb99c8050b4c7b
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 10:54:12 2022 -0700
Automatic changelog generation for PR #70624 [ci skip]
commit d25508d836b196565fcce39693d3bc6a6d1877fe
Author: Profakos <profakos@gmail.com>
Date: Wed Oct 19 19:54:07 2022 +0200
Updates chitinous armor description (#70624)
commit a1cc906a451cd61c3af588dde0d2b74a62acc6cb
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 09:23:23 2022 -0700
Automatic changelog generation for PR #70628 [ci skip]
commit 1497e541f485ec32ce93a851772809902bfd2f48
Author: Paxilmaniac <82386923+Paxilmaniac@users.noreply.github.com>
Date: Wed Oct 19 12:23:19 2022 -0400
[NO GBP] fixes some silly stairs slipups (#70628)
Two things:
Stone stairs didn't actually line up, not a soul would have noticed because mappers probably aren't gonna use it for a while, but I fixed it anyways.
Second, you could still build mat datum stairs freely without the whole frame system, invalidating its existence, so I've fixed that too. You can still build mat datum stairs, you just need a stairs frame made of iron or wood first.
commit 1f67c5bf1191ebac7ba36a3ddfd594f2edbefb32
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 07:05:16 2022 -0700
Automatic changelog generation for PR #70558 [ci skip]
commit 5156834f16b797d2a915a63e98cb7ec7b4ab2afe
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Wed Oct 19 15:05:12 2022 +0100
Fixes mining modsuit storage breaking after recharging it with plasma (#70558)
* Adds QDELETED check to inserting items to storage
commit 07a37789ebd8990e4c38d034a85525caa5ab369a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 03:34:50 2022 -0700
Automatic changelog generation for PR #69904 [ci skip]
commit cd3a7789153441a80bce6b627d460c73e648c8e4
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Wed Oct 19 03:34:45 2022 -0700
PKP Mind Virus: Glorfing Cigs edition (#69904)
* PKP Mind Virus: Glorfing Cigs edition
If you glorf while smoking you'll get the cig stuck in your throat, leaving you unable to breath, speak, or eat. Based off the sort of cig you have a random delay before you vomit up the cig. (Pipes last forever don't philoso-larp kids). Other players can help you by using the help action on you while you're hurt, which leads to something imitating the himelich manuver, a broken chest, and a vomited up blockage. Other forms of vomiting will work too, if that's even applicable.
Oh I fixed a bug in vomit code. Because paralyzing you forces you to the ground, thus changing your dir, paralyzing vomits always went down. This is cringe, easy fix tho.
Ah and I added some extra functionality to sound loops too. You can set them to pick and take from the provided list, then refilling it once it's empty. This keeps some variety while preventing the risk of repeat sounds
Oh and I added some new signals. Some misc ones, for force say and a different kind of help then the existing one, which I renamed. One for breathing, which I used to clean up leroxin. I was planning to hook this but didn't need to in the end.
One for vomiting too. and eating. Also added a way to update looping timer delays. Forgot about that, I also added variable delay for sound loops, because I thought it sounded better here.
Features audio courtesy of our very own san7890, and the quake jump sound.
commit 56a8387b96fb982aea12a1a77b4de0909a751ddc
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 03:20:43 2022 -0700
Automatic changelog generation for PR #70618 [ci skip]
commit 0ac5a9b83b4e68d0b01bc90da9fa5e41347778cc
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Wed Oct 19 03:20:40 2022 -0700
Fix training toolboxes not setting vis_flags correctly (#70618)
Fix training machines not setting vis_flags correctly
commit c8efa0ee300a583d92eac9513f0a28fa4174fd91
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 03:19:14 2022 -0700
Automatic changelog generation for PR #70616 [ci skip]
commit 4edccb07f275262ce53adf5dbc144aac8e5f2e38
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Wed Oct 19 03:19:10 2022 -0700
Remove unnecessary doorjack visible messages (#70616)
commit 1203c483dbac287a516ff7fcb421809deee724a7
Author: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
Date: Wed Oct 19 03:17:13 2022 -0700
Fix test merge bot not patching comment (#70545)
* Support test merge bot patching old comments
commit 6a0fe4fe8c78186ac6c0a7d92062be3480d68e9a
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Wed Oct 19 02:54:52 2022 -0500
Fixes improper hydro `attack_hand_econdary` return (#70542)
commit 98fdf194e17f004974551720bbcf897e301a5778
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 00:54:33 2022 -0700
Automatic changelog generation for PR #70182 [ci skip]
commit 364cd3828519d7ffe3166df765e8ba29c90a4738
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Wed Oct 19 03:54:29 2022 -0400
[MDB IGNORE] Makes only station areas, station areas. (#70182)
* Makes only station areas part of Statioj
* Makes only subtypes of /area/station be part of the station
* Removes Icemoon and Shuttles as a check for Anomaly placers as they aren't needed anymore, not being part of shuttles.
* Removes a ton of uses of NO_ALERTS where it is no longer needed.
commit 701ebb41fdd5f246e611b7569b32b075942f59a8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 00:51:22 2022 -0700
Automatic changelog generation for PR #70477 [ci skip]
commit e710af88f87bfe8722954220a7144b51b478fa0a
Author: Tim <timothymtorres@gmail.com>
Date: Wed Oct 19 02:51:18 2022 -0500
Fix item icons for action buttons to be center aligned (#70477)
commit d75490e1a339d7b872aeda5b9b9a2327659f2caa
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 00:50:25 2022 -0700
Automatic changelog generation for PR #70503 [ci skip]
commit d74f164499be87e9a452a8666d9998002a9d790d
Author: dopamiin0 <112458553+dopamiin0@users.noreply.github.com>
Date: Wed Oct 19 01:50:21 2022 -0600
Prevents chaplain's backpack from noclipping better than a Gmod admin. (#70503)
commit 66ce1fffe28d08c91e552bc2f37f87e75032c619
Author: ShizCalev <ShizCalev@users.noreply.github.com>
Date: Wed Oct 19 03:49:58 2022 -0400
Fixes negative value being passed to runechat fade animation timer (#70531)
commit 270ffb14363a807501302481bf96274703122b32
Author: Jordan Dominion <Cyberboss@users.noreply.github.com>
Date: Wed Oct 19 03:49:32 2022 -0400
Update DreamAnnotate version (#70493)
commit df5dd62fb9150758b9c1a1fde41975bad2f54461
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Wed Oct 19 08:48:29 2022 +0100
Prevents DNA vault causing harddels (#70543)
commit 0b40eebe86e9202800a5f1288ad3207b16ba0c86
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Wed Oct 19 00:46:29 2022 -0700
Automatic changelog generation for PR #70604 [ci skip]
commit d23e95b3bcbe4d87e55a4fd9d3ca02ecdd6dd228
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Wed Oct 19 03:46:25 2022 -0400
Curator and Mime PDAs now start with their ringer off (#70604)
commit 555166a20de3f14bac57ef097f7023abc5154377
Author: san7890 <the@san7890.com>
Date: Wed Oct 19 01:45:53 2022 -0600
Removes bestF from Master Controller Crash Report Filtering (and uses voodoo magic to help cleaning up down the line) (#70610)
* Removes bestF from Master Controller Crash Filtering
We removed bestF from datums back in #2701, but this still remained in the filter. Bit silly, let's get rid of this old cobweb.
I couldn't find anything suggesting that the master_controller could get a statclick variable, but that's actually a term we use in the modern day so I'm not going to bug it since it's benign. The other five are still BYOND-level variables.
Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com>
commit a7650c542ceb7c2f73a5bea1a6db63087f216a95
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Wed Oct 19 03:43:57 2022 -0400
Removes an unused 'ignore monkeys' flag on secbots (#70607)
commit 9edf99cc204bfbc232e9db3b6070fb5c5b913ff4
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 22:37:07 2022 -0700
Automatic changelog generation for PR #70611 [ci skip]
commit 9ab00f0dc3f3b36664ff9363cf953b261001f268
Author: ATH1909 <42606352+ATH1909@users.noreply.github.com>
Date: Wed Oct 19 01:37:02 2022 -0400
Removes the explosive holoparasite's teleportation punch ability (#70611)
* The explosive holoparasite no longer has a 40% chance to randomly teleport a guy they're punching away from them.
commit 5ba6787890d140ab7fbcb5626afabe213cc7bea3
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 22:17:09 2022 -0700
Automatic changelog generation for PR #69629 [ci skip]
commit 09d88b31ee70c1477e2ad18faff20e0289f85692
Author: Tim <timothymtorres@gmail.com>
Date: Wed Oct 19 00:17:05 2022 -0500
Wizard DLC - Tower of Babel (#69629)
About The Pull Request
This adds a new status effect called - Tower of Babel
Any carbon mob afflicted by the status effect will lose knowledge of every known language and gain a randomized one as a replacement. The affected mob will also be hit with a depressing moodlet that lasts for 15 seconds. Silicons are immune to all effects.
This effect is implemented in several ways:
Tower of Babel wizard event (all crew on the station z level are affected. The wizard is not and gains mastery of every language to taunt their victims)
Admin smite option
Admin secret event (can be reversed)
Staff of Babel (formerly the Staff of Sapping) will spawn during spawn magic wizard event
Magicarp will randomly shoot bolts of babel
Staff of Chaos will randomly shoot bolts of babel
Overdosing on Mushroom Hallucinogen will temporarily and sporadically acquire the effect
The effect can be blocked or cured in several ways:
Curators are given immunity
Reading a book of babel (via lavaland loot) cures and gives immunity
Reading a language book cures and gives immunity ONLY for that particular language
Note - The Tower of Babel does not allow tongueless, mute, or tongue tied people the ability to speak
commit 31d6a1d9e75267c14cb0cf9dcfcaa5fdd0d55d9a
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:47:36 2022 -0700
Automatic changelog generation for PR #70340 [ci skip]
commit 4085e792ab5716485d379ce5f3dcbbae1c3d0522
Author: san7890 <the@san7890.com>
Date: Tue Oct 18 22:47:32 2022 -0600
End Of Creating Map Votes with One/Zero Options. (#70340)
Makes it so you can't call a map vote when there is less than two maps to choose from
Co-authored-by: VexingRaven <msgerbs@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit 4c1996c21c22039317041a59bdf6a16e6f186860
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:29:10 2022 -0700
Automatic changelog generation for PR #70480 [ci skip]
commit 61c544f9cb44149d3c7aea989e58ab07cc9d64d7
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Wed Oct 19 05:29:07 2022 +0100
Fixes cryo tubes making their occupant get stuck standing in place when broken (#70480)
commit 2878345ebb33c564647e01429453aca31569fb66
Author: san7890 <the@san7890.com>
Date: Tue Oct 18 22:25:23 2022 -0600
Swaps sleep() to use SECONDS define, changes some sleep(1) to sleep(1 TICKS) (#70452)
commit bcb6cc1c45d31a8ed3161af186fca59cdf5b5960
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:23:57 2022 -0700
Automatic changelog generation for PR #70427 [ci skip]
commit 708c1383049709b6d5fbeedc57705ceaa6f6ef53
Author: lizardqueenlexi <105025397+lizardqueenlexi@users.noreply.github.com>
Date: Tue Oct 18 23:23:53 2022 -0500
Made regenerate_organs() reset external organs as well. (#70427)
commit 901702c36040469489c37851a6d7b8ff1831db39
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:21:53 2022 -0700
Automatic changelog generation for PR #70424 [ci skip]
commit dc8fcf82c92f44cdde3c6a9e3aaaeced206f616c
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Tue Oct 18 23:21:50 2022 -0500
Silver slime extract created food isn't toxic to jellypeople (#70424)
commit 4888c44a5f9183b0003d716cf4690396ad678b19
Author: Wallem <66052067+Wallemations@users.noreply.github.com>
Date: Wed Oct 19 00:15:43 2022 -0400
Scratching an OCD itch, or, how I autodocced `/mob/living/simple_animal/hostile`'s comments (#70614)
commit be02888a00be50f739e0db28f7e77f406ce1308d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:13:24 2022 -0700
Automatic changelog generation for PR #70526 [ci skip]
commit 8f241f0447af11a913a2a94cda3e1b16a8da0aa0
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Wed Oct 19 05:13:20 2022 +0100
Makes weakpoint objective require both areas to be scanned + bugfixes + harddels (#70526)
commit de94c69d61928e418230b2d5affee43f26c3228c
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 21:10:22 2022 -0700
Automatic changelog generation for PR #70518 [ci skip]
commit e2b8d9e2e1c5f09ca2a59f0d4513556bd85fcda7
Author: CCC23 <91553605+CCC23@users.noreply.github.com>
Date: Tue Oct 18 23:10:19 2022 -0500
Adds back purchasing the Autorifle and ammo through emagging the cargo supply console (#70518)
Co-authored-by: Sealed101 <75863639+Sealed101@users.noreply.github.com>
Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit f82ffd493c5e9a603f8305ca4cf53eefc786a66e
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 18:52:44 2022 -0700
Automatic changelog generation for PR #70575 [ci skip]
commit fedcbcbb18c84dffc0d80e7130b3e42469ef432c
Author: texan-down-under <73374039+etherware-novice@users.noreply.github.com>
Date: Tue Oct 18 20:52:40 2022 -0500
Able to clean storage items with soap (#70575)
Co-authored-by: etherware-novice <candy@notarealaddr.com>
Co-authored-by: Candycaneannihalator <candycane@thisisnotarealaddr.com>
Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
commit e40a42f268cdfb18065f9a9aa04dcb6c6d542454
Author: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Date: Tue Oct 18 18:24:28 2022 -0700
Fixes job preference entries persisting after they have been nulled (#70577)
I know this doesn't actually change behavior, but it's confusing, and
adds a potential point of failure if someone doesn't realize it can
happen. Let's be consistent
commit 804902d933d5212e157163c8218c8b8f03507b3b
Author: Changelogs <action@github.com>
Date: Wed Oct 19 00:32:07 2022 +0000
Automatic changelog compile [ci skip]
commit 24382aff62f7b68223d889accecb6a15c0e81466
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 17:21:32 2022 -0700
Automatic changelog generation for PR #70606 [ci skip]
commit 89beb984951e097024f7edc08ca10ecae5c81f7e
Author: GoblinBackwards <22856555+GoblinBackwards@users.noreply.github.com>
Date: Wed Oct 19 01:21:28 2022 +0100
Modular computer fixes (#70606)
* Moves a lot of modular computer attackbys to the cpu instead, which is what handles it all. This allows their parts to be removed and the console deconstructed/repaired once again.
commit 1c5b1e8eeebb448c7f5664966a40841bf01d6ef8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 16:32:25 2022 -0700
Automatic changelog generation for PR #70474 [ci skip]
commit 5a3c1d63cb63edaac080414196658333316b277b
Author: Imaginos16 <77556824+Imaginos16@users.noreply.github.com>
Date: Tue Oct 18 20:32:21 2022 -0300
Adds a brand-new HUD: The Trasen-Knox HUD! (#70474)
Hello everyone! Today I bring to you all a fancy new HUD for you lot to enjoy: The Trasen-Knox HUD! Lovingly based off of the Common Core lore maintained by EOBGames!
Well, what is it?
Its a HUD with a special theming based on the old 1970's CRT screens that were commonplace at the time, including the iconic neon green and the beige plastic casing!
This PR also includes a new behavior so that its possible for each active hand icon to be unique, instead of it being a sole highlighted icon as it was before.
image
And for those wondering, it does indeed account for multiple limbs!
image
Finally, as seen in the first screenshot, this PR adds the behavior to hide the HUD icon when you insert a piece of equipment into the slot. Thank you for adding the behavior, Fikou!
This is all as a step for upgrading and changing how the HUDs we interact with on a daily basis can be upgraded in the future to be more appealing visually! That, and it is simply gorgeous :)
PositiveEntropy, Fikou
add: Adds a new HUD: The Trasen-Knox HUD! With a theming based on classic 1970s CRT screen computers!
code: Added behavior for unique icons for active hands.
code: Added behavior that makes it so when you equip an item, the icon behind it defaults to the blank template type.
commit 56530fa8f0ebc0a8c67b24544d4fd21edb9687e8
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 16:06:43 2022 -0700
Automatic changelog generation for PR #70287 [ci skip]
commit 132508632be70f584b8978945a1ec0de0151bd75
Author: Rhials <Datguy33456@gmail.com>
Date: Tue Oct 18 19:06:39 2022 -0400
Adds the Command Intercom, kills off the varedited freerange intercoms on some maps. (#70287)
* Command intercoms now have a unique sprite and are standardized on all maps.
* Also prevents freerange intercoms from accessing syndicate radio.
commit e071f81508a807f1fbb87c4c6920d0815d15f20d
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 14:51:28 2022 -0700
Automatic changelog generation for PR #70199 [ci skip]
commit 901662f59b15202d71a895da6664a19b6579149d
Author: san7890 <the@san7890.com>
Date: Tue Oct 18 15:51:24 2022 -0600
Changes job config format to use TOML, and add tools for migrating existing format (#70199)
commit 468809e38faf820d74ec1df721a11fd7077270a7
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 14:03:22 2022 -0700
Automatic changelog generation for PR #70536 [ci skip]
commit 12ba4191c46733f5163b7b51595fa8d482df8140
Author: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Date: Tue Oct 18 16:03:18 2022 -0500
Tramstation kitchen dumbwaiter uses an elevator control panel (#70536)
* Tramstation kitchen uses fancy lift
commit c4a6c95870a5c6fb721c46698c3624fe1334e886
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 13:56:52 2022 -0700
Automatic changelog generation for PR #70563 [ci skip]
commit f416a517c882e2168c6e30df5e33a7736da8f8c8
Author: Dani Glore <danielsglore@gmail.com>
Date: Tue Oct 18 16:56:48 2022 -0400
Fix: Blood Deficiency removing more blood than intended (#70563)
commit a1ccaa0848d3e58f13607e548fe5e6b932c8dad6
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 12:47:59 2022 -0700
Automatic changelog generation for PR #70619 [ci skip]
commit 273d29a2f1d6f4329e37a388e6f9109585c9ddee
Author: Y0SH1M4S73R <legoboyo@earthlink.net>
Date: Tue Oct 18 15:47:55 2022 -0400
bumps auxlua to 1.3.2 (#70619)
commit a7191817987784214432e215f151556a7bb907dd
Author: tgstation-server <tgstation-server@tgstation13.org>
Date: Tue Oct 18 05:37:02 2022 -0700
Automatic changelog generation for PR #70568 [ci skip]
commit d6000a1cc107c5fb8d6465b059a46713d21fb70e
Author: John Willard <53777086+JohnFulpWillard@users.noreply.github.com>
Date: Tue Oct 18 08:36:58 2022 -0400
Russian revolver now lets you suicide with it (#70568)
* Russian revolver now lets you suicide with it
Russian revolvers now use fire_gun instead of afterattack, so the gun's suicide (which uses process_fire) will now work.
I haven't tested, but this seems to fix https://github.com/tgstation/tgstation/issues/66152 too (Monkeys getting aggro on people pointing the g…
MrMelbert
pushed a commit
that referenced
this pull request
Sep 25, 2023
## About The Pull Request Unfortunately, back in #70340 (4085e79) which was declared to fix the issue of having only one map to vote for, I cocked up a part of it. For some reason, the part where it states that only one map could be voted for would only play on the emergency shuttle leaving. I think I did this because of the fact that the mapvote would auto-call, and this didn't really respect the fact that people would also call their own votes with only one map to vote for. Thus, the vote would fire with one map to choose for and there wouldn't be the message on there being only one map to vote for that I added in the aforementioned PR. This brings it back to the intended working condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Hey there,
I read oranges thoughts here: https://tgstation13.org/phpBB/viewtopic.php?t=32549, and I thought it was a pretty good idea. The system itself always coped well with the concept that you could have only one (or none) choices, but there really was never any user feedback in regards to how these played out. So, let's dive into it by just making so that you can't call a map vote if you have 1 or 0 choices, gotta have at least two options to vote, of course.
I also added some new functionality to the auto-map vote when the Emergency Shuttle is called. From a UX standpoint, it makes no sense to call a forced map vote with only one option in this new framework, so let's pass in something to track that as well. I also included that framework into the Rock The Vote stuff, bleaugh.
I re-arranged some procs to make this work the way I wanted, let me know if anything's cringe. I include the override for the shuttle-mapvote when one vote exists in
create_votebecause it wouldn't fit anywhere else without causing a slew of other edge case issues.Why It's Good For The Game
Fixes #64963
User feedback is good, and there's really no good reason to give a player an "illusion" of being able to call a map vote when there is literally only one choice. Like, even if it went to the vote, it just wouldn't do anything what-so-ever since it would immediately pass.
Changelog
🆑
qol: The voting system will now prevent you (and give a short message via the tooltip) from starting a map vote when there are zero or one map choices available.
qol: If there is only one map choice available, the map vote will automatically change it to that map choice when the shuttle departs the station. It has also been made so that you may not rock the vote after this point if it has been auto-rotated, since there was only ever once choice to begin with, making the whole purpose of a vote useless.
/:cl:
sorry if this doesn't make sense i'm currently working out some stress in my life through coding. happy to clarify on anything that needs it