Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End Of Creating Map Votes with One/Zero Options. #70340

Merged
merged 6 commits into from Oct 19, 2022
Merged

End Of Creating Map Votes with One/Zero Options. #70340

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ab0299c
Map Votes can no longer be called with one or less choices
san7890 Oct 6, 2022
f75e20d
Adds the pseudo-autorotator
san7890 Oct 6, 2022
9c43df9
Apply suggestions from code review - msgerbs edition
san7890 Oct 6, 2022
9c0c027
documentation update
san7890 Oct 17, 2022
fd00db4
okay
san7890 Oct 18, 2022
1282dd1
Explicitness
Mothblocks Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions code/datums/votes/map_vote.dm
View file
Open in desktop
Expand Up @@ -66,10 +66,11 @@
message = initial(message)
return TRUE

/// Before we create a vote, remove all maps from our choices that are outside of our population range. Note that this can result in zero remaining choices for our vote, which is not ideal. Let's warn users about that if it comes up.
/// Argument create_vote is typically FALSE, pass as TRUE if calling from the create_vote proc.
/// Before we create a vote, remove all maps from our choices that are outside of our population range. Note that this can result in zero remaining choices for our vote, which is not ideal (but ultimately okay).
/// Argument create_vote is typically FALSE, pass as TRUE if calling from the create_vote proc. When FALSE, we collect the default choices in a similar manner to how the create_vote() proc does it.
san7890 marked this conversation as resolved.
Show resolved Hide resolved
/// When TRUE, there's no need to collect the default choices and key it that way since create_vote() already does that in it's own proc handling, so let's avoid doing double work.
/datum/vote/map_vote/proc/check_population(create_vote = FALSE)
if(!create_vote) // We simulate the parent of create_vote here if this is called outside of the create_vote proc.
if(!create_vote)
for(var/key in default_choices)
choices[key] = 0

Expand Down