Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. #71129

AnywayFarus · 2022-11-06T07:35:44Z

About The Pull Request

This PR adds the ability to send faxes to a central command or syndicate, which will be delivered to the admins in request format. And also, a fax panel for admins has been added, which will allow them to conveniently send a fax already back (including stamps)

Why It's Good For The Game

More bureacracy gaming.

Changelog

🆑 Vishenka0704
add: A way to send faxes to CentCom/Syndicate
admin: New fax panel(with stamps!!!)
/:cl:

code/modules/admin/admin_fax_panel.dm

code/modules/paperwork/fax.dm

code/modules/requests/request.dm

ghost · 2022-11-08T08:06:31Z

It may be a good idea to check to see if validation is performed on id and name params since it's being sent to admins.

tgui/packages/tgui/interfaces/AdminFax.js

code/modules/admin/admin_fax_panel.dm

code/__DEFINES/admin.dm

code/modules/admin/admin_fax_panel.dm

tgui/packages/tgui/interfaces/AdminFax.js

tgui/packages/tgui/interfaces/Fax.tsx

YakumoChen · 2022-11-11T02:20:50Z

can I prank the Syndicate by sending them pizzas after I figure out their address?

github-actions · 2022-11-21T07:54:10Z

Your Fix/Feature pull request is currently below zero (-3). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

…staff can answer on them from fax panel. (tgstation#71129) ## About The Pull Request This PR adds the ability to send faxes to a central command or syndicate, which will be delivered to the admins in request format. And also, a fax panel for admins has been added, which will allow them to conveniently send a fax already back (including stamps) ![image](https://user-images.githubusercontent.com/78199449/200159547-4e5f1759-2879-459c-b84f-e6dedd5f1ccb.png) ![image](https://user-images.githubusercontent.com/78199449/200159551-951e235f-e2ac-4f92-a96f-72cba643e634.png) ![image](https://user-images.githubusercontent.com/78199449/200159552-57f3dcf6-5875-4b11-af58-22c0b0fb4ae2.png) ![image](https://user-images.githubusercontent.com/78199449/200159553-57fbf90c-f141-4c12-8879-81a842afe30f.png) ## Why It's Good For The Game More bureacracy gaming. ## Changelog :cl: Vishenka0704 add: A way to send faxes to CentCom/Syndicate admin: New fax panel(with stamps!!!) /:cl: Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>

ghost · 2022-11-24T10:52:34Z

AnywayFarus · 2022-11-24T10:56:10Z

???

ghost · 2022-11-24T11:49:14Z

???

It may be a good idea to check to see if validation is performed on id and name params since it's being sent to admins.

AnywayFarus · 2022-11-24T11:56:40Z

???

It may be a good idea to check to see if validation is performed on id and name params since it's being sent to admins.

This, in fact, should be on the honor of the administration (VV is only with them)

ghost · 2022-11-24T12:00:51Z

This, in fact, should be on the honor of the administration (VV is only with them)

JS requests can be forged. This was done by modifying the send request to be special_send and changing name to html code. So the fault lies solely with this pull. If you check my previous pulls/issues I go more in depth on how this can be done. XSS vulnerabilities tend to be more serious in SS13 because byond's api or whatever lets you mess with clients.

AnywayFarus · 2022-11-24T12:11:46Z

JS requests can be forged. This was done by modifying the send request to be special_send and changing name to html code. So the fault lies solely with this pull. If you check my previous pulls/issues I go more in depth on how this can be done. XSS vulnerabilities tend to be more serious in SS13 because byond's api or whatever lets you mess with clients.

ok, i make view what i understand(panel can be opened only by staff). If u want and can resolve this problem it's coll. I can't 'cause far from home.

AnywayFarus and others added 6 commits October 26, 2022 06:44

integrate faxes in request manager

8c091a3

re-informate request

9c5711e

i hate that

7983545

nice idea

1cf958f

Merge branch 'tgstation:master' into fax-admin

5eed7be

base

6e3dd2c

tgstation-server added Administration As generous gods, we have deigned to throw the jannies a bone Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges labels Nov 6, 2022

github-actions bot requested a review from stylemistake November 6, 2022 07:37

AnywayFarus marked this pull request as draft November 6, 2022 07:49

rotation to stamp. comments. and maybe few.. fixes

9a8c753

AnywayFarus marked this pull request as ready for review November 7, 2022 10:57

Mothblocks requested changes Nov 7, 2022

View reviewed changes

AnywayFarus added 2 commits November 8, 2022 01:32

review changes

d0bb3d3

anoter review change

d5ff87a

AnywayFarus added 3 commits November 9, 2022 02:28

hard-code stamp class?

4c4c9bf

maybe final

b08fcd1

that?

8ef8a90

Mothblocks reviewed Nov 9, 2022

View reviewed changes

tgui/packages/tgui/interfaces/AdminFax.js Outdated Show resolved Hide resolved

no tooltips, but a way to close paper UI.

ba45a7d

Mothblocks reviewed Nov 10, 2022

View reviewed changes

code/modules/admin/admin_fax_panel.dm Outdated Show resolved Hide resolved

updating UI.(wow)

b14fdf5

Mothblocks reviewed Nov 10, 2022

View reviewed changes

code/modules/admin/admin_fax_panel.dm Show resolved Hide resolved

Mothblocks requested changes Nov 11, 2022

View reviewed changes

Another part of review

24a915f

Zonespace27 mentioned this pull request Nov 13, 2022

Corporate Diplomat: NTC Expanded Skyrat-SS13/Skyrat-tg#17453

Closed

AnywayFarus removed the request for review from stylemistake November 13, 2022 22:42

useless

e199995

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2022

AnywayFarus and others added 2 commits November 18, 2022 15:59

ready to merge conflict

c9d7829

Merge branch 'tgstation:master' into fax-admin

8bbbd13

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 18, 2022

AnywayFarus added 2 commits November 18, 2022 16:06

back mine

db4c710

Merge remote-tracking branch 'origin/fax-admin' into fax-admin

afa673d

github-actions bot added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 21, 2022

Merge branch 'master' into fax-admin

147bf36

tgstation-server removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 21, 2022

Mothblocks enabled auto-merge (squash) November 21, 2022 07:19

Mothblocks merged commit ec1115e into tgstation:master Nov 21, 2022

TaleStationBot mentioned this pull request Nov 21, 2022

[MIRROR] [MDB IGNORE] Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. TaleStation/TaleStation#3290

Merged

SkyratBot mentioned this pull request Nov 21, 2022

[MIRROR] Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. [MDB IGNORE] Skyrat-SS13/Skyrat-tg#17623

Merged

github-actions bot added a commit that referenced this pull request Nov 21, 2022

Updating GBP balances for #71129

830ff36

comfyorange added a commit that referenced this pull request Nov 21, 2022

Automatic changelog for PR #71129 [ci skip]

662a3df

Mothblocks pushed a commit to Mothblocks/tgstation that referenced this pull request Nov 22, 2022

Automatic changelog for PR tgstation#71129 [ci skip]

d3ede10

Mothblocks mentioned this pull request Nov 24, 2022

Fix XSS in fax machines #71498

Closed

itsmeow mentioned this pull request Jun 23, 2023

[s] Fix fax machine href exploit BeeStation/BeeStation-Hornet#9297

Merged

itsmeow mentioned this pull request Jul 14, 2023

Fax Machine Requests Redo BeeStation/BeeStation-Hornet#9408

Merged

meemofcourse mentioned this pull request Sep 1, 2023

Updates Paperwork Code Pt. 2 shiptest-ss13/Shiptest#2323

Closed

16 tasks

AnywayFarus deleted the fax-admin branch October 25, 2023 12:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. #71129

Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. #71129

AnywayFarus commented Nov 6, 2022 •

edited

ghost commented Nov 8, 2022

YakumoChen commented Nov 11, 2022

github-actions bot commented Nov 21, 2022

ghost commented Nov 24, 2022

AnywayFarus commented Nov 24, 2022

ghost commented Nov 24, 2022

AnywayFarus commented Nov 24, 2022

ghost commented Nov 24, 2022 •

edited by ghost

AnywayFarus commented Nov 24, 2022

Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. #71129

Add a few networks to fax, which send papers to request manager, and staff can answer on them from fax panel. #71129

Conversation

AnywayFarus commented Nov 6, 2022 • edited

About The Pull Request

Why It's Good For The Game

Changelog

ghost commented Nov 8, 2022

YakumoChen commented Nov 11, 2022

github-actions bot commented Nov 21, 2022

ghost commented Nov 24, 2022

AnywayFarus commented Nov 24, 2022

ghost commented Nov 24, 2022

AnywayFarus commented Nov 24, 2022

ghost commented Nov 24, 2022 • edited by ghost

AnywayFarus commented Nov 24, 2022

AnywayFarus commented Nov 6, 2022 •

edited

ghost commented Nov 24, 2022 •

edited by ghost