Fax Machine Requests Redo #9408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…staff can answer on them from fax panel. (#71129) This PR adds the ability to send faxes to a central command or syndicate, which will be delivered to the admins in request format. And also, a fax panel for admins has been added, which will allow them to conveniently send a fax already back (including stamps)     More bureacracy gaming. :cl: Vishenka0704 add: A way to send faxes to CentCom/Syndicate admin: New fax panel(with stamps!!!) /:cl: Co-authored-by: Mothblocks <35135081+Mothblocks@users.noreply.github.com>
…n fax (#71491) NTpay wasn't validating negative input serverside, allowing for negative payment to users(Negative - Negative = Positive, so it adds money to the senders account.) Also encodes a parameter that was sent unsanitized to admins. :cl: fix: Fixes a NTPay exploit. /:cl:
github-actions
bot
added
Administration
TGUI-Changes
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
PowerfulBacon
approved these changes
Aug 25, 2023
ss13-beebot
added a commit
that referenced
this pull request
Aug 25, 2023
16 tasks
meemofcourse
added a commit
to meemofcourse/Shiptest
that referenced
this pull request
Jan 21, 2024
github-merge-queue bot
pushed a commit
to shiptest-ss13/Shiptest
that referenced
this pull request
Feb 2, 2024
…CentCom (#2653) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This pull requests ports: * BeeStation/BeeStation-Hornet#9408 * BeeStation/BeeStation-Hornet#9236 This pull request reverts: * tgstation/tgstation#70072 The requests manager is now a thing.  It also adds little offices with fax machines for factions to CentCom, which recieve the physical paper and can send faxes back (though admins can still make use of the fax panel).  They can also fax each other, if ever needed.  <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game * Gives admins the ability to see a very easy to use recap of all requests that occur in a round. This system is readily extendible to support other types of requests, should someone care to add it. * Better admin tools, admins can now send faxes directly via the new Fax Manager verb, and faxes are show in the request panel instead of its own panel. * You can now LARP as a Cybersun minimum wage intern handling faxes. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: bobbahbrown, itsmeow, meemofcourse add: CentCom now has some small offices, which recieve physical faxes. add: Fax machines now announce that they have received a fax over radio. add: Fax machines announce important faxes VERY LOUDLY. balance: Faxes no longer require a subspace ansible crystal. code: Faxes now use typepath instead of varedit. tweak: Changed how special/faction faxes work. Login is no longer required to use special faxes. admin: Add Requests Manager to view all fax messages/prayers/centcom and syndicate requests/and nuke code requests within a round. admin: Removed old fax manager in favor of Requests Manager, added "Send Fax Message" verb to send admin faxes via a menu. fix: Fixed runtime when ghosts tried to view paper. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
MysticalFaceLesS
pushed a commit
to MysticalFaceLesS/Shiptest
that referenced
this pull request
Feb 2, 2024
…CentCom (shiptest-ss13#2653) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This pull requests ports: * BeeStation/BeeStation-Hornet#9408 * BeeStation/BeeStation-Hornet#9236 This pull request reverts: * tgstation/tgstation#70072 The requests manager is now a thing.  It also adds little offices with fax machines for factions to CentCom, which recieve the physical paper and can send faxes back (though admins can still make use of the fax panel).  They can also fax each other, if ever needed.  <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game * Gives admins the ability to see a very easy to use recap of all requests that occur in a round. This system is readily extendible to support other types of requests, should someone care to add it. * Better admin tools, admins can now send faxes directly via the new Fax Manager verb, and faxes are show in the request panel instead of its own panel. * You can now LARP as a Cybersun minimum wage intern handling faxes. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: bobbahbrown, itsmeow, meemofcourse add: CentCom now has some small offices, which recieve physical faxes. add: Fax machines now announce that they have received a fax over radio. add: Fax machines announce important faxes VERY LOUDLY. balance: Faxes no longer require a subspace ansible crystal. code: Faxes now use typepath instead of varedit. tweak: Changed how special/faction faxes work. Login is no longer required to use special faxes. admin: Add Requests Manager to view all fax messages/prayers/centcom and syndicate requests/and nuke code requests within a round. admin: Removed old fax manager in favor of Requests Manager, added "Send Fax Message" verb to send admin faxes via a menu. fix: Fixed runtime when ghosts tried to view paper. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
We actually have a PR that is worse that TG closed for our centcom fax system. The new version is much better and removes a lot of extra crap that wasn't needed (logging in to access centcom faxes, uses the request panel)
Reverts:
Ports:
I made sure to test for and keep the changes from #9236
Also fixes a runtime with ghosts and papers that I swear we fixed but somehow still occurs because 0 is returned.
Why It's Good For The Game
Better admin tools, admins can now send faxes directly via the new Fax Manager verb, and faxes are show in the request panel instead of its own panel.
Testing Photographs and Procedure
Screenshots&Videos
Runtime fix
Changelog
🆑
tweak: Changed how special/faction faxes work and removed all except centcom and syndicate. Login is no longer required to use special faxes.
admin: Removed old fax manager in favor of Requests Manager, added "Send Fax Message" verb to send admin faxes via a menu.
fix: Fixed runtime when ghosts tried to view paper.
/:cl: