Refactors crew records

code/__HELPERS/_lists.dm

@@ -639,10 +639,10 @@
 			i++
 	return i
 
-/// Returns datum/data/record
+/// Returns datum/record
 /proc/find_record(field, value, list/inserted_list)
-	for(var/datum/data/record/record_to_check in inserted_list)
-		if(record_to_check.fields[field] == value)
+	for(var/datum/record/crew/record_to_check in inserted_list)
+		if(record_to_check[field] == value)
 			return record_to_check
 	return null
 

code/__HELPERS/cmp.dm

@@ -17,11 +17,11 @@
 	return sorttext(a.name, b.name)
 
 GLOBAL_VAR_INIT(cmp_field, "name")
-/proc/cmp_records_asc(datum/data/record/a, datum/data/record/b)
-	return sorttext(b.fields[GLOB.cmp_field], a.fields[GLOB.cmp_field])
+/proc/cmp_records_asc(datum/record/a, datum/record/b)
+	return sorttext(b[GLOB.cmp_field], a[GLOB.cmp_field])
 
-/proc/cmp_records_dsc(datum/data/record/a, datum/data/record/b)
-	return sorttext(a.fields[GLOB.cmp_field], b.fields[GLOB.cmp_field])
+/proc/cmp_records_dsc(datum/record/a, datum/record/b)
+	return sorttext(a[GLOB.cmp_field], b[GLOB.cmp_field])
 
 // Datum cmp with vars is always slower than a specialist cmp proc, use your judgement.
 /proc/cmp_datum_numeric_asc(datum/a, datum/b, variable)

code/__HELPERS/names.dm

@@ -176,8 +176,8 @@ GLOBAL_DATUM(syndicate_code_response_regex, /regex)
 	var/locations = strings(LOCATIONS_FILE, "locations")
 
 	var/list/names = list()
-	for(var/datum/data/record/t in GLOB.data_core.general)//Picks from crew manifest.
-		names += t.fields["name"]
+	for(var/datum/record/crew/target in GLOB.data_core.general)//Picks from crew manifest.
+		names += target.name
 
 	var/maxwords = words//Extra var to check for duplicates.
 

code/__HELPERS/records.dm

@@ -1,6 +1,6 @@
 
-/proc/overwrite_field_if_available(datum/data/record/base, datum/data/record/other, field_name)
-	if(other.fields[field_name])
-		base.fields[field_name] = other.fields[field_name]
+/proc/overwrite_field_if_available(datum/record/base, datum/record/other, field_name)
+	if(other[field_name])
+		base[field_name] = other[field_name]
 
 

code/_globalvars/lists/mobs.dm

@@ -110,9 +110,8 @@ GLOBAL_LIST_INIT(construct_radial_images, list(
 
 /proc/get_crewmember_minds()
 	var/list/minds = list()
-	for(var/data in GLOB.data_core.locked)
-		var/datum/data/record/record = data
-		var/datum/mind/mind = record.fields["mindref"]
+	for(var/datum/record/locked/record as anything in GLOB.data_core.locked)
+		var/datum/mind/mind = record.mindref
 		if(mind)
 			minds += mind
 	return minds