New sprites for bottles

[MTandi]

About The Pull Request

Updates sprites of many bottles.

Combined effort of three:
Most of these are donated by Kryson.
I tweaked them and added the missing bottles.
Zeckle provided the base for the Voltaic Wine Bottle.

Unholy water now has a separate sprite:

Also made the holy grenade use the holy flask sprite:

dreamseeker_ghN6iH29nO.mp4

Why It's Good For The Game

They look more consistent with other 3/4 items.

Changelog

🆑 Kryson, MTandi, Zeckle (Mike)
image: New bottles and holy grenade sprites
/:cl:

[Loafin34]

the soul of captain's flask....... smh my head....

[Cheshify]

The inubashiri sake is a specific touhou reference. I don't see the same in the new sprite?

[MTandi]

The inubashiri sake is a specific touhou reference. I don't see the same in the new sprite?

Didn't know that. Will address. Can you provide a reference please?

[Cheshify]

[https://en.touhouwiki.net/wiki/Momiji_Inubashiri#Design]
It's literally some wolf girl from touhou 10. The OG bottle's icon has her "tokin" (little red hat). Maybe adding a maple leaf or similar design to the new bottle could work?

[CoiledLamb]

does the ethereal flask still have an animation?

[MTandi]

does the ethereal flask still have an animation?

It doesn't.

[CoiledLamb]

does the ethereal flask still have an animation?

It doesn't.

all good. might add one later when this gets merged (something smaller scale, maybe the same effect but on the face on the front rather than the whole bottle)

[JohnFulpWillard]

The inubashiri sake is a specific touhou reference. I don't see the same in the new sprite?

it is morally correct to remove touhou references

[Wallemations]

No comment on the Touhou reference, but the sabered champagne bottle should have its neck more crooked to emphasize the slice, like the original had.

[Loafin34]

@carshalash it looks like there's a seraka mushroom instead, the tiziran mushroom thing that that one cook PR added

[AdipemDragon]

slightly sad about the shaker's loss of what little ornatability it had, specially on the comemorative NT one, but yeah the bottles are nice, more a reason to make a bottle display like how pubby had one by default

[Sealed101]

with the champagne bottle's height change you'd have to nudge the pixel offset on the frothing a bit to match it up.

tgstation/code/modules/reagents/reagent_containers/cups/glassbottle.dm

Lines 126 to 157 in 382b8c1

	/*
	* Proc to make the bottle spill some of its contents out in a froth geyser of varying intensity/height
	* Arguments:
	* * offset_x = pixel offset by x from where the froth animation will start
	* * offset_y = pixel offset by y from where the froth animation will start
	* * intensity = how strong the effect is, both visually and in the amount of reagents lost. comes in three flavours
	*/
	/obj/item/reagent_containers/cup/glass/bottle/proc/make_froth(offset_x, offset_y, intensity)
	if(!intensity)
	return
	if(!reagents.total_volume)
	return
	var/amount_lost = intensity * 5
	reagents.remove_any(amount_lost)
	visible_message(span_warning("Some of [name]'s contents are let loose!"))
	var/intensity_state = null
	switch(intensity)
	if(1)
	intensity_state = "low"
	if(2)
	intensity_state = "medium"
	if(3)
	intensity_state = "high"
	///The froth fountain that we are sticking onto the bottle
	var/mutable_appearance/froth = mutable_appearance(icon, "froth_bottle_[intensity_state]")
	froth.pixel_x = offset_x
	froth.pixel_y = offset_y
	add_overlay(froth)
	addtimer(CALLBACK(src, TYPE_PROC_REF(/atom, cut_overlay), froth), 2 SECONDS)

tgstation/code/modules/reagents/reagent_containers/cups/glassbottle.dm

Line 658 in 382b8c1

make_froth(offset_x = 0, offset_y = sabraged ? 13 : 15, intensity = froth_severity) //the y offset for sabraged is lower because the bottle's lip is smashed

[Jezzared]

I concur with adipem. The commemorative shaker was always a fun surprise and now i might not even notice it.

If you wanna keep the simple NT logo on it instead of the "I <3 NT", maybe some NT-blue bands?

[bluetshirtguy]

Turning a lot of the different designs/art on the bottles labels with generic "text" is pretty boring.

[Likteer]

I really like the Extra strong absinthe.
The skull on the label got squashed in a previous resprite.
Now the tiny wall of text fits all the random warnings they get in the name.

[MTandi]

No comment on the Touhou reference, but the sabered champagne bottle should have its neck more crooked to emphasize the slice, like the original had.

[https://en.touhouwiki.net/wiki/Momiji_Inubashiri#Design] It's literally some wolf girl from touhou 10. The OG bottle's icon has her "tokin" (little red hat). Maybe adding a maple leaf or similar design to the new bottle could work?

I thought it's some specific bottle like with voltaic wine. How is this supposed to be a reference? Looks like a clump of pixels to me. I have no clue how to refer this character in a bottle design, so leaving this up to you or whoever else who is willing to put this reference back.

Can you explain the lizard wine sprite? Isn't there meant to be some indication of a tail in the bottle?

Also, is the absinthe one meant to be green fairy?

These are from @Krysonism, I'm not sure.

[Sealed101]

is icondiffbot drunk of off all these drinks or did you not animate the blazaam phasing in and out of view

[Sealed101]

can we get an in-game view of this, i feel like with the current sprite it's way too low for both
sabraged one isn't such a low cut and the standard undamaged bottle got taller by 1 px i think?

in hindsight it woulda been easier maybe if i had made these offsets vars on the bottle but maybe another time

[MTandi]

I'm not sure what it supposed to do? Looks fine to me whatever it is.

[MTandi]

I reverted these values and adjusted the sprite to make the holes at the same level as before.

[Sealed101]

one way to do it i guess

captains are naturally good at not making froth especially with their saber, shoulda used the captain pen for the tests but w/e

[MTandi]

Forth seems to be broken, i've seen that there are effects that are supposed to spawn in the icons, but it doesn't happen in-game.

[Sealed101]

smellbert curse you #71810 PR MURDER BARELY A MONTH IN REEEE

[MTandi]

is icondiffbot drunk of off all these drinks or did you not animate the blazaam phasing in and out of view

IconDiffBot thing

[MTandi]

Changed holy water flask and made a separate sprite for unholy water flask

Holy grenade now uses the sprites of a holy water bottle.

[Wallemations]

Much better on the sabered one

[Twaticus]

yeahhh YEAHHHH

[LSommers]

Banger sprite updates that actually look like what they're updating
This is a certified MTandi classic