Adds Custom Announcement Dividers #79071

san7890 · 2023-10-18T05:40:08Z

This ports a whole bunch of various PRs and commits from https://github.com/effigy-se/effigy-se , with heavy refactoring to keep it fresh for /tg/'s code standards.

About The Pull Request

The whole slew of announcement touchups lately (as in #78995 (37db1ec) / #79052 (12308db)) have made me realize how much this stuff sucks. The author of these new spans was advertising these in coding general, so I sat down and coded it. Look at the spans, they're much nicer than what we had going on:

(ignore the capitalized alert status names, this was removed)

Dark Mode

Light Mode

This PR also features

Major announcement code handling cleanup and refactor! There was a lot of copypasta so let's distill it all down into one proc
Better cacheing! We were doing a shit load of new string generation needlessly! That's fixed now.
Better string concatenation! Lists are better for string tree reasons. It still works just as well, as you can see from the screenshots above. Best of all, no fucking <br> dogshit everywhere!
We don't use string equivalency in order to figure out the "type" of an announcement. It's all defines now. This was a bonus that I just coded in since it irritated me.
Minor spellcheck of "announcement".
All of our HTML string mangling stuff is now all span macros! I love macros.

Why It's Good For The Game

In the same vein of adding examine blocks (#67937 (b864589)) because old examinations tended to blend in with the chat and everything chat-wise used to suck really hard- I think this is a really nice way to draw attention to announcements in the chat box without needing a shit load of line breaks that just really look ugly and have no real consistency. You can look at the PRs/commits I linked above for an idea of just how ugly it could be getting.

I haven't audited every announcement in this PR, we can tweak this down the line.

Changelog

🆑 LT3, san7890
add: Announcements have gotten a fresh coat of paint! They should be popping with splendid new colors and should have a lot less ugly linebreaks, while still managing to keep your attention at the screen.
/:cl:

I know we didn't need to port all the CSS themes but I added them anyways in case admins wanna have some fun.
There can probably be more code improvements, just figured I'd crack it out while I had time.
The colors also seem fine, let me know if we need more redness or something. It's okay for stuff to be toned down a bit imo, but that should be done after a hot second.

at least i can atomize this out

pretty much just from effigy no. 34 and other widespread commits chat_alert_2 is now aliased to chat_alert_default

or whatever they are really

spellchecks and level_announce(), more spans

tgui/packages/tgui-panel/styles/tgchat/chat-dark.scss

code/__HELPERS/priority_announce.dm

tgui/packages/tgui-panel/styles/tgchat/chat-light.scss

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>

we'll keep the old one for the time being

Watermelon914 · 2023-10-18T20:48:14Z

tgui/packages/tgui-panel/styles/tgchat/chat-dark.scss

+.chat_alert_default {
+  color: #ffffff;
+  padding: 0.5em 0.5em;
+  margin-bottom: 0.5em;
+  box-shadow: none;
+  font-weight: bold;
+  border: 1px solid #292929;
+  margin: 0.5em 0 0.5em 0;
+  padding: 0.5em 0.75em;
+  background-color: #252525;
+  background-image: repeating-linear-gradient(
+    -45deg,
+    transparent,
+    transparent 10px,
+    #292929 10px,
+    #292929 20px
+  );
+}


I don't think these look great being the background of the announcement system.
Have you considered trying out a border-like system? i.e. the gradient background only acts as a border and the inside is a solid box akin to examine text.

I think it's fine overall, but text layered over patterns tend to be slightly harder to read

I'll ponder on this but I think this can also be done later. If I have time I'll see if I can confangle a demo but I'm no CSS ninja

yeah implementing something like this is beyond the reach of my skill. it doesn't seem possible to do it in a really clean way from what I was reading about this stuff online, especially now that we've macroized the css classes per the other review. this is a challenge for another day.

tgui/packages/tgui-panel/styles/tgchat/chat-dark.scss

less hardcoded shit

there was no reason to be so quirky with it

eh i'm not a fan of it

it's meant to be a boolean so let's scrap the null/TRUE dichotomy

Ghommie · 2023-10-20T13:55:48Z

code/__HELPERS/priority_announce.dm

-			if(target.client.prefs.read_preference(/datum/preference/toggle/sound_announcements))
-				SEND_SOUND(target, sound_to_play)
+	if(isnull(sender_override))
+		if(length(title) > 0)


Suggested change

if(length(title) > 0)

if(length(title))

Is it even possible to have negative text length?

No but it's a codehint pattern that tends to be more explicit. I critiqued some other guys with that same point (implying there's a potential negative text length) over this and they said it just felt better to be more explicit (since we're technically treating a non-boolean value as a boolean if we remove the > 0 portion, as length() returns an integer), which I conceded

I dont care either way

Ghommie · 2023-10-20T13:55:57Z

code/__HELPERS/priority_announce.dm

+	switch(type)
+		if(ANNOUNCEMENT_TYPE_PRIORITY)
+			header = MAJOR_ANNOUNCEMENT_TITLE("Priority Announcement")
+			if(length(title) > 0)


tgui/packages/tgui-panel/styles/tgchat/chat-dark.scss

Original PR: tgstation/tgstation#79071 ----- This ports a whole bunch of various PRs and commits from https://github.com/effigy-se/effigy-se , with heavy refactoring to keep it fresh for /tg/'s code standards. ## About The Pull Request The whole slew of announcement touchups lately (as in #78995 (37db1ecbf8d7ceeaeb134c56b403339555f44cea) / #79052 (12308dbd3dae702a1c7b9f7f80d7859aea085c82)) have made me realize how much this stuff sucks. The author of these new spans was advertising these in coding general, so I sat down and coded it. Look at the spans, they're much nicer than what we had going on: (ignore the capitalized alert status names, this was removed) <details> <summary>Dark Mode</summary> ![image](https://github.com/tgstation/tgstation/assets/34697715/107b8efb-b7a1-41ff-9d16-358c4dc3738d) ![image](https://github.com/tgstation/tgstation/assets/34697715/9e730dfe-7ba3-4edd-96bb-0630fe5e85cf) </details> <details> <summary>Light Mode</summary> ![image](https://github.com/tgstation/tgstation/assets/34697715/57f642f9-ee17-4b16-8027-00a9350e9059) ![image](https://github.com/tgstation/tgstation/assets/34697715/b28b7f49-fd4f-420a-9313-e16b9781c07c) </details> This PR also features * Major announcement code handling cleanup and refactor! There was a lot of copypasta so let's distill it all down into one proc * Better cacheing! We were doing a shit load of new string generation needlessly! That's fixed now. * Better string concatenation! Lists are better for string tree reasons. It still works just as well, as you can see from the screenshots above. Best of all, no fucking `<br>` dogshit everywhere! * We don't use string equivalency in order to figure out the "type" of an announcement. It's all defines now. This was a bonus that I just coded in since it irritated me. * Minor spellcheck of "announcement". * All of our HTML string mangling stuff is now all span macros! I love macros. ## Why It's Good For The Game In the same vein of adding examine blocks (#67937 (b864589)) because old examinations tended to blend in with the chat and everything chat-wise used to suck really hard- I think this is a really nice way to draw attention to announcements in the chat box without needing a shit load of line breaks that just really look ugly and have no real consistency. You can look at the PRs/commits I linked above for an idea of just how ugly it could be getting. I haven't audited every announcement in this PR, we can tweak this down the line. ## Changelog :cl: LT3, san7890 add: Announcements have gotten a fresh coat of paint! They should be popping with splendid new colors and should have a lot less ugly linebreaks, while still managing to keep your attention at the screen. /:cl: I know we didn't need to port all the CSS themes but I added them anyways in case admins wanna have some fun. There can probably be more code improvements, just figured I'd crack it out while I had time. The colors also seem fine, let me know if we need more redness or something. It's okay for stuff to be toned down a bit imo, but that should be done after a hot second. --------- Co-authored-by: san7890 <the@san7890.com> Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>

## About The Pull Request Reverts the CSS styling for announcements back to TG/Effigy original as in tgstation/tgstation#79071, tgstation/tgstation#79236. ## Why It's Good For The Game There's no technical need to override this, the announcements overhaul should be implemented as designed. Bubber doesn't need SR's override. ## Changelog :cl: LT3 code: Announcement CSS is reverted to TG default /:cl:

This ports a whole bunch of various PRs and commits from https://github.com/effigy-se/effigy-se , with heavy refactoring to keep it fresh for /tg/'s code standards. The whole slew of announcement touchups lately (as in tgstation#78995 (37db1ec) / tgstation#79052 (12308db)) have made me realize how much this stuff sucks. The author of these new spans was advertising these in coding general, so I sat down and coded it. Look at the spans, they're much nicer than what we had going on: (ignore the capitalized alert status names, this was removed) <details> <summary>Dark Mode</summary> ![image](https://github.com/tgstation/tgstation/assets/34697715/107b8efb-b7a1-41ff-9d16-358c4dc3738d) ![image](https://github.com/tgstation/tgstation/assets/34697715/9e730dfe-7ba3-4edd-96bb-0630fe5e85cf) </details> <details> <summary>Light Mode</summary> ![image](https://github.com/tgstation/tgstation/assets/34697715/57f642f9-ee17-4b16-8027-00a9350e9059) ![image](https://github.com/tgstation/tgstation/assets/34697715/b28b7f49-fd4f-420a-9313-e16b9781c07c) </details> This PR also features * Major announcement code handling cleanup and refactor! There was a lot of copypasta so let's distill it all down into one proc * Better cacheing! We were doing a shit load of new string generation needlessly! That's fixed now. * Better string concatenation! Lists are better for string tree reasons. It still works just as well, as you can see from the screenshots above. Best of all, no fucking `<br>` dogshit everywhere! * We don't use string equivalency in order to figure out the "type" of an announcement. It's all defines now. This was a bonus that I just coded in since it irritated me. * Minor spellcheck of "announcement". * All of our HTML string mangling stuff is now all span macros! I love macros. In the same vein of adding examine blocks (tgstation#67937 (b864589)) because old examinations tended to blend in with the chat and everything chat-wise used to suck really hard- I think this is a really nice way to draw attention to announcements in the chat box without needing a shit load of line breaks that just really look ugly and have no real consistency. You can look at the PRs/commits I linked above for an idea of just how ugly it could be getting. I haven't audited every announcement in this PR, we can tweak this down the line. :cl: LT3, san7890 add: Announcements have gotten a fresh coat of paint! They should be popping with splendid new colors and should have a lot less ugly linebreaks, while still managing to keep your attention at the screen. /:cl: I know we didn't need to port all the CSS themes but I added them anyways in case admins wanna have some fun. There can probably be more code improvements, just figured I'd crack it out while I had time. The colors also seem fine, let me know if we need more redness or something. It's okay for stuff to be toned down a bit imo, but that should be done after a hot second. Co-Authored-By: lessthanthree <83487515+lessthnthree@users.noreply.github.com>

san7890 added 10 commits October 17, 2023 21:19

moves everything to defines

74ec1b1

at least i can atomize this out

begins the port

2f5c059

pretty much just from effigy no. 34 and other widespread commits chat_alert_2 is now aliased to chat_alert_default

renames the generic spans

49704b2

or whatever they are really

hold on wait a minute TARS

45cb017

alright that should be most of it

0d47e3e

fixes up some fucky <br> issues

d807773

a lot more cooking

6c715bd

spellchecks and level_announce(), more spans

more cleaning

59b2aa1

spins out the dispatch to a new proc

d99ac83

minor tweak

73fef64

san7890 added the Refactor Makes the code harder to read label Oct 18, 2023

tgstation-server added Feature Exposes new bugs in interesting ways UI We make the game less playable, but with round edges labels Oct 18, 2023

github-actions bot requested a review from stylemistake October 18, 2023 05:44

Join() -> jointext()

cfcd9f8

lessthnthree suggested changes Oct 18, 2023

View reviewed changes

tgui/packages/tgui-panel/styles/tgchat/chat-dark.scss Outdated Show resolved Hide resolved

code/__HELPERS/priority_announce.dm Outdated Show resolved Hide resolved

lessthnthree reviewed Oct 18, 2023

View reviewed changes

tgui/packages/tgui-panel/styles/tgchat/chat-light.scss Outdated Show resolved Hide resolved

san7890 and others added 3 commits October 18, 2023 08:56

copypasta moment

eca15f1

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>

gets rid of dupe .minorannounce

4b1a472

we'll keep the old one for the time being

why didn't it commit this file

4464d23

Watermelon914 reviewed Oct 18, 2023

View reviewed changes

san7890 added 8 commits October 18, 2023 22:43

gets sass maps implemented

b6fb135

moves the announcement color to a variable

6003f14

less hardcoded shit

compile moemnt

ed6f046

offloads the level-change announcement to global proc

4167165

there was no reason to be so quirky with it

minor documentation

996eb35

Removes the capitalization

5c516c7

eh i'm not a fan of it

fixes alert in minor_announce()

79bfefd

it's meant to be a boolean so let's scrap the null/TRUE dichotomy

removes documentation fail

1ce5652

Ghommie reviewed Oct 20, 2023

View reviewed changes

Ghommie merged commit 30bac3a into tgstation:master Oct 20, 2023
20 checks passed

SkyratBot mentioned this pull request Oct 20, 2023

[MIRROR] Adds Custom Announcement Dividers [MDB IGNORE] Skyrat-SS13/Skyrat-tg#24471

Merged

github-actions bot added a commit that referenced this pull request Oct 20, 2023

Updating GBP balances for #79071

98dd4f5

comfyorange added a commit that referenced this pull request Oct 20, 2023

Automatic changelog for PR #79071 [ci skip]

3c1eb51

TaleStationBot mentioned this pull request Oct 20, 2023

[MIRROR] [MDB IGNORE] Adds Custom Announcement Dividers TaleStation/TaleStation#8266

Merged

Steals-The-PRs mentioned this pull request Oct 20, 2023

[MIRROR] Adds Custom Announcement Dividers Fluffy-Frontier/FluffySTG#189

Merged

RimiNosha mentioned this pull request Oct 20, 2023

[PORT] Fancy Announcements! Artea-Station/Artea-Station-Server#343

Merged

lessthnthree mentioned this pull request Dec 6, 2023

Revert announcement CSS back to TG Bubberstation/Bubberstation#818

Merged

lessthnthree mentioned this pull request Dec 25, 2023

Revert announcement CSS back to TG Skyrat-SS13/Skyrat-tg#25859

Merged

Steals-The-PRs mentioned this pull request Dec 26, 2023

[MIRROR] Revert announcement CSS back to TG Fluffy-Frontier/FluffySTG#1339

Closed

Gboster-0 mentioned this pull request Jan 7, 2024

Updates announcements to be fancy, ghost-only announcements, new status display icons, sound effects Monkestation/Monkestation2.0#892

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Custom Announcement Dividers #79071

Adds Custom Announcement Dividers #79071

san7890 commented Oct 18, 2023 •

edited

Loading

Watermelon914 Oct 18, 2023

san7890 Oct 18, 2023

san7890 Oct 19, 2023

Ghommie Oct 20, 2023

san7890 Oct 20, 2023 •

edited

Loading

Ghommie Oct 20, 2023

Adds Custom Announcement Dividers #79071

Adds Custom Announcement Dividers #79071

Conversation

san7890 commented Oct 18, 2023 • edited Loading

About The Pull Request

Why It's Good For The Game

Changelog

Watermelon914 Oct 18, 2023

Choose a reason for hiding this comment

san7890 Oct 18, 2023

Choose a reason for hiding this comment

san7890 Oct 19, 2023

Choose a reason for hiding this comment

Ghommie Oct 20, 2023

Choose a reason for hiding this comment

san7890 Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

Ghommie Oct 20, 2023

Choose a reason for hiding this comment

san7890 commented Oct 18, 2023 •

edited

Loading

san7890 Oct 20, 2023 •

edited

Loading