[READY] Adds rabbit infusion to genetics #79698

Iamgoofball · 2023-11-13T02:59:14Z

About The Pull Request

Adds a rabbit infusion to Genetics. Infusing rabbits causes you to be able to jump long distances, become a vegetarian, give good hugs, and upset the geneticist.

Why It's Good For The Game

Expanding the genetics infusion system is good for Genetics gameplay.

Changelog

🆑 Iamgoofball, sprites from Honkpocket
add: Adds a rabbit infusion to Genetics. Infusing rabbits causes you to be able to jump long distances, become a vegetarian, give good hugs, and upset the geneticist. Finishing the Rabbit Mutant infusion entry will flag you as a non-human on medical scanners.
add: Rabbits now hop around.
fix: You can no longer infuse holographic creatures to generate infinite infusions.
/:cl:

LemonInTheDark · 2023-11-13T03:00:03Z

rabbit girls? really?

Iamgoofball · 2023-11-13T03:01:23Z

@LemonInTheDark is there a problem?

LemonInTheDark · 2023-11-13T03:01:37Z

BRO THEY DON'T EVEN DO ANYTHING IT'S JUST VISUAL

Iamgoofball · 2023-11-13T03:01:59Z

@LemonInTheDark good idea, lemme use da tastes system rq

LemonInTheDark · 2023-11-13T03:02:46Z

GOOOOF

OneAsianTortoise · 2023-11-13T03:03:52Z

Do I get good luck if I chop off their feet

Kapu1178 · 2023-11-13T03:05:38Z

LITERAL FETISH CONTENT

snailomi · 2023-11-13T03:07:37Z

wait I thought this person made bad PRs what

MrMelbert · 2023-11-13T03:10:51Z

not opposed to this but DNM until the infusion has unique effects (fox infusion is no excuse)

iwishforducks · 2023-11-13T03:11:07Z

goof. what in the actual fuck. you forgot to make them lay eggs.

MrMelbert · 2023-11-13T03:11:15Z

all you have to do is make it so you can jump up a z-level or something. come on the ideas are already there

Iamgoofball · 2023-11-13T03:13:14Z

@MrMelbert ya im working on it, will ping u when its done

EricZilla · 2023-11-13T04:13:07Z

Giving the ears love of carrots and the tail the ability to do the climbing rope thing would be really funny and give it an actual usecase for miners on icebox

Loafin34 · 2023-11-13T04:29:09Z

give them jump boot ability but they get 2x damage from bullets (hunting rabbits)

itseasytosee · 2023-11-13T05:03:55Z

I love the furry fanfic creator machine from ss13, it just does so much to make me accept the in game universe as cohesive, consistent, and interesting!

gorillion · 2023-11-18T04:01:39Z

the jumping over doors + windows feature needs to be removed. this has been enabling a wave of tiders who are literally impossible to detain. you cannot gulag them, they will jump over the doors/ over the lava. you cannot put them in a cell, they will jump over the windoor. you cannot permabrig them, they will jump over the doors. the only option when you have a rabbitperson criminal is to kill them. this is like when ashen passage didn't require a focus, except this time it's non-antagonists who have a power to escape everything short of a 1x1 solid wall box.

gorillion · 2023-11-18T04:02:58Z

the jumping over doors + windows feature needs to be removed. this has been enabling a wave of tiders who are literally impossible to detain. you cannot gulag them, they will jump over the doors/ over the lava. you cannot put them in a cell, they will jump over the windoor. you cannot permabrig them, they will jump over the doors. the only option when you have a rabbitperson criminal is to kill them. this is like when ashen passage didn't require a focus, except this time it's non-antagonists who have a power to escape everything short of a 1x1 solid wall box.

this is of course on top of it just being an insanely unrivaled tiding tool, not just a security problem.

Iamgoofball · 2023-11-18T05:42:32Z

once again, per my last messages, jumping over doors was a bug, it has been fixed on the latest version, i asked them to update the TM and they did not

krookodilehunter · 2023-11-18T22:33:10Z

there appears to be a bug with dwarfism and rabbit jumping. after you do your rabbit jump, you are no longer able to climb over tables with dwarfism powers

Jacquerel

Mostly small stuff but I do think it probably needs correcting before we're done

Jacquerel · 2023-11-18T23:36:36Z

code/game/machinery/dna_infuser/dna_infuser.dm

+
+/obj/machinery/dna_infuser/proc/pick_limb(mob/living/carbon/human/target)
+	if(!infusing_into)
+		return FALSE


Returning obj | FALSE is a weird pattern, these should probably just be return null and then we can isnull in the proc above

Jacquerel · 2023-11-18T23:40:14Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

@@ -0,0 +1,222 @@
+#define BUNNY_HOP "bunny_hop"
+
+/datum/action/cooldown/spell/bunny_hop


Wait what is this getting from being a spell that it doesn't just get from action/cooldown?

Jacquerel · 2023-11-18T23:40:50Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+	button_icon_state = "jetboot"
+	cooldown_time = 7 SECONDS
+	spell_requirements = NONE
+	var/mob/living/carbon/human/last_caster


Var is undocumented but also seems to be unused?

Jacquerel · 2023-11-18T23:43:47Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+/datum/action/cooldown/spell/bunny_hop/proc/end_jump(mob/living/jumper)
+	jumper.remove_filter(BUNNY_HOP)
+	jumper.layer = initial(jumper.layer)
+	jumper.pass_flags = initial(jumper.pass_flags)


Might want to cache their original pass flags so we're not clearing ones they already had from something else but didn't have on round start
Pain in the ass that these can't have sources but there we are 😔

Yes, you need to use passtable_off for passtable specifically or you will reset stuff like dwarfism. #79698 (comment)

Jacquerel · 2023-11-18T23:45:32Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+		mover.balloon_alert_to_viewers("smashed through!")
+		bunny.apply_damage(damage = rand(5,15), damagetype = BRUTE, wound_bonus = 15, bare_wound_bonus = 25, sharpness = SHARP_EDGED, attack_direction = get_dir(windoor, oldloc))
+		new /obj/effect/decal/cleanable/glass(get_step(bunny, bunny.dir))
+	for(var/obj/structure/grille/grille in get_turf(bunny))


Any reason not to just call break_grilles here? It's not hot enough that it seems like we'd care about proc call overhead.

Jacquerel · 2023-11-18T23:48:50Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+		jumping_power.active_overlay_icon_state = null
+		jumping_power.panel = "Genetic"
+		jumping_power.Grant(new_head_owner)
+	new_head_owner.AddElement(/datum/element/waddling, WADDLE_HOP)


Assume you'd have run into it in testing but I am surprised this doesn't runtime, I'd have expected that the second leg would trigger a signal overridden runtime as it adds the element again.

Jacquerel · 2023-11-18T23:50:29Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+	sniffing_power.background_icon_state = "bg_tech_blue"
+	sniffing_power.base_background_icon_state = sniffing_power.background_icon_state
+	sniffing_power.active_background_icon_state = "[sniffing_power.base_background_icon_state]_active"
+	sniffing_power.overlay_icon_state = "bg_tech_blue_border"
+	sniffing_power.active_overlay_icon_state = null
+	sniffing_power.panel = "Genetic"


This seems a bit silly, just make a subtype they are free

code/modules/surgery/organs/external/tails.dm

code/modules/surgery/organs/internal/ears/_ears.dm

Jacquerel · 2023-11-18T23:52:36Z

code/modules/surgery/organs/internal/ears/_ears.dm

@@ -67,12 +67,13 @@
 	icon_state = "kitty"
 	visual = TRUE
 	damage_multiplier = 2
+	var/ear_to_use = "Cat"


I haven't gone through every var and said "you should doc these" (although you probably should) but this one seems important because it's not intuitive that you'd need to specify that cat ears are not rabbit ears, given that it says that they are cat ears

ophaq · 2023-11-20T23:11:24Z

Boy oh boy I can't wait till this becomes a permanent merge. Really enjoyed it while it was around.

MrMelbert · 2023-11-21T02:26:28Z

code/modules/surgery/bodyparts/species_parts/genetics_bodyparts.dm

+		cast_on.pass_flags |= PASSTABLE|PASSGRILLE|PASSWINDOW|PASSMACHINE|PASSSTRUCTURE
+		RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_glass))
+	else
+		cast_on.pass_flags |= PASSTABLE|PASSGRILLE|PASSMACHINE|PASSSTRUCTURE
+		RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_grilles))


#79698 (comment)

PASSTABLE must be handled with passtable_on

Suggested change

cast_on.pass_flags |= PASSTABLE|PASSGRILLE|PASSWINDOW|PASSMACHINE|PASSSTRUCTURE

RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_glass))

else

cast_on.pass_flags |= PASSTABLE|PASSGRILLE|PASSMACHINE|PASSSTRUCTURE

RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_grilles))

cast_on.pass_flags |= PASSGRILLE|PASSWINDOW|PASSMACHINE|PASSSTRUCTURE

RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_glass))

passtable_on(cast_on, BUNNY_HOP)

else

cast_on.pass_flags |= PASSGRILLE|PASSMACHINE|PASSSTRUCTURE

RegisterSignal(cast_on, COMSIG_MOVABLE_MOVED, PROC_REF(break_grilles))

passtable_on(cast_on, BUNNY_HOP)

github-actions · 2023-11-29T00:22:35Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

CMDRYouth · 2023-11-29T05:44:45Z

Unstale this content the community is raging and demanding their bunny infusions back

ophaq · 2023-11-29T07:28:15Z

Unstale this content the community is raging and demanding their bunny infusions back

This. We want our bnnuy back please!

github-actions · 2023-12-08T00:06:00Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Iamgoofball · 2023-12-08T19:50:21Z

stale b gone

Striders13 · 2023-12-11T14:58:12Z

DONT LET THIS DIE GOOF!!!!!!!!!!

github-actions · 2023-12-19T00:08:46Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

nikothedude · 2023-12-20T20:08:29Z

goof... plesae...

ophaq · 2023-12-27T01:53:30Z

Maybe we will get this by new years... MAYBE.

optimumtact · 2023-12-27T05:21:32Z

obviously dead PR

gueba14 · 2024-03-07T23:37:20Z

I LOVED THIS
AND NOW NO ONE IS MAKING INFUSION PRS

Adds rabbit infusion to genetics + new felinid ear and tail options

da2be7f

Iamgoofball requested review from ExcessiveUseOfCobblestone, Ryll-Ryll, Imaginos16, Krysonism, Twaticus and Wallemations as code owners November 13, 2023 02:59

tgstation-server added Sprites A bikeshed full of soulless bikes. Feature Exposes new bugs in interesting ways labels Nov 13, 2023

github-actions bot requested a review from Time-Green November 13, 2023 03:00

MrMelbert added the Do Not Merge You must have really upset someone label Nov 13, 2023

my brain doesnt fucking work anymore

6fb25ad

Iamgoofball requested a review from MrMelbert as a code owner November 13, 2023 06:00

MrMelbert removed the Do Not Merge You must have really upset someone label Nov 13, 2023

This comment was marked as abuse.

Sign in to view

Vermidia mentioned this pull request Nov 17, 2023

Cursed quirk only triggers once per round #79790

Closed

comments

8efe295

Jacquerel requested changes Nov 18, 2023

View reviewed changes

jlsnow301 marked this pull request as draft November 19, 2023 18:44

tgstation deleted a comment from Yobrocharlie Nov 19, 2023

MrMelbert reviewed Nov 21, 2023

View reviewed changes

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Nov 29, 2023

github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label Nov 30, 2023

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Dec 8, 2023

github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label Dec 9, 2023

github-actions bot added the Stale Even the uncaring universe rejects you, why even go on label Dec 19, 2023

github-actions bot removed the Stale Even the uncaring universe rejects you, why even go on label Dec 21, 2023

optimumtact closed this Dec 27, 2023

ReturnToZender mentioned this pull request Feb 11, 2024

Bunny hop walking animation Bubberstation/Bubberstation#1130

Closed

		@@ -0,0 +1,222 @@
		#define BUNNY_HOP "bunny_hop"

		/datum/action/cooldown/spell/bunny_hop

[READY] Adds rabbit infusion to genetics #79698

[READY] Adds rabbit infusion to genetics #79698

Conversation

Iamgoofball commented Nov 13, 2023 • edited

About The Pull Request

Why It's Good For The Game

Changelog

LemonInTheDark commented Nov 13, 2023

Iamgoofball commented Nov 13, 2023

LemonInTheDark commented Nov 13, 2023

Iamgoofball commented Nov 13, 2023

LemonInTheDark commented Nov 13, 2023

OneAsianTortoise commented Nov 13, 2023

Kapu1178 commented Nov 13, 2023

snailomi commented Nov 13, 2023

MrMelbert commented Nov 13, 2023

iwishforducks commented Nov 13, 2023

MrMelbert commented Nov 13, 2023

Iamgoofball commented Nov 13, 2023

EricZilla commented Nov 13, 2023

Loafin34 commented Nov 13, 2023

itseasytosee commented Nov 13, 2023

This comment was marked as abuse.

gorillion commented Nov 18, 2023

gorillion commented Nov 18, 2023

Iamgoofball commented Nov 18, 2023

krookodilehunter commented Nov 18, 2023

Jacquerel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MrMelbert Nov 21, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ophaq commented Nov 20, 2023

MrMelbert Nov 21, 2023 • edited

Choose a reason for hiding this comment

github-actions bot commented Nov 29, 2023

CMDRYouth commented Nov 29, 2023

ophaq commented Nov 29, 2023

github-actions bot commented Dec 8, 2023

Iamgoofball commented Dec 8, 2023

Striders13 commented Dec 11, 2023

github-actions bot commented Dec 19, 2023

nikothedude commented Dec 20, 2023

ophaq commented Dec 27, 2023

optimumtact commented Dec 27, 2023

gueba14 commented Mar 7, 2024

Iamgoofball commented Nov 13, 2023 •

edited

MrMelbert Nov 21, 2023 •

edited

MrMelbert Nov 21, 2023 •

edited