Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursed quirk only triggers once per round #79790

Closed
Vermidia opened this issue Nov 17, 2023 · 0 comments · Fixed by #79846, Bird-Lounge/Skyraptor-SS13#1636, Skyrat-SS13/Skyrat-tg#25162, TaleStation/TaleStation#8731 or Fluffy-Frontier/FluffySTG#751
Closed

Cursed quirk only triggers once per round #79790

Vermidia opened this issue Nov 17, 2023 · 0 comments · Fixed by #79846, Bird-Lounge/Skyraptor-SS13#1636, Skyrat-SS13/Skyrat-tg#25162, TaleStation/TaleStation#8731 or Fluffy-Frontier/FluffySTG#751
Labels
Bug Correct Functionality

Comments

@Vermidia
Copy link
Contributor

Vermidia commented Nov 17, 2023 •
edited

Round ID:

218929

Testmerges:

#79479
#79698
#79721

Reproduction:

When taking the Cursed quirk, you only experience a single omen before you stop getting any.


bug

The last line is what happens every time any event caused by the Cursed quirk activates.

I have gotten said line from the lights smashing on me and when getting the airlock closed on me.
@Dorsisdwarf Dorsisdwarf added the Bug Correct Functionality label Nov 18, 2023
@lessthnthree lessthnthree mentioned this issue Nov 19, 2023
Merged
Ghommie pushed a commit that referenced this issue Nov 21, 2023
@lessthnthree
Fixes cursed/bad luck initializing with the wrong amount of incidents (…
d541df5 
…#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes #79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:
@NaakaKo NaakaKo mentioned this issue Nov 21, 2023
Merged
NaakaKo pushed a commit to Bird-Lounge/Skyraptor-SS13 that referenced this issue Nov 21, 2023
@lessthnthree @NaakaKo
Fixes cursed/bad luck initializing with the wrong amount of incidents…
1319d01 
… (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:
@SkyratBot SkyratBot mentioned this issue Nov 21, 2023
Merged
SkyratBot pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this issue Nov 21, 2023
@lessthnthree @SkyratBot
Fixes cursed/bad luck initializing with the wrong amount of incidents…
456491b 
… (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:
TaleStationBot pushed a commit to TaleStation/TaleStation that referenced this issue Nov 21, 2023
@lessthnthree @TaleStationBot
Fixes cursed/bad luck initializing with the wrong amount of incidents…
4242c8a 
… (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:
@TaleStationBot TaleStationBot mentioned this issue Nov 21, 2023
Merged
vinylspiders pushed a commit to Skyrat-SS13/Skyrat-tg that referenced this issue Nov 21, 2023
@SkyratBot @lessthnthree
[MIRROR] Fixes cursed/bad luck initializing with the wrong amount of …
5331275 
…incidents [MDB IGNORE] (#25162)

* Fixes cursed/bad luck initializing with the wrong amount of incidents (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:

* Fixes cursed/bad luck initializing with the wrong amount of incidents

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Iajret pushed a commit to Fluffy-Frontier/FluffySTG that referenced this issue Nov 21, 2023
@SkyratBot @lessthnthree
[MIRROR] Fixes cursed/bad luck initializing with the wrong amount of …
371b3c2 
…incidents [MDB IGNORE] (#25162)

* Fixes cursed/bad luck initializing with the wrong amount of incidents (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:

* Fixes cursed/bad luck initializing with the wrong amount of incidents

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
@Steals-The-PRs Steals-The-PRs mentioned this issue Nov 21, 2023
Merged
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this issue Nov 23, 2023
@TaleStationBot @lessthnthree
[MIRROR] [MDB IGNORE] Fixes cursed/bad luck initializing with the wro…
065fbb1 
…ng amount of incidents (#8731)

Original PR: tgstation/tgstation#79846
-----
## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
lessthnthree added a commit to effigy-se/effigy-se that referenced this issue Nov 24, 2023
@lessthnthree
Fixes cursed/bad luck initializing with the wrong amount of incidents…
6ba09ae 
… (#79846)

## About The Pull Request

Fixes cursed/bad luck always spawning with only 1 incident.
incidents_left should not have a default value for the arg, as if it's
called with null it will use the incidents_left var.

Fixes tgstation/tgstation#79790

## Changelog

:cl: LT3
fix: Cursed/bad luck omen will now stick with the player for more than 1
incident
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Correct Functionality
Projects
None yet
Milestone
No milestone
2 participants
@Dorsisdwarf @Vermidia