Improves tgui build speed #79916
Merged
Improves tgui build speed #79916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgstation-server
added
the
UI
LemonInTheDark
added
the
Performance
ZephyrTFA
reviewed
Nov 24, 2023
|
Works on windows 7, but I noticed the inner node executable hangs around for 10 seconds with esbuild.exe running after the build task ends. are you sure your savings are just from it releasing control early? On production I did however notice that peak memory usage is lower, which will help with compilation on prod where we have tighter memory budgets for vm-all-the-things reasons. |
|
Drafting this as #79943 seems to be the superior option. If that PR doesn't work out, this is a good compromise. |
Mothblocks
added
the
📌 Test Merge Candidate
|
mirroring this here: the the the This pr cuts memory usage during compilation massively. |
MrStonedOne
approved these changes
Nov 27, 2023
Jolly-66
added a commit
to TaleStation/TaleStation
that referenced
this pull request
Nov 29, 2023
Original PR: tgstation/tgstation#79916 ----- ## About The Pull Request Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking: <details> <summary>Test environment / My specs</summary> intel i7-13700kf 32GB RAM windows 11 intel 660p m.2 SSD asus 4080 TUF series </details> <details> <summary>Fresh build</summary> Test steps: 1. Delete `tgui/.yarn/webpack` folder 2. `CTRL SHIFT B` Results:  terser averages `25.16s` esbuild averages `19.37s` - 23% faster </details> <details> <summary>Cached build</summary> (assuming files are already there, CTRL SHIFT B if not) 1. add a comment to an interface file 2. `CTRL SHIFT B` Results:  terser averages `9s` esbuild averages `3.52s` - 60.91% faster </details> ## Why It's Good For The Game Faster dev environment ## Changelog N/A nothing player facing Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com> Co-authored-by: Jolly-66 <70232195+Jolly-66@users.noreply.github.com>
github-merge-queue bot
pushed a commit
to cmss13-devs/cmss13
that referenced
this pull request
May 1, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> # About the pull request Replaces tgui build tools with faster alternatives. There were some issues in build of components using hooks which do not exist, which I removed as well. This is not a required part of the PR but React does not use these Based on two PRs: [Esbuild](tgstation/tgstation#79916) [SWC](tgstation/tgstation#80310) <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Faster build times <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding, and may discourage maintainers from reviewing or merging your PR. This section is not strictly required for (non-controversial) fix PRs or backend PRs. --> # Testing Photographs and Procedure <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> <details> <summary>Screenshots & Videos</summary> Before  After  </details>
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
Jun 28, 2024
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking: <details> <summary>Test environment / My specs</summary> intel i7-13700kf 32GB RAM windows 11 intel 660p m.2 SSD asus 4080 TUF series </details> <details> <summary>Fresh build</summary> Test steps: 1. Delete `tgui/.yarn/webpack` folder 2. `CTRL SHIFT B` Results:  terser averages `25.16s` esbuild averages `19.37s` - 23% faster </details> <details> <summary>Cached build</summary> (assuming files are already there, CTRL SHIFT B if not) 1. add a comment to an interface file 2. `CTRL SHIFT B` Results:  terser averages `9s` esbuild averages `3.52s` - 60.91% faster </details> Faster dev environment N/A nothing player facing
Absolucy
pushed a commit
to Absolucy/Monkestation
that referenced
this pull request
Jun 28, 2024
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking: <details> <summary>Test environment / My specs</summary> intel i7-13700kf 32GB RAM windows 11 intel 660p m.2 SSD asus 4080 TUF series </details> <details> <summary>Fresh build</summary> Test steps: 1. Delete `tgui/.yarn/webpack` folder 2. `CTRL SHIFT B` Results:  terser averages `25.16s` esbuild averages `19.37s` - 23% faster </details> <details> <summary>Cached build</summary> (assuming files are already there, CTRL SHIFT B if not) 1. add a comment to an interface file 2. `CTRL SHIFT B` Results:  terser averages `9s` esbuild averages `3.52s` - 60.91% faster </details> Faster dev environment N/A nothing player facing
dwasint
pushed a commit
to Monkestation/Monkestation2.0
that referenced
this pull request
Jun 29, 2024
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking: <details> <summary>Test environment / My specs</summary> intel i7-13700kf 32GB RAM windows 11 intel 660p m.2 SSD asus 4080 TUF series </details> <details> <summary>Fresh build</summary> Test steps: 1. Delete `tgui/.yarn/webpack` folder 2. `CTRL SHIFT B` Results:  terser averages `25.16s` esbuild averages `19.37s` - 23% faster </details> <details> <summary>Cached build</summary> (assuming files are already there, CTRL SHIFT B if not) 1. add a comment to an interface file 2. `CTRL SHIFT B` Results:  terser averages `9s` esbuild averages `3.52s` - 60.91% faster </details> Faster dev environment N/A nothing player facing Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Doubleumc
pushed a commit
to Doubleumc/PvE-CMSS13
that referenced
this pull request
Jul 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> Replaces tgui build tools with faster alternatives. There were some issues in build of components using hooks which do not exist, which I removed as well. This is not a required part of the PR but React does not use these Based on two PRs: [Esbuild](tgstation/tgstation#79916) [SWC](tgstation/tgstation#80310) <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> Faster build times <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding, and may discourage maintainers from reviewing or merging your PR. This section is not strictly required for (non-controversial) fix PRs or backend PRs. --> <!-- Include any screenshots/videos/debugging steps of the modified code functioning successfully, ideally including edge cases. --> <!-- !! If you are modifying sprites, you **must** include one or more in-game screenshots or videos of the new sprites. !! --> <details> <summary>Screenshots & Videos</summary> Before  After  </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Swaps out our minimizer, Terser, with esbuildplugin. This is the engine behind vite. This is a pretty straight forward replacement, let's let the numbers do the talking:
Test environment / My specs
intel i7-13700kf
32GB RAM
windows 11
intel 660p m.2 SSD
asus 4080 TUF series
Fresh build
Test steps:
tgui/.yarn/webpackfolderCTRL SHIFT BResults:
terser averages
25.16sesbuild averages
19.37s- 23% fasterCached build
(assuming files are already there, CTRL SHIFT B if not)
CTRL SHIFT BResults:
terser averages
9sesbuild averages
3.52s- 60.91% fasterWhy It's Good For The Game
Faster dev environment
Changelog
N/A nothing player facing