Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO GBP] Fixes lunatics not having an objective and occasionally not getting their amulettes #80981

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

Rex9001
Copy link
Contributor

@Rex9001 Rex9001 commented Jan 16, 2024

About The Pull Request

Lunatics now have an objective and it properly displays.
Lunatics now get a moonlight amulette on the ground if their hand are full.

Why It's Good For The Game

Lunatics had no idea who their master was except for their flavor text. This made it kinda confusing. This was worsened when they didnt have the identifying amulette.

Changelog

🆑
fix: Lunatics spawned from moon ascension now actually have an objective to assist their ringleader
fix: Lunatics now get a moonlight amulette on the ground if they have full hands
/:cl:

@tgstation-server tgstation-server added Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR labels Jan 16, 2024
@Rex9001 Rex9001 changed the title [NO GBP] Fixes lunatics not having on objective [NO GBP] Fixes lunatics not having an objective and occasionally not getting their amulettes Jan 16, 2024
@necromanceranne
Copy link
Contributor

If it ends up dropping on the ground, players may still end up leaving it behind. A good example of this is cult daggers on conversion and my original implementation of nukies spawning with tools in a box that dumped everything on the ground. Both instances, players just completely overlook it.

My best suggestion is to therefore either force the amulette into the neck slot, or to force unequip whatever is in someones hands, and then equip the amulette.

@RikuLeinonenVuoksi
Copy link
Contributor

If it ends up dropping on the ground, players may still end up leaving it behind. A good example of this is cult daggers on conversion and my original implementation of nukies spawning with tools in a box that dumped everything on the ground. Both instances, players just completely overlook it.

My best suggestion is to therefore either force the amulette into the neck slot, or to force unequip whatever is in someones hands, and then equip the amulette.

And if they have, say, the funny necklace that instakills you if you take it off?
Or any other future edgecase where the action of taking it off causes something bad to happen?
Yeah, that's a bit of an issue...

Anywho, just spawn it in their hands if they don't have their neck slot open and if their hands are full, only then spawn it on the ground. That should be enough safeguards to where 99% of people will have it on.

Also, it badly needs a HUD icon since constantly examining people when 70 dudes are scurrying around is just impossible. You could make the HUD icon appear based on whether you have the necklace on or not.

As for any problematic neck items, you COULD make a blacklist and just add a component to the existing neck item to make it glow or smth and drop the old item if it's not in the blacklist. (the blacklist would be quite small, possibly just that 1 necklace)

@necromanceranne
Copy link
Contributor

necromanceranne commented Jan 17, 2024

And if they have, say, the funny necklace that instakills you if you take it off? Or any other future edgecase where the action of taking it off causes something bad to happen? Yeah, that's a bit of an issue...

I think that affects maybe a very extreme minority in a given round. I also don't really foresee much anything akin to the memento mori being added again, so you can just check for that specifically if that is a problem. Undermining design due to very specific edgecases is a bit silly. And you should always design with player unawareness in mind as a major consideration and not an afterthought.

I would also second hud icons for that reason.

@Rex9001
Copy link
Contributor Author

Rex9001 commented Jan 17, 2024

I cannot add hud icons for the time being. There is a feature freeze and that would very much fall under feature, for the same reason I cannot rebalance any parts of this path.

@Rex9001
Copy link
Contributor Author

Rex9001 commented Jan 17, 2024

As for momento mori, I think its a risk the player is gonna have to take, adding an additional blacklist check for one item seems a bit silly to me. Especially when its mostly worn by miners and only people on the station Z can become lunatics

Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
@Ghommie Ghommie merged commit 3f008a5 into tgstation:master Jan 20, 2024
19 checks passed
comfyorange added a commit that referenced this pull request Jan 20, 2024
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Jan 20, 2024
… and occasionally not getting their amulettes (#9483)

Original PR: tgstation/tgstation#80981
-----
## About The Pull Request
Lunatics now have an objective and it properly displays. 
Lunatics now get a moonlight amulette on the ground if their hand are
full.
## Why It's Good For The Game
Lunatics had no idea who their master was except for their flavor text.
This made it kinda confusing. This was worsened when they didnt have the
identifying amulette.
## Changelog
:cl:
fix: Lunatics spawned from moon ascension now actually have an objective
to assist their ringleader
fix: Lunatics now get a moonlight amulette on the ground if they have
full hands
/:cl:

---------

Co-authored-by: Rex9001 <120136161+Rex9001@users.noreply.github.com>
Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances GBP: No Update Prevent changes to the user's GBP balance from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants